[INFO] cloning repository https://github.com/felicityin/nand2tetris-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/felicityin/nand2tetris-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffelicityin%2Fnand2tetris-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffelicityin%2Fnand2tetris-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 31e8c5b346e355b809f59b09f3f2014cbff4ed9d [INFO] checking felicityin/nand2tetris-rs against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffelicityin%2Fnand2tetris-rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/felicityin/nand2tetris-rs on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/felicityin/nand2tetris-rs [INFO] finished tweaking git repo https://github.com/felicityin/nand2tetris-rs [INFO] tweaked toml for git repo https://github.com/felicityin/nand2tetris-rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/felicityin/nand2tetris-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6355668c7f84bb0ef281e2e7d544a3350a97870bf6fe4ccfbbb67271b0d8a423 [INFO] running `Command { std: "docker" "start" "-a" "6355668c7f84bb0ef281e2e7d544a3350a97870bf6fe4ccfbbb67271b0d8a423", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6355668c7f84bb0ef281e2e7d544a3350a97870bf6fe4ccfbbb67271b0d8a423", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6355668c7f84bb0ef281e2e7d544a3350a97870bf6fe4ccfbbb67271b0d8a423", kill_on_drop: false }` [INFO] [stdout] 6355668c7f84bb0ef281e2e7d544a3350a97870bf6fe4ccfbbb67271b0d8a423 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e706009de05fcaaa69c69e5edd50aceb69cca6cc74f7d57283e9556abcd96c8e [INFO] running `Command { std: "docker" "start" "-a" "e706009de05fcaaa69c69e5edd50aceb69cca6cc74f7d57283e9556abcd96c8e", kill_on_drop: false }` [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle v1.0.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Checking clap_builder v4.4.2 [INFO] [stderr] Checking clap v4.4.2 [INFO] [stderr] Checking nand2tetris-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `type_` is never read [INFO] [stdout] --> src/ast.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct SubroutineDec { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 42 | pub kind: SubroutineKind, [INFO] [stdout] 43 | pub type_: SubroutineType, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `type_` is never read [INFO] [stdout] --> src/ast.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct SubroutineDec { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 42 | pub kind: SubroutineKind, [INFO] [stdout] 43 | pub type_: SubroutineType, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:58:10 [INFO] [stdout] | [INFO] [stdout] 58 | Type(VarType), [INFO] [stdout] | ---- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 58 | Type(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:58:10 [INFO] [stdout] | [INFO] [stdout] 58 | Type(VarType), [INFO] [stdout] | ---- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 58 | Type(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_termial` is never read [INFO] [stdout] --> src/jack_tokenizer.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 207 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 210 | pub is_termial: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_termial` is never read [INFO] [stdout] --> src/jack_tokenizer.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 207 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 210 | pub is_termial: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.63s [INFO] running `Command { std: "docker" "inspect" "e706009de05fcaaa69c69e5edd50aceb69cca6cc74f7d57283e9556abcd96c8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e706009de05fcaaa69c69e5edd50aceb69cca6cc74f7d57283e9556abcd96c8e", kill_on_drop: false }` [INFO] [stdout] e706009de05fcaaa69c69e5edd50aceb69cca6cc74f7d57283e9556abcd96c8e [INFO] checking felicityin/nand2tetris-rs against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffelicityin%2Fnand2tetris-rs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/felicityin/nand2tetris-rs on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/felicityin/nand2tetris-rs [INFO] finished tweaking git repo https://github.com/felicityin/nand2tetris-rs [INFO] tweaked toml for git repo https://github.com/felicityin/nand2tetris-rs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/felicityin/nand2tetris-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8fd1a038f2cb4418baeaca5b6d7cf8cdae247e743df787baada64ab45d7061f7 [INFO] running `Command { std: "docker" "start" "-a" "8fd1a038f2cb4418baeaca5b6d7cf8cdae247e743df787baada64ab45d7061f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8fd1a038f2cb4418baeaca5b6d7cf8cdae247e743df787baada64ab45d7061f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fd1a038f2cb4418baeaca5b6d7cf8cdae247e743df787baada64ab45d7061f7", kill_on_drop: false }` [INFO] [stdout] 8fd1a038f2cb4418baeaca5b6d7cf8cdae247e743df787baada64ab45d7061f7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5decd48fba74d8efc396a27c388982fc49af87621192541e4bb5e2c436f4a1a0 [INFO] running `Command { std: "docker" "start" "-a" "5decd48fba74d8efc396a27c388982fc49af87621192541e4bb5e2c436f4a1a0", kill_on_drop: false }` [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.2 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Checking clap_builder v4.4.2 [INFO] [stderr] Checking clap v4.4.2 [INFO] [stderr] Checking nand2tetris-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `type_` is never read [INFO] [stdout] --> src/ast.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct SubroutineDec { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 42 | pub kind: SubroutineKind, [INFO] [stdout] 43 | pub type_: SubroutineType, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:58:10 [INFO] [stdout] | [INFO] [stdout] 58 | Type(VarType), [INFO] [stdout] | ---- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 58 | Type(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_termial` is never read [INFO] [stdout] --> src/jack_tokenizer.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 207 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 210 | pub is_termial: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:326:23 [INFO] [stdout] | [INFO] [stdout] 306 | let cond = self.compile_expression(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let if_body = self.compile_statements(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | let else_body = if self.tokens.peek().value.as_str() == "else" { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let else_body = self.compile_statements(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | Statement::If(IfStatement { [INFO] [stdout] | _______________________^ [INFO] [stdout] 327 | | cond, [INFO] [stdout] 328 | | if_body, [INFO] [stdout] 329 | | else_body, [INFO] [stdout] 330 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:356:24 [INFO] [stdout] | [INFO] [stdout] 340 | let array_index = if self.tokens.peek().value.as_str() == "[" { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | self.step("["); // [ [INFO] [stdout] 342 | let expression = self.compile_expression(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | let right_expr = self.compile_expression(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | Statement::Let(LetStatement { [INFO] [stdout] | ________________________^ [INFO] [stdout] 357 | | var_name, [INFO] [stdout] 358 | | array_index, [INFO] [stdout] 359 | | right_expr, [INFO] [stdout] 360 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:379:26 [INFO] [stdout] | [INFO] [stdout] 369 | let cond = self.compile_expression(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | let body = self.compile_statements(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 379 | Statement::While(WhileStatement { cond, body }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:421:23 [INFO] [stdout] | [INFO] [stdout] 388 | let subroutine_call = if self.tokens.peek().value.as_str() == "(" { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | self.step("("); // ( [INFO] [stdout] 390 | let args = self.compile_expression_list(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let args = self.compile_expression_list(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 421 | Statement::Do(DoStatement { subroutine_call }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:441:27 [INFO] [stdout] | [INFO] [stdout] 430 | let expr = if self.tokens.peek().value.as_str() != ";" { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | Statement::Return(ReturnStatement { expr }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:481:19 [INFO] [stdout] | [INFO] [stdout] 448 | let term = self.compile_term(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 449 | [INFO] [stdout] 450 | let mut op_terms = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 481 | term: Box::new(term), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nand2tetris-rs` (bin "nand2tetris-rs") due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `type_` is never read [INFO] [stdout] --> src/ast.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct SubroutineDec { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 42 | pub kind: SubroutineKind, [INFO] [stdout] 43 | pub type_: SubroutineType, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:58:10 [INFO] [stdout] | [INFO] [stdout] 58 | Type(VarType), [INFO] [stdout] | ---- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 58 | Type(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_termial` is never read [INFO] [stdout] --> src/jack_tokenizer.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 207 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 210 | pub is_termial: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:326:23 [INFO] [stdout] | [INFO] [stdout] 306 | let cond = self.compile_expression(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let if_body = self.compile_statements(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | let else_body = if self.tokens.peek().value.as_str() == "else" { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let else_body = self.compile_statements(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | Statement::If(IfStatement { [INFO] [stdout] | _______________________^ [INFO] [stdout] 327 | | cond, [INFO] [stdout] 328 | | if_body, [INFO] [stdout] 329 | | else_body, [INFO] [stdout] 330 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:356:24 [INFO] [stdout] | [INFO] [stdout] 340 | let array_index = if self.tokens.peek().value.as_str() == "[" { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | self.step("["); // [ [INFO] [stdout] 342 | let expression = self.compile_expression(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | let right_expr = self.compile_expression(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | Statement::Let(LetStatement { [INFO] [stdout] | ________________________^ [INFO] [stdout] 357 | | var_name, [INFO] [stdout] 358 | | array_index, [INFO] [stdout] 359 | | right_expr, [INFO] [stdout] 360 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:379:26 [INFO] [stdout] | [INFO] [stdout] 369 | let cond = self.compile_expression(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | let body = self.compile_statements(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 379 | Statement::While(WhileStatement { cond, body }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:421:23 [INFO] [stdout] | [INFO] [stdout] 388 | let subroutine_call = if self.tokens.peek().value.as_str() == "(" { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | self.step("("); // ( [INFO] [stdout] 390 | let args = self.compile_expression_list(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let args = self.compile_expression_list(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 421 | Statement::Do(DoStatement { subroutine_call }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:441:27 [INFO] [stdout] | [INFO] [stdout] 430 | let expr = if self.tokens.peek().value.as_str() != ";" { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | Statement::Return(ReturnStatement { expr }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jack_parser.rs:481:19 [INFO] [stdout] | [INFO] [stdout] 448 | let term = self.compile_term(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 449 | [INFO] [stdout] 450 | let mut op_terms = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 481 | term: Box::new(term), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nand2tetris-rs` (bin "nand2tetris-rs" test) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5decd48fba74d8efc396a27c388982fc49af87621192541e4bb5e2c436f4a1a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5decd48fba74d8efc396a27c388982fc49af87621192541e4bb5e2c436f4a1a0", kill_on_drop: false }` [INFO] [stdout] 5decd48fba74d8efc396a27c388982fc49af87621192541e4bb5e2c436f4a1a0