[INFO] cloning repository https://github.com/etscrivner/programmingbitcoin-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/etscrivner/programmingbitcoin-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fetscrivner%2Fprogrammingbitcoin-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fetscrivner%2Fprogrammingbitcoin-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4741bf1d911bcc74fb993e71f3131a0e09f6f5f8 [INFO] checking etscrivner/programmingbitcoin-rust against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fetscrivner%2Fprogrammingbitcoin-rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/etscrivner/programmingbitcoin-rust on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/etscrivner/programmingbitcoin-rust [INFO] finished tweaking git repo https://github.com/etscrivner/programmingbitcoin-rust [INFO] tweaked toml for git repo https://github.com/etscrivner/programmingbitcoin-rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/etscrivner/programmingbitcoin-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded opaque-debug v0.2.1 [INFO] [stderr] Downloaded byte-tools v0.3.0 [INFO] [stderr] Downloaded digest v0.8.0 [INFO] [stderr] Downloaded generic-array v0.12.0 [INFO] [stderr] Downloaded typenum v1.10.0 [INFO] [stderr] Downloaded block-buffer v0.7.0 [INFO] [stderr] Downloaded sha2 v0.8.0 [INFO] [stderr] Downloaded hmac v0.7.0 [INFO] [stderr] Downloaded block-padding v0.1.2 [INFO] [stderr] Downloaded rug v1.2.2 [INFO] [stderr] Downloaded libc v0.2.46 [INFO] [stderr] Downloaded gmp-mpfr-sys v1.1.10 [INFO] [stderr] Downloaded byteorder v1.2.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eae04ce8fdb0db7215d5dcd6524ecf4884de0a972824d3d4aedccca76f887160 [INFO] running `Command { std: "docker" "start" "-a" "eae04ce8fdb0db7215d5dcd6524ecf4884de0a972824d3d4aedccca76f887160", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eae04ce8fdb0db7215d5dcd6524ecf4884de0a972824d3d4aedccca76f887160", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eae04ce8fdb0db7215d5dcd6524ecf4884de0a972824d3d4aedccca76f887160", kill_on_drop: false }` [INFO] [stdout] eae04ce8fdb0db7215d5dcd6524ecf4884de0a972824d3d4aedccca76f887160 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7ec60572f8ea603f5ee02b6aae91b594e49f6aeab653f6c1d34da9161a01a46 [INFO] running `Command { std: "docker" "start" "-a" "f7ec60572f8ea603f5ee02b6aae91b594e49f6aeab653f6c1d34da9161a01a46", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling libc v0.2.46 [INFO] [stderr] Compiling gmp-mpfr-sys v1.1.10 [INFO] [stderr] Checking byte-tools v0.3.0 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Compiling rug v1.2.2 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking block-padding v0.1.2 [INFO] [stderr] Checking opaque-debug v0.2.1 [INFO] [stderr] Checking generic-array v0.12.0 [INFO] [stderr] Checking digest v0.8.0 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking hmac v0.7.0 [INFO] [stderr] Checking pbitcoinrs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated function `from_sec` is never used [INFO] [stdout] --> src/programmingbitcoin/serialization.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 52 | impl Point { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 53 | /// Load SEC formatted public key [INFO] [stdout] 54 | fn from_sec(data: &Vec, curve: &Rc) -> Point { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/programmingbitcoin/base58.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let mut result = base58_encode(bytes); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.77s [INFO] running `Command { std: "docker" "inspect" "f7ec60572f8ea603f5ee02b6aae91b594e49f6aeab653f6c1d34da9161a01a46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7ec60572f8ea603f5ee02b6aae91b594e49f6aeab653f6c1d34da9161a01a46", kill_on_drop: false }` [INFO] [stdout] f7ec60572f8ea603f5ee02b6aae91b594e49f6aeab653f6c1d34da9161a01a46 [INFO] checking etscrivner/programmingbitcoin-rust against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fetscrivner%2Fprogrammingbitcoin-rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/etscrivner/programmingbitcoin-rust on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/etscrivner/programmingbitcoin-rust [INFO] finished tweaking git repo https://github.com/etscrivner/programmingbitcoin-rust [INFO] tweaked toml for git repo https://github.com/etscrivner/programmingbitcoin-rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/etscrivner/programmingbitcoin-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea58d85a6a1dce5de3c74bae53ae832a6fb401600948e5538a1b7c0700dbd8a7 [INFO] running `Command { std: "docker" "start" "-a" "ea58d85a6a1dce5de3c74bae53ae832a6fb401600948e5538a1b7c0700dbd8a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea58d85a6a1dce5de3c74bae53ae832a6fb401600948e5538a1b7c0700dbd8a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea58d85a6a1dce5de3c74bae53ae832a6fb401600948e5538a1b7c0700dbd8a7", kill_on_drop: false }` [INFO] [stdout] ea58d85a6a1dce5de3c74bae53ae832a6fb401600948e5538a1b7c0700dbd8a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c37b2c3d489f43e574664d75b1a00ec56a630d3bddfb174e9f8708b40fb0f98c [INFO] running `Command { std: "docker" "start" "-a" "c37b2c3d489f43e574664d75b1a00ec56a630d3bddfb174e9f8708b40fb0f98c", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling libc v0.2.46 [INFO] [stderr] Compiling gmp-mpfr-sys v1.1.10 [INFO] [stderr] Checking byte-tools v0.3.0 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Compiling rug v1.2.2 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking opaque-debug v0.2.1 [INFO] [stderr] Checking block-padding v0.1.2 [INFO] [stderr] Checking generic-array v0.12.0 [INFO] [stderr] Checking digest v0.8.0 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking hmac v0.7.0 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking pbitcoinrs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/programmingbitcoin/base58.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let mut result = base58_encode(bytes); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_sec` is never used [INFO] [stdout] --> src/programmingbitcoin/serialization.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 52 | impl Point { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 53 | /// Load SEC formatted public key [INFO] [stdout] 54 | fn from_sec(data: &Vec, curve: &Rc) -> Point { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(curve: FiniteEllipticCurve, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | generator_point: Point, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | order: Integer) -> CryptographicCurve [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | order: Rc::new(GaloisField::new(order)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:59:35 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn make_element(&self, value: Integer) -> FieldElement { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | FieldElement::new(value, &self.order.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:77:40 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(r: FieldElement, s: FieldElement, curve: &Rc) -> Signature { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Signature { r: r, s: s, curve: curve.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(secret: FieldElement, curve: &Rc) -> PrivateKey { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | PrivateKey { [INFO] [stdout] 107 | secret: secret.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:108:25 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(secret: FieldElement, curve: &Rc) -> PrivateKey { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | public_key: &secret * &curve.generator_point, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(secret: FieldElement, curve: &Rc) -> PrivateKey { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | curve: curve.clone() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 115 | let z = self.curve.make_element(message.clone()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let k = self.curve.make_element(nonce.clone()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let r = (&k * &self.curve.generator_point).x.unwrap().value; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let mut s = (z + (&r * &self.secret)) / k; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Signature::new(self.curve.make_element(r), s, &self.curve) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ellipticcurve.rs:32:52 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(curve: EllipticCurve, field: &Rc) -> FiniteEllipticCurve { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | FiniteEllipticCurve { curve: curve, field: field.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ellipticcurve.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn make_point(&self, x: Option, y: Option) -> Result { [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | match (x, y) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ellipticcurve.rs:83:36 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn new(x: Option, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | y: Option, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | curve: &FiniteEllipticCurve) -> Point { [INFO] [stdout] 83 | Point { x: x, y: y, curve: curve.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:45:31 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(value: Integer, field: &Rc) -> FieldElement { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | // Otherwise, simply use the value as is [INFO] [stdout] 45 | FieldElement { value: field.value_of(value), field: field.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:45:61 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(value: Integer, field: &Rc) -> FieldElement { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | // Otherwise, simply use the value as is [INFO] [stdout] 45 | FieldElement { value: field.value_of(value), field: field.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | let (power, _) = (self.field.prime.clone() + Integer::from(1)).div_rem_euc(Integer::from(4)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | self.pow(&power).value [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:86:27 [INFO] [stdout] | [INFO] [stdout] 85 | fn add(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | FieldElement::new(self.value + other.value, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pbitcoinrs` (bin "pbitcoinrs") due to 23 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 115 | fn add(self, other: &'a Integer) -> FieldElement { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | FieldElement::new( [INFO] [stdout] 117 | Integer::from(&self.value + other), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:127:27 [INFO] [stdout] | [INFO] [stdout] 126 | fn sub(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | FieldElement::new(self.value - other.value, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 134 | fn sub(self, other: &'a FieldElement) -> FieldElement { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | FieldElement::new( [INFO] [stdout] 136 | Integer::from(&self.value - &other.value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 145 | fn sub(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | FieldElement::new( [INFO] [stdout] 147 | Integer::from(&self.value - &other.value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:168:27 [INFO] [stdout] | [INFO] [stdout] 167 | fn mul(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | FieldElement::new(self.value * other.value, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:176:27 [INFO] [stdout] | [INFO] [stdout] 175 | fn mul(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | FieldElement::new(self * other.value, &other.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:184:27 [INFO] [stdout] | [INFO] [stdout] 183 | fn mul(self, other: Integer) -> FieldElement { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | FieldElement::new(self.value * other, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:192:27 [INFO] [stdout] | [INFO] [stdout] 191 | fn mul(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | FieldElement::new(&self.value * other.value, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(curve: FiniteEllipticCurve, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | generator_point: Point, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | order: Integer) -> CryptographicCurve [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | order: Rc::new(GaloisField::new(order)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:59:35 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn make_element(&self, value: Integer) -> FieldElement { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | FieldElement::new(value, &self.order.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:77:40 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(r: FieldElement, s: FieldElement, curve: &Rc) -> Signature { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Signature { r: r, s: s, curve: curve.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(secret: FieldElement, curve: &Rc) -> PrivateKey { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | PrivateKey { [INFO] [stdout] 107 | secret: secret.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:108:25 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(secret: FieldElement, curve: &Rc) -> PrivateKey { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | public_key: &secret * &curve.generator_point, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(secret: FieldElement, curve: &Rc) -> PrivateKey { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | curve: curve.clone() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ecdsa.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 115 | let z = self.curve.make_element(message.clone()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let k = self.curve.make_element(nonce.clone()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let r = (&k * &self.curve.generator_point).x.unwrap().value; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let mut s = (z + (&r * &self.secret)) / k; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Signature::new(self.curve.make_element(r), s, &self.curve) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ellipticcurve.rs:32:52 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(curve: EllipticCurve, field: &Rc) -> FiniteEllipticCurve { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | FiniteEllipticCurve { curve: curve, field: field.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ellipticcurve.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn make_point(&self, x: Option, y: Option) -> Result { [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | match (x, y) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/ellipticcurve.rs:83:36 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn new(x: Option, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | y: Option, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | curve: &FiniteEllipticCurve) -> Point { [INFO] [stdout] 83 | Point { x: x, y: y, curve: curve.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:45:31 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(value: Integer, field: &Rc) -> FieldElement { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | // Otherwise, simply use the value as is [INFO] [stdout] 45 | FieldElement { value: field.value_of(value), field: field.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:45:61 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(value: Integer, field: &Rc) -> FieldElement { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | // Otherwise, simply use the value as is [INFO] [stdout] 45 | FieldElement { value: field.value_of(value), field: field.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | let (power, _) = (self.field.prime.clone() + Integer::from(1)).div_rem_euc(Integer::from(4)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | self.pow(&power).value [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:86:27 [INFO] [stdout] | [INFO] [stdout] 85 | fn add(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | FieldElement::new(self.value + other.value, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 115 | fn add(self, other: &'a Integer) -> FieldElement { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | FieldElement::new( [INFO] [stdout] 117 | Integer::from(&self.value + other), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:127:27 [INFO] [stdout] | [INFO] [stdout] 126 | fn sub(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | FieldElement::new(self.value - other.value, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 134 | fn sub(self, other: &'a FieldElement) -> FieldElement { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | FieldElement::new( [INFO] [stdout] 136 | Integer::from(&self.value - &other.value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 145 | fn sub(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | FieldElement::new( [INFO] [stdout] 147 | Integer::from(&self.value - &other.value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:168:27 [INFO] [stdout] | [INFO] [stdout] 167 | fn mul(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | FieldElement::new(self.value * other.value, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:176:27 [INFO] [stdout] | [INFO] [stdout] 175 | fn mul(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | FieldElement::new(self * other.value, &other.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:184:27 [INFO] [stdout] | [INFO] [stdout] 183 | fn mul(self, other: Integer) -> FieldElement { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | FieldElement::new(self.value * other, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/programmingbitcoin/finitefield.rs:192:27 [INFO] [stdout] | [INFO] [stdout] 191 | fn mul(self, other: FieldElement) -> FieldElement { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | FieldElement::new(&self.value * other.value, &self.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pbitcoinrs` (bin "pbitcoinrs" test) due to 23 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c37b2c3d489f43e574664d75b1a00ec56a630d3bddfb174e9f8708b40fb0f98c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c37b2c3d489f43e574664d75b1a00ec56a630d3bddfb174e9f8708b40fb0f98c", kill_on_drop: false }` [INFO] [stdout] c37b2c3d489f43e574664d75b1a00ec56a630d3bddfb174e9f8708b40fb0f98c