[INFO] cloning repository https://github.com/endeav0r/squad_rcon [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/endeav0r/squad_rcon" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fendeav0r%2Fsquad_rcon", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fendeav0r%2Fsquad_rcon'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f976a504ba780a448836ef0fa11f23074770f47b [INFO] checking endeav0r/squad_rcon against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fendeav0r%2Fsquad_rcon" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/endeav0r/squad_rcon on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/endeav0r/squad_rcon [INFO] finished tweaking git repo https://github.com/endeav0r/squad_rcon [INFO] tweaked toml for git repo https://github.com/endeav0r/squad_rcon written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/endeav0r/squad_rcon already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded simplelog v0.7.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb37014d0700c85cd6e6d83e428e8471e6d32e53933fff8b61698676a3756393 [INFO] running `Command { std: "docker" "start" "-a" "bb37014d0700c85cd6e6d83e428e8471e6d32e53933fff8b61698676a3756393", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb37014d0700c85cd6e6d83e428e8471e6d32e53933fff8b61698676a3756393", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb37014d0700c85cd6e6d83e428e8471e6d32e53933fff8b61698676a3756393", kill_on_drop: false }` [INFO] [stdout] bb37014d0700c85cd6e6d83e428e8471e6d32e53933fff8b61698676a3756393 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 02bc1b1eae62416ac39c88d3cfb790784c7192b8d6eb9eaa999f51da17b289c6 [INFO] running `Command { std: "docker" "start" "-a" "02bc1b1eae62416ac39c88d3cfb790784c7192b8d6eb9eaa999f51da17b289c6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking simplelog v0.7.5 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Checking squad_rcon v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:195:25 [INFO] [stdout] | [INFO] [stdout] 195 | for chat in squad_rcon.take_chat_log() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 195 | while let Ok(chat) = squad_rcon.take_chat_log() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 195 | for chat in squad_rcon.take_chat_log()? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 195 | if let Ok(chat) = squad_rcon.take_chat_log() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:195:25 [INFO] [stdout] | [INFO] [stdout] 195 | for chat in squad_rcon.take_chat_log() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 195 | while let Ok(chat) = squad_rcon.take_chat_log() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 195 | for chat in squad_rcon.take_chat_log()? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 195 | if let Ok(chat) = squad_rcon.take_chat_log() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.28s [INFO] running `Command { std: "docker" "inspect" "02bc1b1eae62416ac39c88d3cfb790784c7192b8d6eb9eaa999f51da17b289c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02bc1b1eae62416ac39c88d3cfb790784c7192b8d6eb9eaa999f51da17b289c6", kill_on_drop: false }` [INFO] [stdout] 02bc1b1eae62416ac39c88d3cfb790784c7192b8d6eb9eaa999f51da17b289c6 [INFO] checking endeav0r/squad_rcon against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fendeav0r%2Fsquad_rcon" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/endeav0r/squad_rcon on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/endeav0r/squad_rcon [INFO] finished tweaking git repo https://github.com/endeav0r/squad_rcon [INFO] tweaked toml for git repo https://github.com/endeav0r/squad_rcon written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/endeav0r/squad_rcon already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 240c69d834e3b8eeb0462d7c33b433adaf2c89d12b7fff87f1e516ef70729da2 [INFO] running `Command { std: "docker" "start" "-a" "240c69d834e3b8eeb0462d7c33b433adaf2c89d12b7fff87f1e516ef70729da2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "240c69d834e3b8eeb0462d7c33b433adaf2c89d12b7fff87f1e516ef70729da2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "240c69d834e3b8eeb0462d7c33b433adaf2c89d12b7fff87f1e516ef70729da2", kill_on_drop: false }` [INFO] [stdout] 240c69d834e3b8eeb0462d7c33b433adaf2c89d12b7fff87f1e516ef70729da2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 664386ad366c4b98b28a1d85bcdf9e125cd4ab71bdcc6bca3a5cab6050042f1f [INFO] running `Command { std: "docker" "start" "-a" "664386ad366c4b98b28a1d85bcdf9e125cd4ab71bdcc6bca3a5cab6050042f1f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking simplelog v0.7.5 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Checking squad_rcon v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/squad_rcon.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 30 | addr: A, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | password: S, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> Result { [INFO] [stdout] 33 | Ok(SquadRcon { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | rcon_client: RconClient::connect(addr, password)?, [INFO] [stdout] 35 | | chat_log: Vec::new(), [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/squad_rcon.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 30 | addr: A, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | password: S, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> Result { [INFO] [stdout] 33 | Ok(SquadRcon { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | rcon_client: RconClient::connect(addr, password)?, [INFO] [stdout] 35 | | chat_log: Vec::new(), [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `squad_rcon` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `squad_rcon` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "664386ad366c4b98b28a1d85bcdf9e125cd4ab71bdcc6bca3a5cab6050042f1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "664386ad366c4b98b28a1d85bcdf9e125cd4ab71bdcc6bca3a5cab6050042f1f", kill_on_drop: false }` [INFO] [stdout] 664386ad366c4b98b28a1d85bcdf9e125cd4ab71bdcc6bca3a5cab6050042f1f