[INFO] cloning repository https://github.com/edgarogh/ws-hotel [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/edgarogh/ws-hotel" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fedgarogh%2Fws-hotel", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fedgarogh%2Fws-hotel'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eef76ec951115b35544c66b54556188ff1049382 [INFO] checking edgarogh/ws-hotel against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fedgarogh%2Fws-hotel" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/edgarogh/ws-hotel on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc1/source/rust-toolchain [INFO] started tweaking git repo https://github.com/edgarogh/ws-hotel [INFO] finished tweaking git repo https://github.com/edgarogh/ws-hotel [INFO] tweaked toml for git repo https://github.com/edgarogh/ws-hotel written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/edgarogh/ws-hotel already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ws v0.9.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62d50e3ae57f7dd0750db6cccb32ce0ab246db420b659ae5deb6d5d65e1ef8f7 [INFO] running `Command { std: "docker" "start" "-a" "62d50e3ae57f7dd0750db6cccb32ce0ab246db420b659ae5deb6d5d65e1ef8f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62d50e3ae57f7dd0750db6cccb32ce0ab246db420b659ae5deb6d5d65e1ef8f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62d50e3ae57f7dd0750db6cccb32ce0ab246db420b659ae5deb6d5d65e1ef8f7", kill_on_drop: false }` [INFO] [stdout] 62d50e3ae57f7dd0750db6cccb32ce0ab246db420b659ae5deb6d5d65e1ef8f7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd57de03ce48d2c40ddc2b18ee29cbbf739da68c68630cf1a00256e349c4bc3d [INFO] running `Command { std: "docker" "start" "-a" "dd57de03ce48d2c40ddc2b18ee29cbbf739da68c68630cf1a00256e349c4bc3d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking sha-1 v0.8.2 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking ws v0.9.1 [INFO] [stderr] Checking ws-hotel v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `arc_new_cyclic` has been stable since 1.60.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | #![feature(arc_new_cyclic)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `arc_new_cyclic` has been stable since 1.60.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | #![feature(arc_new_cyclic)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `broadcast` is never used [INFO] [stdout] --> src/lib.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 222 | trait RoomAny { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 227 | fn broadcast(&self, msg: Message) -> ws::Result<()>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `broadcast` is never used [INFO] [stdout] --> src/lib.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 222 | trait RoomAny { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 227 | fn broadcast(&self, msg: Message) -> ws::Result<()>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.76s [INFO] running `Command { std: "docker" "inspect" "dd57de03ce48d2c40ddc2b18ee29cbbf739da68c68630cf1a00256e349c4bc3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd57de03ce48d2c40ddc2b18ee29cbbf739da68c68630cf1a00256e349c4bc3d", kill_on_drop: false }` [INFO] [stdout] dd57de03ce48d2c40ddc2b18ee29cbbf739da68c68630cf1a00256e349c4bc3d [INFO] checking edgarogh/ws-hotel against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fedgarogh%2Fws-hotel" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/edgarogh/ws-hotel on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain [INFO] started tweaking git repo https://github.com/edgarogh/ws-hotel [INFO] finished tweaking git repo https://github.com/edgarogh/ws-hotel [INFO] tweaked toml for git repo https://github.com/edgarogh/ws-hotel written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/edgarogh/ws-hotel already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3573cdfcb62eebc7012d64de4269a300691dfe7003af4c775b7bf9de6ba442ff [INFO] running `Command { std: "docker" "start" "-a" "3573cdfcb62eebc7012d64de4269a300691dfe7003af4c775b7bf9de6ba442ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3573cdfcb62eebc7012d64de4269a300691dfe7003af4c775b7bf9de6ba442ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3573cdfcb62eebc7012d64de4269a300691dfe7003af4c775b7bf9de6ba442ff", kill_on_drop: false }` [INFO] [stdout] 3573cdfcb62eebc7012d64de4269a300691dfe7003af4c775b7bf9de6ba442ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43b0e8ae4e1557eba1e78b5e765d4ea23486824651a80298e54602c8ff9530d8 [INFO] running `Command { std: "docker" "start" "-a" "43b0e8ae4e1557eba1e78b5e765d4ea23486824651a80298e54602c8ff9530d8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking sha-1 v0.8.2 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking ws v0.9.1 [INFO] [stderr] Checking ws-hotel v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `arc_new_cyclic` has been stable since 1.60.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | #![feature(arc_new_cyclic)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `arc_new_cyclic` has been stable since 1.60.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | #![feature(arc_new_cyclic)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `broadcast` is never used [INFO] [stdout] --> src/lib.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 222 | trait RoomAny { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 227 | fn broadcast(&self, msg: Message) -> ws::Result<()>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn with T, T>(&self, f: F) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | f(&mut self.0.lock().unwrap().handler) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:41 [INFO] [stdout] | [INFO] [stdout] 141 | .map(|(_, v)| (PhantomData, v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:17 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn new(handler: R) -> RoomRef { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | RoomRef(Arc::new_cyclic(|weak| { [INFO] [stdout] | _________________^ [INFO] [stdout] 185 | | Mutex::new(Room { [INFO] [stdout] 186 | | self_ref: RoomRefWeak(weak.clone()), [INFO] [stdout] 187 | | handler, [INFO] [stdout] 188 | | members: Vec::new(), [INFO] [stdout] 189 | | }) [INFO] [stdout] 190 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn new(handler: R) -> RoomRef { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | RoomRef(Arc::new_cyclic(|weak| { [INFO] [stdout] 185 | Mutex::new(Room { [INFO] [stdout] | ________________________^ [INFO] [stdout] 186 | | self_ref: RoomRefWeak(weak.clone()), [INFO] [stdout] 187 | | handler, [INFO] [stdout] 188 | | members: Vec::new(), [INFO] [stdout] 189 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:216:14 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn new(room: &RoomRef, identity: R::Guest) -> Self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Self(Arc::clone(&room.0) as _, Box::new(identity) as _) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:216:40 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn new(room: &RoomRef, identity: R::Guest) -> Self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Self(Arc::clone(&room.0) as _, Box::new(identity) as _) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:332:51 [INFO] [stdout] | [INFO] [stdout] 332 | .map(|(identity, sender)| sender.send(f(identity))) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 469 | pub fn listen(addr: A, lobby: I) [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 476 | let lobby = lobby.into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 477 | [INFO] [stdout] 478 | let lobby: Arc = Arc::clone(&lobby.0) as _; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | [INFO] [stdout] 480 | / ws::listen(addr, |sender| { [INFO] [stdout] 481 | | let lobby = Arc::clone(&lobby); [INFO] [stdout] 482 | | [INFO] [stdout] 483 | | lobby.add(sender.clone(), Box::new(R::Guest::default())); [INFO] [stdout] ... | [INFO] [stdout] 488 | | } [INFO] [stdout] 489 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ws-hotel` (lib) due to 9 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `broadcast` is never used [INFO] [stdout] --> src/lib.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 222 | trait RoomAny { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 227 | fn broadcast(&self, msg: Message) -> ws::Result<()>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn with T, T>(&self, f: F) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | f(&mut self.0.lock().unwrap().handler) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:41 [INFO] [stdout] | [INFO] [stdout] 141 | .map(|(_, v)| (PhantomData, v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:17 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn new(handler: R) -> RoomRef { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | RoomRef(Arc::new_cyclic(|weak| { [INFO] [stdout] | _________________^ [INFO] [stdout] 185 | | Mutex::new(Room { [INFO] [stdout] 186 | | self_ref: RoomRefWeak(weak.clone()), [INFO] [stdout] 187 | | handler, [INFO] [stdout] 188 | | members: Vec::new(), [INFO] [stdout] 189 | | }) [INFO] [stdout] 190 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn new(handler: R) -> RoomRef { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | RoomRef(Arc::new_cyclic(|weak| { [INFO] [stdout] 185 | Mutex::new(Room { [INFO] [stdout] | ________________________^ [INFO] [stdout] 186 | | self_ref: RoomRefWeak(weak.clone()), [INFO] [stdout] 187 | | handler, [INFO] [stdout] 188 | | members: Vec::new(), [INFO] [stdout] 189 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:216:14 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn new(room: &RoomRef, identity: R::Guest) -> Self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Self(Arc::clone(&room.0) as _, Box::new(identity) as _) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:216:40 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn new(room: &RoomRef, identity: R::Guest) -> Self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Self(Arc::clone(&room.0) as _, Box::new(identity) as _) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:332:51 [INFO] [stdout] | [INFO] [stdout] 332 | .map(|(identity, sender)| sender.send(f(identity))) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 469 | pub fn listen(addr: A, lobby: I) [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 476 | let lobby = lobby.into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 477 | [INFO] [stdout] 478 | let lobby: Arc = Arc::clone(&lobby.0) as _; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | [INFO] [stdout] 480 | / ws::listen(addr, |sender| { [INFO] [stdout] 481 | | let lobby = Arc::clone(&lobby); [INFO] [stdout] 482 | | [INFO] [stdout] 483 | | lobby.add(sender.clone(), Box::new(R::Guest::default())); [INFO] [stdout] ... | [INFO] [stdout] 488 | | } [INFO] [stdout] 489 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ws-hotel` (lib test) due to 9 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "43b0e8ae4e1557eba1e78b5e765d4ea23486824651a80298e54602c8ff9530d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43b0e8ae4e1557eba1e78b5e765d4ea23486824651a80298e54602c8ff9530d8", kill_on_drop: false }` [INFO] [stdout] 43b0e8ae4e1557eba1e78b5e765d4ea23486824651a80298e54602c8ff9530d8