[INFO] cloning repository https://github.com/drew-y/rustracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/drew-y/rustracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrew-y%2Frustracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrew-y%2Frustracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b62f0f494945c78ef9fc6708ee6159c91378edee [INFO] checking drew-y/rustracer against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrew-y%2Frustracer" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/drew-y/rustracer on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/drew-y/rustracer [INFO] finished tweaking git repo https://github.com/drew-y/rustracer [INFO] tweaked toml for git repo https://github.com/drew-y/rustracer written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/drew-y/rustracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rand_jitter v0.1.3 [INFO] [stderr] Downloaded number_prefix v0.3.0 [INFO] [stderr] Downloaded hermit-abi v0.1.5 [INFO] [stderr] Downloaded cfg-if v0.1.7 [INFO] [stderr] Downloaded adler32 v1.0.3 [INFO] [stderr] Downloaded console v0.9.1 [INFO] [stderr] Downloaded crossbeam-deque v0.2.0 [INFO] [stderr] Downloaded jpeg-decoder v0.1.15 [INFO] [stderr] Downloaded indicatif v0.13.0 [INFO] [stderr] Downloaded gif v0.10.1 [INFO] [stderr] Downloaded rayon-core v1.4.1 [INFO] [stderr] Downloaded crossbeam-epoch v0.3.1 [INFO] [stderr] Downloaded crossbeam-utils v0.2.2 [INFO] [stderr] Downloaded rayon v1.0.3 [INFO] [stderr] Downloaded image v0.21.1 [INFO] [stderr] Downloaded syn v0.15.32 [INFO] [stderr] Downloaded deflate v0.7.19 [INFO] [stderr] Downloaded num-rational v0.2.1 [INFO] [stderr] Downloaded libc v0.2.51 [INFO] [stderr] Downloaded autocfg v0.1.2 [INFO] [stderr] Downloaded proc-macro2 v0.4.28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] faea22269f7de20ea40700c2907120745441aacee645ce10eb48753a69d0cd1f [INFO] running `Command { std: "docker" "start" "-a" "faea22269f7de20ea40700c2907120745441aacee645ce10eb48753a69d0cd1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "faea22269f7de20ea40700c2907120745441aacee645ce10eb48753a69d0cd1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "faea22269f7de20ea40700c2907120745441aacee645ce10eb48753a69d0cd1f", kill_on_drop: false }` [INFO] [stdout] faea22269f7de20ea40700c2907120745441aacee645ce10eb48753a69d0cd1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7599db673ba1c27dded78bc2411f9f716eadb55f941c83edb46398ed0d1d2416 [INFO] running `Command { std: "docker" "start" "-a" "7599db673ba1c27dded78bc2411f9f716eadb55f941c83edb46398ed0d1d2416", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling proc-macro2 v0.4.28 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling syn v0.15.32 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Compiling rayon v1.0.3 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.3 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking png v0.14.1 [INFO] [stderr] Checking console v0.9.1 [INFO] [stderr] Checking indicatif v0.13.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking tiff v0.2.2 [INFO] [stderr] Checking image v0.21.1 [INFO] [stderr] Checking rustracer v3.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/tracer/camera.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Camera` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/tracer/camera.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Camera` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/checker_texture.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `CheckerTexture` does not implement `Deref`, so calling `deref` on `&CheckerTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 22 - Box::new(self.deref().clone()) [INFO] [stdout] 22 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `CheckerTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct CheckerTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/constant_texture.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_texture::ConstantTexture` does not implement `Deref`, so calling `deref` on `&constant_texture::ConstantTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 24 - Box::new(self.deref().clone()) [INFO] [stdout] 24 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_texture::ConstantTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct ConstantTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/checker_texture.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `CheckerTexture` does not implement `Deref`, so calling `deref` on `&CheckerTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 22 - Box::new(self.deref().clone()) [INFO] [stdout] 22 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `CheckerTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct CheckerTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/image_texture.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `image_texture::ImageTexture` does not implement `Deref`, so calling `deref` on `&image_texture::ImageTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 26 - Box::new(self.deref().clone()) [INFO] [stdout] 26 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `image_texture::ImageTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct ImageTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/constant_texture.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_texture::ConstantTexture` does not implement `Deref`, so calling `deref` on `&constant_texture::ConstantTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 24 - Box::new(self.deref().clone()) [INFO] [stdout] 24 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_texture::ConstantTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct ConstantTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/image_texture.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `image_texture::ImageTexture` does not implement `Deref`, so calling `deref` on `&image_texture::ImageTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 26 - Box::new(self.deref().clone()) [INFO] [stdout] 26 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `image_texture::ImageTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct ImageTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/noise_texture.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `NoiseTexture` does not implement `Deref`, so calling `deref` on `&NoiseTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 28 - Box::new(self.deref().clone()) [INFO] [stdout] 28 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `NoiseTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 8 + #[derive(Clone)] [INFO] [stdout] 9 | pub struct NoiseTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/noise_texture.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `NoiseTexture` does not implement `Deref`, so calling `deref` on `&NoiseTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 28 - Box::new(self.deref().clone()) [INFO] [stdout] 28 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `NoiseTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 8 + #[derive(Clone)] [INFO] [stdout] 9 | pub struct NoiseTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.86s [INFO] running `Command { std: "docker" "inspect" "7599db673ba1c27dded78bc2411f9f716eadb55f941c83edb46398ed0d1d2416", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7599db673ba1c27dded78bc2411f9f716eadb55f941c83edb46398ed0d1d2416", kill_on_drop: false }` [INFO] [stdout] 7599db673ba1c27dded78bc2411f9f716eadb55f941c83edb46398ed0d1d2416 [INFO] checking drew-y/rustracer against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrew-y%2Frustracer" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/drew-y/rustracer on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/drew-y/rustracer [INFO] finished tweaking git repo https://github.com/drew-y/rustracer [INFO] tweaked toml for git repo https://github.com/drew-y/rustracer written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/drew-y/rustracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 81802aa39b35bce1a1d072e3cee01b2f333766270ede8503cb7906c56f2f4292 [INFO] running `Command { std: "docker" "start" "-a" "81802aa39b35bce1a1d072e3cee01b2f333766270ede8503cb7906c56f2f4292", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "81802aa39b35bce1a1d072e3cee01b2f333766270ede8503cb7906c56f2f4292", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81802aa39b35bce1a1d072e3cee01b2f333766270ede8503cb7906c56f2f4292", kill_on_drop: false }` [INFO] [stdout] 81802aa39b35bce1a1d072e3cee01b2f333766270ede8503cb7906c56f2f4292 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7dfa4d406021de7ca5226f07afc523f406aae3f77c3458684414a8c0929578a7 [INFO] running `Command { std: "docker" "start" "-a" "7dfa4d406021de7ca5226f07afc523f406aae3f77c3458684414a8c0929578a7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling proc-macro2 v0.4.28 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling syn v0.15.32 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling rayon v1.0.3 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.3 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking png v0.14.1 [INFO] [stderr] Checking console v0.9.1 [INFO] [stderr] Checking indicatif v0.13.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking tiff v0.2.2 [INFO] [stderr] Checking image v0.21.1 [INFO] [stderr] Checking rustracer v3.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/tracer/camera.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Camera` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/cuboid.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(pmin: Vec3, pmax: Vec3, material: Material) -> Cuboid { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let mut list: Vec> = Vec::with_capacity(6); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | rects: BVHNode::new(list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/translation.rs:165:22 [INFO] [stdout] | [INFO] [stdout] 163 | fn shift(self, x: f32, y: f32, z: f32) -> Shift { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | Shift { [INFO] [stdout] 165 | hitable: self.box_clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/translation.rs:171:24 [INFO] [stdout] | [INFO] [stdout] 170 | fn rotate_y(self, angle: f32) -> YRotation { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | YRotation::new(self.box_clone(), angle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/translation.rs:175:22 [INFO] [stdout] | [INFO] [stdout] 174 | fn flip_normals(self) -> FlipNormals { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | flip_normals(self.box_clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/translation.rs:187:19 [INFO] [stdout] | [INFO] [stdout] 183 | fn push_into_list_of_boxed_hitables<'a>(self, list: &mut Vec>) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | list.push(self.to_box()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/checker_texture.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `CheckerTexture` does not implement `Deref`, so calling `deref` on `&CheckerTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 22 - Box::new(self.deref().clone()) [INFO] [stdout] 22 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `CheckerTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct CheckerTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/constant_texture.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_texture::ConstantTexture` does not implement `Deref`, so calling `deref` on `&constant_texture::ConstantTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 24 - Box::new(self.deref().clone()) [INFO] [stdout] 24 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_texture::ConstantTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct ConstantTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/image_texture.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `image_texture::ImageTexture` does not implement `Deref`, so calling `deref` on `&image_texture::ImageTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 26 - Box::new(self.deref().clone()) [INFO] [stdout] 26 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `image_texture::ImageTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct ImageTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/noise_texture.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `NoiseTexture` does not implement `Deref`, so calling `deref` on `&NoiseTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 28 - Box::new(self.deref().clone()) [INFO] [stdout] 28 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `NoiseTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 8 + #[derive(Clone)] [INFO] [stdout] 9 | pub struct NoiseTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer/bvh.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(l: Vec) -> BVHNode { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut list = l; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let left_list = list.split_off(list.len() / 2); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let left = Self::new(left_list); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let right = Self::new(list); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | left: Some(Box::new(left)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer/bvh.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(l: Vec) -> BVHNode { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut list = l; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let left_list = list.split_off(list.len() / 2); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let left = Self::new(left_list); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let right = Self::new(list); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | right: Some(Box::new(right)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer/render.rs:129:11 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn render(scene: Scene, path: String) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let mut render_threads: Vec>> = Vec::with_capacity(thread_count); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let pb = render_progress_bar(ny); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | match image::save_buffer(path, &file, nx as u32, ny as u32, image::ColorType::RGB(8)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/tracer/camera.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Camera` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/cuboid.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(pmin: Vec3, pmax: Vec3, material: Material) -> Cuboid { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let mut list: Vec> = Vec::with_capacity(6); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | rects: BVHNode::new(list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/translation.rs:165:22 [INFO] [stdout] | [INFO] [stdout] 163 | fn shift(self, x: f32, y: f32, z: f32) -> Shift { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | Shift { [INFO] [stdout] 165 | hitable: self.box_clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/translation.rs:171:24 [INFO] [stdout] | [INFO] [stdout] 170 | fn rotate_y(self, angle: f32) -> YRotation { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | YRotation::new(self.box_clone(), angle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/translation.rs:175:22 [INFO] [stdout] | [INFO] [stdout] 174 | fn flip_normals(self) -> FlipNormals { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | flip_normals(self.box_clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/translation.rs:187:19 [INFO] [stdout] | [INFO] [stdout] 183 | fn push_into_list_of_boxed_hitables<'a>(self, list: &mut Vec>) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | list.push(self.to_box()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/checker_texture.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `CheckerTexture` does not implement `Deref`, so calling `deref` on `&CheckerTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 22 - Box::new(self.deref().clone()) [INFO] [stdout] 22 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `CheckerTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct CheckerTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/constant_texture.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_texture::ConstantTexture` does not implement `Deref`, so calling `deref` on `&constant_texture::ConstantTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 24 - Box::new(self.deref().clone()) [INFO] [stdout] 24 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_texture::ConstantTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct ConstantTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/image_texture.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `image_texture::ImageTexture` does not implement `Deref`, so calling `deref` on `&image_texture::ImageTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 26 - Box::new(self.deref().clone()) [INFO] [stdout] 26 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `image_texture::ImageTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Clone)] [INFO] [stdout] 7 | pub struct ImageTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/texture/noise_texture.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | Box::new(self.deref().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `NoiseTexture` does not implement `Deref`, so calling `deref` on `&NoiseTexture` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 28 - Box::new(self.deref().clone()) [INFO] [stdout] 28 + Box::new(self.clone()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `NoiseTexture`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 8 + #[derive(Clone)] [INFO] [stdout] 9 | pub struct NoiseTexture { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer/bvh.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(l: Vec) -> BVHNode { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut list = l; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let left_list = list.split_off(list.len() / 2); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let left = Self::new(left_list); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let right = Self::new(list); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | left: Some(Box::new(left)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer/bvh.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(l: Vec) -> BVHNode { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut list = l; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let left_list = list.split_off(list.len() / 2); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let left = Self::new(left_list); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let right = Self::new(list); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | right: Some(Box::new(right)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer/render.rs:129:11 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn render(scene: Scene, path: String) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let mut render_threads: Vec>> = Vec::with_capacity(thread_count); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let pb = render_progress_bar(ny); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | match image::save_buffer(path, &file, nx as u32, ny as u32, image::ColorType::RGB(8)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustracer` (lib) due to 9 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustracer` (lib test) due to 9 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7dfa4d406021de7ca5226f07afc523f406aae3f77c3458684414a8c0929578a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7dfa4d406021de7ca5226f07afc523f406aae3f77c3458684414a8c0929578a7", kill_on_drop: false }` [INFO] [stdout] 7dfa4d406021de7ca5226f07afc523f406aae3f77c3458684414a8c0929578a7