[INFO] cloning repository https://github.com/doy/nbsh [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/doy/nbsh" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdoy%2Fnbsh", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdoy%2Fnbsh'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4151ab7aab939a12721a0f4207c87b5c09ace339 [INFO] checking doy/nbsh against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdoy%2Fnbsh" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/doy/nbsh on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/doy/nbsh [INFO] finished tweaking git repo https://github.com/doy/nbsh [INFO] tweaked toml for git repo https://github.com/doy/nbsh written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/doy/nbsh already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/nix-rust/nix` [INFO] [stderr] Updating git repository `https://github.com/notify-rs/notify` [INFO] [stderr] Updating git repository `https://github.com/doy/pty-process` [INFO] [stderr] Updating git repository `https://github.com/doy/textmode` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded vt100 v0.15.1 [INFO] [stderr] Downloaded console-api v0.1.2 [INFO] [stderr] Downloaded kqueue v1.0.4 [INFO] [stderr] Downloaded console-subscriber v0.1.3 [INFO] [stderr] Downloaded hdrhistogram v7.5.0 [INFO] [stderr] Downloaded clap v3.1.5 [INFO] [stderr] Downloaded git2 v0.14.1 [INFO] [stderr] Downloaded libgit2-sys v0.13.1+1.4.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 380ab7415d07d7953579175a1e6114113c7dcc2d9f7440f0ef3796dd3f42184e [INFO] running `Command { std: "docker" "start" "-a" "380ab7415d07d7953579175a1e6114113c7dcc2d9f7440f0ef3796dd3f42184e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "380ab7415d07d7953579175a1e6114113c7dcc2d9f7440f0ef3796dd3f42184e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "380ab7415d07d7953579175a1e6114113c7dcc2d9f7440f0ef3796dd3f42184e", kill_on_drop: false }` [INFO] [stdout] 380ab7415d07d7953579175a1e6114113c7dcc2d9f7440f0ef3796dd3f42184e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c5eeee178855f4a283233240a2ff73860907630a6837ef021da363ae34ec987 [INFO] running `Command { std: "docker" "start" "-a" "7c5eeee178855f4a283233240a2ff73860907630a6837ef021da363ae34ec987", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling anyhow v1.0.55 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking crossbeam-channel v0.5.2 [INFO] [stderr] Compiling time-macros v0.2.3 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking mio v0.8.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking vte v0.10.1 [INFO] [stderr] Checking nix v0.23.1 (https://github.com/nix-rust/nix#9312f1c4) [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling libgit2-sys v0.13.1+1.4.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking notify v5.0.0-pre.13 (https://github.com/notify-rs/notify#b1802ecc) [INFO] [stderr] Checking vt100 v0.15.1 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking git2 v0.14.1 [INFO] [stderr] Checking clap v3.1.5 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking textmode v0.3.0 (https://github.com/doy/textmode#193e1963) [INFO] [stderr] Checking tokio-util v0.7.0 [INFO] [stderr] Checking pty-process v0.2.0 (https://github.com/doy/pty-process#b2733e64) [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking nbsh v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/runner/builtins/mod.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | pub use command::{Child, Command, File, Io}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `nbsh_tokio_console` [INFO] [stdout] --> src/main.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 57 | #[cfg(nbsh_tokio_console)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(nbsh_tokio_console)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(nbsh_tokio_console)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/runner/builtins/mod.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | pub use command::{Child, Command, File, Io}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `nbsh_tokio_console` [INFO] [stdout] --> src/main.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 57 | #[cfg(nbsh_tokio_console)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(nbsh_tokio_console)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(nbsh_tokio_console)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `allow_with` is never used [INFO] [stdout] --> src/prelude.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait Result { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 24 | fn allow_with(self, allow_e: Self::E, default_t: Self::T) -> Self; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `old_history` is never read [INFO] [stdout] --> src/shell/mod.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 78 | pub struct Shell { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 81 | old_history: old_history::History, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `entries` is never read [INFO] [stdout] --> src/shell/old_history.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct History { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 12 | entries: std::sync::Arc>>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `entry_count` is never used [INFO] [stdout] --> src/shell/old_history.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl History { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn entry_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cmdline`, `start_time`, and `duration` are never read [INFO] [stdout] --> src/shell/old_history.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | pub struct Entry { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 54 | cmdline: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 55 | start_time: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 56 | duration: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `render` and `cmd` are never used [INFO] [stdout] --> src/shell/old_history.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 59 | impl Entry { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] 60 | pub fn render( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 101 | pub fn cmd(&self) -> &str { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `allow_with` is never used [INFO] [stdout] --> src/prelude.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait Result { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 24 | fn allow_with(self, allow_e: Self::E, default_t: Self::T) -> Self; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `old_history` is never read [INFO] [stdout] --> src/shell/mod.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 78 | pub struct Shell { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 81 | old_history: old_history::History, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `entries` is never read [INFO] [stdout] --> src/shell/old_history.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct History { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 12 | entries: std::sync::Arc>>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `entry_count` is never used [INFO] [stdout] --> src/shell/old_history.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl History { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn entry_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `render` and `cmd` are never used [INFO] [stdout] --> src/shell/old_history.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 59 | impl Entry { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] 60 | pub fn render( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 101 | pub fn cmd(&self) -> &str { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.08s [INFO] running `Command { std: "docker" "inspect" "7c5eeee178855f4a283233240a2ff73860907630a6837ef021da363ae34ec987", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c5eeee178855f4a283233240a2ff73860907630a6837ef021da363ae34ec987", kill_on_drop: false }` [INFO] [stdout] 7c5eeee178855f4a283233240a2ff73860907630a6837ef021da363ae34ec987 [INFO] checking doy/nbsh against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdoy%2Fnbsh" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/doy/nbsh on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/doy/nbsh [INFO] finished tweaking git repo https://github.com/doy/nbsh [INFO] tweaked toml for git repo https://github.com/doy/nbsh written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/doy/nbsh already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc2945f7585a05965a9a5bc04e18de563199faca797d6ae498f348fc64efd5a4 [INFO] running `Command { std: "docker" "start" "-a" "fc2945f7585a05965a9a5bc04e18de563199faca797d6ae498f348fc64efd5a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc2945f7585a05965a9a5bc04e18de563199faca797d6ae498f348fc64efd5a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc2945f7585a05965a9a5bc04e18de563199faca797d6ae498f348fc64efd5a4", kill_on_drop: false }` [INFO] [stdout] fc2945f7585a05965a9a5bc04e18de563199faca797d6ae498f348fc64efd5a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b026c02ad81040524e8747ee20fdb066607ffe9046d1673fdf6635b282670eff [INFO] running `Command { std: "docker" "start" "-a" "b026c02ad81040524e8747ee20fdb066607ffe9046d1673fdf6635b282670eff", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling anyhow v1.0.55 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Compiling time-macros v0.2.3 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking crossbeam-channel v0.5.2 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking vte v0.10.1 [INFO] [stderr] Checking mio v0.8.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking nix v0.23.1 (https://github.com/nix-rust/nix#9312f1c4) [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking notify v5.0.0-pre.13 (https://github.com/notify-rs/notify#b1802ecc) [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling libgit2-sys v0.13.1+1.4.2 [INFO] [stderr] Checking vt100 v0.15.1 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking clap v3.1.5 [INFO] [stderr] Checking git2 v0.14.1 [INFO] [stderr] Checking textmode v0.3.0 (https://github.com/doy/textmode#193e1963) [INFO] [stderr] Checking pty-process v0.2.0 (https://github.com/doy/pty-process#b2733e64) [INFO] [stderr] Checking tokio-util v0.7.0 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking nbsh v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/runner/builtins/mod.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | pub use command::{Child, Command, File, Io}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `nbsh_tokio_console` [INFO] [stdout] --> src/main.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 57 | #[cfg(nbsh_tokio_console)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(nbsh_tokio_console)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(nbsh_tokio_console)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/runner/builtins/mod.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | pub use command::{Child, Command, File, Io}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `nbsh_tokio_console` [INFO] [stdout] --> src/main.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 57 | #[cfg(nbsh_tokio_console)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(nbsh_tokio_console)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(nbsh_tokio_console)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `allow_with` is never used [INFO] [stdout] --> src/prelude.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait Result { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 24 | fn allow_with(self, allow_e: Self::E, default_t: Self::T) -> Self; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `old_history` is never read [INFO] [stdout] --> src/shell/mod.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 78 | pub struct Shell { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 81 | old_history: old_history::History, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `entries` is never read [INFO] [stdout] --> src/shell/old_history.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct History { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 12 | entries: std::sync::Arc>>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `entry_count` is never used [INFO] [stdout] --> src/shell/old_history.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl History { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn entry_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cmdline`, `start_time`, and `duration` are never read [INFO] [stdout] --> src/shell/old_history.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | pub struct Entry { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 54 | cmdline: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 55 | start_time: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 56 | duration: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `render` and `cmd` are never used [INFO] [stdout] --> src/shell/old_history.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 59 | impl Entry { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] 60 | pub fn render( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 101 | pub fn cmd(&self) -> &str { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | shell::main().await [INFO] [stdout] | ^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:3:42 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prelude.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 45 | fn allow_with(self, allow_e: Self::E, default_t: Self::T) -> Self { [INFO] [stdout] | ---- ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | self.or_else( [INFO] [stdout] 47 | |e| if e == allow_e { Ok(default_t) } else { Err(e) }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Debug, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:286:38 [INFO] [stdout] | [INFO] [stdout] 286 | .map(|exe| Command::new(exe, io.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:346:8 [INFO] [stdout] | [INFO] [stdout] 313 | mut cmds: Vec, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | let mut children = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | Ok((children, pg_pid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:376:51 [INFO] [stdout] | [INFO] [stdout] 375 | .map(|(i, child)| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | (sys::id_to_pid(child.id().unwrap()), (child, i == count - 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:384:18 [INFO] [stdout] | [INFO] [stdout] 383 | .map(|(i, child)| async move { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | (child.status().await, i == count - 1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 56 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 61 | | let dir = if let Some(dir) = exe.args().get(0) { [INFO] [stdout] 62 | | if dir.is_empty() { [INFO] [stdout] 63 | | ".".to_string().into() [INFO] [stdout] ... | [INFO] [stdout] 86 | | std::process::ExitStatus::from_raw(0) [INFO] [stdout] 87 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 94 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | ) -> Result { [INFO] [stdout] 96 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | let k = if let Some(k) = exe.args().get(0).map(String::as_str) { [INFO] [stdout] 98 | | k [INFO] [stdout] 99 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 109 | | std::process::ExitStatus::from_raw(0) [INFO] [stdout] 110 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:119:8 [INFO] [stdout] | [INFO] [stdout] 117 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | ) -> Result { [INFO] [stdout] 119 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 120 | | let k = if let Some(k) = exe.args().get(0).map(String::as_str) { [INFO] [stdout] 121 | | k [INFO] [stdout] 122 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 127 | | std::process::ExitStatus::from_raw(0) [INFO] [stdout] 128 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 138 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] 140 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 141 | | macro_rules! write_stdout { [INFO] [stdout] 142 | | ($bytes:expr) => { [INFO] [stdout] 143 | | if let Err(e) = cfg.io().write_stdout($bytes) { [INFO] [stdout] ... | [INFO] [stdout] 161 | | std::process::ExitStatus::from_raw(0) [INFO] [stdout] 162 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:171:8 [INFO] [stdout] | [INFO] [stdout] 169 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ) -> Result { [INFO] [stdout] 171 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 172 | | let var = if let Some(var) = exe.args().get(0).map(String::as_str) { [INFO] [stdout] 173 | | var [INFO] [stdout] 174 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 186 | | std::process::ExitStatus::from_raw(if done { 1 << 8 } else { 0 }) [INFO] [stdout] 187 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:230:8 [INFO] [stdout] | [INFO] [stdout] 225 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | let mut cmd = crate::runner::Command::new_binary(&exe); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | cfg.setup_command(&mut cmd); [INFO] [stdout] 230 | Ok(command::Child::new_wrapped(cmd.spawn(env)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:241:8 [INFO] [stdout] | [INFO] [stdout] 236 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let mut cmd = crate::runner::Command::new_builtin(exe, cfg.io().clone()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | cfg.setup_command(&mut cmd); [INFO] [stdout] 241 | Ok(command::Child::new_wrapped(cmd.spawn(env)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/command.rs:69:30 [INFO] [stdout] | [INFO] [stdout] 68 | fn new(io: Io) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Self { io, pre_exec: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/command.rs:343:20 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn new_task(f: F) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | Self::Task(tokio::task::spawn_blocking(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/command.rs:347:23 [INFO] [stdout] | [INFO] [stdout] 346 | pub fn new_wrapped(child: crate::runner::Child) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | Self::Wrapped(Box::new(child)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/command.rs:366:18 [INFO] [stdout] | [INFO] [stdout] 358 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 367 | | match self { [INFO] [stdout] 368 | | Self::Task(task) => task.await.map_err(|e| anyhow!(e)), [INFO] [stdout] 369 | | Self::Wrapped(child) => child.status().await, [INFO] [stdout] 370 | | } [INFO] [stdout] 371 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(exe: crate::parse::Exe, io: super::builtins::Io) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | inner: super::builtins::Command::new(exe, io).map_or_else( [INFO] [stdout] | ____________________^ [INFO] [stdout] 18 | | |exe| Self::new_binary(&exe).inner, [INFO] [stdout] 19 | | Inner::Builtin, [INFO] [stdout] 20 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(exe: crate::parse::Exe, io: super::builtins::Io) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | pre_exec: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:18:23 [INFO] [stdout] | [INFO] [stdout] 18 | |exe| Self::new_binary(&exe).inner, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cmd = tokio::process::Command::new(exe.exe()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | inner: Inner::Binary(cmd), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cmd = tokio::process::Command::new(exe.exe()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | pre_exec: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 42 | io: super::builtins::Io, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | inner: super::builtins::Command::new(exe, io) [INFO] [stdout] | ____________________^ [INFO] [stdout] 48 | | .map_or_else(|_| todo!(), Inner::Builtin), [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 42 | io: super::builtins::Io, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | pre_exec: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 115 | |mut pre_exec| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let redirects = redirects.clone(); [INFO] [stdout] 117 | Box::new(move || { [INFO] [stdout] | __________________________^ [INFO] [stdout] 118 | | apply_redirects(&redirects)?; [INFO] [stdout] 119 | | pre_exec()?; [INFO] [stdout] 120 | | Ok(()) [INFO] [stdout] 121 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:175:18 [INFO] [stdout] | [INFO] [stdout] 167 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 176 | | match self { [INFO] [stdout] 177 | | // this case is handled by waitpid [INFO] [stdout] 178 | | Self::Binary(_) => unreachable!(), [INFO] [stdout] 179 | | Self::Builtin(child) => Ok(child.status().await?), [INFO] [stdout] 180 | | } [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 96 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | readline: readline::Readline::new(), [INFO] [stdout] 98 | | history: history::History::new(), [INFO] [stdout] 99 | | old_history: old_history::History::new(), [INFO] [stdout] ... | [INFO] [stdout] 106 | | offset, [INFO] [stdout] 107 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/event.rs:17:6 [INFO] [stdout] | [INFO] [stdout] 16 | let (event_w, event_r) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | (Writer::new(event_w), Reader::new(event_r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/event.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 16 | let (event_w, event_r) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | (Writer::new(event_w), Reader::new(event_r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/history/entry.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 18 | event_w: crate::shell::event::Writer, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let (pty, pts) = super::pty::Pty::new(size, event_w.clone()).unwrap(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let (child, fh) = Self::spawn_command(&cmdline, &env, &pts)?; [INFO] [stdout] | ----- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | tokio::spawn(Self::task(child, fh, env.idx(), event_w)); [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | cmdline, [INFO] [stdout] 28 | | env, [INFO] [stdout] 29 | | pty, [INFO] [stdout] ... | [INFO] [stdout] 33 | | state: State::Running((0, 0)), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/history/entry.rs:319:12 [INFO] [stdout] | [INFO] [stdout] 303 | let mut cmd = pty_process::Command::new(crate::info::current_exe()?); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | let fh = unsafe { std::fs::File::from_raw_fd(from_r) }; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | let child = cmd.spawn(pts)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | nix::unistd::close(from_w)?; [INFO] [stdout] 319 | Ok((child, fh)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/history/pty.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 17 | event_w: crate::shell::event::Writer, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | ) -> Result<(Self, pty_process::Pts)> { [INFO] [stdout] 19 | let (request_w, request_r) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | [INFO] [stdout] 21 | let pty = pty_process::Pty::new()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | pty.resize(pty_process::Size::new(size.0, size.1))?; [INFO] [stdout] 23 | let pts = pty.pts()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let vt = std::sync::Arc::new(std::sync::Mutex::new(Vt::new(size))); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok((Self { vt, request_w }, pts)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/inputs/mod.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 18 | input: textmode::blocking::Input, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | event_w: crate::shell::event::Writer, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | ) -> Result { [INFO] [stdout] 21 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | _clock: clock::Handler::new(event_w.clone()), [INFO] [stdout] 23 | | git: git::Handler::new(event_w.clone()), [INFO] [stdout] 24 | | _signals: signals::Handler::new(event_w.clone())?, [INFO] [stdout] 25 | | _stdin: stdin::Handler::new(input, event_w), [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 35 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nbsh` (bin "nbsh") due to 36 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `allow_with` is never used [INFO] [stdout] --> src/prelude.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait Result { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 24 | fn allow_with(self, allow_e: Self::E, default_t: Self::T) -> Self; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `old_history` is never read [INFO] [stdout] --> src/shell/mod.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 78 | pub struct Shell { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 81 | old_history: old_history::History, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `entries` is never read [INFO] [stdout] --> src/shell/old_history.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct History { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 12 | entries: std::sync::Arc>>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `entry_count` is never used [INFO] [stdout] --> src/shell/old_history.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl History { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn entry_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `render` and `cmd` are never used [INFO] [stdout] --> src/shell/old_history.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 59 | impl Entry { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] 60 | pub fn render( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 101 | pub fn cmd(&self) -> &str { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | shell::main().await [INFO] [stdout] | ^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:3:42 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prelude.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 45 | fn allow_with(self, allow_e: Self::E, default_t: Self::T) -> Self { [INFO] [stdout] | ---- ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | self.or_else( [INFO] [stdout] 47 | |e| if e == allow_e { Ok(default_t) } else { Err(e) }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Debug, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:286:38 [INFO] [stdout] | [INFO] [stdout] 286 | .map(|exe| Command::new(exe, io.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:346:8 [INFO] [stdout] | [INFO] [stdout] 313 | mut cmds: Vec, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | let mut children = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | Ok((children, pg_pid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:376:51 [INFO] [stdout] | [INFO] [stdout] 375 | .map(|(i, child)| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | (sys::id_to_pid(child.id().unwrap()), (child, i == count - 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:384:18 [INFO] [stdout] | [INFO] [stdout] 383 | .map(|(i, child)| async move { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | (child.status().await, i == count - 1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 56 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 61 | | let dir = if let Some(dir) = exe.args().get(0) { [INFO] [stdout] 62 | | if dir.is_empty() { [INFO] [stdout] 63 | | ".".to_string().into() [INFO] [stdout] ... | [INFO] [stdout] 86 | | std::process::ExitStatus::from_raw(0) [INFO] [stdout] 87 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 94 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | ) -> Result { [INFO] [stdout] 96 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | let k = if let Some(k) = exe.args().get(0).map(String::as_str) { [INFO] [stdout] 98 | | k [INFO] [stdout] 99 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 109 | | std::process::ExitStatus::from_raw(0) [INFO] [stdout] 110 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:119:8 [INFO] [stdout] | [INFO] [stdout] 117 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | ) -> Result { [INFO] [stdout] 119 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 120 | | let k = if let Some(k) = exe.args().get(0).map(String::as_str) { [INFO] [stdout] 121 | | k [INFO] [stdout] 122 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 127 | | std::process::ExitStatus::from_raw(0) [INFO] [stdout] 128 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 138 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] 140 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 141 | | macro_rules! write_stdout { [INFO] [stdout] 142 | | ($bytes:expr) => { [INFO] [stdout] 143 | | if let Err(e) = cfg.io().write_stdout($bytes) { [INFO] [stdout] ... | [INFO] [stdout] 161 | | std::process::ExitStatus::from_raw(0) [INFO] [stdout] 162 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:171:8 [INFO] [stdout] | [INFO] [stdout] 169 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ) -> Result { [INFO] [stdout] 171 | Ok(command::Child::new_task(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 172 | | let var = if let Some(var) = exe.args().get(0).map(String::as_str) { [INFO] [stdout] 173 | | var [INFO] [stdout] 174 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 186 | | std::process::ExitStatus::from_raw(if done { 1 << 8 } else { 0 }) [INFO] [stdout] 187 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:230:8 [INFO] [stdout] | [INFO] [stdout] 225 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | let mut cmd = crate::runner::Command::new_binary(&exe); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | cfg.setup_command(&mut cmd); [INFO] [stdout] 230 | Ok(command::Child::new_wrapped(cmd.spawn(env)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/mod.rs:241:8 [INFO] [stdout] | [INFO] [stdout] 236 | cfg: command::Cfg, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let mut cmd = crate::runner::Command::new_builtin(exe, cfg.io().clone()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | cfg.setup_command(&mut cmd); [INFO] [stdout] 241 | Ok(command::Child::new_wrapped(cmd.spawn(env)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/command.rs:69:30 [INFO] [stdout] | [INFO] [stdout] 68 | fn new(io: Io) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Self { io, pre_exec: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/command.rs:343:20 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn new_task(f: F) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | Self::Task(tokio::task::spawn_blocking(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/command.rs:347:23 [INFO] [stdout] | [INFO] [stdout] 346 | pub fn new_wrapped(child: crate::runner::Child) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | Self::Wrapped(Box::new(child)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/builtins/command.rs:366:18 [INFO] [stdout] | [INFO] [stdout] 358 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 367 | | match self { [INFO] [stdout] 368 | | Self::Task(task) => task.await.map_err(|e| anyhow!(e)), [INFO] [stdout] 369 | | Self::Wrapped(child) => child.status().await, [INFO] [stdout] 370 | | } [INFO] [stdout] 371 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(exe: crate::parse::Exe, io: super::builtins::Io) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | inner: super::builtins::Command::new(exe, io).map_or_else( [INFO] [stdout] | ____________________^ [INFO] [stdout] 18 | | |exe| Self::new_binary(&exe).inner, [INFO] [stdout] 19 | | Inner::Builtin, [INFO] [stdout] 20 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(exe: crate::parse::Exe, io: super::builtins::Io) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | pre_exec: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:18:23 [INFO] [stdout] | [INFO] [stdout] 18 | |exe| Self::new_binary(&exe).inner, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cmd = tokio::process::Command::new(exe.exe()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | inner: Inner::Binary(cmd), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cmd = tokio::process::Command::new(exe.exe()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | pre_exec: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 42 | io: super::builtins::Io, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | inner: super::builtins::Command::new(exe, io) [INFO] [stdout] | ____________________^ [INFO] [stdout] 48 | | .map_or_else(|_| todo!(), Inner::Builtin), [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 42 | io: super::builtins::Io, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | pre_exec: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 115 | |mut pre_exec| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let redirects = redirects.clone(); [INFO] [stdout] 117 | Box::new(move || { [INFO] [stdout] | __________________________^ [INFO] [stdout] 118 | | apply_redirects(&redirects)?; [INFO] [stdout] 119 | | pre_exec()?; [INFO] [stdout] 120 | | Ok(()) [INFO] [stdout] 121 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/command.rs:175:18 [INFO] [stdout] | [INFO] [stdout] 167 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 176 | | match self { [INFO] [stdout] 177 | | // this case is handled by waitpid [INFO] [stdout] 178 | | Self::Binary(_) => unreachable!(), [INFO] [stdout] 179 | | Self::Builtin(child) => Ok(child.status().await?), [INFO] [stdout] 180 | | } [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 96 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | readline: readline::Readline::new(), [INFO] [stdout] 98 | | history: history::History::new(), [INFO] [stdout] 99 | | old_history: old_history::History::new(), [INFO] [stdout] ... | [INFO] [stdout] 106 | | offset, [INFO] [stdout] 107 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/event.rs:17:6 [INFO] [stdout] | [INFO] [stdout] 16 | let (event_w, event_r) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | (Writer::new(event_w), Reader::new(event_r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/event.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 16 | let (event_w, event_r) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | (Writer::new(event_w), Reader::new(event_r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/history/entry.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 18 | event_w: crate::shell::event::Writer, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let (pty, pts) = super::pty::Pty::new(size, event_w.clone()).unwrap(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let (child, fh) = Self::spawn_command(&cmdline, &env, &pts)?; [INFO] [stdout] | ----- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | tokio::spawn(Self::task(child, fh, env.idx(), event_w)); [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | cmdline, [INFO] [stdout] 28 | | env, [INFO] [stdout] 29 | | pty, [INFO] [stdout] ... | [INFO] [stdout] 33 | | state: State::Running((0, 0)), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/history/entry.rs:319:12 [INFO] [stdout] | [INFO] [stdout] 303 | let mut cmd = pty_process::Command::new(crate::info::current_exe()?); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | let fh = unsafe { std::fs::File::from_raw_fd(from_r) }; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | let child = cmd.spawn(pts)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | nix::unistd::close(from_w)?; [INFO] [stdout] 319 | Ok((child, fh)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/history/pty.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 17 | event_w: crate::shell::event::Writer, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | ) -> Result<(Self, pty_process::Pts)> { [INFO] [stdout] 19 | let (request_w, request_r) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | [INFO] [stdout] 21 | let pty = pty_process::Pty::new()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | pty.resize(pty_process::Size::new(size.0, size.1))?; [INFO] [stdout] 23 | let pts = pty.pts()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let vt = std::sync::Arc::new(std::sync::Mutex::new(Vt::new(size))); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok((Self { vt, request_w }, pts)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/inputs/mod.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 18 | input: textmode::blocking::Input, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | event_w: crate::shell::event::Writer, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | ) -> Result { [INFO] [stdout] 21 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | _clock: clock::Handler::new(event_w.clone()), [INFO] [stdout] 23 | | git: git::Handler::new(event_w.clone()), [INFO] [stdout] 24 | | _signals: signals::Handler::new(event_w.clone())?, [INFO] [stdout] 25 | | _stdin: stdin::Handler::new(input, event_w), [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 35 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nbsh` (bin "nbsh" test) due to 36 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b026c02ad81040524e8747ee20fdb066607ffe9046d1673fdf6635b282670eff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b026c02ad81040524e8747ee20fdb066607ffe9046d1673fdf6635b282670eff", kill_on_drop: false }` [INFO] [stdout] b026c02ad81040524e8747ee20fdb066607ffe9046d1673fdf6635b282670eff