[INFO] cloning repository https://github.com/christheblog/graph-commands [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/christheblog/graph-commands" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristheblog%2Fgraph-commands", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristheblog%2Fgraph-commands'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8861930c516adaa8c85ca1628309ded80f9d7d79 [INFO] checking christheblog/graph-commands against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristheblog%2Fgraph-commands" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christheblog/graph-commands on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christheblog/graph-commands [INFO] finished tweaking git repo https://github.com/christheblog/graph-commands [INFO] tweaked toml for git repo https://github.com/christheblog/graph-commands written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/christheblog/graph-commands already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d6937ebae805122ec4a9367e259350e9086390ddc9b13d94e6d854535535876 [INFO] running `Command { std: "docker" "start" "-a" "4d6937ebae805122ec4a9367e259350e9086390ddc9b13d94e6d854535535876", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d6937ebae805122ec4a9367e259350e9086390ddc9b13d94e6d854535535876", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d6937ebae805122ec4a9367e259350e9086390ddc9b13d94e6d854535535876", kill_on_drop: false }` [INFO] [stdout] 4d6937ebae805122ec4a9367e259350e9086390ddc9b13d94e6d854535535876 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4eb7dd6960b2f54b5b909530f02727cc9fa44c7d7ef6ff22bf7b0a767000334 [INFO] running `Command { std: "docker" "start" "-a" "e4eb7dd6960b2f54b5b909530f02727cc9fa44c7d7ef6ff22bf7b0a767000334", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking getrandom v0.1.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.5 [INFO] [stderr] Checking gc-core v0.1.0 (/opt/rustwide/workdir/core) [INFO] [stderr] Checking gc-command v0.1.0 (/opt/rustwide/workdir/command) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> command/src/graph_utils.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | Err(io_err) => Err(io_err.description().to_string()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> command/src/graph_utils.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | Err(io_err) => Err(io_err.description().to_string()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OVERALL_SCORE` is never used [INFO] [stdout] --> command/src/path_formatter.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const OVERALL_SCORE: &str = "{score}"; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OVERALL_SCORE` is never used [INFO] [stdout] --> command/src/path_formatter.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const OVERALL_SCORE: &str = "{score}"; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OVERALL_SCORE_SHORT` is never used [INFO] [stdout] --> command/src/path_formatter.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | const OVERALL_SCORE_SHORT: &str = "%S"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OVERALL_SCORE_SHORT` is never used [INFO] [stdout] --> command/src/path_formatter.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | const OVERALL_SCORE_SHORT: &str = "%S"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NODE_ID` is never used [INFO] [stdout] --> command/src/path_formatter.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const NODE_ID: &str = "{id}"; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NODE_ID` is never used [INFO] [stdout] --> command/src/path_formatter.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const NODE_ID: &str = "{id}"; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NODE_ID_SHORT` is never used [INFO] [stdout] --> command/src/path_formatter.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const NODE_ID_SHORT: &str = "%i"; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NODE_ID_SHORT` is never used [INFO] [stdout] --> command/src/path_formatter.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const NODE_ID_SHORT: &str = "%i"; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `REPEAT` is never used [INFO] [stdout] --> command/src/path_formatter.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const REPEAT: &str = "..."; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `REPEAT` is never used [INFO] [stdout] --> command/src/path_formatter.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const REPEAT: &str = "..."; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> command/src/bin/gc-csp.rs:242:33 [INFO] [stdout] | [INFO] [stdout] 242 | use gc_core::search::a_star;; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:282:14 [INFO] [stdout] | [INFO] [stdout] 282 | for c in constraint_ordered { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 282 | while let Some(c) = constraint_ordered { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 282 | if let Some(c) = constraint_ordered { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:285:14 [INFO] [stdout] | [INFO] [stdout] 285 | for c in constraint_include_cycle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 285 | while let Some(c) = constraint_include_cycle { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 285 | if let Some(c) = constraint_include_cycle { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:288:14 [INFO] [stdout] | [INFO] [stdout] 288 | for c in constraint_no_cycle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 288 | while let Some(c) = constraint_no_cycle { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 288 | if let Some(c) = constraint_no_cycle { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:291:14 [INFO] [stdout] | [INFO] [stdout] 291 | for c in constraint_min_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 291 | while let Some(c) = constraint_min_length { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 291 | if let Some(c) = constraint_min_length { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:294:14 [INFO] [stdout] | [INFO] [stdout] 294 | for c in constraint_max_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 294 | while let Some(c) = constraint_max_length { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 294 | if let Some(c) = constraint_max_length { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:300:14 [INFO] [stdout] | [INFO] [stdout] 300 | for c in constraint_min_score { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 300 | while let Some(c) = constraint_min_score { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 300 | if let Some(c) = constraint_min_score { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:303:14 [INFO] [stdout] | [INFO] [stdout] 303 | for c in constraint_max_score { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 303 | while let Some(c) = constraint_max_score { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 303 | if let Some(c) = constraint_max_score { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-cycle.rs:303:14 [INFO] [stdout] | [INFO] [stdout] 303 | for c in constraint_min_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 303 | while let Some(c) = constraint_min_length { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 303 | if let Some(c) = constraint_min_length { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-cycle.rs:306:14 [INFO] [stdout] | [INFO] [stdout] 306 | for c in constraint_max_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 306 | while let Some(c) = constraint_max_length { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 306 | if let Some(c) = constraint_max_length { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-cycle.rs:312:14 [INFO] [stdout] | [INFO] [stdout] 312 | for c in constraint_min_score { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 312 | while let Some(c) = constraint_min_score { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 312 | if let Some(c) = constraint_min_score { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-cycle.rs:315:14 [INFO] [stdout] | [INFO] [stdout] 315 | for c in constraint_max_score { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 315 | while let Some(c) = constraint_max_score { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 315 | if let Some(c) = constraint_max_score { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> command/src/bin/gc-csp.rs:242:33 [INFO] [stdout] | [INFO] [stdout] 242 | use gc_core::search::a_star;; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> command/src/bin/gc-random.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> command/src/bin/gc-random.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-cycle.rs:303:14 [INFO] [stdout] | [INFO] [stdout] 303 | for c in constraint_min_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 303 | while let Some(c) = constraint_min_length { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 303 | if let Some(c) = constraint_min_length { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-cycle.rs:306:14 [INFO] [stdout] | [INFO] [stdout] 306 | for c in constraint_max_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 306 | while let Some(c) = constraint_max_length { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 306 | if let Some(c) = constraint_max_length { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-cycle.rs:312:14 [INFO] [stdout] | [INFO] [stdout] 312 | for c in constraint_min_score { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 312 | while let Some(c) = constraint_min_score { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 312 | if let Some(c) = constraint_min_score { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-cycle.rs:315:14 [INFO] [stdout] | [INFO] [stdout] 315 | for c in constraint_max_score { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 315 | while let Some(c) = constraint_max_score { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 315 | if let Some(c) = constraint_max_score { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:282:14 [INFO] [stdout] | [INFO] [stdout] 282 | for c in constraint_ordered { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 282 | while let Some(c) = constraint_ordered { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 282 | if let Some(c) = constraint_ordered { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:285:14 [INFO] [stdout] | [INFO] [stdout] 285 | for c in constraint_include_cycle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 285 | while let Some(c) = constraint_include_cycle { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 285 | if let Some(c) = constraint_include_cycle { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:288:14 [INFO] [stdout] | [INFO] [stdout] 288 | for c in constraint_no_cycle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 288 | while let Some(c) = constraint_no_cycle { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 288 | if let Some(c) = constraint_no_cycle { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:291:14 [INFO] [stdout] | [INFO] [stdout] 291 | for c in constraint_min_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 291 | while let Some(c) = constraint_min_length { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 291 | if let Some(c) = constraint_min_length { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:294:14 [INFO] [stdout] | [INFO] [stdout] 294 | for c in constraint_max_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 294 | while let Some(c) = constraint_max_length { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 294 | if let Some(c) = constraint_max_length { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:300:14 [INFO] [stdout] | [INFO] [stdout] 300 | for c in constraint_min_score { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 300 | while let Some(c) = constraint_min_score { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 300 | if let Some(c) = constraint_min_score { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> command/src/bin/gc-csp.rs:303:14 [INFO] [stdout] | [INFO] [stdout] 303 | for c in constraint_max_score { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 303 | while let Some(c) = constraint_max_score { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 303 | if let Some(c) = constraint_max_score { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.11s [INFO] running `Command { std: "docker" "inspect" "e4eb7dd6960b2f54b5b909530f02727cc9fa44c7d7ef6ff22bf7b0a767000334", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4eb7dd6960b2f54b5b909530f02727cc9fa44c7d7ef6ff22bf7b0a767000334", kill_on_drop: false }` [INFO] [stdout] e4eb7dd6960b2f54b5b909530f02727cc9fa44c7d7ef6ff22bf7b0a767000334 [INFO] checking christheblog/graph-commands against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristheblog%2Fgraph-commands" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christheblog/graph-commands on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christheblog/graph-commands [INFO] finished tweaking git repo https://github.com/christheblog/graph-commands [INFO] tweaked toml for git repo https://github.com/christheblog/graph-commands written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/christheblog/graph-commands already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee6e9d4aefa4c6c634f1885f977c0fe39ca615ee051742a3cb5ff3eea9f3b90f [INFO] running `Command { std: "docker" "start" "-a" "ee6e9d4aefa4c6c634f1885f977c0fe39ca615ee051742a3cb5ff3eea9f3b90f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee6e9d4aefa4c6c634f1885f977c0fe39ca615ee051742a3cb5ff3eea9f3b90f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee6e9d4aefa4c6c634f1885f977c0fe39ca615ee051742a3cb5ff3eea9f3b90f", kill_on_drop: false }` [INFO] [stdout] ee6e9d4aefa4c6c634f1885f977c0fe39ca615ee051742a3cb5ff3eea9f3b90f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8131aa3d058987d72876d3ebb72465eefa217c662dc5fb41730c655a96e0210f [INFO] running `Command { std: "docker" "start" "-a" "8131aa3d058987d72876d3ebb72465eefa217c662dc5fb41730c655a96e0210f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking getrandom v0.1.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.5 [INFO] [stderr] Checking gc-core v0.1.0 (/opt/rustwide/workdir/core) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:97:61 [INFO] [stdout] | [INFO] [stdout] 97 | let contains_cycle = constraints.iter().find(|c| **c == ContainsCycle).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 99 | .find(|c| **c == ContainsCycle) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 188 | constraints: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | ) -> impl Iterator { [INFO] [stdout] 190 | constraints.into_iter().filter_map(|nc| match nc { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_best.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 70 | fn empty_best_iter(graph: &DirectedGraph, scorefn: F) -> BestFirstIter [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | visited: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_cycle.rs:136:23 [INFO] [stdout] | [INFO] [stdout] 136 | .filter(|vid| graph.inbound_edges(**vid).count() == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_datastructure.rs:103:34 [INFO] [stdout] | [INFO] [stdout] 102 | fn push(&mut self, elt: T) -> () { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | self.priority_queue.push(Reverse(elt)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/search/a_star.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 17 | g: G, // computing current cost of the path so far [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | h: H, // heuristic [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / iter::iter_best::best_iter_from( [INFO] [stdout] 27 | | graph, [INFO] [stdout] 28 | | |dg, path| g(dg, path) + h(dg, path), // f = g + h [INFO] [stdout] 29 | | start, [INFO] [stdout] 30 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/search/a_star.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 43 | g: G, // Cost of the path so far [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | h: H, // Heuristic - estimated cost to target [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | constraints: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let all_constraints = constraints.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / iter::iter_best_constraint::constrained_best_iter_from( [INFO] [stdout] 55 | | graph, [INFO] [stdout] 56 | | |dg, path| g(dg, path) + h(dg, path), // f = g + h [INFO] [stdout] 57 | | constraints, [INFO] [stdout] 58 | | start, [INFO] [stdout] 59 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gc-core` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:97:61 [INFO] [stdout] | [INFO] [stdout] 97 | let contains_cycle = constraints.iter().find(|c| **c == ContainsCycle).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 99 | .find(|c| **c == ContainsCycle) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/constraint/checker.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 188 | constraints: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | ) -> impl Iterator { [INFO] [stdout] 190 | constraints.into_iter().filter_map(|nc| match nc { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_best.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 70 | fn empty_best_iter(graph: &DirectedGraph, scorefn: F) -> BestFirstIter [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | visited: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_cycle.rs:136:23 [INFO] [stdout] | [INFO] [stdout] 136 | .filter(|vid| graph.inbound_edges(**vid).count() == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/iter/iter_datastructure.rs:103:34 [INFO] [stdout] | [INFO] [stdout] 102 | fn push(&mut self, elt: T) -> () { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | self.priority_queue.push(Reverse(elt)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/search/a_star.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 17 | g: G, // computing current cost of the path so far [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | h: H, // heuristic [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / iter::iter_best::best_iter_from( [INFO] [stdout] 27 | | graph, [INFO] [stdout] 28 | | |dg, path| g(dg, path) + h(dg, path), // f = g + h [INFO] [stdout] 29 | | start, [INFO] [stdout] 30 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/search/a_star.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 43 | g: G, // Cost of the path so far [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | h: H, // Heuristic - estimated cost to target [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | constraints: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let all_constraints = constraints.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / iter::iter_best_constraint::constrained_best_iter_from( [INFO] [stdout] 55 | | graph, [INFO] [stdout] 56 | | |dg, path| g(dg, path) + h(dg, path), // f = g + h [INFO] [stdout] 57 | | constraints, [INFO] [stdout] 58 | | start, [INFO] [stdout] 59 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gc-core` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "8131aa3d058987d72876d3ebb72465eefa217c662dc5fb41730c655a96e0210f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8131aa3d058987d72876d3ebb72465eefa217c662dc5fb41730c655a96e0210f", kill_on_drop: false }` [INFO] [stdout] 8131aa3d058987d72876d3ebb72465eefa217c662dc5fb41730c655a96e0210f