[INFO] cloning repository https://github.com/Xzyaihni/rustcsvthingy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Xzyaihni/rustcsvthingy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXzyaihni%2Frustcsvthingy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXzyaihni%2Frustcsvthingy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 808ef854ffd02416657ea50103c620308685c9d9 [INFO] checking Xzyaihni/rustcsvthingy against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXzyaihni%2Frustcsvthingy" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Xzyaihni/rustcsvthingy on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Xzyaihni/rustcsvthingy [INFO] finished tweaking git repo https://github.com/Xzyaihni/rustcsvthingy [INFO] tweaked toml for git repo https://github.com/Xzyaihni/rustcsvthingy written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/Xzyaihni/rustcsvthingy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1157465956f6febfeb2db54f493f3030822e13cbb3ef806e2d19cd39ff33834b [INFO] running `Command { std: "docker" "start" "-a" "1157465956f6febfeb2db54f493f3030822e13cbb3ef806e2d19cd39ff33834b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1157465956f6febfeb2db54f493f3030822e13cbb3ef806e2d19cd39ff33834b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1157465956f6febfeb2db54f493f3030822e13cbb3ef806e2d19cd39ff33834b", kill_on_drop: false }` [INFO] [stdout] 1157465956f6febfeb2db54f493f3030822e13cbb3ef806e2d19cd39ff33834b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad9f2f37a1fe593a21307046d7b4560218197afed621892a58112c7c12337a17 [INFO] running `Command { std: "docker" "start" "-a" "ad9f2f37a1fe593a21307046d7b4560218197afed621892a58112c7c12337a17", kill_on_drop: false }` [INFO] [stderr] Checking quizanalyze v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:298:47 [INFO] [stdout] | [INFO] [stdout] 298 | replies.filter(|choice| mapping.get(choice.clone()).is_some()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:310:38 [INFO] [stdout] | [INFO] [stdout] 310 | let other = mapping.get(other.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:311:42 [INFO] [stdout] | [INFO] [stdout] 311 | let current = mapping.get(current.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:327:47 [INFO] [stdout] | [INFO] [stdout] 327 | let mut sorted: Vec = Vec::from(slice.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[i32]` does not implement `Clone`, so calling `clone` on `&[i32]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:298:47 [INFO] [stdout] | [INFO] [stdout] 298 | replies.filter(|choice| mapping.get(choice.clone()).is_some()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:310:38 [INFO] [stdout] | [INFO] [stdout] 310 | let other = mapping.get(other.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:311:42 [INFO] [stdout] | [INFO] [stdout] 311 | let current = mapping.get(current.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:327:47 [INFO] [stdout] | [INFO] [stdout] 327 | let mut sorted: Vec = Vec::from(slice.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[i32]` does not implement `Clone`, so calling `clone` on `&[i32]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.13s [INFO] running `Command { std: "docker" "inspect" "ad9f2f37a1fe593a21307046d7b4560218197afed621892a58112c7c12337a17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad9f2f37a1fe593a21307046d7b4560218197afed621892a58112c7c12337a17", kill_on_drop: false }` [INFO] [stdout] ad9f2f37a1fe593a21307046d7b4560218197afed621892a58112c7c12337a17 [INFO] checking Xzyaihni/rustcsvthingy against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXzyaihni%2Frustcsvthingy" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Xzyaihni/rustcsvthingy on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Xzyaihni/rustcsvthingy [INFO] finished tweaking git repo https://github.com/Xzyaihni/rustcsvthingy [INFO] tweaked toml for git repo https://github.com/Xzyaihni/rustcsvthingy written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Xzyaihni/rustcsvthingy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ddd65f38a659f6a6ea5c27ce5a898298d0ca0819917b9269c054bc0b8bf815be [INFO] running `Command { std: "docker" "start" "-a" "ddd65f38a659f6a6ea5c27ce5a898298d0ca0819917b9269c054bc0b8bf815be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ddd65f38a659f6a6ea5c27ce5a898298d0ca0819917b9269c054bc0b8bf815be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddd65f38a659f6a6ea5c27ce5a898298d0ca0819917b9269c054bc0b8bf815be", kill_on_drop: false }` [INFO] [stdout] ddd65f38a659f6a6ea5c27ce5a898298d0ca0819917b9269c054bc0b8bf815be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ce000c7e7e0165610fe6e0001d64acdf2b58c64ea244f43736c75240182083c [INFO] running `Command { std: "docker" "start" "-a" "8ce000c7e7e0165610fe6e0001d64acdf2b58c64ea244f43736c75240182083c", kill_on_drop: false }` [INFO] [stderr] Checking quizanalyze v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:298:5 [INFO] [stdout] | [INFO] [stdout] 295 | replies: impl Iterator, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | / replies.filter(|choice| mapping.get(choice.clone()).is_some()) [INFO] [stdout] 299 | | .map(|choice| [INFO] [stdout] 300 | | { [INFO] [stdout] 301 | | mapping.get(choice) [INFO] [stdout] 302 | | .expect("all invalid values should be filtered").clone() [INFO] [stdout] 303 | | }).collect() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:298:47 [INFO] [stdout] | [INFO] [stdout] 298 | replies.filter(|choice| mapping.get(choice.clone()).is_some()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:310:38 [INFO] [stdout] | [INFO] [stdout] 310 | let other = mapping.get(other.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:311:42 [INFO] [stdout] | [INFO] [stdout] 311 | let current = mapping.get(current.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:327:47 [INFO] [stdout] | [INFO] [stdout] 327 | let mut sorted: Vec = Vec::from(slice.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[i32]` does not implement `Clone`, so calling `clone` on `&[i32]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:298:5 [INFO] [stdout] | [INFO] [stdout] 295 | replies: impl Iterator, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | / replies.filter(|choice| mapping.get(choice.clone()).is_some()) [INFO] [stdout] 299 | | .map(|choice| [INFO] [stdout] 300 | | { [INFO] [stdout] 301 | | mapping.get(choice) [INFO] [stdout] 302 | | .expect("all invalid values should be filtered").clone() [INFO] [stdout] 303 | | }).collect() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:298:47 [INFO] [stdout] | [INFO] [stdout] 298 | replies.filter(|choice| mapping.get(choice.clone()).is_some()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:310:38 [INFO] [stdout] | [INFO] [stdout] 310 | let other = mapping.get(other.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:311:42 [INFO] [stdout] | [INFO] [stdout] 311 | let current = mapping.get(current.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:327:47 [INFO] [stdout] | [INFO] [stdout] 327 | let mut sorted: Vec = Vec::from(slice.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[i32]` does not implement `Clone`, so calling `clone` on `&[i32]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quizanalyze` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quizanalyze` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8ce000c7e7e0165610fe6e0001d64acdf2b58c64ea244f43736c75240182083c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ce000c7e7e0165610fe6e0001d64acdf2b58c64ea244f43736c75240182083c", kill_on_drop: false }` [INFO] [stdout] 8ce000c7e7e0165610fe6e0001d64acdf2b58c64ea244f43736c75240182083c