[INFO] cloning repository https://github.com/Raibows/MLinRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Raibows/MLinRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaibows%2FMLinRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaibows%2FMLinRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b46f0e240a38fb62e4947c627f3c48945131ae82 [INFO] checking Raibows/MLinRust against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaibows%2FMLinRust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Raibows/MLinRust on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Raibows/MLinRust [INFO] finished tweaking git repo https://github.com/Raibows/MLinRust [INFO] tweaked toml for git repo https://github.com/Raibows/MLinRust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/Raibows/MLinRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a4ffb891cc2c84446439856f836522e843a5b15270a564d5a48c2f49242ade6e [INFO] running `Command { std: "docker" "start" "-a" "a4ffb891cc2c84446439856f836522e843a5b15270a564d5a48c2f49242ade6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a4ffb891cc2c84446439856f836522e843a5b15270a564d5a48c2f49242ade6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4ffb891cc2c84446439856f836522e843a5b15270a564d5a48c2f49242ade6e", kill_on_drop: false }` [INFO] [stdout] a4ffb891cc2c84446439856f836522e843a5b15270a564d5a48c2f49242ade6e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01bdd9f23df0e70e0dc6923ab0a0815cc2ec934c4ca3d21b91d250483dfb79f5 [INFO] running `Command { std: "docker" "start" "-a" "01bdd9f23df0e70e0dc6923ab0a0815cc2ec934c4ca3d21b91d250483dfb79f5", kill_on_drop: false }` [INFO] [stderr] Checking mlinrust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:97:51 [INFO] [stdout] | [INFO] [stdout] 97 | let mut node = self.root.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 97 - let mut node = self.root.as_ref().unwrap().clone(); [INFO] [stdout] 97 + let mut node = self.root.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:101:52 [INFO] [stdout] | [INFO] [stdout] 101 | node = &node.left.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 101 - node = &node.left.as_ref().unwrap().clone(); [INFO] [stdout] 101 + node = &node.left.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:103:53 [INFO] [stdout] | [INFO] [stdout] 103 | node = &node.right.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 103 - node = &node.right.as_ref().unwrap().clone(); [INFO] [stdout] 103 + node = &node.right.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:97:51 [INFO] [stdout] | [INFO] [stdout] 97 | let mut node = self.root.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 97 - let mut node = self.root.as_ref().unwrap().clone(); [INFO] [stdout] 97 + let mut node = self.root.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:101:52 [INFO] [stdout] | [INFO] [stdout] 101 | node = &node.left.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 101 - node = &node.left.as_ref().unwrap().clone(); [INFO] [stdout] 101 + node = &node.left.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:103:53 [INFO] [stdout] | [INFO] [stdout] 103 | node = &node.right.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 103 - node = &node.right.as_ref().unwrap().clone(); [INFO] [stdout] 103 + node = &node.right.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `Command { std: "docker" "inspect" "01bdd9f23df0e70e0dc6923ab0a0815cc2ec934c4ca3d21b91d250483dfb79f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01bdd9f23df0e70e0dc6923ab0a0815cc2ec934c4ca3d21b91d250483dfb79f5", kill_on_drop: false }` [INFO] [stdout] 01bdd9f23df0e70e0dc6923ab0a0815cc2ec934c4ca3d21b91d250483dfb79f5 [INFO] checking Raibows/MLinRust against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaibows%2FMLinRust" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Raibows/MLinRust on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Raibows/MLinRust [INFO] finished tweaking git repo https://github.com/Raibows/MLinRust [INFO] tweaked toml for git repo https://github.com/Raibows/MLinRust written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Raibows/MLinRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dfb959e0da2bc5553ec0dd00f53cfe2e4ac2056e37b9ebea6c40908e93597875 [INFO] running `Command { std: "docker" "start" "-a" "dfb959e0da2bc5553ec0dd00f53cfe2e4ac2056e37b9ebea6c40908e93597875", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dfb959e0da2bc5553ec0dd00f53cfe2e4ac2056e37b9ebea6c40908e93597875", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dfb959e0da2bc5553ec0dd00f53cfe2e4ac2056e37b9ebea6c40908e93597875", kill_on_drop: false }` [INFO] [stdout] dfb959e0da2bc5553ec0dd00f53cfe2e4ac2056e37b9ebea6c40908e93597875 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 47b26196e1d59bb29b293dc3a254fdbcd787aecc31ff6ecce39a03c9ba0bb7ae [INFO] running `Command { std: "docker" "start" "-a" "47b26196e1d59bb29b293dc3a254fdbcd787aecc31ff6ecce39a03c9ba0bb7ae", kill_on_drop: false }` [INFO] [stderr] Checking mlinrust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/utils.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 32 | res.into_iter().map(|item| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | / item.into_iter().enumerate().map(|(i, e)| { [INFO] [stdout] 34 | | if let Ok(v) = e { [INFO] [stdout] 35 | | v [INFO] [stdout] 36 | | } else { [INFO] [stdout] 37 | | counter[i] [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | }).collect::>() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/utils.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 43 | res.into_iter().map(|item| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | / item.into_iter().map(|e| { [INFO] [stdout] 45 | | if let Ok(v) = e { [INFO] [stdout] 46 | | v [INFO] [stdout] 47 | | } else { [INFO] [stdout] 48 | | 0.0 [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | }).collect::>() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/utils.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 54 | res.into_iter().map(|item| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | / item.into_iter().map(|e| { [INFO] [stdout] 56 | | if let Ok(v) = e { [INFO] [stdout] 57 | | v [INFO] [stdout] 58 | | } else { [INFO] [stdout] 59 | | value [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | }).collect::>() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:97:51 [INFO] [stdout] | [INFO] [stdout] 97 | let mut node = self.root.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 97 - let mut node = self.root.as_ref().unwrap().clone(); [INFO] [stdout] 97 + let mut node = self.root.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:101:52 [INFO] [stdout] | [INFO] [stdout] 101 | node = &node.left.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 101 - node = &node.left.as_ref().unwrap().clone(); [INFO] [stdout] 101 + node = &node.left.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:103:53 [INFO] [stdout] | [INFO] [stdout] 103 | node = &node.right.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 103 - node = &node.right.as_ref().unwrap().clone(); [INFO] [stdout] 103 + node = &node.right.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mlinrust` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/utils.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 32 | res.into_iter().map(|item| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | / item.into_iter().enumerate().map(|(i, e)| { [INFO] [stdout] 34 | | if let Ok(v) = e { [INFO] [stdout] 35 | | v [INFO] [stdout] 36 | | } else { [INFO] [stdout] 37 | | counter[i] [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | }).collect::>() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/utils.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 43 | res.into_iter().map(|item| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | / item.into_iter().map(|e| { [INFO] [stdout] 45 | | if let Ok(v) = e { [INFO] [stdout] 46 | | v [INFO] [stdout] 47 | | } else { [INFO] [stdout] 48 | | 0.0 [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | }).collect::>() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/utils.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 54 | res.into_iter().map(|item| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | / item.into_iter().map(|e| { [INFO] [stdout] 56 | | if let Ok(v) = e { [INFO] [stdout] 57 | | v [INFO] [stdout] 58 | | } else { [INFO] [stdout] 59 | | value [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | }).collect::>() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:97:51 [INFO] [stdout] | [INFO] [stdout] 97 | let mut node = self.root.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 97 - let mut node = self.root.as_ref().unwrap().clone(); [INFO] [stdout] 97 + let mut node = self.root.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:101:52 [INFO] [stdout] | [INFO] [stdout] 101 | node = &node.left.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 101 - node = &node.left.as_ref().unwrap().clone(); [INFO] [stdout] 101 + node = &node.left.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/decision_tree.rs:103:53 [INFO] [stdout] | [INFO] [stdout] 103 | node = &node.right.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box>` does not implement `Clone`, so calling `clone` on `&Box>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 103 - node = &node.right.as_ref().unwrap().clone(); [INFO] [stdout] 103 + node = &node.right.as_ref().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mlinrust` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "47b26196e1d59bb29b293dc3a254fdbcd787aecc31ff6ecce39a03c9ba0bb7ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47b26196e1d59bb29b293dc3a254fdbcd787aecc31ff6ecce39a03c9ba0bb7ae", kill_on_drop: false }` [INFO] [stdout] 47b26196e1d59bb29b293dc3a254fdbcd787aecc31ff6ecce39a03c9ba0bb7ae