[INFO] cloning repository https://github.com/MadyLab/tree [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MadyLab/tree" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMadyLab%2Ftree", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMadyLab%2Ftree'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dd523135f723bfdf2837a036f81777a48e63f257 [INFO] checking MadyLab/tree against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMadyLab%2Ftree" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MadyLab/tree on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MadyLab/tree [INFO] finished tweaking git repo https://github.com/MadyLab/tree [INFO] tweaked toml for git repo https://github.com/MadyLab/tree written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/MadyLab/tree already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6617980ed87789819aa261ce9fae7ff805a07f59c3d24bd8af85bee764d9440e [INFO] running `Command { std: "docker" "start" "-a" "6617980ed87789819aa261ce9fae7ff805a07f59c3d24bd8af85bee764d9440e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6617980ed87789819aa261ce9fae7ff805a07f59c3d24bd8af85bee764d9440e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6617980ed87789819aa261ce9fae7ff805a07f59c3d24bd8af85bee764d9440e", kill_on_drop: false }` [INFO] [stdout] 6617980ed87789819aa261ce9fae7ff805a07f59c3d24bd8af85bee764d9440e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 73f19fa988bf045dd35d593697fdcc72bfd59a787ad5bde92881a91e20497395 [INFO] running `Command { std: "docker" "start" "-a" "73f19fa988bf045dd35d593697fdcc72bfd59a787ad5bde92881a91e20497395", kill_on_drop: false }` [INFO] [stderr] Checking tree v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> tests/merge.rs:18:65 [INFO] [stdout] | [INFO] [stdout] 18 | .map(|(_, node)| node.children().next().unwrap().1.get().clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> tests/clone.rs:15:75 [INFO] [stdout] | [INFO] [stdout] 15 | let node2_result: Vec<&str> = node2.children().map(|(edge, _)| (*edge).clone()).collect(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> tests/clone.rs:18:75 [INFO] [stdout] | [INFO] [stdout] 18 | let node3_result: Vec<&str> = node3.children().map(|(edge, _)| (*edge).clone()).collect(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s [INFO] running `Command { std: "docker" "inspect" "73f19fa988bf045dd35d593697fdcc72bfd59a787ad5bde92881a91e20497395", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73f19fa988bf045dd35d593697fdcc72bfd59a787ad5bde92881a91e20497395", kill_on_drop: false }` [INFO] [stdout] 73f19fa988bf045dd35d593697fdcc72bfd59a787ad5bde92881a91e20497395 [INFO] checking MadyLab/tree against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMadyLab%2Ftree" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MadyLab/tree on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MadyLab/tree [INFO] finished tweaking git repo https://github.com/MadyLab/tree [INFO] tweaked toml for git repo https://github.com/MadyLab/tree written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MadyLab/tree already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f6929acf5fc43bc139b4ad382aac1be6c6499dbe6ceb0e9618ead3903c005c61 [INFO] running `Command { std: "docker" "start" "-a" "f6929acf5fc43bc139b4ad382aac1be6c6499dbe6ceb0e9618ead3903c005c61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f6929acf5fc43bc139b4ad382aac1be6c6499dbe6ceb0e9618ead3903c005c61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6929acf5fc43bc139b4ad382aac1be6c6499dbe6ceb0e9618ead3903c005c61", kill_on_drop: false }` [INFO] [stdout] f6929acf5fc43bc139b4ad382aac1be6c6499dbe6ceb0e9618ead3903c005c61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c9555904d2bd11bdc578ba27180549556b88c35d193936d9ea1dc86f52e4ee36 [INFO] running `Command { std: "docker" "start" "-a" "c9555904d2bd11bdc578ba27180549556b88c35d193936d9ea1dc86f52e4ee36", kill_on_drop: false }` [INFO] [stderr] Checking tree v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(data: N) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | version: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(data: N) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | raw: RawNode::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 195 | fn new(data: N) -> Rc { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Rc::new(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 197 | | data: Rc::new(data), [INFO] [stdout] 198 | | edges: Default::default(), [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 47 | let mut cache = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Rc::new(Version { [INFO] [stdout] | _________________^ [INFO] [stdout] 63 | | cache: Some(cache), [INFO] [stdout] 64 | | parents: self.parents.clone(), [INFO] [stdout] 65 | | garbage: self.garbage.clone(), [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(data: N) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | version: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(data: N) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | raw: RawNode::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 195 | fn new(data: N) -> Rc { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Rc::new(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 197 | | data: Rc::new(data), [INFO] [stdout] 198 | | edges: Default::default(), [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 47 | let mut cache = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Rc::new(Version { [INFO] [stdout] | _________________^ [INFO] [stdout] 63 | | cache: Some(cache), [INFO] [stdout] 64 | | parents: self.parents.clone(), [INFO] [stdout] 65 | | garbage: self.garbage.clone(), [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tree` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tree` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "c9555904d2bd11bdc578ba27180549556b88c35d193936d9ea1dc86f52e4ee36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9555904d2bd11bdc578ba27180549556b88c35d193936d9ea1dc86f52e4ee36", kill_on_drop: false }` [INFO] [stdout] c9555904d2bd11bdc578ba27180549556b88c35d193936d9ea1dc86f52e4ee36