[INFO] cloning repository https://github.com/JustBobinAround/fi [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JustBobinAround/fi" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJustBobinAround%2Ffi", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJustBobinAround%2Ffi'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2ecf2aab8e68f7f2a59534431804f221988ad20e [INFO] checking JustBobinAround/fi against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJustBobinAround%2Ffi" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JustBobinAround/fi on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JustBobinAround/fi [INFO] finished tweaking git repo https://github.com/JustBobinAround/fi [INFO] tweaked toml for git repo https://github.com/JustBobinAround/fi written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/JustBobinAround/fi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ioctl-rs v0.1.6 [INFO] [stderr] Downloaded serial-unix v0.4.0 [INFO] [stderr] Downloaded serial v0.4.0 [INFO] [stderr] Downloaded termios v0.2.2 [INFO] [stderr] Downloaded serial-core v0.4.0 [INFO] [stderr] Downloaded filedescriptor v0.8.2 [INFO] [stderr] Downloaded serial-windows v0.4.0 [INFO] [stderr] Downloaded portable-pty v0.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9682c276c7798217177a2f764b9b9d0dd2b8edc2744fa955e5431bb68e48dc6d [INFO] running `Command { std: "docker" "start" "-a" "9682c276c7798217177a2f764b9b9d0dd2b8edc2744fa955e5431bb68e48dc6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9682c276c7798217177a2f764b9b9d0dd2b8edc2744fa955e5431bb68e48dc6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9682c276c7798217177a2f764b9b9d0dd2b8edc2744fa955e5431bb68e48dc6d", kill_on_drop: false }` [INFO] [stdout] 9682c276c7798217177a2f764b9b9d0dd2b8edc2744fa955e5431bb68e48dc6d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a44ae29118bcf72a05d2fe7b4f79bd346c48b10102a765efed6a849eb115f645 [INFO] running `Command { std: "docker" "start" "-a" "a44ae29118bcf72a05d2fe7b4f79bd346c48b10102a765efed6a849eb115f645", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking filedescriptor v0.8.2 [INFO] [stderr] Checking portable-pty v0.8.1 [INFO] [stderr] Checking fi v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/pty/raw_mode.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | sync::{Arc, Mutex} [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/pty/raw_mode.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | sync::{Arc, Mutex} [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rgb` [INFO] [stdout] --> src/ascii/escapes.rs:556:41 [INFO] [stdout] | [INFO] [stdout] 556 | ... let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rgb` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rgb` [INFO] [stdout] --> src/ascii/escapes.rs:556:41 [INFO] [stdout] | [INFO] [stdout] 556 | ... let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rgb` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ascii/escapes.rs:556:37 [INFO] [stdout] | [INFO] [stdout] 556 | ... let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rgb` [INFO] [stdout] --> src/ascii/escapes.rs:835:33 [INFO] [stdout] | [INFO] [stdout] 835 | let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rgb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ascii/escapes.rs:556:37 [INFO] [stdout] | [INFO] [stdout] 556 | ... let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rgb` [INFO] [stdout] --> src/ascii/escapes.rs:835:33 [INFO] [stdout] | [INFO] [stdout] 835 | let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rgb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ascii/escapes.rs:835:29 [INFO] [stdout] | [INFO] [stdout] 835 | let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ascii/escapes.rs:835:29 [INFO] [stdout] | [INFO] [stdout] 835 | let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x_offset` and `y_offset` are never read [INFO] [stdout] --> src/ascii/escapes.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct EscapeWriter<'a, T: Write> { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 79 | x_offset: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 80 | y_offset: u32 [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `buffer_hist`, `size_x`, `size_y`, `offset_x`, and `offset_y` are never read [INFO] [stdout] --> src/pty/forker.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct PTerminal{ [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | buffer_hist: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | size_x: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 20 | size_y: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 21 | offset_x: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | offset_y: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read` is never used [INFO] [stdout] --> src/pty/raw_mode.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 67 | impl FileDesc { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn read(&self, buffer: &mut [u8], size: usize) -> io::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x_offset` and `y_offset` are never read [INFO] [stdout] --> src/ascii/escapes.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct EscapeWriter<'a, T: Write> { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 79 | x_offset: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 80 | y_offset: u32 [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `buffer_hist`, `size_x`, `size_y`, `offset_x`, and `offset_y` are never read [INFO] [stdout] --> src/pty/forker.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct PTerminal{ [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | buffer_hist: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | size_x: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 20 | size_y: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 21 | offset_x: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | offset_y: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read` is never used [INFO] [stdout] --> src/pty/raw_mode.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 67 | impl FileDesc { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn read(&self, buffer: &mut [u8], size: usize) -> io::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `portable_pty::CommandBuilder` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use portable_pty::CommandBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `portable_pty::CommandBuilder` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use portable_pty::CommandBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/main.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 20 | Sequence::Text(text) => println!("Text: {:?}", text), [INFO] [stdout] | -------------------- matches some of the same values [INFO] [stdout] 21 | Sequence::Escape(esc) => println!("Escape: {:?}", esc), [INFO] [stdout] | --------------------- matches some of the same values [INFO] [stdout] 22 | _ => {} [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/main.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 20 | Sequence::Text(text) => println!("Text: {:?}", text), [INFO] [stdout] | -------------------- matches some of the same values [INFO] [stdout] 21 | Sequence::Escape(esc) => println!("Escape: {:?}", esc), [INFO] [stdout] | --------------------- matches some of the same values [INFO] [stdout] 22 | _ => {} [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p_term` [INFO] [stdout] --> src/main.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | let (handle,p_term) = PTerminal::new(80, 40, 0, 0)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_p_term` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p_term` [INFO] [stdout] --> src/main.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | let (handle,p_term) = PTerminal::new(80, 40, 0, 0)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_p_term` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | let mut buffer = Vec::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | let mut buffer = Vec::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | handle.join(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 29 | let _ = handle.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | handle.join(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 29 | let _ = handle.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.62s [INFO] running `Command { std: "docker" "inspect" "a44ae29118bcf72a05d2fe7b4f79bd346c48b10102a765efed6a849eb115f645", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a44ae29118bcf72a05d2fe7b4f79bd346c48b10102a765efed6a849eb115f645", kill_on_drop: false }` [INFO] [stdout] a44ae29118bcf72a05d2fe7b4f79bd346c48b10102a765efed6a849eb115f645 [INFO] checking JustBobinAround/fi against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJustBobinAround%2Ffi" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JustBobinAround/fi on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JustBobinAround/fi [INFO] finished tweaking git repo https://github.com/JustBobinAround/fi [INFO] tweaked toml for git repo https://github.com/JustBobinAround/fi written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JustBobinAround/fi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f6b6330ff36a80c66f0e61910bdf6494bc2e05e9e0eaf6f870921ee8b292b7f5 [INFO] running `Command { std: "docker" "start" "-a" "f6b6330ff36a80c66f0e61910bdf6494bc2e05e9e0eaf6f870921ee8b292b7f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f6b6330ff36a80c66f0e61910bdf6494bc2e05e9e0eaf6f870921ee8b292b7f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6b6330ff36a80c66f0e61910bdf6494bc2e05e9e0eaf6f870921ee8b292b7f5", kill_on_drop: false }` [INFO] [stdout] f6b6330ff36a80c66f0e61910bdf6494bc2e05e9e0eaf6f870921ee8b292b7f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93b576e847b440aefa119c882c552f46a039f87001e4f02f4d63de3c4c5b3206 [INFO] running `Command { std: "docker" "start" "-a" "93b576e847b440aefa119c882c552f46a039f87001e4f02f4d63de3c4c5b3206", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking filedescriptor v0.8.2 [INFO] [stderr] Checking portable-pty v0.8.1 [INFO] [stderr] Checking fi v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/pty/raw_mode.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | sync::{Arc, Mutex} [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/pty/raw_mode.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | sync::{Arc, Mutex} [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rgb` [INFO] [stdout] --> src/ascii/escapes.rs:556:41 [INFO] [stdout] | [INFO] [stdout] 556 | ... let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rgb` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ascii/escapes.rs:556:37 [INFO] [stdout] | [INFO] [stdout] 556 | ... let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rgb` [INFO] [stdout] --> src/ascii/escapes.rs:835:33 [INFO] [stdout] | [INFO] [stdout] 835 | let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rgb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ascii/escapes.rs:835:29 [INFO] [stdout] | [INFO] [stdout] 835 | let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x_offset` and `y_offset` are never read [INFO] [stdout] --> src/ascii/escapes.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct EscapeWriter<'a, T: Write> { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 79 | x_offset: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 80 | y_offset: u32 [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `buffer_hist`, `size_x`, `size_y`, `offset_x`, and `offset_y` are never read [INFO] [stdout] --> src/pty/forker.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct PTerminal{ [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | buffer_hist: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | size_x: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 20 | size_y: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 21 | offset_x: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | offset_y: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read` is never used [INFO] [stdout] --> src/pty/raw_mode.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 67 | impl FileDesc { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn read(&self, buffer: &mut [u8], size: usize) -> io::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rgb` [INFO] [stdout] --> src/ascii/escapes.rs:556:41 [INFO] [stdout] | [INFO] [stdout] 556 | ... let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rgb` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pty/forker.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 40 | let pair = native_pty_system().openpty(PtySize { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let pair = match pair { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(pair) => {pair}, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let child = match pair.slave.spawn_command(cmd) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Ok(child) => {child}, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let reader = Arc::new(Mutex::new(pair.master.try_clone_reader().expect("OOF"))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let writer = pair.master.take_writer().expect("OOF"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let p_term = Arc::new(Mutex::new(PTerminal { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let p_term_2 = p_term.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let p_term_3 = p_term.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let pty_handler = std::thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let _key_listener_handler = std::thread::spawn(move || { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok((pty_handler,p_term)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ascii/escapes.rs:556:37 [INFO] [stdout] | [INFO] [stdout] 556 | ... let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rgb` [INFO] [stdout] --> src/ascii/escapes.rs:835:33 [INFO] [stdout] | [INFO] [stdout] 835 | let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rgb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ascii/escapes.rs:835:29 [INFO] [stdout] | [INFO] [stdout] 835 | let mut rgb = (-1,-1 ,-1); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fi` (lib) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `x_offset` and `y_offset` are never read [INFO] [stdout] --> src/ascii/escapes.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct EscapeWriter<'a, T: Write> { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 79 | x_offset: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 80 | y_offset: u32 [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `buffer_hist`, `size_x`, `size_y`, `offset_x`, and `offset_y` are never read [INFO] [stdout] --> src/pty/forker.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct PTerminal{ [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | buffer_hist: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | size_x: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 20 | size_y: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 21 | offset_x: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | offset_y: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read` is never used [INFO] [stdout] --> src/pty/raw_mode.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 67 | impl FileDesc { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn read(&self, buffer: &mut [u8], size: usize) -> io::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pty/forker.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 40 | let pair = native_pty_system().openpty(PtySize { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let pair = match pair { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(pair) => {pair}, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let child = match pair.slave.spawn_command(cmd) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Ok(child) => {child}, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let reader = Arc::new(Mutex::new(pair.master.try_clone_reader().expect("OOF"))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let writer = pair.master.take_writer().expect("OOF"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let p_term = Arc::new(Mutex::new(PTerminal { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let p_term_2 = p_term.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let p_term_3 = p_term.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let pty_handler = std::thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let _key_listener_handler = std::thread::spawn(move || { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok((pty_handler,p_term)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fi` (lib test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "93b576e847b440aefa119c882c552f46a039f87001e4f02f4d63de3c4c5b3206", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93b576e847b440aefa119c882c552f46a039f87001e4f02f4d63de3c4c5b3206", kill_on_drop: false }` [INFO] [stdout] 93b576e847b440aefa119c882c552f46a039f87001e4f02f4d63de3c4c5b3206