[INFO] cloning repository https://github.com/ExcaliburZero/jvm-class-file-parser [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ExcaliburZero/jvm-class-file-parser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FExcaliburZero%2Fjvm-class-file-parser", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FExcaliburZero%2Fjvm-class-file-parser'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5435b9159c2901abaa5f1c5cc6a462abffeaec29 [INFO] checking ExcaliburZero/jvm-class-file-parser against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FExcaliburZero%2Fjvm-class-file-parser" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ExcaliburZero/jvm-class-file-parser on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ExcaliburZero/jvm-class-file-parser [INFO] finished tweaking git repo https://github.com/ExcaliburZero/jvm-class-file-parser [INFO] tweaked toml for git repo https://github.com/ExcaliburZero/jvm-class-file-parser written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/ExcaliburZero/jvm-class-file-parser already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dtoa v0.4.6 [INFO] [stderr] Downloaded yaml-rust v0.4.4 [INFO] [stderr] Downloaded serde_yaml v0.8.14 [INFO] [stderr] Downloaded serde_derive v1.0.117 [INFO] [stderr] Downloaded terminal_size v0.1.15 [INFO] [stderr] Downloaded console v0.12.0 [INFO] [stderr] Downloaded termios v0.3.3 [INFO] [stderr] Downloaded insta v1.3.0 [INFO] [stderr] Downloaded serde v1.0.117 [INFO] [stderr] Downloaded serde_json v1.0.59 [INFO] [stderr] Downloaded syn v1.0.48 [INFO] [stderr] Downloaded libc v0.2.80 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c3fc0ae60b126fedbc847eff532618202cdd207a399c5889dff838bd4621f366 [INFO] running `Command { std: "docker" "start" "-a" "c3fc0ae60b126fedbc847eff532618202cdd207a399c5889dff838bd4621f366", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c3fc0ae60b126fedbc847eff532618202cdd207a399c5889dff838bd4621f366", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3fc0ae60b126fedbc847eff532618202cdd207a399c5889dff838bd4621f366", kill_on_drop: false }` [INFO] [stdout] c3fc0ae60b126fedbc847eff532618202cdd207a399c5889dff838bd4621f366 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1605167848a3a79dbc270a4af271f0f2ad99f4acf376bad0c070b8ea114da5a1 [INFO] running `Command { std: "docker" "start" "-a" "1605167848a3a79dbc270a4af271f0f2ad99f4acf376bad0c070b8ea114da5a1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking yaml-rust v0.4.4 [INFO] [stderr] Checking dtoa v0.4.6 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking jvm-class-file-parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | if let ConstantClass { name_index } = *class.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 69 - if let ConstantClass { name_index } = *class.deref() { [INFO] [stdout] 69 + if let ConstantClass { name_index } = *class { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:75:130 [INFO] [stdout] | [INFO] [stdout] 75 | panic!("The \"name_index\" pointed to by \"this_class\" did not point to a ConstantUtf8. Found: {:?}", class_name.deref()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 75 - panic!("The \"name_index\" pointed to by \"this_class\" did not point to a ConstantUtf8. Found: {:?}", class_name.deref()) [INFO] [stdout] 75 + panic!("The \"name_index\" pointed to by \"this_class\" did not point to a ConstantUtf8. Found: {:?}", class_name) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:80:22 [INFO] [stdout] | [INFO] [stdout] 80 | class.deref() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 80 - class.deref() [INFO] [stdout] 80 + class [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:106:64 [INFO] [stdout] | [INFO] [stdout] 106 | if let ConstantUtf8 { ref string } = *name_constant.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 106 - if let ConstantUtf8 { ref string } = *name_constant.deref() { [INFO] [stdout] 106 + if let ConstantUtf8 { ref string } = *name_constant { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:119:141 [INFO] [stdout] | [INFO] [stdout] 119 | ... panic!("The \"info\" of the \"SourceFile\" annotation did not point to a ConstantUtf8. Found: {:?}", source_constant.deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 119 - panic!("The \"info\" of the \"SourceFile\" annotation did not point to a ConstantUtf8. Found: {:?}", source_constant.deref()); [INFO] [stdout] 119 + panic!("The \"info\" of the \"SourceFile\" annotation did not point to a ConstantUtf8. Found: {:?}", source_constant); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/parsing.rs:139:66 [INFO] [stdout] | [INFO] [stdout] 139 | match constant_pool.get(constant_pool.len() - 1).unwrap().deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 139 - match constant_pool.get(constant_pool.len() - 1).unwrap().deref() { [INFO] [stdout] 139 + match constant_pool.get(constant_pool.len() - 1).unwrap() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bootstrap_method_attr_index` [INFO] [stdout] --> src/main.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 265 | bootstrap_method_attr_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `bootstrap_method_attr_index: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_and_type_index` [INFO] [stdout] --> src/main.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 266 | name_and_type_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `name_and_type_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bootstrap_method_attr_index` [INFO] [stdout] --> src/main.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | bootstrap_method_attr_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `bootstrap_method_attr_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_and_type_index` [INFO] [stdout] --> src/main.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | name_and_type_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `name_and_type_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_index` [INFO] [stdout] --> src/main.rs:278:26 [INFO] [stdout] | [INFO] [stdout] 278 | ConstantModule { name_index } => { [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `name_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_index` [INFO] [stdout] --> src/main.rs:282:27 [INFO] [stdout] | [INFO] [stdout] 282 | ConstantPackage { name_index } => { [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `name_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:174:20 [INFO] [stdout] | [INFO] [stdout] 174 | match *constant.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 174 - match *constant.deref() { [INFO] [stdout] 174 + match *constant { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/workdir/src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking termios v0.3.3 [INFO] [stderr] Checking terminal_size v0.1.15 [INFO] [stderr] Checking console v0.12.0 [INFO] [stderr] Checking serde_yaml v0.8.14 [INFO] [stderr] Checking insta v1.3.0 [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> tests/parse_classes.rs:136:37 [INFO] [stdout] | [INFO] [stdout] 136 | match class_file.get_constant(2).deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 136 - match class_file.get_constant(2).deref() { [INFO] [stdout] 136 + match class_file.get_constant(2) { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/workdir/src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> tests/parse_classes.rs:141:37 [INFO] [stdout] | [INFO] [stdout] 141 | match class_file.get_constant(4).deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 141 - match class_file.get_constant(4).deref() { [INFO] [stdout] 141 + match class_file.get_constant(4) { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/workdir/src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> tests/parse_classes.rs:146:37 [INFO] [stdout] | [INFO] [stdout] 146 | match class_file.get_constant(6).deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 146 - match class_file.get_constant(6).deref() { [INFO] [stdout] 146 + match class_file.get_constant(6) { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/workdir/src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> tests/parse_classes.rs:151:37 [INFO] [stdout] | [INFO] [stdout] 151 | match class_file.get_constant(9).deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 151 - match class_file.get_constant(9).deref() { [INFO] [stdout] 151 + match class_file.get_constant(9) { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/workdir/src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> tests/parse_classes.rs:156:38 [INFO] [stdout] | [INFO] [stdout] 156 | match class_file.get_constant(37).deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 156 - match class_file.get_constant(37).deref() { [INFO] [stdout] 156 + match class_file.get_constant(37) { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/workdir/src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bootstrap_method_attr_index` [INFO] [stdout] --> src/main.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 265 | bootstrap_method_attr_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `bootstrap_method_attr_index: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_and_type_index` [INFO] [stdout] --> src/main.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 266 | name_and_type_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `name_and_type_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bootstrap_method_attr_index` [INFO] [stdout] --> src/main.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | bootstrap_method_attr_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `bootstrap_method_attr_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_and_type_index` [INFO] [stdout] --> src/main.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | name_and_type_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `name_and_type_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_index` [INFO] [stdout] --> src/main.rs:278:26 [INFO] [stdout] | [INFO] [stdout] 278 | ConstantModule { name_index } => { [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `name_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_index` [INFO] [stdout] --> src/main.rs:282:27 [INFO] [stdout] | [INFO] [stdout] 282 | ConstantPackage { name_index } => { [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `name_index: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:174:20 [INFO] [stdout] | [INFO] [stdout] 174 | match *constant.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 174 - match *constant.deref() { [INFO] [stdout] 174 + match *constant { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/workdir/src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | if let ConstantClass { name_index } = *class.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 69 - if let ConstantClass { name_index } = *class.deref() { [INFO] [stdout] 69 + if let ConstantClass { name_index } = *class { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:75:130 [INFO] [stdout] | [INFO] [stdout] 75 | panic!("The \"name_index\" pointed to by \"this_class\" did not point to a ConstantUtf8. Found: {:?}", class_name.deref()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 75 - panic!("The \"name_index\" pointed to by \"this_class\" did not point to a ConstantUtf8. Found: {:?}", class_name.deref()) [INFO] [stdout] 75 + panic!("The \"name_index\" pointed to by \"this_class\" did not point to a ConstantUtf8. Found: {:?}", class_name) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:80:22 [INFO] [stdout] | [INFO] [stdout] 80 | class.deref() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 80 - class.deref() [INFO] [stdout] 80 + class [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:106:64 [INFO] [stdout] | [INFO] [stdout] 106 | if let ConstantUtf8 { ref string } = *name_constant.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 106 - if let ConstantUtf8 { ref string } = *name_constant.deref() { [INFO] [stdout] 106 + if let ConstantUtf8 { ref string } = *name_constant { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:119:141 [INFO] [stdout] | [INFO] [stdout] 119 | ... panic!("The \"info\" of the \"SourceFile\" annotation did not point to a ConstantUtf8. Found: {:?}", source_constant.deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 119 - panic!("The \"info\" of the \"SourceFile\" annotation did not point to a ConstantUtf8. Found: {:?}", source_constant.deref()); [INFO] [stdout] 119 + panic!("The \"info\" of the \"SourceFile\" annotation did not point to a ConstantUtf8. Found: {:?}", source_constant); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/parsing.rs:139:66 [INFO] [stdout] | [INFO] [stdout] 139 | match constant_pool.get(constant_pool.len() - 1).unwrap().deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 139 - match constant_pool.get(constant_pool.len() - 1).unwrap().deref() { [INFO] [stdout] 139 + match constant_pool.get(constant_pool.len() - 1).unwrap() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.20s [INFO] running `Command { std: "docker" "inspect" "1605167848a3a79dbc270a4af271f0f2ad99f4acf376bad0c070b8ea114da5a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1605167848a3a79dbc270a4af271f0f2ad99f4acf376bad0c070b8ea114da5a1", kill_on_drop: false }` [INFO] [stdout] 1605167848a3a79dbc270a4af271f0f2ad99f4acf376bad0c070b8ea114da5a1 [INFO] checking ExcaliburZero/jvm-class-file-parser against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FExcaliburZero%2Fjvm-class-file-parser" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ExcaliburZero/jvm-class-file-parser on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ExcaliburZero/jvm-class-file-parser [INFO] finished tweaking git repo https://github.com/ExcaliburZero/jvm-class-file-parser [INFO] tweaked toml for git repo https://github.com/ExcaliburZero/jvm-class-file-parser written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ExcaliburZero/jvm-class-file-parser already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 51c332f5cbadeec1a93b9eeb9ee0ea6766fd3f1fa35f8db9bbb6db205dbf7673 [INFO] running `Command { std: "docker" "start" "-a" "51c332f5cbadeec1a93b9eeb9ee0ea6766fd3f1fa35f8db9bbb6db205dbf7673", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51c332f5cbadeec1a93b9eeb9ee0ea6766fd3f1fa35f8db9bbb6db205dbf7673", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51c332f5cbadeec1a93b9eeb9ee0ea6766fd3f1fa35f8db9bbb6db205dbf7673", kill_on_drop: false }` [INFO] [stdout] 51c332f5cbadeec1a93b9eeb9ee0ea6766fd3f1fa35f8db9bbb6db205dbf7673 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b0cf7a4f841cbc4ec6d80ca196a9440be2f8999e0136a75f81d0c917e1c715c [INFO] running `Command { std: "docker" "start" "-a" "3b0cf7a4f841cbc4ec6d80ca196a9440be2f8999e0136a75f81d0c917e1c715c", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking dtoa v0.4.6 [INFO] [stderr] Checking yaml-rust v0.4.4 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking jvm-class-file-parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | if let ConstantClass { name_index } = *class.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 69 - if let ConstantClass { name_index } = *class.deref() { [INFO] [stdout] 69 + if let ConstantClass { name_index } = *class { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:75:130 [INFO] [stdout] | [INFO] [stdout] 75 | panic!("The \"name_index\" pointed to by \"this_class\" did not point to a ConstantUtf8. Found: {:?}", class_name.deref()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 75 - panic!("The \"name_index\" pointed to by \"this_class\" did not point to a ConstantUtf8. Found: {:?}", class_name.deref()) [INFO] [stdout] 75 + panic!("The \"name_index\" pointed to by \"this_class\" did not point to a ConstantUtf8. Found: {:?}", class_name) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:80:22 [INFO] [stdout] | [INFO] [stdout] 80 | class.deref() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 80 - class.deref() [INFO] [stdout] 80 + class [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:106:64 [INFO] [stdout] | [INFO] [stdout] 106 | if let ConstantUtf8 { ref string } = *name_constant.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 106 - if let ConstantUtf8 { ref string } = *name_constant.deref() { [INFO] [stdout] 106 + if let ConstantUtf8 { ref string } = *name_constant { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/class_file.rs:119:141 [INFO] [stdout] | [INFO] [stdout] 119 | ... panic!("The \"info\" of the \"SourceFile\" annotation did not point to a ConstantUtf8. Found: {:?}", source_constant.deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 119 - panic!("The \"info\" of the \"SourceFile\" annotation did not point to a ConstantUtf8. Found: {:?}", source_constant.deref()); [INFO] [stdout] 119 + panic!("The \"info\" of the \"SourceFile\" annotation did not point to a ConstantUtf8. Found: {:?}", source_constant); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 65 | let fields = read_fields(file).context(READ_FIELDS)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let access_flags = promote_result_to_io(ClassAccess::from_access_flags(access_flags))?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | Ok(ClassFile { [INFO] [stdout] | ________^ [INFO] [stdout] 72 | | minor_version, [INFO] [stdout] 73 | | major_version, [INFO] [stdout] 74 | | constant_pool, [INFO] [stdout] ... | [INFO] [stdout] 81 | | attributes, [INFO] [stdout] 82 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/parsing.rs:139:66 [INFO] [stdout] | [INFO] [stdout] 139 | match constant_pool.get(constant_pool.len() - 1).unwrap().deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `constant_pool::ConstantPoolEntry` does not implement `Deref`, so calling `deref` on `&constant_pool::ConstantPoolEntry` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 139 - match constant_pool.get(constant_pool.len() - 1).unwrap().deref() { [INFO] [stdout] 139 + match constant_pool.get(constant_pool.len() - 1).unwrap() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `constant_pool::ConstantPoolEntry`, implement `Clone` for it [INFO] [stdout] --> src/constant_pool.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum ConstantPoolEntry { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:345:8 [INFO] [stdout] | [INFO] [stdout] 343 | let access_flags = promote_result_to_io(FieldAccess::from_access_flags(access_flags))?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | [INFO] [stdout] 345 | Ok(Field { [INFO] [stdout] | ________^ [INFO] [stdout] 346 | | access_flags, [INFO] [stdout] 347 | | name_index, [INFO] [stdout] 348 | | descriptor_index, [INFO] [stdout] 349 | | attributes, [INFO] [stdout] 350 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 30 | fn context>(self, error_description: S) -> io::Result { [INFO] [stdout] | ---- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | self.map_err(|e| io_err(format!("{} {}", error_description.into(), e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jvm-class-file-parser` (lib) due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3b0cf7a4f841cbc4ec6d80ca196a9440be2f8999e0136a75f81d0c917e1c715c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b0cf7a4f841cbc4ec6d80ca196a9440be2f8999e0136a75f81d0c917e1c715c", kill_on_drop: false }` [INFO] [stdout] 3b0cf7a4f841cbc4ec6d80ca196a9440be2f8999e0136a75f81d0c917e1c715c