[INFO] crate zrs 0.1.1 is already in cache [INFO] extracting crate zrs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/zrs/0.1.1 [INFO] extracting crate zrs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zrs/0.1.1 [INFO] validating manifest of zrs-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zrs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zrs-0.1.1 [INFO] finished frobbing zrs-0.1.1 [INFO] frobbed toml for zrs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/zrs/0.1.1/Cargo.toml [INFO] started frobbing zrs-0.1.1 [INFO] finished frobbing zrs-0.1.1 [INFO] frobbed toml for zrs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zrs/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zrs-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zrs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 31163f03116a4f08ce2bb8f54a2187c264e56fec74859590e173708c4bf9e007 [INFO] running `"docker" "start" "-a" "31163f03116a4f08ce2bb8f54a2187c264e56fec74859590e173708c4bf9e007"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking zrs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | const HELPER_SCRIPT: &'static [u8] = include_bytes!("../z.sh"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:347:5 [INFO] [stderr] | [INFO] [stderr] 347 | / if non_blocking_add { [INFO] [stderr] 348 | | if fork_is_parent().with_context(|_| err_msg("forking"))? { [INFO] [stderr] 349 | | return Ok(Return::NoOutput); [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 347 | if non_blocking_add && fork_is_parent().with_context(|_| err_msg("forking"))? { [INFO] [stderr] 348 | return Ok(Return::NoOutput); [INFO] [stderr] 349 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | const HELPER_SCRIPT: &'static [u8] = include_bytes!("../z.sh"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:347:5 [INFO] [stderr] | [INFO] [stderr] 347 | / if non_blocking_add { [INFO] [stderr] 348 | | if fork_is_parent().with_context(|_| err_msg("forking"))? { [INFO] [stderr] 349 | | return Ok(Return::NoOutput); [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 347 | if non_blocking_add && fork_is_parent().with_context(|_| err_msg("forking"))? { [INFO] [stderr] 348 | return Ok(Return::NoOutput); [INFO] [stderr] 349 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | let mut rows = rows.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:152:11 [INFO] [stderr] | [INFO] [stderr] 152 | table.into_iter().map(|line| line.rank).sum() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `complete` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:274:37 [INFO] [stderr] | [INFO] [stderr] 274 | return complete(&data_file, &mut line); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | let mut rows = rows.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:152:11 [INFO] [stderr] | [INFO] [stderr] 152 | table.into_iter().map(|line| line.rank).sum() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `complete` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:274:37 [INFO] [stderr] | [INFO] [stderr] 274 | return complete(&data_file, &mut line); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.18s [INFO] running `"docker" "inspect" "31163f03116a4f08ce2bb8f54a2187c264e56fec74859590e173708c4bf9e007"` [INFO] running `"docker" "rm" "-f" "31163f03116a4f08ce2bb8f54a2187c264e56fec74859590e173708c4bf9e007"` [INFO] [stdout] 31163f03116a4f08ce2bb8f54a2187c264e56fec74859590e173708c4bf9e007