[INFO] crate zpatial 0.1.1 is already in cache [INFO] extracting crate zpatial 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/zpatial/0.1.1 [INFO] extracting crate zpatial 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zpatial/0.1.1 [INFO] validating manifest of zpatial-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zpatial-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zpatial-0.1.1 [INFO] finished frobbing zpatial-0.1.1 [INFO] frobbed toml for zpatial-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/zpatial/0.1.1/Cargo.toml [INFO] started frobbing zpatial-0.1.1 [INFO] finished frobbing zpatial-0.1.1 [INFO] frobbed toml for zpatial-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zpatial/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zpatial-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zpatial/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdd3e6d895a502e1c38c74f88f1e74892e79ea8809faf677e17e430d404af751 [INFO] running `"docker" "start" "-a" "fdd3e6d895a502e1c38c74f88f1e74892e79ea8809faf677e17e430d404af751"` [INFO] [stderr] Checking mazth v0.1.2 [INFO] [stderr] Checking zpatial v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> lib/implement/bvh.rs:211:17 [INFO] [stderr] | [INFO] [stderr] 211 | let l = q.pop().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> lib/implement/bvh.rs:211:17 [INFO] [stderr] | [INFO] [stderr] 211 | let l = q.pop().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> lib/implement/bvh.rs:216:43 [INFO] [stderr] | [INFO] [stderr] 216 | BvhBranch::CHILD( ref o ) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> lib/implement/bvh.rs:223:43 [INFO] [stderr] | [INFO] [stderr] 223 | BvhBranch::CHILD( ref o ) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> lib/implement/bvh.rs:216:43 [INFO] [stderr] | [INFO] [stderr] 216 | BvhBranch::CHILD( ref o ) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> lib/implement/bvh.rs:223:43 [INFO] [stderr] | [INFO] [stderr] 223 | BvhBranch::CHILD( ref o ) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> lib/implement/bvh.rs:246:55 [INFO] [stderr] | [INFO] [stderr] 246 | let func_collect = | x | { out.push( x ); () }; [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> lib/implement/bvh.rs:246:55 [INFO] [stderr] | [INFO] [stderr] 246 | let func_collect = | x | { out.push( x ); () }; [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:93:32 [INFO] [stderr] | [INFO] [stderr] 93 | let bin_len = length / num_bins as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:98:48 [INFO] [stderr] | [INFO] [stderr] 98 | Axis::X => { bin_offsets.push( i as f64 * bin_len + self._bound._bound_lower[0] ); }, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:99:48 [INFO] [stderr] | [INFO] [stderr] 99 | Axis::Y => { bin_offsets.push( i as f64 * bin_len + self._bound._bound_lower[1] ); }, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:100:48 [INFO] [stderr] | [INFO] [stderr] 100 | Axis::Z => { bin_offsets.push( i as f64 * bin_len + self._bound._bound_lower[2] ); }, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:118:97 [INFO] [stderr] | [INFO] [stderr] 118 | let entry_bin = ( ( obj_entry[0] - self._bound._bound_lower[0] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:119:95 [INFO] [stderr] | [INFO] [stderr] 119 | let exit_bin = ( ( obj_exit[0] - self._bound._bound_lower[0] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:123:73 [INFO] [stderr] | [INFO] [stderr] 123 | ( ( c[0] - self._bound._bound_lower[0] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:126:97 [INFO] [stderr] | [INFO] [stderr] 126 | let entry_bin = ( ( obj_entry[1] - self._bound._bound_lower[1] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:127:95 [INFO] [stderr] | [INFO] [stderr] 127 | let exit_bin = ( ( obj_exit[1] - self._bound._bound_lower[1] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:131:73 [INFO] [stderr] | [INFO] [stderr] 131 | ( ( c[1] - self._bound._bound_lower[1] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:134:97 [INFO] [stderr] | [INFO] [stderr] 134 | let entry_bin = ( ( obj_entry[2] - self._bound._bound_lower[2] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:135:95 [INFO] [stderr] | [INFO] [stderr] 135 | let exit_bin = ( ( obj_exit[2] - self._bound._bound_lower[2] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:139:73 [INFO] [stderr] | [INFO] [stderr] 139 | ( ( c[2] - self._bound._bound_lower[2] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `idx_obj` is used as a loop counter. Consider using `for (idx_obj, item) in obj_bin.enumerate()` or similar iterators [INFO] [stderr] --> lib/implement/bvh.rs:177:18 [INFO] [stderr] | [INFO] [stderr] 177 | for i in obj_bin { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib/implement/bvh.rs:187:12 [INFO] [stderr] | [INFO] [stderr] 187 | if bin_left.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bin_left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib/implement/bvh.rs:196:12 [INFO] [stderr] | [INFO] [stderr] 196 | if bin_right.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bin_right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib/implement/bvh.rs:210:15 [INFO] [stderr] | [INFO] [stderr] 210 | while q.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!q.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:93:32 [INFO] [stderr] | [INFO] [stderr] 93 | let bin_len = length / num_bins as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:98:48 [INFO] [stderr] | [INFO] [stderr] 98 | Axis::X => { bin_offsets.push( i as f64 * bin_len + self._bound._bound_lower[0] ); }, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:99:48 [INFO] [stderr] | [INFO] [stderr] 99 | Axis::Y => { bin_offsets.push( i as f64 * bin_len + self._bound._bound_lower[1] ); }, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:100:48 [INFO] [stderr] | [INFO] [stderr] 100 | Axis::Z => { bin_offsets.push( i as f64 * bin_len + self._bound._bound_lower[2] ); }, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:118:97 [INFO] [stderr] | [INFO] [stderr] 118 | let entry_bin = ( ( obj_entry[0] - self._bound._bound_lower[0] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:119:95 [INFO] [stderr] | [INFO] [stderr] 119 | let exit_bin = ( ( obj_exit[0] - self._bound._bound_lower[0] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:123:73 [INFO] [stderr] | [INFO] [stderr] 123 | ( ( c[0] - self._bound._bound_lower[0] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:126:97 [INFO] [stderr] | [INFO] [stderr] 126 | let entry_bin = ( ( obj_entry[1] - self._bound._bound_lower[1] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:127:95 [INFO] [stderr] | [INFO] [stderr] 127 | let exit_bin = ( ( obj_exit[1] - self._bound._bound_lower[1] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:131:73 [INFO] [stderr] | [INFO] [stderr] 131 | ( ( c[1] - self._bound._bound_lower[1] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:134:97 [INFO] [stderr] | [INFO] [stderr] 134 | let entry_bin = ( ( obj_entry[2] - self._bound._bound_lower[2] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:135:95 [INFO] [stderr] | [INFO] [stderr] 135 | let exit_bin = ( ( obj_exit[2] - self._bound._bound_lower[2] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> lib/implement/bvh.rs:139:73 [INFO] [stderr] | [INFO] [stderr] 139 | ( ( c[2] - self._bound._bound_lower[2] ) / length * (num_bins as f64) * ( 1.0 - epsilon ) ) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_bins)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `idx_obj` is used as a loop counter. Consider using `for (idx_obj, item) in obj_bin.enumerate()` or similar iterators [INFO] [stderr] --> lib/implement/bvh.rs:177:18 [INFO] [stderr] | [INFO] [stderr] 177 | for i in obj_bin { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib/implement/bvh.rs:187:12 [INFO] [stderr] | [INFO] [stderr] 187 | if bin_left.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bin_left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib/implement/bvh.rs:196:12 [INFO] [stderr] | [INFO] [stderr] 196 | if bin_right.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bin_right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib/implement/bvh.rs:210:15 [INFO] [stderr] | [INFO] [stderr] 210 | while q.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!q.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `bounds` [INFO] [stderr] --> lib/tests/bvh.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0..20 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for (i, ) in bounds.iter().enumerate().take(20) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> lib/tests/bvh.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match a.query_intersect( &query ) { [INFO] [stderr] 59 | | Ok( o ) => { [INFO] [stderr] 60 | | assert!( o.len() == 6, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 61 | | for j in o { [INFO] [stderr] ... | [INFO] [stderr] 65 | | _ => (), [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | if let Ok( o ) = a.query_intersect( &query ) { [INFO] [stderr] 59 | assert!( o.len() == 6, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 60 | for j in o { [INFO] [stderr] 61 | assert!( j <= 5, "bvh query_intersect return index unexpected" ); [INFO] [stderr] 62 | } [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> lib/tests/bvh.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / match a.query_intersect( &query ) { [INFO] [stderr] 72 | | Ok( o ) => { [INFO] [stderr] 73 | | assert!( o.len() == 6, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 74 | | for j in o { [INFO] [stderr] ... | [INFO] [stderr] 78 | | _ => (), [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | if let Ok( o ) = a.query_intersect( &query ) { [INFO] [stderr] 72 | assert!( o.len() == 6, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 73 | for j in o { [INFO] [stderr] 74 | assert!( j >= 14, "bvh query_intersect return index unexpected" ); [INFO] [stderr] 75 | } [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> lib/tests/bvh.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match a.query_intersect( &query ) { [INFO] [stderr] 85 | | Ok( o ) => { [INFO] [stderr] 86 | | assert!( o.len() == 1, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 87 | | for j in o { [INFO] [stderr] ... | [INFO] [stderr] 91 | | _ => (), [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Ok( o ) = a.query_intersect( &query ) { [INFO] [stderr] 85 | assert!( o.len() == 1, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 86 | for j in o { [INFO] [stderr] 87 | assert!( j == 0, "bvh query_intersect return index unexpected" ); [INFO] [stderr] 88 | } [INFO] [stderr] 89 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> lib/tests/bvh.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match a.query_intersect( &query ) { [INFO] [stderr] 100 | | Ok( o ) => { [INFO] [stderr] 101 | | assert!( o.len() == 0, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 102 | | }, [INFO] [stderr] 103 | | _ => (), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 99 | if let Ok( o ) = a.query_intersect( &query ) { [INFO] [stderr] 100 | assert!( o.len() == 0, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib/tests/bvh.rs:101:26 [INFO] [stderr] | [INFO] [stderr] 101 | assert!( o.len() == 0, "bvh query_intersect return length unexpected" ); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `o.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> lib/tests/bvh.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / match a.query_intersect( &query ) { [INFO] [stderr] 110 | | Ok( o ) => { [INFO] [stderr] 111 | | assert!( o.len() == 0, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 112 | | }, [INFO] [stderr] 113 | | _ => (), [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | if let Ok( o ) = a.query_intersect( &query ) { [INFO] [stderr] 110 | assert!( o.len() == 0, "bvh query_intersect return length unexpected" ); [INFO] [stderr] 111 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> lib/tests/bvh.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | assert!( o.len() == 0, "bvh query_intersect return length unexpected" ); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `o.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.47s [INFO] running `"docker" "inspect" "fdd3e6d895a502e1c38c74f88f1e74892e79ea8809faf677e17e430d404af751"` [INFO] running `"docker" "rm" "-f" "fdd3e6d895a502e1c38c74f88f1e74892e79ea8809faf677e17e430d404af751"` [INFO] [stdout] fdd3e6d895a502e1c38c74f88f1e74892e79ea8809faf677e17e430d404af751