[INFO] crate zoneinfo_parse 0.1.4 is already in cache [INFO] extracting crate zoneinfo_parse 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/zoneinfo_parse/0.1.4 [INFO] extracting crate zoneinfo_parse 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zoneinfo_parse/0.1.4 [INFO] validating manifest of zoneinfo_parse-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zoneinfo_parse-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zoneinfo_parse-0.1.4 [INFO] finished frobbing zoneinfo_parse-0.1.4 [INFO] frobbed toml for zoneinfo_parse-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/zoneinfo_parse/0.1.4/Cargo.toml [INFO] started frobbing zoneinfo_parse-0.1.4 [INFO] finished frobbing zoneinfo_parse-0.1.4 [INFO] frobbed toml for zoneinfo_parse-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zoneinfo_parse/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zoneinfo_parse-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zoneinfo_parse/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 41ecfcb611bd3490f2a349452742a1b601f86b95283723a7c37f04d94f448acd [INFO] running `"docker" "start" "-a" "41ecfcb611bd3490f2a349452742a1b601f86b95283723a7c37f04d94f448acd"` [INFO] [stderr] Checking iso8601 v0.1.1 [INFO] [stderr] Checking pad v0.1.5 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking locale v0.2.2 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking datetime v0.4.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking zoneinfo_parse v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | name: name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:250:17 [INFO] [stderr] | [INFO] [stderr] 250 | from_year: from_year, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from_year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | to_year: to_year, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `to_year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | day: day, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:254:17 [INFO] [stderr] | [INFO] [stderr] 254 | time: time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | time_to_add: time_to_add, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_to_add` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | letters: letters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `letters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:304:17 [INFO] [stderr] | [INFO] [stderr] 304 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:305:17 [INFO] [stderr] | [INFO] [stderr] 305 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | utc_offset: utc_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `utc_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | saving: saving, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `saving` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | time: time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/line.rs:441:58 [INFO] [stderr] | [INFO] [stderr] 441 | TimeSpec::HoursMinutesSeconds(h, mm, s) => LocalTime::hms(h, mm, s).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | name: name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:250:17 [INFO] [stderr] | [INFO] [stderr] 250 | from_year: from_year, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from_year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | to_year: to_year, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `to_year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | day: day, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:254:17 [INFO] [stderr] | [INFO] [stderr] 254 | time: time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | time_to_add: time_to_add, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_to_add` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | letters: letters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `letters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:304:17 [INFO] [stderr] | [INFO] [stderr] 304 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:305:17 [INFO] [stderr] | [INFO] [stderr] 305 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | utc_offset: utc_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `utc_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | saving: saving, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `saving` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | time: time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/line.rs:441:58 [INFO] [stderr] | [INFO] [stderr] 441 | TimeSpec::HoursMinutesSeconds(h, mm, s) => LocalTime::hms(h, mm, s).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transitions.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | utc_offset: utc_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `utc_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transitions.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structure.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | TableStructure { mappings: mappings } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mappings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structure.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | keys: keys, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transitions.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | utc_offset: utc_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `utc_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transitions.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structure.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | TableStructure { mappings: mappings } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mappings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structure.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | keys: keys, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/line.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/line.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/line.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/table.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | let mut zoneset = match self.table.zonesets.entry(zone_line.name.to_owned()) { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/table.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | let mut zoneset = match self.current_zoneset_name { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/line.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / pub fn from_str(input: &str) -> Result { [INFO] [stderr] 219 | | if let Some(caps) = RULE_LINE.captures(input) { [INFO] [stderr] 220 | | let name = caps.name("name").unwrap(); [INFO] [stderr] 221 | | let from_year = try!(caps.name("from").unwrap().parse()); [INFO] [stderr] ... | [INFO] [stderr] 261 | | } [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/line.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | / pub fn from_str(input: &str) -> Result { [INFO] [stderr] 299 | | if let Some(caps) = ZONE_LINE.captures(input) { [INFO] [stderr] 300 | | let name = caps.name("name").unwrap(); [INFO] [stderr] 301 | | let info = try!(ZoneInfo::from_captures(caps)); [INFO] [stderr] ... | [INFO] [stderr] 310 | | } [INFO] [stderr] 311 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/line.rs:467:5 [INFO] [stderr] | [INFO] [stderr] 467 | / pub fn from_str(input: &str) -> Result { [INFO] [stderr] 468 | | if let Some(caps) = LINK_LINE.captures(input) { [INFO] [stderr] 469 | | let target = caps.name("target").unwrap(); [INFO] [stderr] 470 | | let name = caps.name("name").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 475 | | } [INFO] [stderr] 476 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/line.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn to_concrete_date(&self, year: i64, month: Month) -> LocalDate { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/line.rs:702:23 [INFO] [stderr] | [INFO] [stderr] 702 | pub fn as_seconds(&self) -> i64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:705:55 [INFO] [stderr] | [INFO] [stderr] 705 | TimeSpec::Hours(h) => h as i64 * 3600, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:706:55 [INFO] [stderr] | [INFO] [stderr] 706 | TimeSpec::HoursMinutes(h, m) => h as i64 * 3600 + m as i64 * 60, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:706:73 [INFO] [stderr] | [INFO] [stderr] 706 | TimeSpec::HoursMinutes(h, m) => h as i64 * 3600 + m as i64 * 60, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:707:55 [INFO] [stderr] | [INFO] [stderr] 707 | TimeSpec::HoursMinutesSeconds(h, m, s) => h as i64 * 3600 + m as i64 * 60 + s as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:707:73 [INFO] [stderr] | [INFO] [stderr] 707 | TimeSpec::HoursMinutesSeconds(h, m, s) => h as i64 * 3600 + m as i64 * 60 + s as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:707:89 [INFO] [stderr] | [INFO] [stderr] 707 | TimeSpec::HoursMinutesSeconds(h, m, s) => h as i64 * 3600 + m as i64 * 60 + s as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/line.rs:818:5 [INFO] [stderr] | [INFO] [stderr] 818 | / pub fn from_str(input: &str) -> Result { [INFO] [stderr] 819 | | if EMPTY_LINE.is_match(input) { [INFO] [stderr] 820 | | Ok(Line::Space) [INFO] [stderr] 821 | | } [INFO] [stderr] ... | [INFO] [stderr] 836 | | } [INFO] [stderr] 837 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/line.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/table.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | pub fn format(&self, dst_offset: i64, letters: Option<&String>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | #![warn(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/table.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | pub fn format_constant(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `table::TableBuilder` [INFO] [stderr] --> src/table.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / pub fn new() -> TableBuilder { [INFO] [stderr] 310 | | TableBuilder { [INFO] [stderr] 311 | | table: Table::default(), [INFO] [stderr] 312 | | current_zoneset_name: None, [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 295 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transitions.rs:241:51 [INFO] [stderr] | [INFO] [stderr] 241 | name: start_zone_id.clone().unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transitions.rs:251:51 [INFO] [stderr] | [INFO] [stderr] 251 | name: start_zone_id.clone().unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/transitions.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | / fn add_multiple_saving(&mut self, timespan: &ZoneInfo, rules: &[RuleInfo], [INFO] [stderr] 258 | | dst_offset: &mut i64, use_until: bool, utc_offset: i64, insert_start_transition: &mut bool, [INFO] [stderr] 259 | | start_zone_id: &mut Option, start_utc_offset: &mut i64, start_dst_offset: &mut i64) [INFO] [stderr] 260 | | { [INFO] [stderr] ... | [INFO] [stderr] 327 | | [INFO] [stderr] 328 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: unused result [INFO] [stderr] --> src/structure.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | set.insert(Child::TimeZone(&key[last_slash + 1 ..])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | #![warn(unused_results)] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused result [INFO] [stderr] --> src/structure.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | set.insert(Child::Submodule(&parent[first_slash + 1 ..])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/structure.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / loop { [INFO] [stderr] 119 | | let key = match self.keys.pop() { [INFO] [stderr] 120 | | Some(k) => k, [INFO] [stderr] 121 | | None => return None, [INFO] [stderr] ... | [INFO] [stderr] 130 | | }); [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `zoneinfo_parse`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/table.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | let mut zoneset = match self.table.zonesets.entry(zone_line.name.to_owned()) { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/table.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | let mut zoneset = match self.current_zoneset_name { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/line.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / pub fn from_str(input: &str) -> Result { [INFO] [stderr] 219 | | if let Some(caps) = RULE_LINE.captures(input) { [INFO] [stderr] 220 | | let name = caps.name("name").unwrap(); [INFO] [stderr] 221 | | let from_year = try!(caps.name("from").unwrap().parse()); [INFO] [stderr] ... | [INFO] [stderr] 261 | | } [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/line.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | / pub fn from_str(input: &str) -> Result { [INFO] [stderr] 299 | | if let Some(caps) = ZONE_LINE.captures(input) { [INFO] [stderr] 300 | | let name = caps.name("name").unwrap(); [INFO] [stderr] 301 | | let info = try!(ZoneInfo::from_captures(caps)); [INFO] [stderr] ... | [INFO] [stderr] 310 | | } [INFO] [stderr] 311 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/line.rs:467:5 [INFO] [stderr] | [INFO] [stderr] 467 | / pub fn from_str(input: &str) -> Result { [INFO] [stderr] 468 | | if let Some(caps) = LINK_LINE.captures(input) { [INFO] [stderr] 469 | | let target = caps.name("target").unwrap(); [INFO] [stderr] 470 | | let name = caps.name("name").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 475 | | } [INFO] [stderr] 476 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/line.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn to_concrete_date(&self, year: i64, month: Month) -> LocalDate { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/line.rs:702:23 [INFO] [stderr] | [INFO] [stderr] 702 | pub fn as_seconds(&self) -> i64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:705:55 [INFO] [stderr] | [INFO] [stderr] 705 | TimeSpec::Hours(h) => h as i64 * 3600, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:706:55 [INFO] [stderr] | [INFO] [stderr] 706 | TimeSpec::HoursMinutes(h, m) => h as i64 * 3600 + m as i64 * 60, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:706:73 [INFO] [stderr] | [INFO] [stderr] 706 | TimeSpec::HoursMinutes(h, m) => h as i64 * 3600 + m as i64 * 60, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:707:55 [INFO] [stderr] | [INFO] [stderr] 707 | TimeSpec::HoursMinutesSeconds(h, m, s) => h as i64 * 3600 + m as i64 * 60 + s as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:707:73 [INFO] [stderr] | [INFO] [stderr] 707 | TimeSpec::HoursMinutesSeconds(h, m, s) => h as i64 * 3600 + m as i64 * 60 + s as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/line.rs:707:89 [INFO] [stderr] | [INFO] [stderr] 707 | TimeSpec::HoursMinutesSeconds(h, m, s) => h as i64 * 3600 + m as i64 * 60 + s as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/line.rs:818:5 [INFO] [stderr] | [INFO] [stderr] 818 | / pub fn from_str(input: &str) -> Result { [INFO] [stderr] 819 | | if EMPTY_LINE.is_match(input) { [INFO] [stderr] 820 | | Ok(Line::Space) [INFO] [stderr] 821 | | } [INFO] [stderr] ... | [INFO] [stderr] 836 | | } [INFO] [stderr] 837 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `table::TableBuilder` [INFO] [stderr] --> src/table.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / pub fn new() -> TableBuilder { [INFO] [stderr] 310 | | TableBuilder { [INFO] [stderr] 311 | | table: Table::default(), [INFO] [stderr] 312 | | current_zoneset_name: None, [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 295 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transitions.rs:241:51 [INFO] [stderr] | [INFO] [stderr] 241 | name: start_zone_id.clone().unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/transitions.rs:251:51 [INFO] [stderr] | [INFO] [stderr] 251 | name: start_zone_id.clone().unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/transitions.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | / fn add_multiple_saving(&mut self, timespan: &ZoneInfo, rules: &[RuleInfo], [INFO] [stderr] 258 | | dst_offset: &mut i64, use_until: bool, utc_offset: i64, insert_start_transition: &mut bool, [INFO] [stderr] 259 | | start_zone_id: &mut Option, start_utc_offset: &mut i64, start_dst_offset: &mut i64) [INFO] [stderr] 260 | | { [INFO] [stderr] ... | [INFO] [stderr] 327 | | [INFO] [stderr] 328 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: unused result [INFO] [stderr] --> src/structure.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | set.insert(Child::TimeZone(&key[last_slash + 1 ..])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | #![warn(unused_results)] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused result [INFO] [stderr] --> src/structure.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | set.insert(Child::Submodule(&parent[first_slash + 1 ..])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/structure.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / loop { [INFO] [stderr] 119 | | let key = match self.keys.pop() { [INFO] [stderr] 120 | | Some(k) => k, [INFO] [stderr] 121 | | None => return None, [INFO] [stderr] ... | [INFO] [stderr] 130 | | }); [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `zoneinfo_parse`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "41ecfcb611bd3490f2a349452742a1b601f86b95283723a7c37f04d94f448acd"` [INFO] running `"docker" "rm" "-f" "41ecfcb611bd3490f2a349452742a1b601f86b95283723a7c37f04d94f448acd"` [INFO] [stdout] 41ecfcb611bd3490f2a349452742a1b601f86b95283723a7c37f04d94f448acd