[INFO] crate zmq-pw 0.9.8 is already in cache [INFO] extracting crate zmq-pw 0.9.8 into work/ex/clippy-test-run/sources/stable/reg/zmq-pw/0.9.8 [INFO] extracting crate zmq-pw 0.9.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zmq-pw/0.9.8 [INFO] validating manifest of zmq-pw-0.9.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zmq-pw-0.9.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zmq-pw-0.9.8 [INFO] removed 0 missing examples [INFO] removed path dependency zmq-pw-sys from zmq-pw-0.9.8 [INFO] removed path dependency zmq-pw-sys from zmq-pw-0.9.8 [INFO] finished frobbing zmq-pw-0.9.8 [INFO] frobbed toml for zmq-pw-0.9.8 written to work/ex/clippy-test-run/sources/stable/reg/zmq-pw/0.9.8/Cargo.toml [INFO] started frobbing zmq-pw-0.9.8 [INFO] removed 0 missing examples [INFO] removed path dependency zmq-pw-sys from zmq-pw-0.9.8 [INFO] removed path dependency zmq-pw-sys from zmq-pw-0.9.8 [INFO] finished frobbing zmq-pw-0.9.8 [INFO] frobbed toml for zmq-pw-0.9.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zmq-pw/0.9.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zmq-pw-0.9.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zmq-pw/0.9.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 139ce1ec59db1a6579e1583a01a3d58e251d4e54046b58d5e2294fbd1061cf11 [INFO] running `"docker" "start" "-a" "139ce1ec59db1a6579e1583a01a3d58e251d4e54046b58d5e2294fbd1061cf11"` [INFO] [stderr] Compiling metadeps v1.1.2 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking nix v0.7.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking timebomb v0.1.2 [INFO] [stderr] Compiling zmq-pw-sys v0.9.8 [INFO] [stderr] Checking quickcheck v0.4.1 [INFO] [stderr] warning: redundant linker flag specified for library `zmq-pw` [INFO] [stderr] [INFO] [stderr] Compiling zmq-pw v0.9.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant linker flag specified for library `zmq-pw` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | Message { msg: msg } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:574:13 [INFO] [stderr] | [INFO] [stderr] 574 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:990:13 [INFO] [stderr] | [INFO] [stderr] 990 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | Message { msg: msg } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:574:13 [INFO] [stderr] | [INFO] [stderr] 574 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:990:13 [INFO] [stderr] | [INFO] [stderr] 990 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | 156384714 => Error::EPROTONOSUPPORT, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_714` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | 156384715 => Error::ENOBUFS, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_715` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | 156384716 => Error::ENETDOWN, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_716` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | 156384717 => Error::EADDRINUSE, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_717` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | 156384718 => Error::EADDRNOTAVAIL, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_718` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | 156384719 => Error::ECONNREFUSED, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_719` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | 156384720 => Error::EINPROGRESS, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_720` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | 156384721 => Error::ENOTSOCK, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_721` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | 156384763 => Error::EFSM, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_763` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | 156384764 => Error::ENOCOMPATPROTO, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_764` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | 156384765 => Error::ETERM, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_765` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | 156384766 => Error::EMTHREAD, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_766` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1237:5 [INFO] [stderr] | [INFO] [stderr] 1237 | return ((j as i32) << 8) | (i as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((j as i32) << 8) | (i as i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | 156384714 => Error::EPROTONOSUPPORT, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_714` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | 156384715 => Error::ENOBUFS, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_715` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | 156384716 => Error::ENETDOWN, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_716` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | 156384717 => Error::EADDRINUSE, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_717` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | 156384718 => Error::EADDRNOTAVAIL, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_718` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | 156384719 => Error::ECONNREFUSED, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_719` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | 156384720 => Error::EINPROGRESS, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_720` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | 156384721 => Error::ENOTSOCK, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_721` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | 156384763 => Error::EFSM, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_763` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | 156384764 => Error::ENOCOMPATPROTO, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_764` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | 156384765 => Error::ETERM, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_765` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | 156384766 => Error::EMTHREAD, [INFO] [stderr] | ^^^^^^^^^ help: consider: `156_384_766` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1237:5 [INFO] [stderr] | [INFO] [stderr] 1237 | return ((j as i32) << 8) | (i as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((j as i32) << 8) | (i as i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/message.rs:143:35 [INFO] [stderr] | [INFO] [stderr] 143 | slice::from_raw_parts(mem::transmute(data), len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `data as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/message.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | &self[..] == &other[..] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 150 | self[..] == other[..] [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/message.rs:163:39 [INFO] [stderr] | [INFO] [stderr] 163 | slice::from_raw_parts_mut(mem::transmute(data), len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `data as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:164:19 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn to_raw(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:220:19 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn to_raw(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1237:13 [INFO] [stderr] | [INFO] [stderr] 1237 | return ((j as i32) << 8) | (i as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1237:32 [INFO] [stderr] | [INFO] [stderr] 1237 | return ((j as i32) << 8) | (i as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/message.rs:143:35 [INFO] [stderr] | [INFO] [stderr] 143 | slice::from_raw_parts(mem::transmute(data), len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `data as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/message.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | &self[..] == &other[..] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 150 | self[..] == other[..] [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/message.rs:163:39 [INFO] [stderr] | [INFO] [stderr] 163 | slice::from_raw_parts_mut(mem::transmute(data), len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `data as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:164:19 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn to_raw(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:220:19 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn to_raw(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1237:13 [INFO] [stderr] | [INFO] [stderr] 1237 | return ((j as i32) << 8) | (i as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1237:32 [INFO] [stderr] | [INFO] [stderr] 1237 | return ((j as i32) << 8) | (i as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/msgsend/main.rs:93:27 [INFO] [stderr] | [INFO] [stderr] 93 | d.as_secs() as f64 + (d.subsec_nanos() as f64 / 1e9) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/zguide/weather_server/main.rs:22:44 [INFO] [stderr] | [INFO] [stderr] 22 | let zipcode = rng.gen_range(0, 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> examples/zguide/mspoller/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / if items[0].is_readable() { [INFO] [stderr] 29 | | if receiver.recv(&mut msg, 0).is_ok() { [INFO] [stderr] 30 | | // Process task [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | if items[0].is_readable() && receiver.recv(&mut msg, 0).is_ok() { [INFO] [stderr] 29 | // Process task [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> examples/zguide/mspoller/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / if items[1].is_readable() { [INFO] [stderr] 34 | | if subscriber.recv(&mut msg, 0).is_ok() { [INFO] [stderr] 35 | | // Process weather update [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 33 | if items[1].is_readable() && subscriber.recv(&mut msg, 0).is_ok() { [INFO] [stderr] 34 | // Process weather update [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | sock.set_maxmsgsize(512000).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `512_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:185:48 [INFO] [stderr] | [INFO] [stderr] 185 | assert_eq!(sock.get_maxmsgsize().unwrap(), 512000); [INFO] [stderr] | ^^^^^^ help: consider: `512_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/zguide/fileio3/main.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | static CHUNK_SIZE: usize = 250000; [INFO] [stderr] | ^^^^^^ help: consider: `250_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/connection/unix.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> examples/zguide/fileio3/main.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | file.write(random_string(10 * CHUNK_SIZE).as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `zmq-pw`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/z85.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return input.0 == decoded; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `input.0 == decoded` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> tests/message.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | let v2 = (0..).map(|_| T::arbitrary(g)).filter(|v| *v != v1).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|v| *v != v1).next()` with `find(|v| *v != v1)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "139ce1ec59db1a6579e1583a01a3d58e251d4e54046b58d5e2294fbd1061cf11"` [INFO] running `"docker" "rm" "-f" "139ce1ec59db1a6579e1583a01a3d58e251d4e54046b58d5e2294fbd1061cf11"` [INFO] [stdout] 139ce1ec59db1a6579e1583a01a3d58e251d4e54046b58d5e2294fbd1061cf11