[INFO] crate zlo 0.1.0 is already in cache [INFO] extracting crate zlo 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/zlo/0.1.0 [INFO] extracting crate zlo 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zlo/0.1.0 [INFO] validating manifest of zlo-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zlo-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zlo-0.1.0 [INFO] finished frobbing zlo-0.1.0 [INFO] frobbed toml for zlo-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/zlo/0.1.0/Cargo.toml [INFO] started frobbing zlo-0.1.0 [INFO] finished frobbing zlo-0.1.0 [INFO] frobbed toml for zlo-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zlo/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zlo-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zlo/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da14983e25e5892a17ed4580cffe71c58d96989d31104ae353f853890b25d28f [INFO] running `"docker" "start" "-a" "da14983e25e5892a17ed4580cffe71c58d96989d31104ae353f853890b25d28f"` [INFO] [stderr] Checking serde_bytes v0.10.4 [INFO] [stderr] Checking zlo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser/mod.rs:346:23 [INFO] [stderr] | [INFO] [stderr] 346 | SizeChecker { size_limit: size_limit } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser/mod.rs:911:18 [INFO] [stderr] | [INFO] [stderr] 911 | EncodeUtf8 { buf: buf, pos: pos } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser/mod.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | EncodeUtf8 { buf: buf, pos: pos } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | size_limit: size_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:206:36 [INFO] [stderr] | [INFO] [stderr] 206 | self.write_bit((frac & 0xffffff) != 0)?; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | if (frac & 0xffffff) != 0 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser/mod.rs:346:23 [INFO] [stderr] | [INFO] [stderr] 346 | SizeChecker { size_limit: size_limit } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser/mod.rs:911:18 [INFO] [stderr] | [INFO] [stderr] 911 | EncodeUtf8 { buf: buf, pos: pos } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser/mod.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | EncodeUtf8 { buf: buf, pos: pos } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | size_limit: size_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser/mod.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(()) => Ok(self.store = if self.shift > 0 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 75 | | v >> (8 - self.shift) [INFO] [stderr] 76 | | } else { [INFO] [stderr] 77 | | 0 [INFO] [stderr] 78 | | }), [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 74 | Ok(()) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `frac` [INFO] [stderr] --> src/ser/mod.rs:210:33 [INFO] [stderr] | [INFO] [stderr] 210 | self.write_byte((frac >> 0) as u8)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:388:22 [INFO] [stderr] | [INFO] [stderr] 388 | self.add(1 + (18 - z) as u64 - (z == 0) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(18 - z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:393:22 [INFO] [stderr] | [INFO] [stderr] 393 | self.add(1 + (36 - z) as u64 - (z == 0) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(36 - z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:398:22 [INFO] [stderr] | [INFO] [stderr] 398 | self.add(1 + (72 - z) as u64 - (z == 0) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(72 - z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | v |= (self.read_byte()? as $ty) << x * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte()?)` [INFO] [stderr] ... [INFO] [stderr] 95 | de_uint!(de_u16, u16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | v |= (self.read_byte()? as $ty) << x * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_byte()?)` [INFO] [stderr] ... [INFO] [stderr] 96 | de_uint!(de_u32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | v |= (self.read_byte()? as $ty) << x * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] ... [INFO] [stderr] 97 | de_uint!(de_u64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:188:14 [INFO] [stderr] | [INFO] [stderr] 188 | ((self.read_byte()? as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:189:20 [INFO] [stderr] | [INFO] [stderr] 189 | | ((self.read_byte()? as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:190:41 [INFO] [stderr] | [INFO] [stderr] 190 | | if self.read_bit()? { self.read_byte()? as u32 } else { 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:192:45 [INFO] [stderr] | [INFO] [stderr] 192 | let bits = ((sign as u32) << 31) | ((exp as u32) << 23) | frac; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:205:19 [INFO] [stderr] | [INFO] [stderr] 205 | | self.read_byte()? as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:210:14 [INFO] [stderr] | [INFO] [stderr] 210 | ((self.read_byte()? as u64) << 48) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:211:16 [INFO] [stderr] | [INFO] [stderr] 211 | | ((self.read_byte()? as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:212:16 [INFO] [stderr] | [INFO] [stderr] 212 | | ((self.read_byte()? as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:213:16 [INFO] [stderr] | [INFO] [stderr] 213 | | ((self.read_byte()? as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:215:18 [INFO] [stderr] | [INFO] [stderr] 215 | ((self.read_byte()? as u64) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:216:24 [INFO] [stderr] | [INFO] [stderr] 216 | | ((self.read_byte()? as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.read_byte()? as u64)` [INFO] [stderr] --> src/de/mod.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | | ((self.read_byte()? as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:217:24 [INFO] [stderr] | [INFO] [stderr] 217 | | ((self.read_byte()? as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:220:45 [INFO] [stderr] | [INFO] [stderr] 220 | let bits = ((sign as u64) << 63) | ((exp as u64) << 52) | frac; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/de/mod.rs:237:24 [INFO] [stderr] | [INFO] [stderr] 237 | let error = || Error::InvalidEncoding { [INFO] [stderr] | ________________________^ [INFO] [stderr] 238 | | desc: "Invalid char encoding", [INFO] [stderr] 239 | | detail: None, [INFO] [stderr] 240 | | }.into(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 237 | let error = || Error::InvalidEncoding { [INFO] [stderr] 238 | desc: "Invalid char encoding", [INFO] [stderr] 239 | detail: None, [INFO] [stderr] 240 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de/mod.rs:259:14 [INFO] [stderr] | [INFO] [stderr] 259 | .ok_or(error())?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `ok_or_else(error)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/de/mod.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | / match self.read_bit()? { [INFO] [stderr] 389 | | false => visitor.visit_none(), [INFO] [stderr] 390 | | true => visitor.visit_some(&mut *self), [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.read_bit()? { visitor.visit_some(&mut *self) } else { visitor.visit_none() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | Error::Io(err).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Io(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | Error::Custom(desc.to_string()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Custom(desc.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | Error::Custom(msg.to_string()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Custom(msg.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:206:36 [INFO] [stderr] | [INFO] [stderr] 206 | self.write_bit((frac & 0xffffff) != 0)?; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | if (frac & 0xffffff) != 0 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `zlo::Infinite` [INFO] [stderr] --> examples/float_delta.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use zlo::Infinite; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `zlo::deserialize` [INFO] [stderr] --> examples/float_delta.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use zlo::deserialize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `zlo::serialize` [INFO] [stderr] --> examples/float_delta.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use zlo::serialize; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/float_delta.rs:10:53 [INFO] [stderr] | [INFO] [stderr] 10 | let sign_23 = |x| x | if (x & (1 << 22)) != 0 { 0xff800000 } else { 0 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff80_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/float_delta.rs:26:53 [INFO] [stderr] | [INFO] [stderr] 26 | let sign_52 = |x| x | if (x & (1 << 51)) != 0 { 0xfff0000000000000 } else { 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xfff0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `f32_diff` [INFO] [stderr] --> examples/float_delta.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn f32_diff(a: f32, b: f32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `f64_diff` [INFO] [stderr] --> examples/float_delta.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | fn f64_diff(a: f64, b: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> examples/float_delta.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | let bits = ((sign as u32) << 31) | ((exp as u32) << 23) | frac; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> examples/float_delta.rs:38:41 [INFO] [stderr] | [INFO] [stderr] 38 | let bits = ((sign as u64) << 63) | ((exp as u64) << 52) | frac; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser/mod.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(()) => Ok(self.store = if self.shift > 0 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 75 | | v >> (8 - self.shift) [INFO] [stderr] 76 | | } else { [INFO] [stderr] 77 | | 0 [INFO] [stderr] 78 | | }), [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 74 | Ok(()) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `frac` [INFO] [stderr] --> src/ser/mod.rs:210:33 [INFO] [stderr] | [INFO] [stderr] 210 | self.write_byte((frac >> 0) as u8)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:388:22 [INFO] [stderr] | [INFO] [stderr] 388 | self.add(1 + (18 - z) as u64 - (z == 0) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(18 - z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:393:22 [INFO] [stderr] | [INFO] [stderr] 393 | self.add(1 + (36 - z) as u64 - (z == 0) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(36 - z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:398:22 [INFO] [stderr] | [INFO] [stderr] 398 | self.add(1 + (72 - z) as u64 - (z == 0) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(72 - z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | v |= (self.read_byte()? as $ty) << x * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte()?)` [INFO] [stderr] ... [INFO] [stderr] 95 | de_uint!(de_u16, u16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | v |= (self.read_byte()? as $ty) << x * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_byte()?)` [INFO] [stderr] ... [INFO] [stderr] 96 | de_uint!(de_u32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | v |= (self.read_byte()? as $ty) << x * 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] ... [INFO] [stderr] 97 | de_uint!(de_u64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:188:14 [INFO] [stderr] | [INFO] [stderr] 188 | ((self.read_byte()? as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:189:20 [INFO] [stderr] | [INFO] [stderr] 189 | | ((self.read_byte()? as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:190:41 [INFO] [stderr] | [INFO] [stderr] 190 | | if self.read_bit()? { self.read_byte()? as u32 } else { 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:192:45 [INFO] [stderr] | [INFO] [stderr] 192 | let bits = ((sign as u32) << 31) | ((exp as u32) << 23) | frac; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:205:19 [INFO] [stderr] | [INFO] [stderr] 205 | | self.read_byte()? as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:210:14 [INFO] [stderr] | [INFO] [stderr] 210 | ((self.read_byte()? as u64) << 48) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:211:16 [INFO] [stderr] | [INFO] [stderr] 211 | | ((self.read_byte()? as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:212:16 [INFO] [stderr] | [INFO] [stderr] 212 | | ((self.read_byte()? as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:213:16 [INFO] [stderr] | [INFO] [stderr] 213 | | ((self.read_byte()? as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:215:18 [INFO] [stderr] | [INFO] [stderr] 215 | ((self.read_byte()? as u64) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:216:24 [INFO] [stderr] | [INFO] [stderr] 216 | | ((self.read_byte()? as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.read_byte()? as u64)` [INFO] [stderr] --> src/de/mod.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | | ((self.read_byte()? as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:217:24 [INFO] [stderr] | [INFO] [stderr] 217 | | ((self.read_byte()? as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_byte()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:220:45 [INFO] [stderr] | [INFO] [stderr] 220 | let bits = ((sign as u64) << 63) | ((exp as u64) << 52) | frac; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/de/mod.rs:237:24 [INFO] [stderr] | [INFO] [stderr] 237 | let error = || Error::InvalidEncoding { [INFO] [stderr] | ________________________^ [INFO] [stderr] 238 | | desc: "Invalid char encoding", [INFO] [stderr] 239 | | detail: None, [INFO] [stderr] 240 | | }.into(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 237 | let error = || Error::InvalidEncoding { [INFO] [stderr] 238 | desc: "Invalid char encoding", [INFO] [stderr] 239 | detail: None, [INFO] [stderr] 240 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de/mod.rs:259:14 [INFO] [stderr] | [INFO] [stderr] 259 | .ok_or(error())?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `ok_or_else(error)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/de/mod.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | / match self.read_bit()? { [INFO] [stderr] 389 | | false => visitor.visit_none(), [INFO] [stderr] 390 | | true => visitor.visit_some(&mut *self), [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.read_bit()? { visitor.visit_some(&mut *self) } else { visitor.visit_none() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | Error::Io(err).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Io(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | Error::Custom(desc.to_string()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Custom(desc.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | Error::Custom(msg.to_string()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Custom(msg.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:240:40 [INFO] [stderr] | [INFO] [stderr] 240 | assert_eq!(4 * 9, serialized_size(&0xffffffffu32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:241:40 [INFO] [stderr] | [INFO] [stderr] 241 | assert_eq!(8 * 9, serialized_size(&0xffffffffffffffffu64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:276:26 [INFO] [stderr] | [INFO] [stderr] 276 | assert_8!(serialize(&0xffffffffu32, Infinite).unwrap().len() as u64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:277:32 [INFO] [stderr] | [INFO] [stderr] 277 | serialized_size(&0xffffffffu32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/range.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | (x * (if x < 0.0 { MIN } else { MAX }) as f32) as i8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((if x < 0.0 { MIN } else { MAX }))` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:278:26 [INFO] [stderr] | [INFO] [stderr] 278 | assert_8!(serialize(&0xffffffffffffffffu64, Infinite).unwrap().len() as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:279:32 [INFO] [stderr] | [INFO] [stderr] 279 | serialized_size(&0xffffffffffffffffu64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/range.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | x as f32 * if x < 0 { 1.0 / MIN as f32 } else { 1.0 / MAX as f32 } [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/range.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | x as f32 * if x < 0 { 1.0 / MIN as f32 } else { 1.0 / MAX as f32 } [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/range.rs:46:59 [INFO] [stderr] | [INFO] [stderr] 46 | x as f32 * if x < 0 { 1.0 / MIN as f32 } else { 1.0 / MAX as f32 } [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> examples/range.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | fn serialize_axis(axis: &[f32; 2], serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:367:39 [INFO] [stderr] | [INFO] [stderr] 367 | let x = serialize(&FakeVec { len: 0xffffffffffffffffu64, byte: 1 }, Bounded::new_bytes(11)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:397:24 [INFO] [stderr] | [INFO] [stderr] 397 | let bits = 0x80000000 | (exp << 23) | frac; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:420:24 [INFO] [stderr] | [INFO] [stderr] 420 | let bits = 0x8000000000000000 | (exp << 52) | frac; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> examples/range.rs:79:49 [INFO] [stderr] | [INFO] [stderr] 79 | let a: i8 = visitor.next_element()?.ok_or(V::Error::invalid_length(0, &"2"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| V::Error::invalid_length(0, &"2"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> examples/range.rs:80:49 [INFO] [stderr] | [INFO] [stderr] 80 | let b: i8 = visitor.next_element()?.ok_or(V::Error::invalid_length(1, &"2"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| V::Error::invalid_length(1, &"2"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/test.rs:136:44 [INFO] [stderr] | [INFO] [stderr] 136 | the_same(TestEnum::StructLike{x: 4, y: 3.14159}); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `9` [INFO] [stderr] --> tests/test.rs:238:16 [INFO] [stderr] | [INFO] [stderr] 238 | assert_eq!(1 * 9, serialized_size(&0xffu8)); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test.rs:351:13 [INFO] [stderr] | [INFO] [stderr] 351 | assert!(slice == &vecx[..]); [INFO] [stderr] | ^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `vecx[..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `zlo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "da14983e25e5892a17ed4580cffe71c58d96989d31104ae353f853890b25d28f"` [INFO] running `"docker" "rm" "-f" "da14983e25e5892a17ed4580cffe71c58d96989d31104ae353f853890b25d28f"` [INFO] [stdout] da14983e25e5892a17ed4580cffe71c58d96989d31104ae353f853890b25d28f