[INFO] crate zksnark 0.0.2 is already in cache [INFO] extracting crate zksnark 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/zksnark/0.0.2 [INFO] extracting crate zksnark 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zksnark/0.0.2 [INFO] validating manifest of zksnark-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zksnark-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zksnark-0.0.2 [INFO] finished frobbing zksnark-0.0.2 [INFO] frobbed toml for zksnark-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/zksnark/0.0.2/Cargo.toml [INFO] started frobbing zksnark-0.0.2 [INFO] finished frobbing zksnark-0.0.2 [INFO] frobbed toml for zksnark-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zksnark/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zksnark-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zksnark/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b817e36abad2f5f0474e666673d2a2c88ceca9f94a71fa9c7ec260c04fcccefa [INFO] running `"docker" "start" "-a" "b817e36abad2f5f0474e666673d2a2c88ceca9f94a71fa9c7ec260c04fcccefa"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Compiling crunchy v0.1.6 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking bigint v4.4.1 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking bn v0.4.3 [INFO] [stderr] Checking zksnark v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/field/mod.rs:255:28 [INFO] [stderr] | [INFO] [stderr] 255 | let (mut r, mut s, mut t, mut q): (T, T, T, T); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/field/mod.rs:255:35 [INFO] [stderr] | [INFO] [stderr] 255 | let (mut r, mut s, mut t, mut q): (T, T, T, T); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/field/mod.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | let s = r[r.degree()] / c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/groth16/mod.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | let h = (u_sum * v_sum - w_sum) / qap.t.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/groth16/mod.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | let c = h [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: function is never used: `chinese_remainder` [INFO] [stderr] --> src/field/mod.rs:274:1 [INFO] [stderr] | [INFO] [stderr] 274 | / fn chinese_remainder(rems: &[T], moduli: &[T]) -> T [INFO] [stderr] 275 | | where [INFO] [stderr] 276 | | T: Div [INFO] [stderr] 277 | | + Mul [INFO] [stderr] ... | [INFO] [stderr] 295 | | .fold(T::zero(), |acc, x| acc + x) [INFO] [stderr] 296 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/field/z251.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | let sum: u16 = self.inner as u16 + rhs.inner as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.inner)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/field/z251.rs:12:44 [INFO] [stderr] | [INFO] [stderr] 12 | let sum: u16 = self.inner as u16 + rhs.inner as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(rhs.inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/field/z251.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | inner: (sum % 251) as u8, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/field/z251.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | let product = (self.inner as u16) * (rhs.inner as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/field/z251.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | let product = (self.inner as u16) * (rhs.inner as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(rhs.inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/field/z251.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | inner: (product % 251) as u8, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/field/z251.rs:59:14 [INFO] [stderr] | [INFO] [stderr] 59 | self * Z251 { inner: inv as u8 } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/field/mod.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | self.iter().map(|&x| x).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/field/mod.rs:342:30 [INFO] [stderr] | [INFO] [stderr] 342 | while r.degree() >= d && r.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!r.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/groth16/circuit/ast.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if group.tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `group.tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/groth16/circuit/ast.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | if group.tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `group.tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/groth16/circuit/ast.rs:213:24 [INFO] [stderr] | [INFO] [stderr] 213 | if group.tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `group.tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/groth16/circuit/ast.rs:317:27 [INFO] [stderr] | [INFO] [stderr] 317 | if substr.starts_with("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/groth16/circuit/ast.rs:323:8 [INFO] [stderr] | [INFO] [stderr] 323 | if substr.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `substr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/groth16/circuit/ast.rs:336:32 [INFO] [stderr] | [INFO] [stderr] 336 | if substr.contains("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/groth16/circuit/ast.rs:338:39 [INFO] [stderr] | [INFO] [stderr] 338 | } else if substr.contains("*") || substr.contains("+") || substr.contains("=") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/groth16/circuit/ast.rs:338:63 [INFO] [stderr] | [INFO] [stderr] 338 | } else if substr.contains("*") || substr.contains("+") || substr.contains("=") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/groth16/circuit/ast.rs:338:87 [INFO] [stderr] | [INFO] [stderr] 338 | } else if substr.contains("*") || substr.contains("+") || substr.contains("=") { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/groth16/circuit/ast.rs:343:16 [INFO] [stderr] | [INFO] [stderr] 343 | if tokens.len() != 0 && end.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/groth16/circuit/ast.rs:343:37 [INFO] [stderr] | [INFO] [stderr] 343 | if tokens.len() != 0 && end.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!end.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/groth16/circuit/builder/mod.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn inner_id(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `groth16::circuit::builder::Circuit` [INFO] [stderr] --> src/groth16/circuit/builder/mod.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | / pub fn new() -> Self { [INFO] [stderr] 205 | | // TODO: Initialise the unity wire value to be one? [INFO] [stderr] 206 | | Circuit { [INFO] [stderr] 207 | | next_wire_id: WireId(1), [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 200 | impl Default for groth16::circuit::builder::Circuit { [INFO] [stderr] 201 | fn default() -> Self { [INFO] [stderr] 202 | Self::new() [INFO] [stderr] 203 | } [INFO] [stderr] 204 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/groth16/circuit/builder/mod.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | / self.wire_assignments [INFO] [stderr] 256 | | .get_mut(&wire) [INFO] [stderr] 257 | | .map(|v| v.push(connection)); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 255 | if let Some(v) = self.wire_assignments [INFO] [stderr] 256 | .get_mut(&wire) { v.push(connection) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/groth16/circuit/builder/mod.rs:262:45 [INFO] [stderr] | [INFO] [stderr] 262 | (0..self.next_sub_circuit_id.0).map(|id| SubCircuitId(id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SubCircuitId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/groth16/circuit/builder/mod.rs:344:22 [INFO] [stderr] | [INFO] [stderr] 344 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/groth16/circuit/builder/mod.rs:345:37 [INFO] [stderr] | [INFO] [stderr] 345 | .filter_map(|c| if let &Output(sc) = c { Some(sc) } else { None }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 345 | .filter_map(|c| if let Output(sc) = *c { Some(sc) } else { None }) [INFO] [stderr] | ^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/groth16/circuit/dummy_rep.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | roots: (1..line_count + 1).map(|n| n.into()).collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(1..=line_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/groth16/circuit/mod.rs:240:25 [INFO] [stderr] | [INFO] [stderr] 240 | / if !variables.contains_key(&vr) { [INFO] [stderr] 241 | | let index = u.len(); [INFO] [stderr] 242 | | variables.insert(vr, index); [INFO] [stderr] 243 | | [INFO] [stderr] ... | [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________________________^ help: consider using: `variables.entry(vr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/groth16/circuit/mod.rs:249:33 [INFO] [stderr] | [INFO] [stderr] 249 | if *variables.get(&vr).unwrap() <= input { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&variables[&vr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/groth16/circuit/mod.rs:250:45 [INFO] [stderr] | [INFO] [stderr] 250 | let index = variables.get(&vr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&variables[&vr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/groth16/circuit/mod.rs:251:36 [INFO] [stderr] | [INFO] [stderr] 251 | if w[*index].len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!w[*index].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/groth16/circuit/mod.rs:277:33 [INFO] [stderr] | [INFO] [stderr] 277 | / if !variables.contains_key(&vr) { [INFO] [stderr] 278 | | let index = u.len(); [INFO] [stderr] 279 | | variables.insert(vr, index); [INFO] [stderr] 280 | | [INFO] [stderr] ... | [INFO] [stderr] 287 | | u[*index].push((gate_number.into(), 1.into())); [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `variables.entry(vr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/groth16/circuit/mod.rs:286:49 [INFO] [stderr] | [INFO] [stderr] 286 | let index = variables.get(&vr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&variables[&vr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/groth16/circuit/mod.rs:295:45 [INFO] [stderr] | [INFO] [stderr] 295 | / if !variables.contains_key(&vr) { [INFO] [stderr] 296 | | let index = u.len(); [INFO] [stderr] 297 | | variables.insert(vr, index); [INFO] [stderr] 298 | | [INFO] [stderr] ... | [INFO] [stderr] 305 | | u[*index].push((gate_number.into(), 1.into())); [INFO] [stderr] 306 | | } [INFO] [stderr] | |_____________________________________________^ help: consider using: `variables.entry(vr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/groth16/circuit/mod.rs:304:61 [INFO] [stderr] | [INFO] [stderr] 304 | let index = variables.get(&vr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&variables[&vr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/groth16/circuit/mod.rs:324:45 [INFO] [stderr] | [INFO] [stderr] 324 | / if !variables.contains_key(&right) { [INFO] [stderr] 325 | | let index = u.len(); [INFO] [stderr] 326 | | variables.insert(right, index); [INFO] [stderr] 327 | | [INFO] [stderr] ... | [INFO] [stderr] 334 | | u[*index].push((gate_number.into(), left)); [INFO] [stderr] 335 | | } [INFO] [stderr] | |_____________________________________________^ help: consider using: `variables.entry(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/groth16/circuit/mod.rs:333:61 [INFO] [stderr] | [INFO] [stderr] 333 | let index = variables.get(&right).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&variables[&right]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/groth16/circuit/mod.rs:359:33 [INFO] [stderr] | [INFO] [stderr] 359 | / if !variables.contains_key(&vr) { [INFO] [stderr] 360 | | let index = v.len(); [INFO] [stderr] 361 | | variables.insert(vr, index); [INFO] [stderr] 362 | | [INFO] [stderr] ... | [INFO] [stderr] 369 | | v[*index].push((gate_number.into(), 1.into())); [INFO] [stderr] 370 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `variables.entry(vr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/groth16/circuit/mod.rs:368:49 [INFO] [stderr] | [INFO] [stderr] 368 | let index = variables.get(&vr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&variables[&vr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/groth16/circuit/mod.rs:377:45 [INFO] [stderr] | [INFO] [stderr] 377 | / if !variables.contains_key(&vr) { [INFO] [stderr] 378 | | let index = v.len(); [INFO] [stderr] 379 | | variables.insert(vr, index); [INFO] [stderr] 380 | | [INFO] [stderr] ... | [INFO] [stderr] 387 | | v[*index].push((gate_number.into(), 1.into())); [INFO] [stderr] 388 | | } [INFO] [stderr] | |_____________________________________________^ help: consider using: `variables.entry(vr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/groth16/circuit/mod.rs:386:61 [INFO] [stderr] | [INFO] [stderr] 386 | let index = variables.get(&vr).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&variables[&vr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/groth16/circuit/mod.rs:406:45 [INFO] [stderr] | [INFO] [stderr] 406 | / if !variables.contains_key(&right) { [INFO] [stderr] 407 | | let index = v.len(); [INFO] [stderr] 408 | | variables.insert(right, index); [INFO] [stderr] 409 | | [INFO] [stderr] ... | [INFO] [stderr] 416 | | v[*index].push((gate_number.into(), left)); [INFO] [stderr] 417 | | } [INFO] [stderr] | |_____________________________________________^ help: consider using: `variables.entry(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/groth16/circuit/mod.rs:415:61 [INFO] [stderr] | [INFO] [stderr] 415 | let index = variables.get(&right).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&variables[&right]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/groth16/circuit/mod.rs:451:21 [INFO] [stderr] | [INFO] [stderr] 451 | let roots = (1..gate_number + 1).map(|r| r.into()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=gate_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/groth16/circuit/mod.rs:512:25 [INFO] [stderr] | [INFO] [stderr] 512 | for var in vars.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/groth16/circuit/mod.rs:526:35 [INFO] [stderr] | [INFO] [stderr] 526 | for assignment in program.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/groth16/circuit/mod.rs:580:34 [INFO] [stderr] | [INFO] [stderr] 580 | Literal(ref lit) => Some(lit.clone()), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*lit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/groth16/circuit/mod.rs:585:35 [INFO] [stderr] | [INFO] [stderr] 585 | Add(ref inputs) => inputs.into_iter().try_fold(F::zero(), |acc, x| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/groth16/coefficient_poly.rs:115:54 [INFO] [stderr] | [INFO] [stderr] 115 | .skip(max(self.degree() as isize - i as isize, 0) as usize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/groth16/coefficient_poly.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | .take(i + 1) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/groth16/coefficient_poly.rs:121:46 [INFO] [stderr] | [INFO] [stderr] 121 | .skip(max(i as isize - self.degree() as isize, 0) as usize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/groth16/fr.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | FrLocal(self.0 * rhs.0.inverse().expect("Tried to divide by zero")) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/groth16/fr.rs:229:24 [INFO] [stderr] | [INFO] [stderr] 229 | GtLocal(self.0 * rhs.0) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/groth16/mod.rs:313:35 [INFO] [stderr] | [INFO] [stderr] 313 | .zip(once(T::one()).chain(inputs.iter().map(|&x| x))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `inputs.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `zksnark`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "b817e36abad2f5f0474e666673d2a2c88ceca9f94a71fa9c7ec260c04fcccefa"` [INFO] running `"docker" "rm" "-f" "b817e36abad2f5f0474e666673d2a2c88ceca9f94a71fa9c7ec260c04fcccefa"` [INFO] [stdout] b817e36abad2f5f0474e666673d2a2c88ceca9f94a71fa9c7ec260c04fcccefa