[INFO] crate zipkin 0.3.2 is already in cache [INFO] extracting crate zipkin 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/zipkin/0.3.2 [INFO] extracting crate zipkin 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zipkin/0.3.2 [INFO] validating manifest of zipkin-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zipkin-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zipkin-0.3.2 [INFO] finished frobbing zipkin-0.3.2 [INFO] frobbed toml for zipkin-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/zipkin/0.3.2/Cargo.toml [INFO] started frobbing zipkin-0.3.2 [INFO] finished frobbing zipkin-0.3.2 [INFO] frobbed toml for zipkin-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zipkin/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zipkin-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zipkin/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 54bef3e98c1bb7bd5a420f32f2048ab628f039cf32e7e408e02845f3b032557c [INFO] running `"docker" "start" "-a" "54bef3e98c1bb7bd5a420f32f2048ab628f039cf32e7e408e02845f3b032557c"` [INFO] [stderr] Checking zipkin-types v0.1.0 [INFO] [stderr] Checking thread-local-object v0.1.0 [INFO] [stderr] Checking zipkin v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sampling_flags.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn sampled(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sampling_flags.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn debug(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/tracer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / Real { [INFO] [stderr] 96 | | span: span::Builder, [INFO] [stderr] 97 | | start_instant: Instant, [INFO] [stderr] 98 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/tracer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / Real { [INFO] [stderr] 96 | | span: span::Builder, [INFO] [stderr] 97 | | start_instant: Instant, [INFO] [stderr] 98 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/tracer.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if let None = context.sampled() { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 330 | | context = trace_context::Builder::from(context) [INFO] [stderr] 331 | | .sampled(self.0.sampler.sample(context.trace_id())) [INFO] [stderr] 332 | | .build(); [INFO] [stderr] ... | [INFO] [stderr] 335 | | shared = false; [INFO] [stderr] 336 | | } [INFO] [stderr] | |_________- help: try this: `if context.sampled().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sampling_flags.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn sampled(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sampling_flags.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn debug(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/tracer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / Real { [INFO] [stderr] 96 | | span: span::Builder, [INFO] [stderr] 97 | | start_instant: Instant, [INFO] [stderr] 98 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/tracer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / Real { [INFO] [stderr] 96 | | span: span::Builder, [INFO] [stderr] 97 | | start_instant: Instant, [INFO] [stderr] 98 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/tracer.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if let None = context.sampled() { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 330 | | context = trace_context::Builder::from(context) [INFO] [stderr] 331 | | .sampled(self.0.sampler.sample(context.trace_id())) [INFO] [stderr] 332 | | .build(); [INFO] [stderr] ... | [INFO] [stderr] 335 | | shared = false; [INFO] [stderr] 336 | | } [INFO] [stderr] | |_________- help: try this: `if context.sampled().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.92s [INFO] running `"docker" "inspect" "54bef3e98c1bb7bd5a420f32f2048ab628f039cf32e7e408e02845f3b032557c"` [INFO] running `"docker" "rm" "-f" "54bef3e98c1bb7bd5a420f32f2048ab628f039cf32e7e408e02845f3b032557c"` [INFO] [stdout] 54bef3e98c1bb7bd5a420f32f2048ab628f039cf32e7e408e02845f3b032557c