[INFO] crate zipcat 0.1.0 is already in cache [INFO] extracting crate zipcat 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/zipcat/0.1.0 [INFO] extracting crate zipcat 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zipcat/0.1.0 [INFO] validating manifest of zipcat-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zipcat-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zipcat-0.1.0 [INFO] finished frobbing zipcat-0.1.0 [INFO] frobbed toml for zipcat-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/zipcat/0.1.0/Cargo.toml [INFO] started frobbing zipcat-0.1.0 [INFO] finished frobbing zipcat-0.1.0 [INFO] frobbed toml for zipcat-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zipcat/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zipcat-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zipcat/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 09eda1cc4d8e5d171e27515f90d00644aa7f98c49728d93b34ea9a2ad18983bf [INFO] running `"docker" "start" "-a" "09eda1cc4d8e5d171e27515f90d00644aa7f98c49728d93b34ea9a2ad18983bf"` [INFO] [stderr] Compiling miniz_oxide_c_api v0.2.1 [INFO] [stderr] Compiling bzip2-sys v0.1.7 [INFO] [stderr] Checking miniz_oxide v0.2.1 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking zip v0.2.8 [INFO] [stderr] Checking zipcat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | print!("{}\n", e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | print!("{}\n", e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / return (includes.len() == 0 || includes.iter().any(|p| p.matches_with(path, &options))) && [INFO] [stderr] 97 | | !excludes.iter().any(|p| p.matches_with(path, &options)); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 96 | (includes.len() == 0 || includes.iter().any(|p| p.matches_with(path, &options))) && [INFO] [stderr] 97 | !excludes.iter().any(|p| p.matches_with(path, &options)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / return (includes.len() == 0 || includes.iter().any(|p| p.matches_with(path, &options))) && [INFO] [stderr] 97 | | !excludes.iter().any(|p| p.matches_with(path, &options)); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 96 | (includes.len() == 0 || includes.iter().any(|p| p.matches_with(path, &options))) && [INFO] [stderr] 97 | !excludes.iter().any(|p| p.matches_with(path, &options)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | fn include_file(path: &str, includes: &Vec, excludes: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Pattern]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:88:64 [INFO] [stderr] | [INFO] [stderr] 88 | fn include_file(path: &str, includes: &Vec, excludes: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Pattern]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | return (includes.len() == 0 || includes.iter().any(|p| p.matches_with(path, &options))) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `includes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | fn include_file(path: &str, includes: &Vec, excludes: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Pattern]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:88:64 [INFO] [stderr] | [INFO] [stderr] 88 | fn include_file(path: &str, includes: &Vec, excludes: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Pattern]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | return (includes.len() == 0 || includes.iter().any(|p| p.matches_with(path, &options))) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `includes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.42s [INFO] running `"docker" "inspect" "09eda1cc4d8e5d171e27515f90d00644aa7f98c49728d93b34ea9a2ad18983bf"` [INFO] running `"docker" "rm" "-f" "09eda1cc4d8e5d171e27515f90d00644aa7f98c49728d93b34ea9a2ad18983bf"` [INFO] [stdout] 09eda1cc4d8e5d171e27515f90d00644aa7f98c49728d93b34ea9a2ad18983bf