[INFO] crate zhelezo 0.7.0-beta.2 is already in cache [INFO] extracting crate zhelezo 0.7.0-beta.2 into work/ex/clippy-test-run/sources/stable/reg/zhelezo/0.7.0-beta.2 [INFO] extracting crate zhelezo 0.7.0-beta.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zhelezo/0.7.0-beta.2 [INFO] validating manifest of zhelezo-0.7.0-beta.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zhelezo-0.7.0-beta.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zhelezo-0.7.0-beta.2 [INFO] finished frobbing zhelezo-0.7.0-beta.2 [INFO] frobbed toml for zhelezo-0.7.0-beta.2 written to work/ex/clippy-test-run/sources/stable/reg/zhelezo/0.7.0-beta.2/Cargo.toml [INFO] started frobbing zhelezo-0.7.0-beta.2 [INFO] finished frobbing zhelezo-0.7.0-beta.2 [INFO] frobbed toml for zhelezo-0.7.0-beta.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zhelezo/0.7.0-beta.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zhelezo-0.7.0-beta.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zhelezo/0.7.0-beta.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c6c07481dc895ccc154e62fbafc643d5bfe3cbcc237ace89a8ad08a89fdef11 [INFO] running `"docker" "start" "-a" "0c6c07481dc895ccc154e62fbafc643d5bfe3cbcc237ace89a8ad08a89fdef11"` [INFO] [stderr] Compiling rand_core v0.4.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking tokio-sync v0.1.0 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking tokio-executor v0.1.6 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking crossbeam-channel v0.3.7 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_jitter v0.1.0 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking mime v0.3.13 [INFO] [stderr] Checking tokio-timer v0.2.9 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand_os v0.1.1 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking zhelezo v0.7.0-beta.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | local_addr: local_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/middleware/test.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | befores: befores, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `befores` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/middleware/test.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | afters: afters [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `afters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/middleware/test.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | mode: mode [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | local_addr: local_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `zhelezo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `response::Response` [INFO] [stderr] --> src/response.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn new() -> Response { [INFO] [stderr] 96 | | Response { [INFO] [stderr] 97 | | status: None, // Start with no response code. [INFO] [stderr] 98 | | body: None, // Start with no body. [INFO] [stderr] ... | [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | impl Default for response::Response { [INFO] [stderr] 94 | fn default() -> Self { [INFO] [stderr] 95 | Self::new() [INFO] [stderr] 96 | } [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/modifiers.rs:133:14 [INFO] [stderr] | [INFO] [stderr] 133 | .expect(&format!("No such file: {}", self.display())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("No such file: {}", self.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/iron.rs:143:35 [INFO] [stderr] | [INFO] [stderr] 143 | self.local_address = Some(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/iron.rs:182:19 [INFO] [stderr] | [INFO] [stderr] 182 | addr: self.local_address.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.local_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/iron.rs:204:20 [INFO] [stderr] | [INFO] [stderr] 204 | let addr = self.addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0c6c07481dc895ccc154e62fbafc643d5bfe3cbcc237ace89a8ad08a89fdef11"` [INFO] running `"docker" "rm" "-f" "0c6c07481dc895ccc154e62fbafc643d5bfe3cbcc237ace89a8ad08a89fdef11"` [INFO] [stdout] 0c6c07481dc895ccc154e62fbafc643d5bfe3cbcc237ace89a8ad08a89fdef11