[INFO] crate zbuf 0.1.2 is already in cache
[INFO] extracting crate zbuf 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/zbuf/0.1.2
[INFO] extracting crate zbuf 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zbuf/0.1.2
[INFO] validating manifest of zbuf-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of zbuf-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing zbuf-0.1.2
[INFO] removed 0 missing tests
[INFO] finished frobbing zbuf-0.1.2
[INFO] frobbed toml for zbuf-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/zbuf/0.1.2/Cargo.toml
[INFO] started frobbing zbuf-0.1.2
[INFO] removed 0 missing tests
[INFO] finished frobbing zbuf-0.1.2
[INFO] frobbed toml for zbuf-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zbuf/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting zbuf-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zbuf/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5f590f5d35754ec177e9754a337d22958bcaa42d0ae2a9973abe730aa4d5c820
[INFO] running `"docker" "start" "-a" "5f590f5d35754ec177e9754a337d22958bcaa42d0ae2a9973abe730aa4d5c820"`
[INFO] [stderr]     Checking utf-8 v0.7.5
[INFO] [stderr]     Checking zbuf v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> bytesbuf.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     with_new_len
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> bytesbuf.rs:78:24
[INFO] [stderr]    |
[INFO] [stderr] 78 |     let with_new_len = without_len | (new_len << INLINE_LENGTH_OFFSET_BITS);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> bytesbuf.rs:201:13
[INFO] [stderr]     |
[INFO] [stderr] 201 |             return (initialized, tail)
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(initialized, tail)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> bytesbuf.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     with_new_len
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> bytesbuf.rs:78:24
[INFO] [stderr]    |
[INFO] [stderr] 78 |     let with_new_len = without_len | (new_len << INLINE_LENGTH_OFFSET_BITS);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> bytesbuf.rs:201:13
[INFO] [stderr]     |
[INFO] [stderr] 201 |             return (initialized, tail)
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(initialized, tail)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> bytesbuf.rs:249:16
[INFO] [stderr]     |
[INFO] [stderr] 249 |           if let Ok(_) = self.as_allocated() {
[INFO] [stderr]     |  _________-      ^^^^^
[INFO] [stderr] 250 | |             let bytes = usize_to_u32(bytes);
[INFO] [stderr] 251 | |             match self.0.len.checked_sub(bytes) {
[INFO] [stderr] 252 | |                 None => panic!("tried to pop {} bytes, only {} are available", bytes, self.0.len),
[INFO] [stderr] ...   |
[INFO] [stderr] 260 | |             *self = Self::from(&self[bytes..])
[INFO] [stderr] 261 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.as_allocated().is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> bytesbuf.rs:308:16
[INFO] [stderr]     |
[INFO] [stderr] 308 |           if let Ok(_) = self.as_allocated() {
[INFO] [stderr]     |  _________-      ^^^^^
[INFO] [stderr] 309 | |             let _: &[u8] = &self[at..];  // Check bounds
[INFO] [stderr] 310 | |             let at = usize_to_u32(at);
[INFO] [stderr] 311 | |             tail = self.clone();
[INFO] [stderr] ...   |
[INFO] [stderr] 315 | |             tail = Self::from(&self[at..])
[INFO] [stderr] 316 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.as_allocated().is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> bytesbuf.rs:249:16
[INFO] [stderr]     |
[INFO] [stderr] 249 |           if let Ok(_) = self.as_allocated() {
[INFO] [stderr]     |  _________-      ^^^^^
[INFO] [stderr] 250 | |             let bytes = usize_to_u32(bytes);
[INFO] [stderr] 251 | |             match self.0.len.checked_sub(bytes) {
[INFO] [stderr] 252 | |                 None => panic!("tried to pop {} bytes, only {} are available", bytes, self.0.len),
[INFO] [stderr] ...   |
[INFO] [stderr] 260 | |             *self = Self::from(&self[bytes..])
[INFO] [stderr] 261 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.as_allocated().is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> bytesbuf.rs:308:16
[INFO] [stderr]     |
[INFO] [stderr] 308 |           if let Ok(_) = self.as_allocated() {
[INFO] [stderr]     |  _________-      ^^^^^
[INFO] [stderr] 309 | |             let _: &[u8] = &self[at..];  // Check bounds
[INFO] [stderr] 310 | |             let at = usize_to_u32(at);
[INFO] [stderr] 311 | |             tail = self.clone();
[INFO] [stderr] ...   |
[INFO] [stderr] 315 | |             tail = Self::from(&self[at..])
[INFO] [stderr] 316 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.as_allocated().is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]    --> strbuf.rs:467:13
[INFO] [stderr]     |
[INFO] [stderr] 467 |             &tail_str[..additional_len];  // Check char boundary
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a `&mut [u8]` to a `&mut str`
[INFO] [stderr]    --> strbuf.rs:535:5
[INFO] [stderr]     |
[INFO] [stderr] 535 |     mem::transmute(v)
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8_mut(v).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_bytes_to_str)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]    --> strbuf.rs:467:13
[INFO] [stderr]     |
[INFO] [stderr] 467 |             &tail_str[..additional_len];  // Check char boundary
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a `&mut [u8]` to a `&mut str`
[INFO] [stderr]    --> strbuf.rs:535:5
[INFO] [stderr]     |
[INFO] [stderr] 535 |     mem::transmute(v)
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8_mut(v).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_bytes_to_str)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `utf8_decoder::LossyUtf8Decoder`
[INFO] [stderr]   --> utf8_decoder.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 | /     pub fn new() -> Self {
[INFO] [stderr] 52 | |         LossyUtf8Decoder(StrictUtf8Decoder::new())
[INFO] [stderr] 53 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 49 | impl Default for utf8_decoder::LossyUtf8Decoder {
[INFO] [stderr] 50 |     fn default() -> Self {
[INFO] [stderr] 51 |         Self::new()
[INFO] [stderr] 52 |     }
[INFO] [stderr] 53 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `utf8_decoder::StrictUtf8Decoder`
[INFO] [stderr]    --> utf8_decoder.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     pub fn new() -> Self {
[INFO] [stderr] 146 | |         StrictUtf8Decoder {
[INFO] [stderr] 147 | |             incomplete_char: Incomplete::empty(),
[INFO] [stderr] 148 | |             input_chunk: BytesBuf::new(),
[INFO] [stderr] ...   |
[INFO] [stderr] 151 | |         }
[INFO] [stderr] 152 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 143 | impl Default for utf8_decoder::StrictUtf8Decoder {
[INFO] [stderr] 144 |     fn default() -> Self {
[INFO] [stderr] 145 |         Self::new()
[INFO] [stderr] 146 |     }
[INFO] [stderr] 147 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `utf8_decoder::LossyUtf8Decoder`
[INFO] [stderr]   --> utf8_decoder.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 | /     pub fn new() -> Self {
[INFO] [stderr] 52 | |         LossyUtf8Decoder(StrictUtf8Decoder::new())
[INFO] [stderr] 53 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 49 | impl Default for utf8_decoder::LossyUtf8Decoder {
[INFO] [stderr] 50 |     fn default() -> Self {
[INFO] [stderr] 51 |         Self::new()
[INFO] [stderr] 52 |     }
[INFO] [stderr] 53 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `utf8_decoder::StrictUtf8Decoder`
[INFO] [stderr]    --> utf8_decoder.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     pub fn new() -> Self {
[INFO] [stderr] 146 | |         StrictUtf8Decoder {
[INFO] [stderr] 147 | |             incomplete_char: Incomplete::empty(),
[INFO] [stderr] 148 | |             input_chunk: BytesBuf::new(),
[INFO] [stderr] ...   |
[INFO] [stderr] 151 | |         }
[INFO] [stderr] 152 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 143 | impl Default for utf8_decoder::StrictUtf8Decoder {
[INFO] [stderr] 144 |     fn default() -> Self {
[INFO] [stderr] 145 |         Self::new()
[INFO] [stderr] 146 |     }
[INFO] [stderr] 147 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> utf8_decoder.rs:315:21
[INFO] [stderr]     |
[INFO] [stderr] 315 |     pub fn position(&self) -> usize {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> utf8_decoder.rs:315:21
[INFO] [stderr]     |
[INFO] [stderr] 315 |     pub fn position(&self) -> usize {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]    --> tests.rs:11:9
[INFO] [stderr]     |
[INFO] [stderr] 11  |     use std::ascii::AsciiExt;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 230 |     common_tests!(BytesBuf);
[INFO] [stderr]     |     ------------------------ in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]    --> tests.rs:11:9
[INFO] [stderr]     |
[INFO] [stderr] 11  |     use std::ascii::AsciiExt;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 292 |     common_tests!(StrBuf);
[INFO] [stderr]     |     ---------------------- in this macro invocation
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ascii::AsciiExt`
[INFO] [stderr]    --> tests.rs:11:9
[INFO] [stderr]     |
[INFO] [stderr] 11  |     use std::ascii::AsciiExt;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 230 |     common_tests!(BytesBuf);
[INFO] [stderr]     |     ------------------------ in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ascii::AsciiExt`
[INFO] [stderr]    --> tests.rs:11:9
[INFO] [stderr]     |
[INFO] [stderr] 11  |     use std::ascii::AsciiExt;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 292 |     common_tests!(StrBuf);
[INFO] [stderr]     |     ---------------------- in this macro invocation
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a reference to a reference
[INFO] [stderr]    --> tests.rs:289:9
[INFO] [stderr]     |
[INFO] [stderr] 289 |         ::std::mem::transmute(s)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(s as *mut str as *mut [u8])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.22s
[INFO] running `"docker" "inspect" "5f590f5d35754ec177e9754a337d22958bcaa42d0ae2a9973abe730aa4d5c820"`
[INFO] running `"docker" "rm" "-f" "5f590f5d35754ec177e9754a337d22958bcaa42d0ae2a9973abe730aa4d5c820"`
[INFO] [stdout] 5f590f5d35754ec177e9754a337d22958bcaa42d0ae2a9973abe730aa4d5c820