[INFO] crate zapper_derive 0.9.0 is already in cache [INFO] extracting crate zapper_derive 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/zapper_derive/0.9.0 [INFO] extracting crate zapper_derive 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zapper_derive/0.9.0 [INFO] validating manifest of zapper_derive-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zapper_derive-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zapper_derive-0.9.0 [INFO] finished frobbing zapper_derive-0.9.0 [INFO] frobbed toml for zapper_derive-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/zapper_derive/0.9.0/Cargo.toml [INFO] started frobbing zapper_derive-0.9.0 [INFO] finished frobbing zapper_derive-0.9.0 [INFO] frobbed toml for zapper_derive-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zapper_derive/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zapper_derive-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zapper_derive/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f0af8d9d8b949d5b52009d2699e19d56bae41130c0c388e575a22f4232cde73 [INFO] running `"docker" "start" "-a" "7f0af8d9d8b949d5b52009d2699e19d56bae41130c0c388e575a22f4232cde73"` [INFO] [stderr] Checking proc-macro2 v0.3.8 [INFO] [stderr] Checking quote v0.5.2 [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Checking zapper_derive v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | .expect(&format!("Error: Expected #[{} = value]", attr_name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Error: Expected #[{} = value]", attr_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | let val = attr.tts [INFO] [stderr] | _______________________^ [INFO] [stderr] 27 | | .clone() [INFO] [stderr] 28 | | .into_iter() [INFO] [stderr] 29 | | .skip(1) [INFO] [stderr] 30 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | if attr.path.segments[0].ident.to_string() == "zapper_ignore" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*attr.path.segments[0].ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | let runner = runner.expect(&format!( [INFO] [stderr] | _________________________^ [INFO] [stderr] 98 | | "You must provide a #[runner = ZapperRunnerStruct] annotation on the \"{}\" struct.", [INFO] [stderr] 99 | | name [INFO] [stderr] 100 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|| panic!("You must provide a #[runner = ZapperRunnerStruct] annotation on the \"{}\" struct.", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | .expect(&format!("Error: Expected #[{} = value]", attr_name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Error: Expected #[{} = value]", attr_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | let val = attr.tts [INFO] [stderr] | _______________________^ [INFO] [stderr] 27 | | .clone() [INFO] [stderr] 28 | | .into_iter() [INFO] [stderr] 29 | | .skip(1) [INFO] [stderr] 30 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | if attr.path.segments[0].ident.to_string() == "zapper_ignore" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*attr.path.segments[0].ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | let runner = runner.expect(&format!( [INFO] [stderr] | _________________________^ [INFO] [stderr] 98 | | "You must provide a #[runner = ZapperRunnerStruct] annotation on the \"{}\" struct.", [INFO] [stderr] 99 | | name [INFO] [stderr] 100 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|| panic!("You must provide a #[runner = ZapperRunnerStruct] annotation on the \"{}\" struct.", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.13s [INFO] running `"docker" "inspect" "7f0af8d9d8b949d5b52009d2699e19d56bae41130c0c388e575a22f4232cde73"` [INFO] running `"docker" "rm" "-f" "7f0af8d9d8b949d5b52009d2699e19d56bae41130c0c388e575a22f4232cde73"` [INFO] [stdout] 7f0af8d9d8b949d5b52009d2699e19d56bae41130c0c388e575a22f4232cde73