[INFO] crate zacli 0.1.0 is already in cache [INFO] extracting crate zacli 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/zacli/0.1.0 [INFO] extracting crate zacli 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zacli/0.1.0 [INFO] validating manifest of zacli-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zacli-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zacli-0.1.0 [INFO] finished frobbing zacli-0.1.0 [INFO] frobbed toml for zacli-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/zacli/0.1.0/Cargo.toml [INFO] started frobbing zacli-0.1.0 [INFO] finished frobbing zacli-0.1.0 [INFO] frobbed toml for zacli-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/zacli/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zacli-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/zacli/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb8fedfb2a8215e6142f7438ab8034da503a68cb1bcb4ac67cdcb8d566f6b453 [INFO] running `"docker" "start" "-a" "cb8fedfb2a8215e6142f7438ab8034da503a68cb1bcb4ac67cdcb8d566f6b453"` [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking tokio-sync v0.1.0 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-channel v0.3.7 [INFO] [stderr] Checking tokio-executor v0.1.6 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-timer v0.2.9 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking zaif-api v0.5.0 [INFO] [stderr] Checking zacli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/commands/config.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/mod.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | let mut path = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/commands/config.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/mod.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | let mut path = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/commands/config.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | let config = config::open_config(file_path.as_path()).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/commands/config.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | let config = config::open_config(file_path.as_path()).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands/currency_pairs.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | let kind = match pair.is_token { [INFO] [stderr] | ____________________^ [INFO] [stderr] 45 | | true => "トークン", [INFO] [stderr] 46 | | false => "主要通貨", [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if pair.is_token { "トークン" } else { "主要通貨" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/commands/mod.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn dispatch<'a>(matches: ArgMatches<'a>) { [INFO] [stderr] 28 | | match matches.subcommand() { [INFO] [stderr] 29 | | (config::COMMAND_NAME, Some(sub_m)) => config::Command::run(sub_m), [INFO] [stderr] 30 | | (currencies::COMMAND_NAME, Some(sub_m)) => currencies::Command::run(sub_m), [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config/mod.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | .ok_or("Homeディレクトリがみつかりませんでした".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Homeディレクトリがみつかりませんでした".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | write_contents(path, &contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config/mod.rs:57:10 [INFO] [stderr] | [INFO] [stderr] 57 | .ok_or("Missing version".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Missing version".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands/currency_pairs.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | let kind = match pair.is_token { [INFO] [stderr] | ____________________^ [INFO] [stderr] 45 | | true => "トークン", [INFO] [stderr] 46 | | false => "主要通貨", [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if pair.is_token { "トークン" } else { "主要通貨" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/commands/mod.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn dispatch<'a>(matches: ArgMatches<'a>) { [INFO] [stderr] 28 | | match matches.subcommand() { [INFO] [stderr] 29 | | (config::COMMAND_NAME, Some(sub_m)) => config::Command::run(sub_m), [INFO] [stderr] 30 | | (currencies::COMMAND_NAME, Some(sub_m)) => currencies::Command::run(sub_m), [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config/mod.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | .ok_or("Homeディレクトリがみつかりませんでした".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Homeディレクトリがみつかりませんでした".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | write_contents(path, &contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config/mod.rs:57:10 [INFO] [stderr] | [INFO] [stderr] 57 | .ok_or("Missing version".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Missing version".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `"docker" "inspect" "cb8fedfb2a8215e6142f7438ab8034da503a68cb1bcb4ac67cdcb8d566f6b453"` [INFO] running `"docker" "rm" "-f" "cb8fedfb2a8215e6142f7438ab8034da503a68cb1bcb4ac67cdcb8d566f6b453"` [INFO] [stdout] cb8fedfb2a8215e6142f7438ab8034da503a68cb1bcb4ac67cdcb8d566f6b453