[INFO] crate z85 0.1.4 is already in cache [INFO] extracting crate z85 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/z85/0.1.4 [INFO] extracting crate z85 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/z85/0.1.4 [INFO] validating manifest of z85-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of z85-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing z85-0.1.4 [INFO] finished frobbing z85-0.1.4 [INFO] frobbed toml for z85-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/z85/0.1.4/Cargo.toml [INFO] started frobbing z85-0.1.4 [INFO] finished frobbing z85-0.1.4 [INFO] frobbed toml for z85-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/z85/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting z85-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/z85/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 564ad2d30cb0ed465368b5fb234aa4d0dd2db110d9c33eee35fef65499989fb2 [INFO] running `"docker" "start" "-a" "564ad2d30cb0ed465368b5fb234aa4d0dd2db110d9c33eee35fef65499989fb2"` [INFO] [stderr] Checking z85 v0.1.4 (/opt/crater/workdir) [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const CHARS: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | const BYTE_OFFSETS: &'static [i8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[i8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | block_num = block_num / 256; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_num /= 256` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | pos = pos + 5; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `pos += 5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:172:47 [INFO] [stderr] | [INFO] [stderr] 172 | block_num = block_num * 256 + (*byte as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | block_num = block_num / 85; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_num /= 85` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const CHARS: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | const BYTE_OFFSETS: &'static [i8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[i8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | block_num = block_num / 256; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_num /= 256` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | pos = pos + 5; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `pos += 5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:172:47 [INFO] [stderr] | [INFO] [stderr] 172 | block_num = block_num * 256 + (*byte as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | block_num = block_num / 85; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_num /= 85` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.65s [INFO] running `"docker" "inspect" "564ad2d30cb0ed465368b5fb234aa4d0dd2db110d9c33eee35fef65499989fb2"` [INFO] running `"docker" "rm" "-f" "564ad2d30cb0ed465368b5fb234aa4d0dd2db110d9c33eee35fef65499989fb2"` [INFO] [stdout] 564ad2d30cb0ed465368b5fb234aa4d0dd2db110d9c33eee35fef65499989fb2