[INFO] crate yyid 0.2.4 is already in cache [INFO] extracting crate yyid 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/yyid/0.2.4 [INFO] extracting crate yyid 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yyid/0.2.4 [INFO] validating manifest of yyid-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yyid-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yyid-0.2.4 [INFO] finished frobbing yyid-0.2.4 [INFO] frobbed toml for yyid-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/yyid/0.2.4/Cargo.toml [INFO] started frobbing yyid-0.2.4 [INFO] finished frobbing yyid-0.2.4 [INFO] frobbed toml for yyid-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yyid/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yyid-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yyid/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3066ae4a50e9ad40e828c1e84b4ede29f95bcf1a25b53b2d09ec279c58a4d94 [INFO] running `"docker" "start" "-a" "c3066ae4a50e9ad40e828c1e84b4ede29f95bcf1a25b53b2d09ec279c58a4d94"` [INFO] [stderr] Checking yyid v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `YYID` [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> YYID { [INFO] [stderr] 94 | | let mut ybytes = [0u8; 16]; [INFO] [stderr] 95 | | rand::thread_rng().fill_bytes(&mut ybytes); [INFO] [stderr] 96 | | YYID{ bytes: ybytes } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / pub fn as_bytes<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 101 | | &self.bytes [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: you should consider deriving a `Default` implementation for `YYID` [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> YYID { [INFO] [stderr] 94 | | let mut ybytes = [0u8; 16]; [INFO] [stderr] 95 | | rand::thread_rng().fill_bytes(&mut ybytes); [INFO] [stderr] 96 | | YYID{ bytes: ybytes } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default_derive)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / pub fn as_bytes<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 101 | | &self.bytes [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_lifetimes)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:271:17 [INFO] [stderr] | [INFO] [stderr] 271 | assert!(yyid1 == yyid1); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | assert!(yyid2 == yyid2); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:289:21 [INFO] [stderr] | [INFO] [stderr] 289 | let yyid2 = yyid1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `yyid1` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::clone_on_copy)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:292:17 [INFO] [stderr] | [INFO] [stderr] 292 | assert!(yyid1 == yyid1); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:318:20 [INFO] [stderr] | [INFO] [stderr] 318 | set.insert(yyid1.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `yyid1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yyid`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c3066ae4a50e9ad40e828c1e84b4ede29f95bcf1a25b53b2d09ec279c58a4d94"` [INFO] running `"docker" "rm" "-f" "c3066ae4a50e9ad40e828c1e84b4ede29f95bcf1a25b53b2d09ec279c58a4d94"` [INFO] [stdout] c3066ae4a50e9ad40e828c1e84b4ede29f95bcf1a25b53b2d09ec279c58a4d94