[INFO] crate yukikaze 0.3.1 is already in cache [INFO] extracting crate yukikaze 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/yukikaze/0.3.1 [INFO] extracting crate yukikaze 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yukikaze/0.3.1 [INFO] validating manifest of yukikaze-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yukikaze-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yukikaze-0.3.1 [INFO] finished frobbing yukikaze-0.3.1 [INFO] frobbed toml for yukikaze-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/yukikaze/0.3.1/Cargo.toml [INFO] started frobbing yukikaze-0.3.1 [INFO] finished frobbing yukikaze-0.3.1 [INFO] frobbed toml for yukikaze-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yukikaze/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yukikaze-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yukikaze/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b5c697db4184f373a857f8a7769ee87528312712384917000f42ba809a6d0429 [INFO] running `"docker" "start" "-a" "b5c697db4184f373a857f8a7769ee87528312712384917000f42ba809a6d0429"` [INFO] [stderr] Checking string v0.1.3 [INFO] [stderr] Checking etag v1.0.2 [INFO] [stderr] Checking data-encoding v2.1.2 [INFO] [stderr] Compiling ring v0.13.5 [INFO] [stderr] Compiling miniz-sys v0.1.11 [INFO] [stderr] Compiling pest v2.1.0 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking http v0.1.15 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Compiling pest_meta v2.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Checking h2 v0.1.16 [INFO] [stderr] Checking sct v0.4.0 [INFO] [stderr] Checking webpki v0.18.1 [INFO] [stderr] Checking webpki-roots v0.15.0 [INFO] [stderr] Checking rustls v0.14.0 [INFO] [stderr] Checking ct-logs v0.4.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking tokio-rustls v0.8.1 [INFO] [stderr] Checking hyper-rustls v0.15.1 [INFO] [stderr] Checking yukikaze v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | const _GRAMMAR: &'static str = include_str!("content_disposition.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:239:23 [INFO] [stderr] | [INFO] [stderr] 239 | const INPUT: &'static str = "rori.mp4"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:246:23 [INFO] [stderr] | [INFO] [stderr] 246 | const INPUT: &'static str = "ロリへんたい.mp4"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:253:23 [INFO] [stderr] | [INFO] [stderr] 253 | const INPUT: &'static str = "inline"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:268:23 [INFO] [stderr] | [INFO] [stderr] 268 | const INPUT: &'static str = "attachment; filename"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:289:23 [INFO] [stderr] | [INFO] [stderr] 289 | const INPUT: &'static str = "attachment; filename=\"lolka.jpg\";filename=\"lolka2.jpg\""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:310:30 [INFO] [stderr] | [INFO] [stderr] 310 | const EXPECT_INPUT: &'static str = "attachment; filename*=UTF-8'en'%C2%A3%20and%20%E2%82%AC%20rates"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:311:23 [INFO] [stderr] | [INFO] [stderr] 311 | const INPUT: &'static str = "attachment;\t filename*=UTF-8'en'%C2%A3%20and%20%E2%82%AC%20rates"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:337:30 [INFO] [stderr] | [INFO] [stderr] 337 | const EXPECT_INPUT: &'static str = "form-data; name=\"lolka\"; filename=\"lolka.jpg\""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:338:23 [INFO] [stderr] | [INFO] [stderr] 338 | const INPUT: &'static str = "form-data;\t name=\"lolka\";filename=\"lolka.jpg\""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:360:23 [INFO] [stderr] | [INFO] [stderr] 360 | const INPUT: &'static str = "form-data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:382:23 [INFO] [stderr] | [INFO] [stderr] 382 | const INPUT: &'static str = "form-data; filename=\"lolka.jpg\""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:404:23 [INFO] [stderr] | [INFO] [stderr] 404 | const INPUT: &'static str = "form-data; name=\"lolka\""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/request/multipart.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | const DEFAULT_BOUNDARY: &'static str = "yuki"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/client/request/multipart.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | *(&mut bytes[len-2]) = 45; //'-' [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes[len-2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/client/request/multipart.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | *(&mut bytes[len-1]) = 45; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes[len-1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/request/multipart.rs:132:26 [INFO] [stderr] | [INFO] [stderr] 132 | const EXPECTED: &'static str = "--yuki\r\nContent-Disposition: form-data; name=\"SimpleField\"\r\n\r\nsimple test\r\n--yuki--\r\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/request/multipart.rs:145:27 [INFO] [stderr] | [INFO] [stderr] 145 | const FILE_NAME: &'static str = "Cargo.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/request/multipart.rs:164:26 [INFO] [stderr] | [INFO] [stderr] 164 | const EXPECTED: &'static str = "--yuki\r\nContent-Disposition: form-data; name=\"SimpleField\"\r\n\r\nsimple test\r\n--yuki\r\n--yuki\r\nContent-Disposition: form-data; name=\"SimpleFile\"; filename=\"File.txt\"\r\nContent-Type: text/plain\r\n\r\nsimple file\r\n--yuki--\r\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/request/mod.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | const BASIC: &'static str = "basic "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/request/mod.rs:298:22 [INFO] [stderr] | [INFO] [stderr] 298 | const TYPE: &'static str = "bearer "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/mod.rs:102:38 [INFO] [stderr] | [INFO] [stderr] 102 | const DEFAULT_COMPRESS: &'static str = "gzip, deflate"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/header/content_disposition.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | const _GRAMMAR: &'static str = include_str!("content_disposition.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/request/multipart.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | const DEFAULT_BOUNDARY: &'static str = "yuki"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/client/request/multipart.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | *(&mut bytes[len-2]) = 45; //'-' [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes[len-2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/client/request/multipart.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | *(&mut bytes[len-1]) = 45; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes[len-1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/request/mod.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | const BASIC: &'static str = "basic "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/request/mod.rs:298:22 [INFO] [stderr] | [INFO] [stderr] 298 | const TYPE: &'static str = "bearer "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/mod.rs:102:38 [INFO] [stderr] | [INFO] [stderr] 102 | const DEFAULT_COMPRESS: &'static str = "gzip, deflate"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `header::content_disposition::Filename` [INFO] [stderr] --> src/header/content_disposition.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | Filename::Name(None) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | impl Default for header::content_disposition::Filename { [INFO] [stderr] 28 | fn default() -> Self { [INFO] [stderr] 29 | Self::new() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/header/content_disposition.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match is_non_ascii { [INFO] [stderr] 46 | | false => Self::with_name(name), [INFO] [stderr] 47 | | true => { [INFO] [stderr] 48 | | let bytes = name.into_bytes(); [INFO] [stderr] 49 | | Filename::Extended("utf-8".to_owned(), None, bytes) [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 45 | if is_non_ascii { [INFO] [stderr] 46 | let bytes = name.into_bytes(); [INFO] [stderr] 47 | Filename::Extended("utf-8".to_owned(), None, bytes) [INFO] [stderr] 48 | } else { Self::with_name(name) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/header/content_disposition.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / pub fn from_str(text: &str) -> Option { [INFO] [stderr] 111 | | let result = CdParser::parse(Rule::disposition, text).ok().and_then(|mut result| result.next()); [INFO] [stderr] 112 | | [INFO] [stderr] 113 | | let result = match result { [INFO] [stderr] ... | [INFO] [stderr] 189 | | Some(res) [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/header/content_disposition.rs:323:61 [INFO] [stderr] | [INFO] [stderr] 323 | let expected_value = percent_decode("%C2%A3%20and%20%E2%82%AC%20rates".as_bytes()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"%C2%A3%20and%20%E2%82%AC%20rates"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::request::multipart::Form` [INFO] [stderr] --> src/client/request/multipart.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Self { [INFO] [stderr] 29 | | Self::with_boundary(DEFAULT_BOUNDARY) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for client::request::multipart::Form { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/client/request/multipart.rs:135:51 [INFO] [stderr] | [INFO] [stderr] 135 | form.add_field("SimpleField".to_string(), "simple test".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"simple test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/client/request/multipart.rs:167:51 [INFO] [stderr] | [INFO] [stderr] 167 | form.add_field("SimpleField".to_string(), "simple test".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"simple test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/client/request/multipart.rs:168:92 [INFO] [stderr] | [INFO] [stderr] 168 | form.add_file_field("SimpleFile".to_string(), "File.txt".to_string(), &TEXT_PLAIN, "simple file".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"simple file"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/client/request/tags.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | const HEADER_NAME: header::HeaderName; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/client/request/tags.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | const HEADER_NAME: header::HeaderName; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client/request/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new>(method: hyper::Method, uri: U) -> Result { [INFO] [stderr] 40 | | let uri = uri.as_ref().parse::()?; [INFO] [stderr] 41 | | Ok(Builder::new(uri, method)) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/request/mod.rs:108:54 [INFO] [stderr] | [INFO] [stderr] 108 | let body = self.body.map(|body| body.into()).unwrap_or(hyper::Body::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(hyper::Body::empty)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/client/request/mod.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | Err(_) => panic!("Attempt to set invalid header"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/request/mod.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match self.headers().entry(key).expect("Valid header name") { [INFO] [stderr] 173 | | http::header::Entry::Vacant(entry) => match HeaderValue::try_from(value) { [INFO] [stderr] 174 | | Ok(value) => { [INFO] [stderr] 175 | | entry.insert(value); [INFO] [stderr] ... | [INFO] [stderr] 179 | | _ => (), [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 172 | if let http::header::Entry::Vacant(entry) = self.headers().entry(key).expect("Valid header name") { match HeaderValue::try_from(value) { [INFO] [stderr] 173 | Ok(value) => { [INFO] [stderr] 174 | entry.insert(value); [INFO] [stderr] 175 | }, [INFO] [stderr] 176 | Err(_) => panic!("Attempt to set invalid header value") [INFO] [stderr] 177 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/client/request/mod.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | Err(_) => panic!("Attempt to set invalid header value") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/request/mod.rs:202:56 [INFO] [stderr] | [INFO] [stderr] 202 | pub fn set_date(mut self, date: &httpdate::HttpDate, _: E) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `httpdate::HttpDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/client/request/mod.rs:375:9 [INFO] [stderr] | [INFO] [stderr] 375 | let _ = serde_json::to_writer(&mut buffer, &body)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/response/errors.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &ContentTypeError::Mime(ref error) => write!(f, "Failed to parse Mime: {}", error), [INFO] [stderr] 27 | | &ContentTypeError::UnknownEncoding => write!(f, "Unable to recognize encoding") [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | ContentTypeError::Mime(ref error) => write!(f, "Failed to parse Mime: {}", error), [INFO] [stderr] 27 | ContentTypeError::UnknownEncoding => write!(f, "Unable to recognize encoding") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/response/errors.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match self { [INFO] [stderr] 97 | | &ResponseError::Timeout(_) => write!(f, "Request timed out."), [INFO] [stderr] 98 | | &ResponseError::Timer(ref error, _) => write!(f, "IO timer error happened while executing request: {}", error), [INFO] [stderr] 99 | | &ResponseError::HyperError(ref error) => write!(f, "Request failed due to HTTP error: {}", error) [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *self { [INFO] [stderr] 97 | ResponseError::Timeout(_) => write!(f, "Request timed out."), [INFO] [stderr] 98 | ResponseError::Timer(ref error, _) => write!(f, "IO timer error happened while executing request: {}", error), [INFO] [stderr] 99 | ResponseError::HyperError(ref error) => write!(f, "Request failed due to HTTP error: {}", error) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/response/errors.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / match self { [INFO] [stderr] 147 | | &BodyReadError::Hyper(ref error) => write!(f, "Failed to read due to HTTP error: {}", error), [INFO] [stderr] 148 | | &BodyReadError::Overflow => write!(f, "Read limit is reached. Aborted reading."), [INFO] [stderr] 149 | | &BodyReadError::EncodingError => write!(f, "Unable to decode content into UTF-8"), [INFO] [stderr] ... | [INFO] [stderr] 153 | | &BodyReadError::FileError(_, ref error) => write!(f, "Error file writing response into file. Error: {}", error), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *self { [INFO] [stderr] 147 | BodyReadError::Hyper(ref error) => write!(f, "Failed to read due to HTTP error: {}", error), [INFO] [stderr] 148 | BodyReadError::Overflow => write!(f, "Read limit is reached. Aborted reading."), [INFO] [stderr] 149 | BodyReadError::EncodingError => write!(f, "Unable to decode content into UTF-8"), [INFO] [stderr] 150 | BodyReadError::JsonError(ref error) => write!(f, "Failed to extract JSON. Error: {}", error), [INFO] [stderr] 151 | BodyReadError::DeflateError(ref error) => write!(f, "Failed to decompress content. Error: {}", error), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:55:52 [INFO] [stderr] | [INFO] [stderr] 55 | .and_then(|cook| cookie::Cookie::parse(cook)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `cookie::Cookie::parse` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:54:51 [INFO] [stderr] | [INFO] [stderr] 54 | let cook = cook.decode_utf8().map_err(|error| cookie::ParseError::Utf8Error(error)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `cookie::ParseError::Utf8Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client/response/extractor/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | Gzip(hyper::Body, flate2::write::GzDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/client/response/extractor/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | Gzip(hyper::Body, flate2::write::GzDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/client/response/extractor/mod.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / if let &BodyType::Plain(_, _) = &self.body { [INFO] [stderr] 119 | | return self [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 118 | if let BodyType::Plain(_, _) = self.body { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:141:52 [INFO] [stderr] | [INFO] [stderr] 141 | content_type.parse::().map(|mime| Some(mime)).map_err(errors::ContentTypeError::from) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:221:59 [INFO] [stderr] | [INFO] [stderr] 221 | decoder.write_all(&chunk).map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:222:49 [INFO] [stderr] | [INFO] [stderr] 222 | decoder.flush().map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:231:54 [INFO] [stderr] | [INFO] [stderr] 231 | decoder.try_finish().map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:242:59 [INFO] [stderr] | [INFO] [stderr] 242 | decoder.write_all(&chunk).map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:243:49 [INFO] [stderr] | [INFO] [stderr] 243 | decoder.flush().map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:252:54 [INFO] [stderr] | [INFO] [stderr] 252 | decoder.try_finish().map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:346:102 [INFO] [stderr] | [INFO] [stderr] 346 | .map(|st| futures::Async::Ready(st)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `futures::Async::Ready` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:444:99 [INFO] [stderr] | [INFO] [stderr] 444 | .map(|st| futures::Async::Ready(st)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `futures::Async::Ready` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client/response/extractor/mod.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | Gzip(hyper::Body, Option>>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/client/response/extractor/mod.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | Gzip(hyper::Body, Option>>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:564:77 [INFO] [stderr] | [INFO] [stderr] 564 | decoder.as_mut().unwrap().write_all(&chunk).map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:570:49 [INFO] [stderr] | [INFO] [stderr] 570 | decoder.flush().map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:571:61 [INFO] [stderr] | [INFO] [stderr] 571 | let file = decoder.finish().map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:586:77 [INFO] [stderr] | [INFO] [stderr] 586 | decoder.as_mut().unwrap().write_all(&chunk).map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:592:49 [INFO] [stderr] | [INFO] [stderr] 592 | decoder.flush().map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:593:61 [INFO] [stderr] | [INFO] [stderr] 593 | let file = decoder.finish().map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/client/response/future.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | fn into_timeout(&mut self) -> errors::Timeout { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/mod.rs:101:52 [INFO] [stderr] | [INFO] [stderr] 101 | content_type.parse::().map(|mime| Some(mime)).map_err(errors::ContentTypeError::from) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yukikaze`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `header::content_disposition::Filename` [INFO] [stderr] --> src/header/content_disposition.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | Filename::Name(None) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | impl Default for header::content_disposition::Filename { [INFO] [stderr] 28 | fn default() -> Self { [INFO] [stderr] 29 | Self::new() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/header/content_disposition.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match is_non_ascii { [INFO] [stderr] 46 | | false => Self::with_name(name), [INFO] [stderr] 47 | | true => { [INFO] [stderr] 48 | | let bytes = name.into_bytes(); [INFO] [stderr] 49 | | Filename::Extended("utf-8".to_owned(), None, bytes) [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 45 | if is_non_ascii { [INFO] [stderr] 46 | let bytes = name.into_bytes(); [INFO] [stderr] 47 | Filename::Extended("utf-8".to_owned(), None, bytes) [INFO] [stderr] 48 | } else { Self::with_name(name) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/header/content_disposition.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / pub fn from_str(text: &str) -> Option { [INFO] [stderr] 111 | | let result = CdParser::parse(Rule::disposition, text).ok().and_then(|mut result| result.next()); [INFO] [stderr] 112 | | [INFO] [stderr] 113 | | let result = match result { [INFO] [stderr] ... | [INFO] [stderr] 189 | | Some(res) [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::request::multipart::Form` [INFO] [stderr] --> src/client/request/multipart.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Self { [INFO] [stderr] 29 | | Self::with_boundary(DEFAULT_BOUNDARY) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for client::request::multipart::Form { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/client/request/tags.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | const HEADER_NAME: header::HeaderName; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/client/request/tags.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | const HEADER_NAME: header::HeaderName; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client/request/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new>(method: hyper::Method, uri: U) -> Result { [INFO] [stderr] 40 | | let uri = uri.as_ref().parse::()?; [INFO] [stderr] 41 | | Ok(Builder::new(uri, method)) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/request/mod.rs:108:54 [INFO] [stderr] | [INFO] [stderr] 108 | let body = self.body.map(|body| body.into()).unwrap_or(hyper::Body::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(hyper::Body::empty)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/client/request/mod.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | Err(_) => panic!("Attempt to set invalid header"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/request/mod.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match self.headers().entry(key).expect("Valid header name") { [INFO] [stderr] 173 | | http::header::Entry::Vacant(entry) => match HeaderValue::try_from(value) { [INFO] [stderr] 174 | | Ok(value) => { [INFO] [stderr] 175 | | entry.insert(value); [INFO] [stderr] ... | [INFO] [stderr] 179 | | _ => (), [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 172 | if let http::header::Entry::Vacant(entry) = self.headers().entry(key).expect("Valid header name") { match HeaderValue::try_from(value) { [INFO] [stderr] 173 | Ok(value) => { [INFO] [stderr] 174 | entry.insert(value); [INFO] [stderr] 175 | }, [INFO] [stderr] 176 | Err(_) => panic!("Attempt to set invalid header value") [INFO] [stderr] 177 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/client/request/mod.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | Err(_) => panic!("Attempt to set invalid header value") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/request/mod.rs:202:56 [INFO] [stderr] | [INFO] [stderr] 202 | pub fn set_date(mut self, date: &httpdate::HttpDate, _: E) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `httpdate::HttpDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/client/request/mod.rs:375:9 [INFO] [stderr] | [INFO] [stderr] 375 | let _ = serde_json::to_writer(&mut buffer, &body)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/response/errors.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &ContentTypeError::Mime(ref error) => write!(f, "Failed to parse Mime: {}", error), [INFO] [stderr] 27 | | &ContentTypeError::UnknownEncoding => write!(f, "Unable to recognize encoding") [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | ContentTypeError::Mime(ref error) => write!(f, "Failed to parse Mime: {}", error), [INFO] [stderr] 27 | ContentTypeError::UnknownEncoding => write!(f, "Unable to recognize encoding") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/response/errors.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match self { [INFO] [stderr] 97 | | &ResponseError::Timeout(_) => write!(f, "Request timed out."), [INFO] [stderr] 98 | | &ResponseError::Timer(ref error, _) => write!(f, "IO timer error happened while executing request: {}", error), [INFO] [stderr] 99 | | &ResponseError::HyperError(ref error) => write!(f, "Request failed due to HTTP error: {}", error) [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *self { [INFO] [stderr] 97 | ResponseError::Timeout(_) => write!(f, "Request timed out."), [INFO] [stderr] 98 | ResponseError::Timer(ref error, _) => write!(f, "IO timer error happened while executing request: {}", error), [INFO] [stderr] 99 | ResponseError::HyperError(ref error) => write!(f, "Request failed due to HTTP error: {}", error) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/response/errors.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / match self { [INFO] [stderr] 147 | | &BodyReadError::Hyper(ref error) => write!(f, "Failed to read due to HTTP error: {}", error), [INFO] [stderr] 148 | | &BodyReadError::Overflow => write!(f, "Read limit is reached. Aborted reading."), [INFO] [stderr] 149 | | &BodyReadError::EncodingError => write!(f, "Unable to decode content into UTF-8"), [INFO] [stderr] ... | [INFO] [stderr] 153 | | &BodyReadError::FileError(_, ref error) => write!(f, "Error file writing response into file. Error: {}", error), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *self { [INFO] [stderr] 147 | BodyReadError::Hyper(ref error) => write!(f, "Failed to read due to HTTP error: {}", error), [INFO] [stderr] 148 | BodyReadError::Overflow => write!(f, "Read limit is reached. Aborted reading."), [INFO] [stderr] 149 | BodyReadError::EncodingError => write!(f, "Unable to decode content into UTF-8"), [INFO] [stderr] 150 | BodyReadError::JsonError(ref error) => write!(f, "Failed to extract JSON. Error: {}", error), [INFO] [stderr] 151 | BodyReadError::DeflateError(ref error) => write!(f, "Failed to decompress content. Error: {}", error), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:55:52 [INFO] [stderr] | [INFO] [stderr] 55 | .and_then(|cook| cookie::Cookie::parse(cook)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `cookie::Cookie::parse` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:54:51 [INFO] [stderr] | [INFO] [stderr] 54 | let cook = cook.decode_utf8().map_err(|error| cookie::ParseError::Utf8Error(error)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `cookie::ParseError::Utf8Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client/response/extractor/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | Gzip(hyper::Body, flate2::write::GzDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/client/response/extractor/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | Gzip(hyper::Body, flate2::write::GzDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/client/response/extractor/mod.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / if let &BodyType::Plain(_, _) = &self.body { [INFO] [stderr] 119 | | return self [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 118 | if let BodyType::Plain(_, _) = self.body { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:141:52 [INFO] [stderr] | [INFO] [stderr] 141 | content_type.parse::().map(|mime| Some(mime)).map_err(errors::ContentTypeError::from) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:221:59 [INFO] [stderr] | [INFO] [stderr] 221 | decoder.write_all(&chunk).map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:222:49 [INFO] [stderr] | [INFO] [stderr] 222 | decoder.flush().map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:231:54 [INFO] [stderr] | [INFO] [stderr] 231 | decoder.try_finish().map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:242:59 [INFO] [stderr] | [INFO] [stderr] 242 | decoder.write_all(&chunk).map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:243:49 [INFO] [stderr] | [INFO] [stderr] 243 | decoder.flush().map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:252:54 [INFO] [stderr] | [INFO] [stderr] 252 | decoder.try_finish().map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:346:102 [INFO] [stderr] | [INFO] [stderr] 346 | .map(|st| futures::Async::Ready(st)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `futures::Async::Ready` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:444:99 [INFO] [stderr] | [INFO] [stderr] 444 | .map(|st| futures::Async::Ready(st)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `futures::Async::Ready` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client/response/extractor/mod.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | Gzip(hyper::Body, Option>>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/client/response/extractor/mod.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | Gzip(hyper::Body, Option>>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:564:77 [INFO] [stderr] | [INFO] [stderr] 564 | decoder.as_mut().unwrap().write_all(&chunk).map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:570:49 [INFO] [stderr] | [INFO] [stderr] 570 | decoder.flush().map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:571:61 [INFO] [stderr] | [INFO] [stderr] 571 | let file = decoder.finish().map_err(|error| BodyReadError::DeflateError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::DeflateError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:586:77 [INFO] [stderr] | [INFO] [stderr] 586 | decoder.as_mut().unwrap().write_all(&chunk).map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:592:49 [INFO] [stderr] | [INFO] [stderr] 592 | decoder.flush().map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/extractor/mod.rs:593:61 [INFO] [stderr] | [INFO] [stderr] 593 | let file = decoder.finish().map_err(|error| BodyReadError::GzipError(error))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BodyReadError::GzipError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/client/response/future.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | fn into_timeout(&mut self) -> errors::Timeout { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/response/mod.rs:101:52 [INFO] [stderr] | [INFO] [stderr] 101 | content_type.parse::().map(|mime| Some(mime)).map_err(errors::ContentTypeError::from) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yukikaze`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b5c697db4184f373a857f8a7769ee87528312712384917000f42ba809a6d0429"` [INFO] running `"docker" "rm" "-f" "b5c697db4184f373a857f8a7769ee87528312712384917000f42ba809a6d0429"` [INFO] [stdout] b5c697db4184f373a857f8a7769ee87528312712384917000f42ba809a6d0429