[INFO] crate yubihsm-client 0.0.0 is already in cache [INFO] extracting crate yubihsm-client 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/yubihsm-client/0.0.0 [INFO] extracting crate yubihsm-client 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yubihsm-client/0.0.0 [INFO] validating manifest of yubihsm-client-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yubihsm-client-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yubihsm-client-0.0.0 [INFO] finished frobbing yubihsm-client-0.0.0 [INFO] frobbed toml for yubihsm-client-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/yubihsm-client/0.0.0/Cargo.toml [INFO] started frobbing yubihsm-client-0.0.0 [INFO] finished frobbing yubihsm-client-0.0.0 [INFO] frobbed toml for yubihsm-client-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yubihsm-client/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yubihsm-client-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yubihsm-client/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac9175852ad77504a2c2cd0206c8dc2432702fdb1a681b8b488ff4e8f739dd3d [INFO] running `"docker" "start" "-a" "ac9175852ad77504a2c2cd0206c8dc2432702fdb1a681b8b488ff4e8f739dd3d"` [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking yubihsm-client v0.0.0 (/opt/crater/workdir) [INFO] [stderr] error: you should use the `ends_with` method [INFO] [stderr] --> src/connector.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if connector_url.chars().last() == Some('/') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `connector_url.ends_with('/')` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | #![deny(warnings, missing_docs, trivial_casts, trivial_numeric_casts)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::chars_last_cmp)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] error: single-character string constant used as pattern [INFO] [stderr] --> src/connector.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | for line in response.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | #![deny(warnings, missing_docs, trivial_casts, trivial_numeric_casts)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::single_char_pattern)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: single-character string constant used as pattern [INFO] [stderr] --> src/connector.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | let mut fields = line.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yubihsm-client`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you should use the `ends_with` method [INFO] [stderr] --> src/connector.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if connector_url.chars().last() == Some('/') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `connector_url.ends_with('/')` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | #![deny(warnings, missing_docs, trivial_casts, trivial_numeric_casts)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::chars_last_cmp)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] error: single-character string constant used as pattern [INFO] [stderr] --> src/connector.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | for line in response.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | #![deny(warnings, missing_docs, trivial_casts, trivial_numeric_casts)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::single_char_pattern)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: single-character string constant used as pattern [INFO] [stderr] --> src/connector.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | let mut fields = line.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yubihsm-client`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ac9175852ad77504a2c2cd0206c8dc2432702fdb1a681b8b488ff4e8f739dd3d"` [INFO] running `"docker" "rm" "-f" "ac9175852ad77504a2c2cd0206c8dc2432702fdb1a681b8b488ff4e8f739dd3d"` [INFO] [stdout] ac9175852ad77504a2c2cd0206c8dc2432702fdb1a681b8b488ff4e8f739dd3d