[INFO] crate ytr 0.1.0 is already in cache [INFO] extracting crate ytr 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ytr/0.1.0 [INFO] extracting crate ytr 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ytr/0.1.0 [INFO] validating manifest of ytr-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ytr-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ytr-0.1.0 [INFO] finished frobbing ytr-0.1.0 [INFO] frobbed toml for ytr-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ytr/0.1.0/Cargo.toml [INFO] started frobbing ytr-0.1.0 [INFO] finished frobbing ytr-0.1.0 [INFO] frobbed toml for ytr-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ytr/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ytr-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ytr/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4dcc58fcf4a5d24fdf68a46ede85cdf6e78d90b481e920bfed4a0cb5c0ebb1c [INFO] running `"docker" "start" "-a" "e4dcc58fcf4a5d24fdf68a46ede85cdf6e78d90b481e920bfed4a0cb5c0ebb1c"` [INFO] [stderr] Compiling rand_core v0.4.0 [INFO] [stderr] Compiling encoding_rs v0.8.14 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking tokio-sync v0.1.0 [INFO] [stderr] Compiling openssl-sys v0.9.40 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking libflate v0.1.19 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking mime v0.3.13 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_jitter v0.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-channel v0.3.7 [INFO] [stderr] Checking tokio-executor v0.1.6 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_os v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking tokio-timer v0.2.9 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking ytr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/client.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 90 | | if let Ok(err_obj) = resp.json() { [INFO] [stderr] 91 | | Err(Error::ApiError(err_obj)) [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | Err(Error::UnexpectedResponse) [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:50:54 [INFO] [stderr] | [INFO] [stderr] 50 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | } else if let Ok(err_obj) = resp.json() { [INFO] [stderr] 90 | Err(Error::ApiError(err_obj)) [INFO] [stderr] 91 | } else { [INFO] [stderr] 92 | Err(Error::UnexpectedResponse) [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/client.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 90 | | if let Ok(err_obj) = resp.json() { [INFO] [stderr] 91 | | Err(Error::ApiError(err_obj)) [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | Err(Error::UnexpectedResponse) [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:50:54 [INFO] [stderr] | [INFO] [stderr] 50 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | } else if let Ok(err_obj) = resp.json() { [INFO] [stderr] 90 | Err(Error::ApiError(err_obj)) [INFO] [stderr] 91 | } else { [INFO] [stderr] 92 | Err(Error::UnexpectedResponse) [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ytr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ytr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e4dcc58fcf4a5d24fdf68a46ede85cdf6e78d90b481e920bfed4a0cb5c0ebb1c"` [INFO] running `"docker" "rm" "-f" "e4dcc58fcf4a5d24fdf68a46ede85cdf6e78d90b481e920bfed4a0cb5c0ebb1c"` [INFO] [stdout] e4dcc58fcf4a5d24fdf68a46ede85cdf6e78d90b481e920bfed4a0cb5c0ebb1c