[INFO] crate yt_downloader 1.0.0 is already in cache [INFO] extracting crate yt_downloader 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/yt_downloader/1.0.0 [INFO] extracting crate yt_downloader 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yt_downloader/1.0.0 [INFO] validating manifest of yt_downloader-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yt_downloader-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yt_downloader-1.0.0 [INFO] finished frobbing yt_downloader-1.0.0 [INFO] frobbed toml for yt_downloader-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/yt_downloader/1.0.0/Cargo.toml [INFO] started frobbing yt_downloader-1.0.0 [INFO] finished frobbing yt_downloader-1.0.0 [INFO] frobbed toml for yt_downloader-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yt_downloader/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yt_downloader-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yt_downloader/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0b1f67a1408db88833cec9063edd763340dd764f7ce424ea12648b049f5dd2e [INFO] running `"docker" "start" "-a" "f0b1f67a1408db88833cec9063edd763340dd764f7ce424ea12648b049f5dd2e"` [INFO] [stderr] Checking colored v1.7.0 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking pbr v1.0.1 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_os v0.1.1 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-channel v0.3.7 [INFO] [stderr] Checking tokio-executor v0.1.6 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-timer v0.2.9 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking rafy v0.2.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking yt_downloader v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: structure field `videoId` should have a snake case name such as `video_id` [INFO] [stderr] --> src/youtube/search_result.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | pub videoId: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `publishedAt` should have a snake case name such as `published_at` [INFO] [stderr] --> src/youtube/search_result.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub publishedAt: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `channelId` should have a snake case name such as `channel_id` [INFO] [stderr] --> src/youtube/search_result.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub channelId: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `channelTitle` should have a snake case name such as `channel_title` [INFO] [stderr] --> src/youtube/search_result.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub channelTitle: String [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `videoId` should have a snake case name such as `video_id` [INFO] [stderr] --> src/youtube/search_result.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_object(id: i32, videoId: String, publishedAt: String, channelId: String, title: String, description: String, channelTitle: String) -> Video { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `publishedAt` should have a snake case name such as `published_at` [INFO] [stderr] --> src/youtube/search_result.rs:16:50 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_object(id: i32, videoId: String, publishedAt: String, channelId: String, title: String, description: String, channelTitle: String) -> Video { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `channelId` should have a snake case name such as `channel_id` [INFO] [stderr] --> src/youtube/search_result.rs:16:71 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_object(id: i32, videoId: String, publishedAt: String, channelId: String, title: String, description: String, channelTitle: String) -> Video { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `channelTitle` should have a snake case name such as `channel_title` [INFO] [stderr] --> src/youtube/search_result.rs:16:126 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_object(id: i32, videoId: String, publishedAt: String, channelId: String, title: String, description: String, channelTitle: String) -> Video { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/youtube/mod.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | Err(_) => panic!("Unable to get the content of the body.") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match env::var("YOUTUBE_API_KEY") { [INFO] [stderr] 10 | | Ok(_) => true, [INFO] [stderr] 11 | | Err(_) => false [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ help: try this: `env::var("YOUTUBE_API_KEY").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: structure field `videoId` should have a snake case name such as `video_id` [INFO] [stderr] --> src/youtube/search_result.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | pub videoId: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `publishedAt` should have a snake case name such as `published_at` [INFO] [stderr] --> src/youtube/search_result.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub publishedAt: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `channelId` should have a snake case name such as `channel_id` [INFO] [stderr] --> src/youtube/search_result.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub channelId: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `channelTitle` should have a snake case name such as `channel_title` [INFO] [stderr] --> src/youtube/search_result.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub channelTitle: String [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `videoId` should have a snake case name such as `video_id` [INFO] [stderr] --> src/youtube/search_result.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_object(id: i32, videoId: String, publishedAt: String, channelId: String, title: String, description: String, channelTitle: String) -> Video { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `publishedAt` should have a snake case name such as `published_at` [INFO] [stderr] --> src/youtube/search_result.rs:16:50 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_object(id: i32, videoId: String, publishedAt: String, channelId: String, title: String, description: String, channelTitle: String) -> Video { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `channelId` should have a snake case name such as `channel_id` [INFO] [stderr] --> src/youtube/search_result.rs:16:71 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_object(id: i32, videoId: String, publishedAt: String, channelId: String, title: String, description: String, channelTitle: String) -> Video { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `channelTitle` should have a snake case name such as `channel_title` [INFO] [stderr] --> src/youtube/search_result.rs:16:126 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_object(id: i32, videoId: String, publishedAt: String, channelId: String, title: String, description: String, channelTitle: String) -> Video { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/youtube/mod.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | Err(_) => panic!("Unable to get the content of the body.") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match env::var("YOUTUBE_API_KEY") { [INFO] [stderr] 10 | | Ok(_) => true, [INFO] [stderr] 11 | | Err(_) => false [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ help: try this: `env::var("YOUTUBE_API_KEY").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 06s [INFO] running `"docker" "inspect" "f0b1f67a1408db88833cec9063edd763340dd764f7ce424ea12648b049f5dd2e"` [INFO] running `"docker" "rm" "-f" "f0b1f67a1408db88833cec9063edd763340dd764f7ce424ea12648b049f5dd2e"` [INFO] [stdout] f0b1f67a1408db88833cec9063edd763340dd764f7ce424ea12648b049f5dd2e