[INFO] crate yosys-netlist-json 0.0.2 is already in cache [INFO] extracting crate yosys-netlist-json 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/yosys-netlist-json/0.0.2 [INFO] extracting crate yosys-netlist-json 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yosys-netlist-json/0.0.2 [INFO] validating manifest of yosys-netlist-json-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yosys-netlist-json-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yosys-netlist-json-0.0.2 [INFO] finished frobbing yosys-netlist-json-0.0.2 [INFO] frobbed toml for yosys-netlist-json-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/yosys-netlist-json/0.0.2/Cargo.toml [INFO] started frobbing yosys-netlist-json-0.0.2 [INFO] finished frobbing yosys-netlist-json-0.0.2 [INFO] frobbed toml for yosys-netlist-json-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yosys-netlist-json/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yosys-netlist-json-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yosys-netlist-json/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a2570f080221b2e6aaa3052d0b82eea6ccb06cf6374d20dc968d0f7608bdab5 [INFO] running `"docker" "start" "-a" "1a2570f080221b2e6aaa3052d0b82eea6ccb06cf6374d20dc968d0f7608bdab5"` [INFO] [stderr] Checking yosys-netlist-json v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &SpecialBit::_0 => serializer.emit_str(key, "0"), [INFO] [stderr] 67 | | &SpecialBit::_1 => serializer.emit_str(key, "1"), [INFO] [stderr] 68 | | &SpecialBit::X => serializer.emit_str(key, "x"), [INFO] [stderr] 69 | | &SpecialBit::Z => serializer.emit_str(key, "z"), [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | SpecialBit::_0 => serializer.emit_str(key, "0"), [INFO] [stderr] 67 | SpecialBit::_1 => serializer.emit_str(key, "1"), [INFO] [stderr] 68 | SpecialBit::X => serializer.emit_str(key, "x"), [INFO] [stderr] 69 | SpecialBit::Z => serializer.emit_str(key, "z"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &BitVal::N(n) => { [INFO] [stderr] 88 | | serializer.emit_usize(key, n) [INFO] [stderr] 89 | | }, [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | BitVal::N(n) => { [INFO] [stderr] 88 | serializer.emit_usize(key, n) [INFO] [stderr] 89 | }, [INFO] [stderr] 90 | BitVal::S(s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / match self { [INFO] [stderr] 110 | | &AttributeVal::N(n) => { [INFO] [stderr] 111 | | serializer.emit_usize(key, n) [INFO] [stderr] 112 | | }, [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | match *self { [INFO] [stderr] 110 | AttributeVal::N(n) => { [INFO] [stderr] 111 | serializer.emit_usize(key, n) [INFO] [stderr] 112 | }, [INFO] [stderr] 113 | AttributeVal::S(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:266:20 [INFO] [stderr] | [INFO] [stderr] 266 | assert_eq!(result.modules.get("mymodule").unwrap().cells.get("mycell").unwrap().connections.get("IN").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result.modules.get("mymodule").unwrap().cells.get("mycell").unwrap().connections["IN"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:266:20 [INFO] [stderr] | [INFO] [stderr] 266 | assert_eq!(result.modules.get("mymodule").unwrap().cells.get("mycell").unwrap().connections.get("IN").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result.modules.get("mymodule").unwrap().cells["mycell"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:266:20 [INFO] [stderr] | [INFO] [stderr] 266 | assert_eq!(result.modules.get("mymodule").unwrap().cells.get("mycell").unwrap().connections.get("IN").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result.modules["mymodule"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:309:20 [INFO] [stderr] | [INFO] [stderr] 309 | assert_eq!(result.modules.get("mymodule").unwrap().cells.get("mycell").unwrap() [INFO] [stderr] | ____________________^ [INFO] [stderr] 310 | | .parameters.get("testparam").unwrap(), &AttributeVal::N(123)); [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 309 | assert_eq!(&result.modules.get("mymodule").unwrap().cells.get("mycell").unwrap() [INFO] [stderr] 310 | .parameters["testparam"], &AttributeVal::N(123)); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:309:20 [INFO] [stderr] | [INFO] [stderr] 309 | assert_eq!(result.modules.get("mymodule").unwrap().cells.get("mycell").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result.modules.get("mymodule").unwrap().cells["mycell"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:309:20 [INFO] [stderr] | [INFO] [stderr] 309 | assert_eq!(result.modules.get("mymodule").unwrap().cells.get("mycell").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result.modules["mymodule"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &SpecialBit::_0 => serializer.emit_str(key, "0"), [INFO] [stderr] 67 | | &SpecialBit::_1 => serializer.emit_str(key, "1"), [INFO] [stderr] 68 | | &SpecialBit::X => serializer.emit_str(key, "x"), [INFO] [stderr] 69 | | &SpecialBit::Z => serializer.emit_str(key, "z"), [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | SpecialBit::_0 => serializer.emit_str(key, "0"), [INFO] [stderr] 67 | SpecialBit::_1 => serializer.emit_str(key, "1"), [INFO] [stderr] 68 | SpecialBit::X => serializer.emit_str(key, "x"), [INFO] [stderr] 69 | SpecialBit::Z => serializer.emit_str(key, "z"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &BitVal::N(n) => { [INFO] [stderr] 88 | | serializer.emit_usize(key, n) [INFO] [stderr] 89 | | }, [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | BitVal::N(n) => { [INFO] [stderr] 88 | serializer.emit_usize(key, n) [INFO] [stderr] 89 | }, [INFO] [stderr] 90 | BitVal::S(s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / match self { [INFO] [stderr] 110 | | &AttributeVal::N(n) => { [INFO] [stderr] 111 | | serializer.emit_usize(key, n) [INFO] [stderr] 112 | | }, [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | match *self { [INFO] [stderr] 110 | AttributeVal::N(n) => { [INFO] [stderr] 111 | serializer.emit_usize(key, n) [INFO] [stderr] 112 | }, [INFO] [stderr] 113 | AttributeVal::S(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.55s [INFO] running `"docker" "inspect" "1a2570f080221b2e6aaa3052d0b82eea6ccb06cf6374d20dc968d0f7608bdab5"` [INFO] running `"docker" "rm" "-f" "1a2570f080221b2e6aaa3052d0b82eea6ccb06cf6374d20dc968d0f7608bdab5"` [INFO] [stdout] 1a2570f080221b2e6aaa3052d0b82eea6ccb06cf6374d20dc968d0f7608bdab5