[INFO] crate yobot 0.1.1 is already in cache [INFO] extracting crate yobot 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/yobot/0.1.1 [INFO] extracting crate yobot 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yobot/0.1.1 [INFO] validating manifest of yobot-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yobot-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yobot-0.1.1 [INFO] finished frobbing yobot-0.1.1 [INFO] frobbed toml for yobot-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/yobot/0.1.1/Cargo.toml [INFO] started frobbing yobot-0.1.1 [INFO] finished frobbing yobot-0.1.1 [INFO] frobbed toml for yobot-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yobot/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yobot-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yobot/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b22404fc3a5a38a2a051e069687a3467051121bc43755f798fbac53a6cabbc78 [INFO] running `"docker" "start" "-a" "b22404fc3a5a38a2a051e069687a3467051121bc43755f798fbac53a6cabbc78"` [INFO] [stderr] Checking utf-8 v0.7.5 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking hyper v0.10.15 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tungstenite v0.2.4 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking slack_api v0.17.0 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking slack v0.18.0 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking yobot v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slackhandler.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | event_handler: event_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slackhandler.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | is_addressed: is_addressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_addressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slackhandler.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | event_handler: event_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slackhandler.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | is_addressed: is_addressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_addressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/slackhandler.rs:74:35 [INFO] [stderr] | [INFO] [stderr] 74 | message = message.slice_unchecked(prefix_len, message_len); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/slackhandler.rs:74:35 [INFO] [stderr] | [INFO] [stderr] 74 | message = message.slice_unchecked(prefix_len, message_len); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/slackhandler.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | let mut message = raw.clone(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 65 | let mut message = &(*raw).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 65 | let mut message = &str::clone(raw); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/slackhandler.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | / match event { [INFO] [stderr] 126 | | slack::Event::Message(box_message) => { [INFO] [stderr] 127 | | match *box_message { [INFO] [stderr] 128 | | slack::Message::Standard(msg) => { [INFO] [stderr] ... | [INFO] [stderr] 142 | | _ => {} [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 125 | if let slack::Event::Message(box_message) = event { [INFO] [stderr] 126 | match *box_message { [INFO] [stderr] 127 | slack::Message::Standard(msg) => { [INFO] [stderr] 128 | let text = msg.text.unwrap_or("".to_owned()); [INFO] [stderr] 129 | let (is_addressed, message) = self.parse_message(&text); [INFO] [stderr] 130 | let channel = msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/slackhandler.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | / match *box_message { [INFO] [stderr] 128 | | slack::Message::Standard(msg) => { [INFO] [stderr] 129 | | let text = msg.text.unwrap_or("".to_owned()); [INFO] [stderr] 130 | | let (is_addressed, message) = self.parse_message(&text); [INFO] [stderr] ... | [INFO] [stderr] 139 | | _ => {} [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | if let slack::Message::Standard(msg) = *box_message { [INFO] [stderr] 128 | let text = msg.text.unwrap_or("".to_owned()); [INFO] [stderr] 129 | let (is_addressed, message) = self.parse_message(&text); [INFO] [stderr] 130 | let channel = msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] 131 | let message = Message { [INFO] [stderr] 132 | channel: channel.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slackhandler.rs:129:45 [INFO] [stderr] | [INFO] [stderr] 129 | let text = msg.text.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slackhandler.rs:131:51 [INFO] [stderr] | [INFO] [stderr] 131 | let channel = msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `yobot::Yobot` [INFO] [stderr] --> src/yobot.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Yobot { [INFO] [stderr] 36 | | Yobot { listeners: Vec::new() } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `yobot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/slackhandler.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | let mut message = raw.clone(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 65 | let mut message = &(*raw).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 65 | let mut message = &str::clone(raw); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/slackhandler.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | / match event { [INFO] [stderr] 126 | | slack::Event::Message(box_message) => { [INFO] [stderr] 127 | | match *box_message { [INFO] [stderr] 128 | | slack::Message::Standard(msg) => { [INFO] [stderr] ... | [INFO] [stderr] 142 | | _ => {} [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 125 | if let slack::Event::Message(box_message) = event { [INFO] [stderr] 126 | match *box_message { [INFO] [stderr] 127 | slack::Message::Standard(msg) => { [INFO] [stderr] 128 | let text = msg.text.unwrap_or("".to_owned()); [INFO] [stderr] 129 | let (is_addressed, message) = self.parse_message(&text); [INFO] [stderr] 130 | let channel = msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/slackhandler.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | / match *box_message { [INFO] [stderr] 128 | | slack::Message::Standard(msg) => { [INFO] [stderr] 129 | | let text = msg.text.unwrap_or("".to_owned()); [INFO] [stderr] 130 | | let (is_addressed, message) = self.parse_message(&text); [INFO] [stderr] ... | [INFO] [stderr] 139 | | _ => {} [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | if let slack::Message::Standard(msg) = *box_message { [INFO] [stderr] 128 | let text = msg.text.unwrap_or("".to_owned()); [INFO] [stderr] 129 | let (is_addressed, message) = self.parse_message(&text); [INFO] [stderr] 130 | let channel = msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] 131 | let message = Message { [INFO] [stderr] 132 | channel: channel.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slackhandler.rs:129:45 [INFO] [stderr] | [INFO] [stderr] 129 | let text = msg.text.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slackhandler.rs:131:51 [INFO] [stderr] | [INFO] [stderr] 131 | let channel = msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `yobot::Yobot` [INFO] [stderr] --> src/yobot.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Yobot { [INFO] [stderr] 36 | | Yobot { listeners: Vec::new() } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `yobot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b22404fc3a5a38a2a051e069687a3467051121bc43755f798fbac53a6cabbc78"` [INFO] running `"docker" "rm" "-f" "b22404fc3a5a38a2a051e069687a3467051121bc43755f798fbac53a6cabbc78"` [INFO] [stdout] b22404fc3a5a38a2a051e069687a3467051121bc43755f798fbac53a6cabbc78