[INFO] crate yasna 0.1.3 is already in cache [INFO] extracting crate yasna 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/yasna/0.1.3 [INFO] extracting crate yasna 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yasna/0.1.3 [INFO] validating manifest of yasna-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yasna-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yasna-0.1.3 [INFO] finished frobbing yasna-0.1.3 [INFO] frobbed toml for yasna-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/yasna/0.1.3/Cargo.toml [INFO] started frobbing yasna-0.1.3 [INFO] finished frobbing yasna-0.1.3 [INFO] frobbed toml for yasna-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yasna/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yasna-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yasna/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8cbf61f7123e184f76210c9bcc2c60761f8f643ba66e0283a09d836840a7e66b [INFO] running `"docker" "start" "-a" "8cbf61f7123e184f76210c9bcc2c60761f8f643ba66e0283a09d836840a7e66b"` [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking yasna v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/oid.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/time.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer/mod.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/error.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | tag_class: tag_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | tag_number: tag_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:910:49 [INFO] [stderr] | [INFO] [stderr] 910 | return callback(&mut BERReaderSeq { inner: inner, }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:1129:17 [INFO] [stderr] | [INFO] [stderr] 1129 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:1130:17 [INFO] [stderr] | [INFO] [stderr] 1130 | implicit_tag: implicit_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implicit_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:1204:42 [INFO] [stderr] | [INFO] [stderr] 1204 | callback(&mut BERReaderSeq { inner: inner, }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | tag_number: tag_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | tag_number: tag_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | tag_number: tag_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/oid.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/time.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer/mod.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/error.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | tag_class: tag_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | tag_number: tag_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:910:49 [INFO] [stderr] | [INFO] [stderr] 910 | return callback(&mut BERReaderSeq { inner: inner, }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:1129:17 [INFO] [stderr] | [INFO] [stderr] 1129 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:1130:17 [INFO] [stderr] | [INFO] [stderr] 1130 | implicit_tag: implicit_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implicit_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:1204:42 [INFO] [stderr] | [INFO] [stderr] 1204 | callback(&mut BERReaderSeq { inner: inner, }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | tag_number: tag_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | tag_number: tag_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | tag_number: tag_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/oid.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return ObjectIdentifier { [INFO] [stderr] 41 | | components: components, [INFO] [stderr] 42 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | ObjectIdentifier { [INFO] [stderr] 41 | components: components, [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/oid.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / return ObjectIdentifier { [INFO] [stderr] 57 | | components: components.to_vec(), [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | ObjectIdentifier { [INFO] [stderr] 57 | components: components.to_vec(), [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/oid.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/charstring.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return Some(PrintableString { [INFO] [stderr] 31 | | string: String::from_utf8(bytes).unwrap(), [INFO] [stderr] 32 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | Some(PrintableString { [INFO] [stderr] 31 | string: String::from_utf8(bytes).unwrap(), [INFO] [stderr] 32 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/charstring.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return &self.string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/time.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / return UtcTime { [INFO] [stderr] 17 | | bytes: bytes, [INFO] [stderr] 18 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | UtcTime { [INFO] [stderr] 17 | bytes: bytes, [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return DERWriter { [INFO] [stderr] 113 | | buf: buf, [INFO] [stderr] 114 | | implicit_tag: None, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | DERWriter { [INFO] [stderr] 113 | buf: buf, [INFO] [stderr] 114 | implicit_tag: None, [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/mod.rs:498:33 [INFO] [stderr] | [INFO] [stderr] 498 | (id0 < 3) && (id1 < 18446744073709551535) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_535` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:557:9 [INFO] [stderr] | [INFO] [stderr] 557 | / return self.with_length(|writer| { [INFO] [stderr] 558 | | callback(&mut DERWriterSeq { [INFO] [stderr] 559 | | buf: writer.buf, [INFO] [stderr] 560 | | }) [INFO] [stderr] 561 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 557 | self.with_length(|writer| { [INFO] [stderr] 558 | callback(&mut DERWriterSeq { [INFO] [stderr] 559 | buf: writer.buf, [INFO] [stderr] 560 | }) [INFO] [stderr] 561 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:615:9 [INFO] [stderr] | [INFO] [stderr] 615 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:606:13 [INFO] [stderr] | [INFO] [stderr] 606 | return buf0[1..].cmp(&buf1[1..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf0[1..].cmp(&buf1[1..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:658:9 [INFO] [stderr] | [INFO] [stderr] 658 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:677:9 [INFO] [stderr] | [INFO] [stderr] 677 | / return self.with_length(|writer| { [INFO] [stderr] 678 | | callback(DERWriter::from_buf(writer.buf)) [INFO] [stderr] 679 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 677 | self.with_length(|writer| { [INFO] [stderr] 678 | callback(DERWriter::from_buf(writer.buf)) [INFO] [stderr] 679 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:702:9 [INFO] [stderr] | [INFO] [stderr] 702 | return callback(writer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `callback(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:735:9 [INFO] [stderr] | [INFO] [stderr] 735 | return DERWriter::from_buf(self.buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DERWriter::from_buf(self.buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:769:9 [INFO] [stderr] | [INFO] [stderr] 769 | return DERWriter::from_buf(self.bufs.last_mut().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DERWriter::from_buf(self.bufs.last_mut().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/error.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/error.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return io::Error::new(io::ErrorKind::InvalidData, e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `io::Error::new(io::ErrorKind::InvalidData, e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / return BERReaderImpl { [INFO] [stderr] 142 | | buf: buf, [INFO] [stderr] 143 | | pos: 0, [INFO] [stderr] 144 | | mode: mode, [INFO] [stderr] 145 | | depth: 0, [INFO] [stderr] 146 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 141 | BERReaderImpl { [INFO] [stderr] 142 | buf: buf, [INFO] [stderr] 143 | pos: 0, [INFO] [stderr] 144 | mode: mode, [INFO] [stderr] 145 | depth: 0, [INFO] [stderr] 146 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / return BERReaderImpl { [INFO] [stderr] 151 | | buf: buf, [INFO] [stderr] 152 | | pos: pos, [INFO] [stderr] 153 | | mode: mode, [INFO] [stderr] 154 | | depth: 0, [INFO] [stderr] 155 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 150 | BERReaderImpl { [INFO] [stderr] 151 | buf: buf, [INFO] [stderr] 152 | pos: pos, [INFO] [stderr] 153 | mode: mode, [INFO] [stderr] 154 | depth: 0, [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | return Err(ASN1Error::new(ASN1ErrorKind::Eof)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::Eof))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return Ok((tag, pcbit)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((tag, pcbit))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | return Ok(Some(length)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(length))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | return Ok(skip_tag.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(skip_tag.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:330:9 [INFO] [stderr] | [INFO] [stderr] 330 | return Ok((result, buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((result, buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | return Ok(b != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(b != 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:467:13 [INFO] [stderr] | [INFO] [stderr] 467 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:502:13 [INFO] [stderr] | [INFO] [stderr] 502 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:514:13 [INFO] [stderr] | [INFO] [stderr] 514 | return Ok(val as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:528:13 [INFO] [stderr] | [INFO] [stderr] 528 | return Ok(val as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:542:13 [INFO] [stderr] | [INFO] [stderr] 542 | return Ok(val as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as i16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:544:13 [INFO] [stderr] | [INFO] [stderr] 544 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:556:13 [INFO] [stderr] | [INFO] [stderr] 556 | return Ok(val as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as u16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:570:13 [INFO] [stderr] | [INFO] [stderr] 570 | return Ok(val as i8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:572:13 [INFO] [stderr] | [INFO] [stderr] 572 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:584:13 [INFO] [stderr] | [INFO] [stderr] 584 | return Ok(val as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:586:13 [INFO] [stderr] | [INFO] [stderr] 586 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:626:17 [INFO] [stderr] | [INFO] [stderr] 626 | return Ok(BigInt::from_bytes_be(Sign::Plus, buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BigInt::from_bytes_be(Sign::Plus, buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:636:17 [INFO] [stderr] | [INFO] [stderr] 636 | return Ok(BigInt::from_bytes_le(Sign::Minus, &buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BigInt::from_bytes_le(Sign::Minus, &buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:668:13 [INFO] [stderr] | [INFO] [stderr] 668 | return Ok(BigUint::from_bytes_be(buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BigUint::from_bytes_be(buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:700:21 [INFO] [stderr] | [INFO] [stderr] 700 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:716:21 [INFO] [stderr] | [INFO] [stderr] 716 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:750:9 [INFO] [stderr] | [INFO] [stderr] 750 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:758:21 [INFO] [stderr] | [INFO] [stderr] 758 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:773:21 [INFO] [stderr] | [INFO] [stderr] 773 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:794:9 [INFO] [stderr] | [INFO] [stderr] 794 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:820:13 [INFO] [stderr] | [INFO] [stderr] 820 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:874:13 [INFO] [stderr] | [INFO] [stderr] 874 | return Ok(ObjectIdentifier::new(components)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ObjectIdentifier::new(components))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:910:13 [INFO] [stderr] | [INFO] [stderr] 910 | return callback(&mut BERReaderSeq { inner: inner, }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `callback(&mut BERReaderSeq { inner: inner, })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:976:13 [INFO] [stderr] | [INFO] [stderr] 976 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1033:13 [INFO] [stderr] | [INFO] [stderr] 1033 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1069:9 [INFO] [stderr] | [INFO] [stderr] 1069 | return Ok(collection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(collection)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1067:13 [INFO] [stderr] | [INFO] [stderr] 1067 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1117:9 [INFO] [stderr] | [INFO] [stderr] 1117 | / return callback(BERReader { [INFO] [stderr] 1118 | | inner: self.inner, [INFO] [stderr] 1119 | | implicit_tag: Some(tag), [INFO] [stderr] 1120 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1117 | callback(BERReader { [INFO] [stderr] 1118 | inner: self.inner, [INFO] [stderr] 1119 | implicit_tag: Some(tag), [INFO] [stderr] 1120 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1193:17 [INFO] [stderr] | [INFO] [stderr] 1193 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return parse_ber_general(src, mode, |reader| { [INFO] [stderr] 26 | | return Self::from_ber(reader); [INFO] [stderr] 27 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | parse_ber_general(src, mode, |reader| { [INFO] [stderr] 26 | return Self::from_ber(reader); [INFO] [stderr] 27 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | return Self::from_ber(reader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::from_ber(reader)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | / return PrintableString::from_bytes(octets) [INFO] [stderr] 123 | | .ok_or(ASN1Error::new(ASN1ErrorKind::Invalid)); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 122 | PrintableString::from_bytes(octets) [INFO] [stderr] 123 | .ok_or(ASN1Error::new(ASN1ErrorKind::Invalid)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | return Ok(UtcTime::new(octets)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(UtcTime::new(octets))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return Tag { [INFO] [stderr] 113 | | tag_class: TagClass::Application, [INFO] [stderr] 114 | | tag_number: tag_number, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | Tag { [INFO] [stderr] 113 | tag_class: TagClass::Application, [INFO] [stderr] 114 | tag_number: tag_number, [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / return Tag { [INFO] [stderr] 120 | | tag_class: TagClass::ContextSpecific, [INFO] [stderr] 121 | | tag_number: tag_number, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 119 | Tag { [INFO] [stderr] 120 | tag_class: TagClass::ContextSpecific, [INFO] [stderr] 121 | tag_number: tag_number, [INFO] [stderr] 122 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / return Tag { [INFO] [stderr] 127 | | tag_class: TagClass::Private, [INFO] [stderr] 128 | | tag_number: tag_number, [INFO] [stderr] 129 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 126 | Tag { [INFO] [stderr] 127 | tag_class: TagClass::Private, [INFO] [stderr] 128 | tag_number: tag_number, [INFO] [stderr] 129 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/oid.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return ObjectIdentifier { [INFO] [stderr] 41 | | components: components, [INFO] [stderr] 42 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | ObjectIdentifier { [INFO] [stderr] 41 | components: components, [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/oid.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / return ObjectIdentifier { [INFO] [stderr] 57 | | components: components.to_vec(), [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | ObjectIdentifier { [INFO] [stderr] 57 | components: components.to_vec(), [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/oid.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/charstring.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return Some(PrintableString { [INFO] [stderr] 31 | | string: String::from_utf8(bytes).unwrap(), [INFO] [stderr] 32 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | Some(PrintableString { [INFO] [stderr] 31 | string: String::from_utf8(bytes).unwrap(), [INFO] [stderr] 32 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/charstring.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return &self.string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/time.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / return UtcTime { [INFO] [stderr] 17 | | bytes: bytes, [INFO] [stderr] 18 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | UtcTime { [INFO] [stderr] 17 | bytes: bytes, [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return DERWriter { [INFO] [stderr] 113 | | buf: buf, [INFO] [stderr] 114 | | implicit_tag: None, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | DERWriter { [INFO] [stderr] 113 | buf: buf, [INFO] [stderr] 114 | implicit_tag: None, [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/mod.rs:498:33 [INFO] [stderr] | [INFO] [stderr] 498 | (id0 < 3) && (id1 < 18446744073709551535) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_535` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:557:9 [INFO] [stderr] | [INFO] [stderr] 557 | / return self.with_length(|writer| { [INFO] [stderr] 558 | | callback(&mut DERWriterSeq { [INFO] [stderr] 559 | | buf: writer.buf, [INFO] [stderr] 560 | | }) [INFO] [stderr] 561 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 557 | self.with_length(|writer| { [INFO] [stderr] 558 | callback(&mut DERWriterSeq { [INFO] [stderr] 559 | buf: writer.buf, [INFO] [stderr] 560 | }) [INFO] [stderr] 561 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:615:9 [INFO] [stderr] | [INFO] [stderr] 615 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:606:13 [INFO] [stderr] | [INFO] [stderr] 606 | return buf0[1..].cmp(&buf1[1..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf0[1..].cmp(&buf1[1..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:658:9 [INFO] [stderr] | [INFO] [stderr] 658 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:677:9 [INFO] [stderr] | [INFO] [stderr] 677 | / return self.with_length(|writer| { [INFO] [stderr] 678 | | callback(DERWriter::from_buf(writer.buf)) [INFO] [stderr] 679 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 677 | self.with_length(|writer| { [INFO] [stderr] 678 | callback(DERWriter::from_buf(writer.buf)) [INFO] [stderr] 679 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:702:9 [INFO] [stderr] | [INFO] [stderr] 702 | return callback(writer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `callback(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:735:9 [INFO] [stderr] | [INFO] [stderr] 735 | return DERWriter::from_buf(self.buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DERWriter::from_buf(self.buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/writer/mod.rs:769:9 [INFO] [stderr] | [INFO] [stderr] 769 | return DERWriter::from_buf(self.bufs.last_mut().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DERWriter::from_buf(self.bufs.last_mut().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:32:11 [INFO] [stderr] | [INFO] [stderr] 32 | (-9223372036854775808, &[2, 8, 128, 0, 0, 0, 0, 0, 0, 0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | (9223372036854775807, &[2, 8, 127, 255, 255, 255, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:69:10 [INFO] [stderr] | [INFO] [stderr] 69 | (9223372036854775807, &[2, 8, 127, 255, 255, 255, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:70:10 [INFO] [stderr] | [INFO] [stderr] 70 | (18446744073709551615, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:84:11 [INFO] [stderr] | [INFO] [stderr] 84 | (-2147483648, &[2, 4, 128, 0, 0, 0]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:100:10 [INFO] [stderr] | [INFO] [stderr] 100 | (2147483647, &[2, 4, 127, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:121:10 [INFO] [stderr] | [INFO] [stderr] 121 | (2147483647, &[2, 4, 127, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:122:10 [INFO] [stderr] | [INFO] [stderr] 122 | (4294967295, &[2, 5, 0, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:211:11 [INFO] [stderr] | [INFO] [stderr] 211 | (-9223372036854775808, &[2, 8, 128, 0, 0, 0, 0, 0, 0, 0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:227:10 [INFO] [stderr] | [INFO] [stderr] 227 | (9223372036854775807, &[2, 8, 127, 255, 255, 255, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:267:10 [INFO] [stderr] | [INFO] [stderr] 267 | (9223372036854775807, &[2, 8, 127, 255, 255, 255, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:268:10 [INFO] [stderr] | [INFO] [stderr] 268 | (18446744073709551615, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:354:49 [INFO] [stderr] | [INFO] [stderr] 354 | writer.next().write_bytes(&vec![91; 200000]); [INFO] [stderr] | ^^^^^^ help: consider: `200_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:359:28 [INFO] [stderr] | [INFO] [stderr] 359 | assert_eq!(data.len(), 200010); [INFO] [stderr] | ^^^^^^ help: consider: `200_010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:367:49 [INFO] [stderr] | [INFO] [stderr] 367 | writer.next().write_bytes(&vec![91; 20000000]); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:372:28 [INFO] [stderr] | [INFO] [stderr] 372 | assert_eq!(data.len(), 20000012); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:380:34 [INFO] [stderr] | [INFO] [stderr] 380 | writer.write_i64(456789) [INFO] [stderr] | ^^^^^^ help: consider: `456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:382:53 [INFO] [stderr] | [INFO] [stderr] 382 | writer.next().write_tagged(Tag::context(345678), |writer| { [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:386:34 [INFO] [stderr] | [INFO] [stderr] 386 | writer.write_i64(456790) [INFO] [stderr] | ^^^^^^ help: consider: `456_790` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/tests.rs:388:53 [INFO] [stderr] | [INFO] [stderr] 388 | writer.next().write_tagged(Tag::context(345677), |writer| { [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/error.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/error.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return io::Error::new(io::ErrorKind::InvalidData, e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `io::Error::new(io::ErrorKind::InvalidData, e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / return BERReaderImpl { [INFO] [stderr] 142 | | buf: buf, [INFO] [stderr] 143 | | pos: 0, [INFO] [stderr] 144 | | mode: mode, [INFO] [stderr] 145 | | depth: 0, [INFO] [stderr] 146 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 141 | BERReaderImpl { [INFO] [stderr] 142 | buf: buf, [INFO] [stderr] 143 | pos: 0, [INFO] [stderr] 144 | mode: mode, [INFO] [stderr] 145 | depth: 0, [INFO] [stderr] 146 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / return BERReaderImpl { [INFO] [stderr] 151 | | buf: buf, [INFO] [stderr] 152 | | pos: pos, [INFO] [stderr] 153 | | mode: mode, [INFO] [stderr] 154 | | depth: 0, [INFO] [stderr] 155 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 150 | BERReaderImpl { [INFO] [stderr] 151 | buf: buf, [INFO] [stderr] 152 | pos: pos, [INFO] [stderr] 153 | mode: mode, [INFO] [stderr] 154 | depth: 0, [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | return Err(ASN1Error::new(ASN1ErrorKind::Eof)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::Eof))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return Ok((tag, pcbit)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((tag, pcbit))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | return Ok(Some(length)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(length))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | return Ok(skip_tag.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(skip_tag.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:330:9 [INFO] [stderr] | [INFO] [stderr] 330 | return Ok((result, buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((result, buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | return Ok(b != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(b != 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:467:13 [INFO] [stderr] | [INFO] [stderr] 467 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:502:13 [INFO] [stderr] | [INFO] [stderr] 502 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:514:13 [INFO] [stderr] | [INFO] [stderr] 514 | return Ok(val as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:528:13 [INFO] [stderr] | [INFO] [stderr] 528 | return Ok(val as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:542:13 [INFO] [stderr] | [INFO] [stderr] 542 | return Ok(val as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as i16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:544:13 [INFO] [stderr] | [INFO] [stderr] 544 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:556:13 [INFO] [stderr] | [INFO] [stderr] 556 | return Ok(val as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as u16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:570:13 [INFO] [stderr] | [INFO] [stderr] 570 | return Ok(val as i8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:572:13 [INFO] [stderr] | [INFO] [stderr] 572 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:584:13 [INFO] [stderr] | [INFO] [stderr] 584 | return Ok(val as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val as u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:586:13 [INFO] [stderr] | [INFO] [stderr] 586 | return Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:626:17 [INFO] [stderr] | [INFO] [stderr] 626 | return Ok(BigInt::from_bytes_be(Sign::Plus, buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BigInt::from_bytes_be(Sign::Plus, buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:636:17 [INFO] [stderr] | [INFO] [stderr] 636 | return Ok(BigInt::from_bytes_le(Sign::Minus, &buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BigInt::from_bytes_le(Sign::Minus, &buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:668:13 [INFO] [stderr] | [INFO] [stderr] 668 | return Ok(BigUint::from_bytes_be(buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BigUint::from_bytes_be(buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:700:21 [INFO] [stderr] | [INFO] [stderr] 700 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:716:21 [INFO] [stderr] | [INFO] [stderr] 716 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:750:9 [INFO] [stderr] | [INFO] [stderr] 750 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:758:21 [INFO] [stderr] | [INFO] [stderr] 758 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:773:21 [INFO] [stderr] | [INFO] [stderr] 773 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:794:9 [INFO] [stderr] | [INFO] [stderr] 794 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:820:13 [INFO] [stderr] | [INFO] [stderr] 820 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:874:13 [INFO] [stderr] | [INFO] [stderr] 874 | return Ok(ObjectIdentifier::new(components)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ObjectIdentifier::new(components))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:910:13 [INFO] [stderr] | [INFO] [stderr] 910 | return callback(&mut BERReaderSeq { inner: inner, }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `callback(&mut BERReaderSeq { inner: inner, })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:976:13 [INFO] [stderr] | [INFO] [stderr] 976 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1033:13 [INFO] [stderr] | [INFO] [stderr] 1033 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1069:9 [INFO] [stderr] | [INFO] [stderr] 1069 | return Ok(collection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(collection)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1067:13 [INFO] [stderr] | [INFO] [stderr] 1067 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1117:9 [INFO] [stderr] | [INFO] [stderr] 1117 | / return callback(BERReader { [INFO] [stderr] 1118 | | inner: self.inner, [INFO] [stderr] 1119 | | implicit_tag: Some(tag), [INFO] [stderr] 1120 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1117 | callback(BERReader { [INFO] [stderr] 1118 | inner: self.inner, [INFO] [stderr] 1119 | implicit_tag: Some(tag), [INFO] [stderr] 1120 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/mod.rs:1193:17 [INFO] [stderr] | [INFO] [stderr] 1193 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:95:11 [INFO] [stderr] | [INFO] [stderr] 95 | (-9223372036854775808, &[2, 8, 128, 0, 0, 0, 0, 0, 0, 0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | (9223372036854775807, &[2, 8, 127, 255, 255, 255, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:169:10 [INFO] [stderr] | [INFO] [stderr] 169 | (9223372036854775807, &[2, 8, 127, 255, 255, 255, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:170:10 [INFO] [stderr] | [INFO] [stderr] 170 | (18446744073709551615, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:222:11 [INFO] [stderr] | [INFO] [stderr] 222 | (-2147483648, &[2, 4, 128, 0, 0, 0]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:238:10 [INFO] [stderr] | [INFO] [stderr] 238 | (2147483647, &[2, 4, 127, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:291:10 [INFO] [stderr] | [INFO] [stderr] 291 | (2147483647, &[2, 4, 127, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:292:10 [INFO] [stderr] | [INFO] [stderr] 292 | (4294967295, &[2, 5, 0, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:560:11 [INFO] [stderr] | [INFO] [stderr] 560 | (-9223372036854775808, &[2, 8, 128, 0, 0, 0, 0, 0, 0, 0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:576:10 [INFO] [stderr] | [INFO] [stderr] 576 | (9223372036854775807, &[2, 8, 127, 255, 255, 255, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:662:10 [INFO] [stderr] | [INFO] [stderr] 662 | (9223372036854775807, &[2, 8, 127, 255, 255, 255, 255, 255, 255, 255]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:663:10 [INFO] [stderr] | [INFO] [stderr] 663 | (18446744073709551615, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:845:17 [INFO] [stderr] | [INFO] [stderr] 845 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:891:17 [INFO] [stderr] | [INFO] [stderr] 891 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:910:17 [INFO] [stderr] | [INFO] [stderr] 910 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:953:17 [INFO] [stderr] | [INFO] [stderr] 953 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:962:11 [INFO] [stderr] | [INFO] [stderr] 962 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:962:36 [INFO] [stderr] | [INFO] [stderr] 962 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_790` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:985:17 [INFO] [stderr] | [INFO] [stderr] 985 | return Ok((a, b, c, d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((a, b, c, d))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:973:62 [INFO] [stderr] | [INFO] [stderr] 973 | let b = try!(try!(reader.next(&[Tag::context(345678)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:974:47 [INFO] [stderr] | [INFO] [stderr] 974 | .read_tagged(Tag::context(345678), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:981:62 [INFO] [stderr] | [INFO] [stderr] 981 | let d = try!(try!(reader.next(&[Tag::context(345677)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:982:47 [INFO] [stderr] | [INFO] [stderr] 982 | .read_tagged(Tag::context(345677), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1044:17 [INFO] [stderr] | [INFO] [stderr] 1044 | return Ok((a, b, c, d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((a, b, c, d))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1032:62 [INFO] [stderr] | [INFO] [stderr] 1032 | let b = try!(try!(reader.next(&[Tag::context(345678)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1033:47 [INFO] [stderr] | [INFO] [stderr] 1033 | .read_tagged(Tag::context(345678), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1040:62 [INFO] [stderr] | [INFO] [stderr] 1040 | let d = try!(try!(reader.next(&[Tag::context(345677)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1041:47 [INFO] [stderr] | [INFO] [stderr] 1041 | .read_tagged(Tag::context(345677), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1053:11 [INFO] [stderr] | [INFO] [stderr] 1053 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1053:36 [INFO] [stderr] | [INFO] [stderr] 1053 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_790` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1056:11 [INFO] [stderr] | [INFO] [stderr] 1056 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1056:36 [INFO] [stderr] | [INFO] [stderr] 1056 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_790` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1060:11 [INFO] [stderr] | [INFO] [stderr] 1060 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1060:36 [INFO] [stderr] | [INFO] [stderr] 1060 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_790` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1063:11 [INFO] [stderr] | [INFO] [stderr] 1063 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1063:36 [INFO] [stderr] | [INFO] [stderr] 1063 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_790` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1066:11 [INFO] [stderr] | [INFO] [stderr] 1066 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1066:36 [INFO] [stderr] | [INFO] [stderr] 1066 | ((456789, b"Foo".to_vec(), 456790, b"Bar".to_vec()), &[ [INFO] [stderr] | ^^^^^^ help: consider: `456_790` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1089:17 [INFO] [stderr] | [INFO] [stderr] 1089 | return Ok((a, b, c, d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((a, b, c, d))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1077:62 [INFO] [stderr] | [INFO] [stderr] 1077 | let b = try!(try!(reader.next(&[Tag::context(345678)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1078:47 [INFO] [stderr] | [INFO] [stderr] 1078 | .read_tagged(Tag::context(345678), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1085:62 [INFO] [stderr] | [INFO] [stderr] 1085 | let d = try!(try!(reader.next(&[Tag::context(345677)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1086:47 [INFO] [stderr] | [INFO] [stderr] 1086 | .read_tagged(Tag::context(345677), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1139:17 [INFO] [stderr] | [INFO] [stderr] 1139 | return Ok((a, b, c, d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((a, b, c, d))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1127:62 [INFO] [stderr] | [INFO] [stderr] 1127 | let b = try!(try!(reader.next(&[Tag::context(345678)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1128:47 [INFO] [stderr] | [INFO] [stderr] 1128 | .read_tagged(Tag::context(345678), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1135:62 [INFO] [stderr] | [INFO] [stderr] 1135 | let d = try!(try!(reader.next(&[Tag::context(345677)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1136:47 [INFO] [stderr] | [INFO] [stderr] 1136 | .read_tagged(Tag::context(345677), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1205:17 [INFO] [stderr] | [INFO] [stderr] 1205 | return Ok((a, b, c, d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((a, b, c, d))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1193:62 [INFO] [stderr] | [INFO] [stderr] 1193 | let b = try!(try!(reader.next(&[Tag::context(345678)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1194:47 [INFO] [stderr] | [INFO] [stderr] 1194 | .read_tagged(Tag::context(345678), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1201:62 [INFO] [stderr] | [INFO] [stderr] 1201 | let d = try!(try!(reader.next(&[Tag::context(345677)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1202:47 [INFO] [stderr] | [INFO] [stderr] 1202 | .read_tagged(Tag::context(345677), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1277:17 [INFO] [stderr] | [INFO] [stderr] 1277 | return Ok((a, b, c, d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((a, b, c, d))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1265:62 [INFO] [stderr] | [INFO] [stderr] 1265 | let b = try!(try!(reader.next(&[Tag::context(345678)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1266:47 [INFO] [stderr] | [INFO] [stderr] 1266 | .read_tagged(Tag::context(345678), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1273:62 [INFO] [stderr] | [INFO] [stderr] 1273 | let d = try!(try!(reader.next(&[Tag::context(345677)])) [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/tests.rs:1274:47 [INFO] [stderr] | [INFO] [stderr] 1274 | .read_tagged(Tag::context(345677), |reader| { [INFO] [stderr] | ^^^^^^ help: consider: `345_677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1308:21 [INFO] [stderr] | [INFO] [stderr] 1308 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1330:21 [INFO] [stderr] | [INFO] [stderr] 1330 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1391:21 [INFO] [stderr] | [INFO] [stderr] 1391 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1412:21 [INFO] [stderr] | [INFO] [stderr] 1412 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1468:21 [INFO] [stderr] | [INFO] [stderr] 1468 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1491:21 [INFO] [stderr] | [INFO] [stderr] 1491 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1551:21 [INFO] [stderr] | [INFO] [stderr] 1551 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader/tests.rs:1574:21 [INFO] [stderr] | [INFO] [stderr] 1574 | return Ok((i, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return parse_ber_general(src, mode, |reader| { [INFO] [stderr] 26 | | return Self::from_ber(reader); [INFO] [stderr] 27 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | parse_ber_general(src, mode, |reader| { [INFO] [stderr] 26 | return Self::from_ber(reader); [INFO] [stderr] 27 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | return Self::from_ber(reader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::from_ber(reader)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Ok(ret); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | / return PrintableString::from_bytes(octets) [INFO] [stderr] 123 | | .ok_or(ASN1Error::new(ASN1ErrorKind::Invalid)); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 122 | PrintableString::from_bytes(octets) [INFO] [stderr] 123 | .ok_or(ASN1Error::new(ASN1ErrorKind::Invalid)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserializer/mod.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | return Ok(UtcTime::new(octets)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(UtcTime::new(octets))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return Tag { [INFO] [stderr] 113 | | tag_class: TagClass::Application, [INFO] [stderr] 114 | | tag_number: tag_number, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | Tag { [INFO] [stderr] 113 | tag_class: TagClass::Application, [INFO] [stderr] 114 | tag_number: tag_number, [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / return Tag { [INFO] [stderr] 120 | | tag_class: TagClass::ContextSpecific, [INFO] [stderr] 121 | | tag_number: tag_number, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 119 | Tag { [INFO] [stderr] 120 | tag_class: TagClass::ContextSpecific, [INFO] [stderr] 121 | tag_number: tag_number, [INFO] [stderr] 122 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / return Tag { [INFO] [stderr] 127 | | tag_class: TagClass::Private, [INFO] [stderr] 128 | | tag_number: tag_number, [INFO] [stderr] 129 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 126 | Tag { [INFO] [stderr] 127 | tag_class: TagClass::Private, [INFO] [stderr] 128 | tag_number: tag_number, [INFO] [stderr] 129 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/reader/mod.rs:384:27 [INFO] [stderr] | [INFO] [stderr] 384 | fn read_general(mut self, tag: Tag, callback: F) -> ASN1Result [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/reader/mod.rs:1123:35 [INFO] [stderr] | [INFO] [stderr] 1123 | pub fn read_with_buffer(mut self, callback: F) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `models::setof::SetOf` [INFO] [stderr] --> src/models/setof.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | SetOf { [INFO] [stderr] 17 | | vec: Vec::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:283:24 [INFO] [stderr] | [INFO] [stderr] 283 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:288:24 [INFO] [stderr] | [INFO] [stderr] 288 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:293:24 [INFO] [stderr] | [INFO] [stderr] 293 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:298:24 [INFO] [stderr] | [INFO] [stderr] 298 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:303:24 [INFO] [stderr] | [INFO] [stderr] 303 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:308:24 [INFO] [stderr] | [INFO] [stderr] 308 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/writer/mod.rs:394:12 [INFO] [stderr] | [INFO] [stderr] 394 | if &bytes == &[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 394 | if bytes == [0] { [INFO] [stderr] | ^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/mod.rs:593:21 [INFO] [stderr] | [INFO] [stderr] 593 | assert!(buf.len() > 0, "Empty output in write_set()"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/writer/mod.rs:609:56 [INFO] [stderr] | [INFO] [stderr] 609 | let bufs_len = bufs.iter().map(|buf| buf.len()).fold(0, |x, y| x + y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/mod.rs:648:21 [INFO] [stderr] | [INFO] [stderr] 648 | assert!(buf.len() > 0, "Empty output in write_set_of()"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/writer/mod.rs:652:56 [INFO] [stderr] | [INFO] [stderr] 652 | let bufs_len = bufs.iter().map(|buf| buf.len()).fold(0, |x, y| x + y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/writer/mod.rs:734:5 [INFO] [stderr] | [INFO] [stderr] 734 | / pub fn next<'b>(&'b mut self) -> DERWriter<'b> { [INFO] [stderr] 735 | | return DERWriter::from_buf(self.buf); [INFO] [stderr] 736 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/writer/mod.rs:734:5 [INFO] [stderr] | [INFO] [stderr] 734 | / pub fn next<'b>(&'b mut self) -> DERWriter<'b> { [INFO] [stderr] 735 | | return DERWriter::from_buf(self.buf); [INFO] [stderr] 736 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/writer/mod.rs:767:5 [INFO] [stderr] | [INFO] [stderr] 767 | / pub fn next<'b>(&'b mut self) -> DERWriter<'b> { [INFO] [stderr] 768 | | self.bufs.push(Vec::new()); [INFO] [stderr] 769 | | return DERWriter::from_buf(self.bufs.last_mut().unwrap()); [INFO] [stderr] 770 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/writer/mod.rs:767:5 [INFO] [stderr] | [INFO] [stderr] 767 | / pub fn next<'b>(&'b mut self) -> DERWriter<'b> { [INFO] [stderr] 768 | | self.bufs.push(Vec::new()); [INFO] [stderr] 769 | | return DERWriter::from_buf(self.bufs.last_mut().unwrap()); [INFO] [stderr] 770 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:191:30 [INFO] [stderr] | [INFO] [stderr] 191 | let mut tag_number = (tagbyte & 31) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tagbyte & 31)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | let b = try!(self.read_u8()) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 195 | let b = u64::from(match $ expr { [INFO] [stderr] 196 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 197 | :: Err ( err ) => { [INFO] [stderr] 198 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 199 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader/mod.rs:197:54 [INFO] [stderr] | [INFO] [stderr] 197 | try!(tag_number.checked_mul(128).ok_or( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 198 | | ASN1Error::new(ASN1ErrorKind::IntegerOverflow))); [INFO] [stderr] | |_______________________________________________________________________^ help: try this: `ok_or_else(|| ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader/mod.rs:228:50 [INFO] [stderr] | [INFO] [stderr] 228 | let x = try!(length.checked_mul(256).ok_or( [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 229 | | ASN1Error::new(ASN1ErrorKind::Eof))); [INFO] [stderr] | |___________________________________________________^ help: try this: `ok_or_else(|| ASN1Error::new(ASN1ErrorKind::Eof))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:451:16 [INFO] [stderr] | [INFO] [stderr] 451 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:454:27 [INFO] [stderr] | [INFO] [stderr] 454 | return Ok(buf[0] as i8 as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf[0] as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:456:26 [INFO] [stderr] | [INFO] [stderr] 456 | let mut x = ((buf[0] as i8 as i64) << 8) + (buf[1] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf[0] as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:456:56 [INFO] [stderr] | [INFO] [stderr] 456 | let mut x = ((buf[0] as i8 as i64) << 8) + (buf[1] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:465:32 [INFO] [stderr] | [INFO] [stderr] 465 | x = (x << 8) | (b as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:484:16 [INFO] [stderr] | [INFO] [stderr] 484 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:489:27 [INFO] [stderr] | [INFO] [stderr] 489 | return Ok(buf[0] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:491:26 [INFO] [stderr] | [INFO] [stderr] 491 | let mut x = ((buf[0] as u64) << 8) + (buf[1] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:491:50 [INFO] [stderr] | [INFO] [stderr] 491 | let mut x = ((buf[0] as u64) << 8) + (buf[1] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:500:32 [INFO] [stderr] | [INFO] [stderr] 500 | x = (x << 8) | (b as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:616:16 [INFO] [stderr] | [INFO] [stderr] 616 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:621:23 [INFO] [stderr] | [INFO] [stderr] 621 | let x2 = ((buf[0] as i8 as i32) << 8) + (buf[1] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buf[0] as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:621:53 [INFO] [stderr] | [INFO] [stderr] 621 | let x2 = ((buf[0] as i8 as i32) << 8) + (buf[1] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:655:16 [INFO] [stderr] | [INFO] [stderr] 655 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:662:23 [INFO] [stderr] | [INFO] [stderr] 662 | let x2 = ((buf[0] as i8 as i32) << 8) + (buf[1] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buf[0] as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:662:53 [INFO] [stderr] | [INFO] [stderr] 662 | let x2 = ((buf[0] as i8 as i32) << 8) + (buf[1] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:683:24 [INFO] [stderr] | [INFO] [stderr] 683 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:817:16 [INFO] [stderr] | [INFO] [stderr] 817 | if buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:845:16 [INFO] [stderr] | [INFO] [stderr] 845 | if buf.len() == 0 || buf[buf.len()-1] >= 128 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader/mod.rs:854:22 [INFO] [stderr] | [INFO] [stderr] 854 | .ok_or(ASN1Error::new( [INFO] [stderr] | ______________________^ [INFO] [stderr] 855 | | ASN1ErrorKind::IntegerOverflow))) + ((b & 127) as u64); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 854 | .ok_or_else(|| ASN1Error::new( [INFO] [stderr] 855 | ASN1ErrorKind::IntegerOverflow))) + ((b & 127) as u64); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:855:61 [INFO] [stderr] | [INFO] [stderr] 855 | ASN1ErrorKind::IntegerOverflow))) + ((b & 127) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b & 127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:857:24 [INFO] [stderr] | [INFO] [stderr] 857 | if components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:973:16 [INFO] [stderr] | [INFO] [stderr] 973 | if elements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/reader/mod.rs:1171:5 [INFO] [stderr] | [INFO] [stderr] 1171 | / pub fn next<'c>(&'c mut self) -> BERReader<'a, 'c> { [INFO] [stderr] 1172 | | BERReader::new(self.inner) [INFO] [stderr] 1173 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/deserializer/mod.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | .ok_or(ASN1Error::new(ASN1ErrorKind::Invalid)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ASN1Error::new(ASN1ErrorKind::Invalid))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/reader/mod.rs:384:27 [INFO] [stderr] | [INFO] [stderr] 384 | fn read_general(mut self, tag: Tag, callback: F) -> ASN1Result [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/reader/mod.rs:1123:35 [INFO] [stderr] | [INFO] [stderr] 1123 | pub fn read_with_buffer(mut self, callback: F) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `models::setof::SetOf` [INFO] [stderr] --> src/models/setof.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | SetOf { [INFO] [stderr] 17 | | vec: Vec::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:283:24 [INFO] [stderr] | [INFO] [stderr] 283 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:288:24 [INFO] [stderr] | [INFO] [stderr] 288 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:293:24 [INFO] [stderr] | [INFO] [stderr] 293 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:298:24 [INFO] [stderr] | [INFO] [stderr] 298 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:303:24 [INFO] [stderr] | [INFO] [stderr] 303 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer/mod.rs:308:24 [INFO] [stderr] | [INFO] [stderr] 308 | self.write_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/writer/mod.rs:394:12 [INFO] [stderr] | [INFO] [stderr] 394 | if &bytes == &[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 394 | if bytes == [0] { [INFO] [stderr] | ^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/mod.rs:593:21 [INFO] [stderr] | [INFO] [stderr] 593 | assert!(buf.len() > 0, "Empty output in write_set()"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/writer/mod.rs:609:56 [INFO] [stderr] | [INFO] [stderr] 609 | let bufs_len = bufs.iter().map(|buf| buf.len()).fold(0, |x, y| x + y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/mod.rs:648:21 [INFO] [stderr] | [INFO] [stderr] 648 | assert!(buf.len() > 0, "Empty output in write_set_of()"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/writer/mod.rs:652:56 [INFO] [stderr] | [INFO] [stderr] 652 | let bufs_len = bufs.iter().map(|buf| buf.len()).fold(0, |x, y| x + y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/writer/mod.rs:734:5 [INFO] [stderr] | [INFO] [stderr] 734 | / pub fn next<'b>(&'b mut self) -> DERWriter<'b> { [INFO] [stderr] 735 | | return DERWriter::from_buf(self.buf); [INFO] [stderr] 736 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/writer/mod.rs:734:5 [INFO] [stderr] | [INFO] [stderr] 734 | / pub fn next<'b>(&'b mut self) -> DERWriter<'b> { [INFO] [stderr] 735 | | return DERWriter::from_buf(self.buf); [INFO] [stderr] 736 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/writer/mod.rs:767:5 [INFO] [stderr] | [INFO] [stderr] 767 | / pub fn next<'b>(&'b mut self) -> DERWriter<'b> { [INFO] [stderr] 768 | | self.bufs.push(Vec::new()); [INFO] [stderr] 769 | | return DERWriter::from_buf(self.bufs.last_mut().unwrap()); [INFO] [stderr] 770 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/writer/mod.rs:767:5 [INFO] [stderr] | [INFO] [stderr] 767 | / pub fn next<'b>(&'b mut self) -> DERWriter<'b> { [INFO] [stderr] 768 | | self.bufs.push(Vec::new()); [INFO] [stderr] 769 | | return DERWriter::from_buf(self.bufs.last_mut().unwrap()); [INFO] [stderr] 770 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/writer/tests.rs:324:39 [INFO] [stderr] | [INFO] [stderr] 324 | writer.next().write_bytes(&vec![91; 20]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[91; 20]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/writer/tests.rs:333:39 [INFO] [stderr] | [INFO] [stderr] 333 | writer.next().write_bytes(&vec![91; 200]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[91; 200]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/writer/tests.rs:342:39 [INFO] [stderr] | [INFO] [stderr] 342 | writer.next().write_bytes(&vec![91; 2000]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[91; 2000]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/writer/tests.rs:354:39 [INFO] [stderr] | [INFO] [stderr] 354 | writer.next().write_bytes(&vec![91; 200000]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[91; 200000]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/writer/tests.rs:367:39 [INFO] [stderr] | [INFO] [stderr] 367 | writer.next().write_bytes(&vec![91; 20000000]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[91; 20000000]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:191:30 [INFO] [stderr] | [INFO] [stderr] 191 | let mut tag_number = (tagbyte & 31) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tagbyte & 31)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | let b = try!(self.read_u8()) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 195 | let b = u64::from(match $ expr { [INFO] [stderr] 196 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 197 | :: Err ( err ) => { [INFO] [stderr] 198 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 199 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader/mod.rs:197:54 [INFO] [stderr] | [INFO] [stderr] 197 | try!(tag_number.checked_mul(128).ok_or( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 198 | | ASN1Error::new(ASN1ErrorKind::IntegerOverflow))); [INFO] [stderr] | |_______________________________________________________________________^ help: try this: `ok_or_else(|| ASN1Error::new(ASN1ErrorKind::IntegerOverflow))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader/mod.rs:228:50 [INFO] [stderr] | [INFO] [stderr] 228 | let x = try!(length.checked_mul(256).ok_or( [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 229 | | ASN1Error::new(ASN1ErrorKind::Eof))); [INFO] [stderr] | |___________________________________________________^ help: try this: `ok_or_else(|| ASN1Error::new(ASN1ErrorKind::Eof))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:451:16 [INFO] [stderr] | [INFO] [stderr] 451 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:454:27 [INFO] [stderr] | [INFO] [stderr] 454 | return Ok(buf[0] as i8 as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf[0] as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:456:26 [INFO] [stderr] | [INFO] [stderr] 456 | let mut x = ((buf[0] as i8 as i64) << 8) + (buf[1] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf[0] as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:456:56 [INFO] [stderr] | [INFO] [stderr] 456 | let mut x = ((buf[0] as i8 as i64) << 8) + (buf[1] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:465:32 [INFO] [stderr] | [INFO] [stderr] 465 | x = (x << 8) | (b as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:484:16 [INFO] [stderr] | [INFO] [stderr] 484 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:489:27 [INFO] [stderr] | [INFO] [stderr] 489 | return Ok(buf[0] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:491:26 [INFO] [stderr] | [INFO] [stderr] 491 | let mut x = ((buf[0] as u64) << 8) + (buf[1] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:491:50 [INFO] [stderr] | [INFO] [stderr] 491 | let mut x = ((buf[0] as u64) << 8) + (buf[1] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:500:32 [INFO] [stderr] | [INFO] [stderr] 500 | x = (x << 8) | (b as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:616:16 [INFO] [stderr] | [INFO] [stderr] 616 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:621:23 [INFO] [stderr] | [INFO] [stderr] 621 | let x2 = ((buf[0] as i8 as i32) << 8) + (buf[1] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buf[0] as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:621:53 [INFO] [stderr] | [INFO] [stderr] 621 | let x2 = ((buf[0] as i8 as i32) << 8) + (buf[1] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:655:16 [INFO] [stderr] | [INFO] [stderr] 655 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:662:23 [INFO] [stderr] | [INFO] [stderr] 662 | let x2 = ((buf[0] as i8 as i32) << 8) + (buf[1] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buf[0] as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:662:53 [INFO] [stderr] | [INFO] [stderr] 662 | let x2 = ((buf[0] as i8 as i32) << 8) + (buf[1] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:683:24 [INFO] [stderr] | [INFO] [stderr] 683 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:817:16 [INFO] [stderr] | [INFO] [stderr] 817 | if buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:845:16 [INFO] [stderr] | [INFO] [stderr] 845 | if buf.len() == 0 || buf[buf.len()-1] >= 128 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader/mod.rs:854:22 [INFO] [stderr] | [INFO] [stderr] 854 | .ok_or(ASN1Error::new( [INFO] [stderr] | ______________________^ [INFO] [stderr] 855 | | ASN1ErrorKind::IntegerOverflow))) + ((b & 127) as u64); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 854 | .ok_or_else(|| ASN1Error::new( [INFO] [stderr] 855 | ASN1ErrorKind::IntegerOverflow))) + ((b & 127) as u64); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:855:61 [INFO] [stderr] | [INFO] [stderr] 855 | ASN1ErrorKind::IntegerOverflow))) + ((b & 127) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b & 127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:857:24 [INFO] [stderr] | [INFO] [stderr] 857 | if components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/mod.rs:973:16 [INFO] [stderr] | [INFO] [stderr] 973 | if elements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/reader/mod.rs:1171:5 [INFO] [stderr] | [INFO] [stderr] 1171 | / pub fn next<'c>(&'c mut self) -> BERReader<'a, 'c> { [INFO] [stderr] 1172 | | BERReader::new(self.inner) [INFO] [stderr] 1173 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let value =` [INFO] [stderr] --> src/reader/tests.rs:792:5 [INFO] [stderr] | [INFO] [stderr] 792 | / let value = parse_der(&[5, 0], |reader| { [INFO] [stderr] 793 | | reader.read_null() [INFO] [stderr] 794 | | }).unwrap(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let value =` [INFO] [stderr] --> src/reader/tests.rs:814:5 [INFO] [stderr] | [INFO] [stderr] 814 | / let value = parse_ber(&[5, 0], |reader| { [INFO] [stderr] 815 | | reader.read_null() [INFO] [stderr] 816 | | }).unwrap(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let value =` [INFO] [stderr] --> src/reader/tests.rs:855:9 [INFO] [stderr] | [INFO] [stderr] 855 | / let value = parse_der(data, |reader| { [INFO] [stderr] 856 | | reader.read_sequence(|_| { [INFO] [stderr] 857 | | Ok(()) [INFO] [stderr] 858 | | }) [INFO] [stderr] 859 | | }).unwrap(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let value =` [INFO] [stderr] --> src/reader/tests.rs:921:9 [INFO] [stderr] | [INFO] [stderr] 921 | / let value = parse_ber(data, |reader| { [INFO] [stderr] 922 | | reader.read_sequence(|_| { [INFO] [stderr] 923 | | Ok(()) [INFO] [stderr] 924 | | }) [INFO] [stderr] 925 | | }).unwrap(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/reader/tests.rs:961:17 [INFO] [stderr] | [INFO] [stderr] 961 | let tests : &[((i64, Vec, i64, Vec), &[u8])] = &[ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/reader/tests.rs:1052:17 [INFO] [stderr] | [INFO] [stderr] 1052 | let tests : &[((i64, Vec, i64, Vec), &[u8])] = &[ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/deserializer/mod.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | .ok_or(ASN1Error::new(ASN1ErrorKind::Invalid)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ASN1Error::new(ASN1ErrorKind::Invalid))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.96s [INFO] running `"docker" "inspect" "8cbf61f7123e184f76210c9bcc2c60761f8f643ba66e0283a09d836840a7e66b"` [INFO] running `"docker" "rm" "-f" "8cbf61f7123e184f76210c9bcc2c60761f8f643ba66e0283a09d836840a7e66b"` [INFO] [stdout] 8cbf61f7123e184f76210c9bcc2c60761f8f643ba66e0283a09d836840a7e66b