[INFO] crate yar_client 0.1.3 is already in cache [INFO] extracting crate yar_client 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/yar_client/0.1.3 [INFO] extracting crate yar_client 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yar_client/0.1.3 [INFO] validating manifest of yar_client-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yar_client-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yar_client-0.1.3 [INFO] finished frobbing yar_client-0.1.3 [INFO] frobbed toml for yar_client-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/yar_client/0.1.3/Cargo.toml [INFO] started frobbing yar_client-0.1.3 [INFO] finished frobbing yar_client-0.1.3 [INFO] frobbed toml for yar_client-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yar_client/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yar_client-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yar_client/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7427e2bd83d0b54121aaf95895659779422c6699144e14636ffd5589ee8a3a2 [INFO] running `"docker" "start" "-a" "d7427e2bd83d0b54121aaf95895659779422c6699144e14636ffd5589ee8a3a2"` [INFO] [stderr] Compiling curl-sys v0.4.16 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking snowflake-multi-threaded v0.1.1 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking curl v0.4.19 [INFO] [stderr] Checking yar_client v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/transport/client.rs:70:66 [INFO] [stderr] | [INFO] [stderr] 70 | let req_id = self.snow_flake_id.generate_id().unwrap() & 0xFFFFFFF ; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/transport/request.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | magic_num:0x80DFEC60, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x80DF_EC60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/transport/client.rs:70:66 [INFO] [stderr] | [INFO] [stderr] 70 | let req_id = self.snow_flake_id.generate_id().unwrap() & 0xFFFFFFF ; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/transport/request.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | magic_num:0x80DFEC60, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x80DF_EC60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/transport/client.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | pub const YAR_OPT_PACKAGER:u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/transport/request.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn encode(&self, packager:&Box,token:&str, provider:&str )->Result>{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Packager` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/transport/request.rs:41:50 [INFO] [stderr] | [INFO] [stderr] 41 | protocol.pack_name[0..4].copy_from_slice("JSON".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"JSON"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/packager/json_packager.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | let i = request.id.clone() as u32 ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `request.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/packager/mod.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn to_protocol(bytes: Vec) -> YarProtocol{ [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/transport/client.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | pub const YAR_OPT_PACKAGER:u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/transport/request.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn encode(&self, packager:&Box,token:&str, provider:&str )->Result>{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Packager` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/transport/request.rs:41:50 [INFO] [stderr] | [INFO] [stderr] 41 | protocol.pack_name[0..4].copy_from_slice("JSON".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"JSON"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/packager/json_packager.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | let i = request.id.clone() as u32 ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `request.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/packager/mod.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn to_protocol(bytes: Vec) -> YarProtocol{ [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.98s [INFO] running `"docker" "inspect" "d7427e2bd83d0b54121aaf95895659779422c6699144e14636ffd5589ee8a3a2"` [INFO] running `"docker" "rm" "-f" "d7427e2bd83d0b54121aaf95895659779422c6699144e14636ffd5589ee8a3a2"` [INFO] [stdout] d7427e2bd83d0b54121aaf95895659779422c6699144e14636ffd5589ee8a3a2