[INFO] crate yandex_translate 2.1.0 is already in cache [INFO] extracting crate yandex_translate 2.1.0 into work/ex/clippy-test-run/sources/stable/reg/yandex_translate/2.1.0 [INFO] extracting crate yandex_translate 2.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yandex_translate/2.1.0 [INFO] validating manifest of yandex_translate-2.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yandex_translate-2.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yandex_translate-2.1.0 [INFO] finished frobbing yandex_translate-2.1.0 [INFO] frobbed toml for yandex_translate-2.1.0 written to work/ex/clippy-test-run/sources/stable/reg/yandex_translate/2.1.0/Cargo.toml [INFO] started frobbing yandex_translate-2.1.0 [INFO] finished frobbing yandex_translate-2.1.0 [INFO] frobbed toml for yandex_translate-2.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yandex_translate/2.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yandex_translate-2.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yandex_translate/2.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56dd1a9eb854b6338c1a7ad6966c648c330fc3cb8d2ff7e5fdb3e1ea9030dbac [INFO] running `"docker" "start" "-a" "56dd1a9eb854b6338c1a7ad6966c648c330fc3cb8d2ff7e5fdb3e1ea9030dbac"` [INFO] [stderr] Checking hyper v0.10.15 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking yandex_translate v2.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/yandex_translate/client.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | const BASE_URL: &'static str = "https://translate.yandex.net/api/v1.5/tr.json/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/yandex_translate/answer.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/yandex_translate/answer.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | let result = self.text.iter() [INFO] [stderr] | ______________________^ [INFO] [stderr] 73 | | .fold(String::new(), |mut r, v| { [INFO] [stderr] 74 | | r.push_str(&format!("{}", v)); [INFO] [stderr] 75 | | r [INFO] [stderr] 76 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/yandex_translate/client.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | const BASE_URL: &'static str = "https://translate.yandex.net/api/v1.5/tr.json/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/yandex_translate/answer.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/yandex_translate/answer.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | let result = self.text.iter() [INFO] [stderr] | ______________________^ [INFO] [stderr] 73 | | .fold(String::new(), |mut r, v| { [INFO] [stderr] 74 | | r.push_str(&format!("{}", v)); [INFO] [stderr] 75 | | r [INFO] [stderr] 76 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_lang` [INFO] [stderr] --> src/yandex_translate/answer.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | fn get_lang(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::YandexTranslate` [INFO] [stderr] --> src/yandex_translate/client.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> YandexTranslate { [INFO] [stderr] 34 | | let ssl = NativeTlsClient::new().unwrap(); [INFO] [stderr] 35 | | let connector = HttpsConnector::new(ssl); [INFO] [stderr] 36 | | YandexTranslate { [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/yandex_translate/answer.rs:23:66 [INFO] [stderr] | [INFO] [stderr] 23 | let error: ErrorYt = serde_json::from_str(&data).unwrap_or(ErrorYt::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ErrorYt::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/yandex_translate/answer.rs:38:66 [INFO] [stderr] | [INFO] [stderr] 38 | let error: ErrorYt = serde_json::from_str(&data).unwrap_or(ErrorYt::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ErrorYt::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/yandex_translate/answer.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | r.push_str(&format!("{}", v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `v.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_lang` [INFO] [stderr] --> src/yandex_translate/answer.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | fn get_lang(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::YandexTranslate` [INFO] [stderr] --> src/yandex_translate/client.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> YandexTranslate { [INFO] [stderr] 34 | | let ssl = NativeTlsClient::new().unwrap(); [INFO] [stderr] 35 | | let connector = HttpsConnector::new(ssl); [INFO] [stderr] 36 | | YandexTranslate { [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/yandex_translate/answer.rs:23:66 [INFO] [stderr] | [INFO] [stderr] 23 | let error: ErrorYt = serde_json::from_str(&data).unwrap_or(ErrorYt::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ErrorYt::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/yandex_translate/answer.rs:38:66 [INFO] [stderr] | [INFO] [stderr] 38 | let error: ErrorYt = serde_json::from_str(&data).unwrap_or(ErrorYt::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ErrorYt::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/yandex_translate/answer.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | r.push_str(&format!("{}", v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `v.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / let mut text: String = mathc_args [INFO] [stderr] 50 | | .value_of("inline_text") [INFO] [stderr] 51 | | .unwrap_or("") [INFO] [stderr] 52 | | .into(); [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | if mathc_args.is_present("pipe") { text = get_text_from_pipe(); } [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 49 | let text = if mathc_args.is_present("pipe") { get_text_from_pipe() } else { mathc_args [INFO] [stderr] 50 | .value_of("inline_text") [INFO] [stderr] 51 | .unwrap_or("") [INFO] [stderr] 52 | .into() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / let mut text: String = mathc_args [INFO] [stderr] 50 | | .value_of("inline_text") [INFO] [stderr] 51 | | .unwrap_or("") [INFO] [stderr] 52 | | .into(); [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | if mathc_args.is_present("pipe") { text = get_text_from_pipe(); } [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 49 | let text = if mathc_args.is_present("pipe") { get_text_from_pipe() } else { mathc_args [INFO] [stderr] 50 | .value_of("inline_text") [INFO] [stderr] 51 | .unwrap_or("") [INFO] [stderr] 52 | .into() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/lib.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | const API_KEY: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.14s [INFO] running `"docker" "inspect" "56dd1a9eb854b6338c1a7ad6966c648c330fc3cb8d2ff7e5fdb3e1ea9030dbac"` [INFO] running `"docker" "rm" "-f" "56dd1a9eb854b6338c1a7ad6966c648c330fc3cb8d2ff7e5fdb3e1ea9030dbac"` [INFO] [stdout] 56dd1a9eb854b6338c1a7ad6966c648c330fc3cb8d2ff7e5fdb3e1ea9030dbac