[INFO] crate yamux 0.1.1 is already in cache [INFO] extracting crate yamux 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/yamux/0.1.1 [INFO] extracting crate yamux 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yamux/0.1.1 [INFO] validating manifest of yamux-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yamux-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yamux-0.1.1 [INFO] finished frobbing yamux-0.1.1 [INFO] frobbed toml for yamux-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/yamux/0.1.1/Cargo.toml [INFO] started frobbing yamux-0.1.1 [INFO] finished frobbing yamux-0.1.1 [INFO] frobbed toml for yamux-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yamux/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yamux-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yamux/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9fa789c90501245f5ef76a687303aa4de76736e0bd52c5a51c0434a71d662f12 [INFO] running `"docker" "start" "-a" "9fa789c90501245f5ef76a687303aa4de76736e0bd52c5a51c0434a71d662f12"` [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Checking nohash-hasher v0.1.1 [INFO] [stderr] Checking quick-error v0.1.4 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking yamux v0.1.1 (/opt/crater/workdir) [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/connection.rs:486:20 [INFO] [stderr] | [INFO] [stderr] 486 | return () [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/connection.rs:489:20 [INFO] [stderr] | [INFO] [stderr] 489 | return () [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: The function/method `close_notify` doesn't need a mutable reference [INFO] [stderr] --> src/connection.rs:127:37 [INFO] [stderr] | [INFO] [stderr] 127 | c.resource.close_notify(&mut c.tasks, 0)? [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking quickcheck v0.6.2 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/connection.rs:486:20 [INFO] [stderr] | [INFO] [stderr] 486 | return () [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/connection.rs:489:20 [INFO] [stderr] | [INFO] [stderr] 489 | return () [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: The function/method `close_notify` doesn't need a mutable reference [INFO] [stderr] --> src/connection.rs:127:37 [INFO] [stderr] | [INFO] [stderr] 127 | c.resource.close_notify(&mut c.tasks, 0)? [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frame/codec.rs:149:22 [INFO] [stderr] | [INFO] [stderr] 149 | let ty = g.choose(&[Data, WindowUpdate, Ping, GoAway]).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*g.choose(&[Data, WindowUpdate, Ping, GoAway]).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame/codec.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | let len = g.gen::() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(g.gen::())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/smoke.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | "Hi client!".as_bytes().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hi client!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/smoke.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | "See you!".as_bytes().into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"See you!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/smoke.rs:78:45 [INFO] [stderr] | [INFO] [stderr] 78 | let future = codec.send("Hi server!".as_bytes().into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hi server!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.56s [INFO] running `"docker" "inspect" "9fa789c90501245f5ef76a687303aa4de76736e0bd52c5a51c0434a71d662f12"` [INFO] running `"docker" "rm" "-f" "9fa789c90501245f5ef76a687303aa4de76736e0bd52c5a51c0434a71d662f12"` [INFO] [stdout] 9fa789c90501245f5ef76a687303aa4de76736e0bd52c5a51c0434a71d662f12