[INFO] crate yamaha_avr 0.2.0 is already in cache [INFO] extracting crate yamaha_avr 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/yamaha_avr/0.2.0 [INFO] extracting crate yamaha_avr 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yamaha_avr/0.2.0 [INFO] validating manifest of yamaha_avr-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yamaha_avr-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yamaha_avr-0.2.0 [INFO] finished frobbing yamaha_avr-0.2.0 [INFO] frobbed toml for yamaha_avr-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/yamaha_avr/0.2.0/Cargo.toml [INFO] started frobbing yamaha_avr-0.2.0 [INFO] finished frobbing yamaha_avr-0.2.0 [INFO] frobbed toml for yamaha_avr-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yamaha_avr/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yamaha_avr-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yamaha_avr/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5313848f43856a59066ba9d010f5cc225962a62817e9744375c9e8b3986c4e94 [INFO] running `"docker" "start" "-a" "5313848f43856a59066ba9d010f5cc225962a62817e9744375c9e8b3986c4e94"` [INFO] [stderr] Checking yamaha_avr v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/yamaha/http.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/yamaha/system_config.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | }else if in_feature_existence { [INFO] [stderr] | _______________________^ [INFO] [stderr] 113 | | if s == "1" { [INFO] [stderr] 114 | | match current_feature.as_ref().map(String::as_ref) { [INFO] [stderr] 115 | | Some("Main_Zone") => available_zones.push("Main_Zone".to_owned()), [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | }else if in_feature_existence && s == "1" { [INFO] [stderr] 113 | match current_feature.as_ref().map(String::as_ref) { [INFO] [stderr] 114 | Some("Main_Zone") => available_zones.push("Main_Zone".to_owned()), [INFO] [stderr] 115 | Some("Zone_2") => available_zones.push("Zone_2".to_owned()), [INFO] [stderr] 116 | Some("Zone_3") => available_zones.push("Zone_3".to_owned()), [INFO] [stderr] 117 | Some("Tuner") => available_features.tuner = true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/yamaha/basic_info.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(basic_info); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(basic_info)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/yamaha/http.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/yamaha/system_config.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | }else if in_feature_existence { [INFO] [stderr] | _______________________^ [INFO] [stderr] 113 | | if s == "1" { [INFO] [stderr] 114 | | match current_feature.as_ref().map(String::as_ref) { [INFO] [stderr] 115 | | Some("Main_Zone") => available_zones.push("Main_Zone".to_owned()), [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | }else if in_feature_existence && s == "1" { [INFO] [stderr] 113 | match current_feature.as_ref().map(String::as_ref) { [INFO] [stderr] 114 | Some("Main_Zone") => available_zones.push("Main_Zone".to_owned()), [INFO] [stderr] 115 | Some("Zone_2") => available_zones.push("Zone_2".to_owned()), [INFO] [stderr] 116 | Some("Zone_3") => available_zones.push("Zone_3".to_owned()), [INFO] [stderr] 117 | Some("Tuner") => available_features.tuner = true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/yamaha/basic_info.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(basic_info); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(basic_info)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/yamaha/basic_info.rs:50:44 [INFO] [stderr] | [INFO] [stderr] 50 | basic_info.power = if s == "On" { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `s == "On"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/yamaha/basic_info.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | basic_info.mute = if s == "On" { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `s == "On"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/yamaha/basic_info.rs:50:44 [INFO] [stderr] | [INFO] [stderr] 50 | basic_info.power = if s == "On" { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `s == "On"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/yamaha/basic_info.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | basic_info.mute = if s == "On" { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `s == "On"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.70s [INFO] running `"docker" "inspect" "5313848f43856a59066ba9d010f5cc225962a62817e9744375c9e8b3986c4e94"` [INFO] running `"docker" "rm" "-f" "5313848f43856a59066ba9d010f5cc225962a62817e9744375c9e8b3986c4e94"` [INFO] [stdout] 5313848f43856a59066ba9d010f5cc225962a62817e9744375c9e8b3986c4e94