[INFO] crate yalal 0.0.1 is already in cache [INFO] extracting crate yalal 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/yalal/0.0.1 [INFO] extracting crate yalal 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yalal/0.0.1 [INFO] validating manifest of yalal-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yalal-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yalal-0.0.1 [INFO] finished frobbing yalal-0.0.1 [INFO] frobbed toml for yalal-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/yalal/0.0.1/Cargo.toml [INFO] started frobbing yalal-0.0.1 [INFO] finished frobbing yalal-0.0.1 [INFO] frobbed toml for yalal-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yalal/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yalal-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yalal/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca2ead80cb4f7f908760a4207049aa91d86ff2401d3a5e859da430f0dd03a1e0 [INFO] running `"docker" "start" "-a" "ca2ead80cb4f7f908760a4207049aa91d86ff2401d3a5e859da430f0dd03a1e0"` [INFO] [stderr] Checking yalal v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: this looks like you are swapping `*i` and `*j` manually [INFO] [stderr] --> src/matrix.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / let tmp = *i; [INFO] [stderr] 131 | | *i = *j; [INFO] [stderr] 132 | | *j = tmp; [INFO] [stderr] | |________________________^ help: try: `std::mem::swap(&mut (*i), &mut (*j))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `row`. [INFO] [stderr] --> src/matrix.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | for k in 0..self.n { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 151 | for in row.iter_mut().take(self.n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `row` [INFO] [stderr] --> src/matrix.rs:198:18 [INFO] [stderr] | [INFO] [stderr] 198 | for k in 0..self.n { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 198 | for (k, ) in row.iter().enumerate().take(self.n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `*i` and `*j` manually [INFO] [stderr] --> src/matrix.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / let tmp = *i; [INFO] [stderr] 131 | | *i = *j; [INFO] [stderr] 132 | | *j = tmp; [INFO] [stderr] | |________________________^ help: try: `std::mem::swap(&mut (*i), &mut (*j))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `row`. [INFO] [stderr] --> src/matrix.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | for k in 0..self.n { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 151 | for in row.iter_mut().take(self.n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `row` [INFO] [stderr] --> src/matrix.rs:198:18 [INFO] [stderr] | [INFO] [stderr] 198 | for k in 0..self.n { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 198 | for (k, ) in row.iter().enumerate().take(self.n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "ca2ead80cb4f7f908760a4207049aa91d86ff2401d3a5e859da430f0dd03a1e0"` [INFO] running `"docker" "rm" "-f" "ca2ead80cb4f7f908760a4207049aa91d86ff2401d3a5e859da430f0dd03a1e0"` [INFO] [stdout] ca2ead80cb4f7f908760a4207049aa91d86ff2401d3a5e859da430f0dd03a1e0