[INFO] crate yade 0.1.2 is already in cache [INFO] extracting crate yade 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/yade/0.1.2 [INFO] extracting crate yade 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yade/0.1.2 [INFO] validating manifest of yade-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yade-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yade-0.1.2 [INFO] finished frobbing yade-0.1.2 [INFO] frobbed toml for yade-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/yade/0.1.2/Cargo.toml [INFO] started frobbing yade-0.1.2 [INFO] finished frobbing yade-0.1.2 [INFO] frobbed toml for yade-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yade/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yade-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yade/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 674edcfc390c0f4d20fd85dd1317cc76ad4427fd49613a1606a3923124a7a85f [INFO] running `"docker" "start" "-a" "674edcfc390c0f4d20fd85dd1317cc76ad4427fd49613a1606a3923124a7a85f"` [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Compiling yade v0.1.2 (/opt/crater/workdir) [INFO] [stderr] Checking synstructure v0.6.1 [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | const DISPLAY_ATTR: &'static str = "display"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | const DISPLAY_MSG: &'static str = "msg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | const CAUSE_ATTR: &'static str = "cause"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | const INVALID_CAUSE: &'static str = "Cause must be a type implementing Error, a Box, or an Option>"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:152:20 [INFO] [stderr] | [INFO] [stderr] 152 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 153 | | if let syn::MetaItem::List(_, ref list) = attr.value { [INFO] [stderr] 154 | | error_msg = Some(&list[..]); [INFO] [stderr] 155 | | } else { [INFO] [stderr] 156 | | panic!("Attribute '{}' requires parens", DISPLAY_ATTR) [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 152 | } else if let syn::MetaItem::List(_, ref list) = attr.value { [INFO] [stderr] 153 | error_msg = Some(&list[..]); [INFO] [stderr] 154 | } else { [INFO] [stderr] 155 | panic!("Attribute '{}' requires parens", DISPLAY_ATTR) [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:111:44 [INFO] [stderr] | [INFO] [stderr] 111 | if id.as_ref().starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | fn is_cause(bi: &&synstructure::BindingInfo) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&synstructure::BindingInfo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | const DISPLAY_ATTR: &'static str = "display"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | const DISPLAY_MSG: &'static str = "msg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | const CAUSE_ATTR: &'static str = "cause"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | const INVALID_CAUSE: &'static str = "Cause must be a type implementing Error, a Box, or an Option>"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:152:20 [INFO] [stderr] | [INFO] [stderr] 152 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 153 | | if let syn::MetaItem::List(_, ref list) = attr.value { [INFO] [stderr] 154 | | error_msg = Some(&list[..]); [INFO] [stderr] 155 | | } else { [INFO] [stderr] 156 | | panic!("Attribute '{}' requires parens", DISPLAY_ATTR) [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 152 | } else if let syn::MetaItem::List(_, ref list) = attr.value { [INFO] [stderr] 153 | error_msg = Some(&list[..]); [INFO] [stderr] 154 | } else { [INFO] [stderr] 155 | panic!("Attribute '{}' requires parens", DISPLAY_ATTR) [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/lib_test.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | .map_err(|e| EnumError::Last(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `EnumError::Last` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:111:44 [INFO] [stderr] | [INFO] [stderr] 111 | if id.as_ref().starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | fn is_cause(bi: &&synstructure::BindingInfo) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&synstructure::BindingInfo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.88s [INFO] running `"docker" "inspect" "674edcfc390c0f4d20fd85dd1317cc76ad4427fd49613a1606a3923124a7a85f"` [INFO] running `"docker" "rm" "-f" "674edcfc390c0f4d20fd85dd1317cc76ad4427fd49613a1606a3923124a7a85f"` [INFO] [stdout] 674edcfc390c0f4d20fd85dd1317cc76ad4427fd49613a1606a3923124a7a85f