[INFO] crate yabs 0.2.2 is already in cache
[INFO] extracting crate yabs 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/yabs/0.2.2
[INFO] extracting crate yabs 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yabs/0.2.2
[INFO] validating manifest of yabs-0.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of yabs-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing yabs-0.2.2
[INFO] finished frobbing yabs-0.2.2
[INFO] frobbed toml for yabs-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/yabs/0.2.2/Cargo.toml
[INFO] started frobbing yabs-0.2.2
[INFO] finished frobbing yabs-0.2.2
[INFO] frobbed toml for yabs-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yabs/0.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting yabs-0.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/yabs/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e4ceff081a9e4d240b5f7820d8d2dfda5fada2f1083941b9444064718378b4ef
[INFO] running `"docker" "start" "-a" "e4ceff081a9e4d240b5f7820d8d2dfda5fada2f1083941b9444064718378b4ef"`
[INFO] [stderr]     Checking toml v0.4.10
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking error-chain v0.10.0
[INFO] [stderr]     Checking yabs v0.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> lib/build.rs:93:20
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 if modtime > &fs::metadata(&target_path)?.modified()? || !target.object().exists() {
[INFO] [stderr]    |                    ^^^^^^^^^^----------------------------------------
[INFO] [stderr]    |                              |
[INFO] [stderr]    |                              help: use the right value directly: `fs::metadata(&target_path)?.modified()?`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> lib/build.rs:156:12
[INFO] [stderr]     |
[INFO] [stderr] 156 |           Ok(run_cmd(&format!("{CC} {LFLAGS} -o {BIN} {OBJ_LIST} {LIB_DIR} {LIBS}",
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 157 | |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stderr] 158 | |                            LFLAGS = &self.project
[INFO] [stderr] 159 | |                                          .lflags
[INFO] [stderr] ...   |
[INFO] [stderr] 171 | |                                           .join(" "),
[INFO] [stderr] 172 | |                            LIBS = &self.project.libs_as_string()))?)
[INFO] [stderr]     | |___________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 156 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> lib/build.rs:177:12
[INFO] [stderr]     |
[INFO] [stderr] 177 |           Ok(run_cmd(&format!("{AR} {ARFLAGS} {LIB} {OBJ_LIST}",
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 178 | |                            AR = &self.project.ar.as_ref().unwrap_or(&String::from("ar")),
[INFO] [stderr] 179 | |                            ARFLAGS =
[INFO] [stderr] 180 | |                                &self.project.arflags.as_ref().unwrap_or(&String::from("rcs")),
[INFO] [stderr] 181 | |                            LIB = library.static_file_name().display(),
[INFO] [stderr] 182 | |                            OBJ_LIST = object_list))?)
[INFO] [stderr]     | |____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 177 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> lib/build.rs:187:12
[INFO] [stderr]     |
[INFO] [stderr] 187 |           Ok(run_cmd(&format!("{CC} -shared -o {LIB} {OBJ_LIST} {LIBS}",
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 188 | |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stderr] 189 | |                            LIB = library.dynamic_file_name().display(),
[INFO] [stderr] 190 | |                            OBJ_LIST = object_list,
[INFO] [stderr] 191 | |                            LIBS = &self.project.libs_as_string()))?)
[INFO] [stderr]     | |___________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 187 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> lib/build.rs:206:46
[INFO] [stderr]     |
[INFO] [stderr] 206 |             if let Some(library) = libraries.into_iter()
[INFO] [stderr]     |                                              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> lib/build.rs:222:44
[INFO] [stderr]     |
[INFO] [stderr] 222 |             if let Some(binary) = binaries.into_iter()
[INFO] [stderr]     |                                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> lib/build.rs:237:12
[INFO] [stderr]     |
[INFO] [stderr] 237 |         if !self.libraries.is_some() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.libraries.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> lib/new.rs:17:8
[INFO] [stderr]    |
[INFO] [stderr] 17 |     Ok(create_bin_files(&dir.to_path_buf(), name)?)
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 17 |     Ok(())
[INFO] [stderr]    |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> lib/new.rs:23:16
[INFO] [stderr]    |
[INFO] [stderr] 23 |               Ok(file.write_all(format!("[project]\n\
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 24 | |                 name = \"{0}\"\n\
[INFO] [stderr] 25 | |                 version = \"0.0.1\"\n\
[INFO] [stderr] 26 | |                 target = [\"{0}\"]\n\
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |                                       name)
[INFO] [stderr] 45 | |                                   .as_bytes())?)
[INFO] [stderr]    | |_______________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 23 |             Ok(())
[INFO] [stderr]    |                ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> lib/new.rs:49:26
[INFO] [stderr]    |
[INFO] [stderr] 49 |                         Ok(src.write_all(b"#include <iostream>\n\n\
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 50 | |             int main() {\n\
[INFO] [stderr] 51 | |             \treturn 0;\n\
[INFO] [stderr] 52 | |             }")?)
[INFO] [stderr]    | |________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 49 |                       Ok(())
[INFO] [stderr]    |                          ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> lib/logger.rs:13:12
[INFO] [stderr]    |
[INFO] [stderr] 13 |           Ok(log::set_logger(|max_log_level| {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 14 | |                                max_log_level.set(LogLevelFilter::Info);
[INFO] [stderr] 15 | |                                Box::new(Logger)
[INFO] [stderr] 16 | |                            })?)
[INFO] [stderr]    | |______________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 13 |         Ok(())
[INFO] [stderr]    |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> lib/build.rs:93:20
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 if modtime > &fs::metadata(&target_path)?.modified()? || !target.object().exists() {
[INFO] [stderr]    |                    ^^^^^^^^^^----------------------------------------
[INFO] [stderr]    |                              |
[INFO] [stderr]    |                              help: use the right value directly: `fs::metadata(&target_path)?.modified()?`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> lib/build.rs:156:12
[INFO] [stderr]     |
[INFO] [stderr] 156 |           Ok(run_cmd(&format!("{CC} {LFLAGS} -o {BIN} {OBJ_LIST} {LIB_DIR} {LIBS}",
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 157 | |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stderr] 158 | |                            LFLAGS = &self.project
[INFO] [stderr] 159 | |                                          .lflags
[INFO] [stderr] ...   |
[INFO] [stderr] 171 | |                                           .join(" "),
[INFO] [stderr] 172 | |                            LIBS = &self.project.libs_as_string()))?)
[INFO] [stderr]     | |___________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 156 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> lib/build.rs:177:12
[INFO] [stderr]     |
[INFO] [stderr] 177 |           Ok(run_cmd(&format!("{AR} {ARFLAGS} {LIB} {OBJ_LIST}",
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 178 | |                            AR = &self.project.ar.as_ref().unwrap_or(&String::from("ar")),
[INFO] [stderr] 179 | |                            ARFLAGS =
[INFO] [stderr] 180 | |                                &self.project.arflags.as_ref().unwrap_or(&String::from("rcs")),
[INFO] [stderr] 181 | |                            LIB = library.static_file_name().display(),
[INFO] [stderr] 182 | |                            OBJ_LIST = object_list))?)
[INFO] [stderr]     | |____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 177 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> lib/build.rs:187:12
[INFO] [stderr]     |
[INFO] [stderr] 187 |           Ok(run_cmd(&format!("{CC} -shared -o {LIB} {OBJ_LIST} {LIBS}",
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 188 | |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stderr] 189 | |                            LIB = library.dynamic_file_name().display(),
[INFO] [stderr] 190 | |                            OBJ_LIST = object_list,
[INFO] [stderr] 191 | |                            LIBS = &self.project.libs_as_string()))?)
[INFO] [stderr]     | |___________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 187 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> lib/build.rs:206:46
[INFO] [stderr]     |
[INFO] [stderr] 206 |             if let Some(library) = libraries.into_iter()
[INFO] [stderr]     |                                              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> lib/build.rs:222:44
[INFO] [stderr]     |
[INFO] [stderr] 222 |             if let Some(binary) = binaries.into_iter()
[INFO] [stderr]     |                                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> lib/build.rs:237:12
[INFO] [stderr]     |
[INFO] [stderr] 237 |         if !self.libraries.is_some() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.libraries.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> lib/new.rs:17:8
[INFO] [stderr]    |
[INFO] [stderr] 17 |     Ok(create_bin_files(&dir.to_path_buf(), name)?)
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 17 |     Ok(())
[INFO] [stderr]    |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> lib/new.rs:23:16
[INFO] [stderr]    |
[INFO] [stderr] 23 |               Ok(file.write_all(format!("[project]\n\
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 24 | |                 name = \"{0}\"\n\
[INFO] [stderr] 25 | |                 version = \"0.0.1\"\n\
[INFO] [stderr] 26 | |                 target = [\"{0}\"]\n\
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |                                       name)
[INFO] [stderr] 45 | |                                   .as_bytes())?)
[INFO] [stderr]    | |_______________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 23 |             Ok(())
[INFO] [stderr]    |                ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> lib/new.rs:49:26
[INFO] [stderr]    |
[INFO] [stderr] 49 |                         Ok(src.write_all(b"#include <iostream>\n\n\
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 50 | |             int main() {\n\
[INFO] [stderr] 51 | |             \treturn 0;\n\
[INFO] [stderr] 52 | |             }")?)
[INFO] [stderr]    | |________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 49 |                       Ok(())
[INFO] [stderr]    |                          ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> lib/logger.rs:13:12
[INFO] [stderr]    |
[INFO] [stderr] 13 |           Ok(log::set_logger(|max_log_level| {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 14 | |                                max_log_level.set(LogLevelFilter::Info);
[INFO] [stderr] 15 | |                                Box::new(Logger)
[INFO] [stderr] 16 | |                            })?)
[INFO] [stderr]    | |______________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 13 |         Ok(())
[INFO] [stderr]    |            ^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.99s
[INFO] running `"docker" "inspect" "e4ceff081a9e4d240b5f7820d8d2dfda5fada2f1083941b9444064718378b4ef"`
[INFO] running `"docker" "rm" "-f" "e4ceff081a9e4d240b5f7820d8d2dfda5fada2f1083941b9444064718378b4ef"`
[INFO] [stdout] e4ceff081a9e4d240b5f7820d8d2dfda5fada2f1083941b9444064718378b4ef