[INFO] crate y4m 0.3.1 is already in cache [INFO] extracting crate y4m 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/y4m/0.3.1 [INFO] extracting crate y4m 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/y4m/0.3.1 [INFO] validating manifest of y4m-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of y4m-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing y4m-0.3.1 [INFO] finished frobbing y4m-0.3.1 [INFO] frobbed toml for y4m-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/y4m/0.3.1/Cargo.toml [INFO] started frobbing y4m-0.3.1 [INFO] finished frobbing y4m-0.3.1 [INFO] frobbed toml for y4m-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/y4m/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting y4m-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/y4m/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a1c33da3b6f1fa96584402930ffbd2660f4731f25f129e3f7d7fb05c55aa563 [INFO] running `"docker" "start" "-a" "4a1c33da3b6f1fa96584402930ffbd2660f4731f25f129e3f7d7fb05c55aa563"` [INFO] [stderr] Checking y4m v0.3.1 (/opt/crater/workdir) [INFO] [stderr] Checking resize v0.3.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | Ratio {num: num, den: den} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | Ratio {num: num, den: den} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `den` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | params_buf: params_buf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `params_buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | frame_buf: frame_buf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | raw_params: raw_params, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | y_len: y_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | u_len: u_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `u_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | planes: planes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `planes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | raw_params: raw_params [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:401:13 [INFO] [stderr] | [INFO] [stderr] 401 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | framerate: framerate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `framerate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | y_len: y_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | u_len: u_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `u_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | v_len: v_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `v_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | const FILE_MAGICK: &'static [u8] = b"YUV4MPEG2 "; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const FRAME_MAGICK: &'static [u8] = b"FRAME"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | let chunk_size = self.read(&mut buf[collected..collected+1])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `collected..=collected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn get_bit_depth(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] --> src/lib.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | Ratio {num: num, den: den} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | Ratio {num: num, den: den} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `den` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:169:33 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn get_bytes_per_sample(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | params_buf: params_buf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `params_buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | frame_buf: frame_buf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | raw_params: raw_params, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | y_len: y_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | u_len: u_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `u_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | planes: planes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `planes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | raw_params: raw_params [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:401:13 [INFO] [stderr] | [INFO] [stderr] 401 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | framerate: framerate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `framerate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | y_len: y_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | u_len: u_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `u_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | v_len: v_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `v_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:235:16 [INFO] [stderr] | [INFO] [stderr] 235 | if param.len() < 1 { continue } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `param.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | / match frame.get_raw_params() { [INFO] [stderr] 448 | | Some(params) => { [INFO] [stderr] 449 | | self.writer.write_all(&[FIELD_SEP])?; [INFO] [stderr] 450 | | self.writer.write_all(params)?; [INFO] [stderr] 451 | | }, [INFO] [stderr] 452 | | _ => {}, [INFO] [stderr] 453 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 447 | if let Some(params) = frame.get_raw_params() { [INFO] [stderr] 448 | self.writer.write_all(&[FIELD_SEP])?; [INFO] [stderr] 449 | self.writer.write_all(params)?; [INFO] [stderr] 450 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | const FILE_MAGICK: &'static [u8] = b"YUV4MPEG2 "; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const FRAME_MAGICK: &'static [u8] = b"FRAME"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/resize.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | let dst_dims: Vec<_> = args[2].split("x").map(|s| s.parse().unwrap()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> examples/resize.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / loop { [INFO] [stderr] 44 | | match decoder.read_frame() { [INFO] [stderr] 45 | | Ok(frame) => { [INFO] [stderr] 46 | | resizer.resize(frame.get_y_plane(), &mut dst); [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(frame) = decoder.read_frame() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | let chunk_size = self.read(&mut buf[collected..collected+1])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `collected..=collected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn get_bit_depth(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:169:33 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn get_bytes_per_sample(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:235:16 [INFO] [stderr] | [INFO] [stderr] 235 | if param.len() < 1 { continue } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `param.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | / match frame.get_raw_params() { [INFO] [stderr] 448 | | Some(params) => { [INFO] [stderr] 449 | | self.writer.write_all(&[FIELD_SEP])?; [INFO] [stderr] 450 | | self.writer.write_all(params)?; [INFO] [stderr] 451 | | }, [INFO] [stderr] 452 | | _ => {}, [INFO] [stderr] 453 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 447 | if let Some(params) = frame.get_raw_params() { [INFO] [stderr] 448 | self.writer.write_all(&[FIELD_SEP])?; [INFO] [stderr] 449 | self.writer.write_all(params)?; [INFO] [stderr] 450 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.05s [INFO] running `"docker" "inspect" "4a1c33da3b6f1fa96584402930ffbd2660f4731f25f129e3f7d7fb05c55aa563"` [INFO] running `"docker" "rm" "-f" "4a1c33da3b6f1fa96584402930ffbd2660f4731f25f129e3f7d7fb05c55aa563"` [INFO] [stdout] 4a1c33da3b6f1fa96584402930ffbd2660f4731f25f129e3f7d7fb05c55aa563