[INFO] crate xz-decom 0.2.0 is already in cache [INFO] extracting crate xz-decom 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/xz-decom/0.2.0 [INFO] extracting crate xz-decom 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xz-decom/0.2.0 [INFO] validating manifest of xz-decom-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xz-decom-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xz-decom-0.2.0 [INFO] removed path dependency xz-embedded-sys from xz-decom-0.2.0 [INFO] finished frobbing xz-decom-0.2.0 [INFO] frobbed toml for xz-decom-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/xz-decom/0.2.0/Cargo.toml [INFO] started frobbing xz-decom-0.2.0 [INFO] removed path dependency xz-embedded-sys from xz-decom-0.2.0 [INFO] finished frobbing xz-decom-0.2.0 [INFO] frobbed toml for xz-decom-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xz-decom/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xz-decom-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xz-decom/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90ae86db216f1ae444412d4c52a10df8ed741c4ea25430f3d92e0ff7f16acb0b [INFO] running `"docker" "start" "-a" "90ae86db216f1ae444412d4c52a10df8ed741c4ea25430f3d92e0ff7f16acb0b"` [INFO] [stderr] Compiling xz-embedded-sys v0.1.1 [INFO] [stderr] Checking xz-decom v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / fn cause<'a>(&'a self) -> Option<&'a Error> { [INFO] [stderr] 24 | | if let Some(ref e) = self.code { [INFO] [stderr] 25 | | Some(e) [INFO] [stderr] 26 | | } else { [INFO] [stderr] 27 | | None [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 70 | let mut out_buf = Vec::with_capacity(out_size); [INFO] [stderr] | ---------------------------- help: consider replace allocation with: `vec![0; out_size]` [INFO] [stderr] 71 | out_buf.resize(out_size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / fn cause<'a>(&'a self) -> Option<&'a Error> { [INFO] [stderr] 24 | | if let Some(ref e) = self.code { [INFO] [stderr] 25 | | Some(e) [INFO] [stderr] 26 | | } else { [INFO] [stderr] 27 | | None [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 70 | let mut out_buf = Vec::with_capacity(out_size); [INFO] [stderr] | ---------------------------- help: consider replace allocation with: `vec![0; out_size]` [INFO] [stderr] 71 | out_buf.resize(out_size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | assert_eq!(result, "hello".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | let data = "not a valid xz file".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"not a valid xz file"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.15s [INFO] running `"docker" "inspect" "90ae86db216f1ae444412d4c52a10df8ed741c4ea25430f3d92e0ff7f16acb0b"` [INFO] running `"docker" "rm" "-f" "90ae86db216f1ae444412d4c52a10df8ed741c4ea25430f3d92e0ff7f16acb0b"` [INFO] [stdout] 90ae86db216f1ae444412d4c52a10df8ed741c4ea25430f3d92e0ff7f16acb0b