[INFO] crate xxtea 0.2.0 is already in cache
[INFO] extracting crate xxtea 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/xxtea/0.2.0
[INFO] extracting crate xxtea 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xxtea/0.2.0
[INFO] validating manifest of xxtea-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of xxtea-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing xxtea-0.2.0
[INFO] finished frobbing xxtea-0.2.0
[INFO] frobbed toml for xxtea-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/xxtea/0.2.0/Cargo.toml
[INFO] started frobbing xxtea-0.2.0
[INFO] finished frobbing xxtea-0.2.0
[INFO] frobbed toml for xxtea-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xxtea/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting xxtea-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xxtea/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dd6219cd86f5c6b3272e305f35faaa177576a1c6b4152e1ae272558ba54b97f1
[INFO] running `"docker" "start" "-a" "dd6219cd86f5c6b3272e305f35faaa177576a1c6b4152e1ae272558ba54b97f1"`
[INFO] [stderr]     Checking xxtea v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:39:49
[INFO] [stderr]    |
[INFO] [stderr] 39 | fn mx(sum: u32, y: u32, z: u32, p: u32, e: u32, k: &Vec<u32>) -> u32 {
[INFO] [stderr]    |                                                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 |     let mut y: u32;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |     let mut z = v[n as usize];
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |     let mut q: u32 = 6 + 52 / length;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:84:17
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let mut y: u32 = v[0];
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:85:17
[INFO] [stderr]    |
[INFO] [stderr] 85 |         let mut z;
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let q: u32 = 6 + 52 / length;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:90:21
[INFO] [stderr]    |
[INFO] [stderr] 90 |             let mut p:usize = n as usize;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:39:49
[INFO] [stderr]    |
[INFO] [stderr] 39 | fn mx(sum: u32, y: u32, z: u32, p: u32, e: u32, k: &Vec<u32>) -> u32 {
[INFO] [stderr]    |                                                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 |     let mut y: u32;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |     let mut z = v[n as usize];
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |     let mut q: u32 = 6 + 52 / length;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:84:17
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let mut y: u32 = v[0];
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:85:17
[INFO] [stderr]    |
[INFO] [stderr] 85 |         let mut z;
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let q: u32 = 6 + 52 / length;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/xxtea.rs:90:21
[INFO] [stderr]    |
[INFO] [stderr] 90 |             let mut p:usize = n as usize;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/xxtea.rs:1:20
[INFO] [stderr]   |
[INFO] [stderr] 1 | const DELTA: u32 = 0x9E3779B9;
[INFO] [stderr]   |                    ^^^^^^^^^^ help: consider: `0x9E37_79B9`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/xxtea.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     return bytes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/xxtea.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/xxtea.rs:76:5
[INFO] [stderr]    |
[INFO] [stderr] 76 |     return v.clone();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/xxtea.rs:68:70
[INFO] [stderr]    |
[INFO] [stderr] 68 |             v[p as usize] = v[p as usize].wrapping_add(mx(sum, y, z, (p as u32), e, &key));
[INFO] [stderr]    |                                                                      ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xxtea.rs:102:9
[INFO] [stderr]     |
[INFO] [stderr] 102 |         return v.clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/xxtea.rs:93:56
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 v[p] = v[p].wrapping_sub(mx(sum, y, z, (p as u32), e, &key));
[INFO] [stderr]    |                                                        ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/xxtea.rs:3:16
[INFO] [stderr]   |
[INFO] [stderr] 3 | fn to_bytes(v: &Vec<u32>, include_length: bool) -> Vec<u8> {
[INFO] [stderr]   |                ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]  --> src/xxtea.rs:8:9
[INFO] [stderr]   |
[INFO] [stderr] 8 |         n = n - 4;
[INFO] [stderr]   |         ^^^^^^^^^ help: replace it with: `n -= 4`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:20:18
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn to_u32(bytes: &Vec<u8>, include_length: bool) -> Vec<u32> {
[INFO] [stderr]    |                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/xxtea.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         n = n + 1;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `n += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/xxtea.rs:34:33
[INFO] [stderr]    |
[INFO] [stderr] 34 |         v[(i >> 2) as usize] |= (bytes[i as usize] as u32) << ((i & 3) << 3) as u32;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[i as usize])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:39:52
[INFO] [stderr]    |
[INFO] [stderr] 39 | fn mx(sum: u32, y: u32, z: u32, p: u32, e: u32, k: &Vec<u32>) -> u32 {
[INFO] [stderr]    |                                                    ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:43:12
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn fixk(k: &Vec<u32>) -> Vec<u32> {
[INFO] [stderr]    |            ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn fixk(k: &[u32]) -> Vec<u32> {
[INFO] [stderr]    |            ^^^^^^
[INFO] [stderr] help: change `k.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let mut key = k.to_owned();
[INFO] [stderr]    |                   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:54:34
[INFO] [stderr]    |
[INFO] [stderr] 54 | fn encrypt_(v: &mut Vec<u32>, k: &Vec<u32>) -> Vec<u32> {
[INFO] [stderr]    |                                  ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/xxtea.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 |         q = q - 1;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `q -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:79:34
[INFO] [stderr]    |
[INFO] [stderr] 79 | fn decrypt_(v: &mut Vec<u32>, k: &Vec<u32>) -> Vec<u32>{
[INFO] [stderr]    |                                  ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/xxtea.rs:95:17
[INFO] [stderr]    |
[INFO] [stderr] 95 |                 p = p - 1;
[INFO] [stderr]    |                 ^^^^^^^^^ help: replace it with: `p -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xxtea.rs:112:22
[INFO] [stderr]     |
[INFO] [stderr] 112 | pub fn decrypt(data: &Vec<u8>, key: &str) -> Vec<u8> {
[INFO] [stderr]     |                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xxtea.rs:141:26
[INFO] [stderr]     |
[INFO] [stderr] 141 | pub fn encrypt_raw(data: &Vec<u8>, key: &str) -> Vec<u8> {
[INFO] [stderr]     |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xxtea.rs:167:26
[INFO] [stderr]     |
[INFO] [stderr] 167 | pub fn decrypt_raw(data: &Vec<u8>, key: &str) -> Vec<u8> {
[INFO] [stderr]     |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/xxtea.rs:1:20
[INFO] [stderr]   |
[INFO] [stderr] 1 | const DELTA: u32 = 0x9E3779B9;
[INFO] [stderr]   |                    ^^^^^^^^^^ help: consider: `0x9E37_79B9`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/xxtea.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     return bytes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/xxtea.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/xxtea.rs:76:5
[INFO] [stderr]    |
[INFO] [stderr] 76 |     return v.clone();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/xxtea.rs:68:70
[INFO] [stderr]    |
[INFO] [stderr] 68 |             v[p as usize] = v[p as usize].wrapping_add(mx(sum, y, z, (p as u32), e, &key));
[INFO] [stderr]    |                                                                      ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xxtea.rs:102:9
[INFO] [stderr]     |
[INFO] [stderr] 102 |         return v.clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/xxtea.rs:93:56
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 v[p] = v[p].wrapping_sub(mx(sum, y, z, (p as u32), e, &key));
[INFO] [stderr]    |                                                        ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/xxtea.rs:3:16
[INFO] [stderr]   |
[INFO] [stderr] 3 | fn to_bytes(v: &Vec<u32>, include_length: bool) -> Vec<u8> {
[INFO] [stderr]   |                ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]  --> src/xxtea.rs:8:9
[INFO] [stderr]   |
[INFO] [stderr] 8 |         n = n - 4;
[INFO] [stderr]   |         ^^^^^^^^^ help: replace it with: `n -= 4`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:20:18
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn to_u32(bytes: &Vec<u8>, include_length: bool) -> Vec<u32> {
[INFO] [stderr]    |                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/xxtea.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         n = n + 1;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `n += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/xxtea.rs:34:33
[INFO] [stderr]    |
[INFO] [stderr] 34 |         v[(i >> 2) as usize] |= (bytes[i as usize] as u32) << ((i & 3) << 3) as u32;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[i as usize])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:39:52
[INFO] [stderr]    |
[INFO] [stderr] 39 | fn mx(sum: u32, y: u32, z: u32, p: u32, e: u32, k: &Vec<u32>) -> u32 {
[INFO] [stderr]    |                                                    ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:43:12
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn fixk(k: &Vec<u32>) -> Vec<u32> {
[INFO] [stderr]    |            ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn fixk(k: &[u32]) -> Vec<u32> {
[INFO] [stderr]    |            ^^^^^^
[INFO] [stderr] help: change `k.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let mut key = k.to_owned();
[INFO] [stderr]    |                   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:54:34
[INFO] [stderr]    |
[INFO] [stderr] 54 | fn encrypt_(v: &mut Vec<u32>, k: &Vec<u32>) -> Vec<u32> {
[INFO] [stderr]    |                                  ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/xxtea.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 |         q = q - 1;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `q -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/xxtea.rs:79:34
[INFO] [stderr]    |
[INFO] [stderr] 79 | fn decrypt_(v: &mut Vec<u32>, k: &Vec<u32>) -> Vec<u32>{
[INFO] [stderr]    |                                  ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/xxtea.rs:95:17
[INFO] [stderr]    |
[INFO] [stderr] 95 |                 p = p - 1;
[INFO] [stderr]    |                 ^^^^^^^^^ help: replace it with: `p -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xxtea.rs:112:22
[INFO] [stderr]     |
[INFO] [stderr] 112 | pub fn decrypt(data: &Vec<u8>, key: &str) -> Vec<u8> {
[INFO] [stderr]     |                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xxtea.rs:141:26
[INFO] [stderr]     |
[INFO] [stderr] 141 | pub fn encrypt_raw(data: &Vec<u8>, key: &str) -> Vec<u8> {
[INFO] [stderr]     |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xxtea.rs:167:26
[INFO] [stderr]     |
[INFO] [stderr] 167 | pub fn decrypt_raw(data: &Vec<u8>, key: &str) -> Vec<u8> {
[INFO] [stderr]     |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.66s
[INFO] running `"docker" "inspect" "dd6219cd86f5c6b3272e305f35faaa177576a1c6b4152e1ae272558ba54b97f1"`
[INFO] running `"docker" "rm" "-f" "dd6219cd86f5c6b3272e305f35faaa177576a1c6b4152e1ae272558ba54b97f1"`
[INFO] [stdout] dd6219cd86f5c6b3272e305f35faaa177576a1c6b4152e1ae272558ba54b97f1