[INFO] crate xterm256_converter 0.2.0 is already in cache
[INFO] extracting crate xterm256_converter 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/xterm256_converter/0.2.0
[INFO] extracting crate xterm256_converter 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xterm256_converter/0.2.0
[INFO] validating manifest of xterm256_converter-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of xterm256_converter-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing xterm256_converter-0.2.0
[INFO] finished frobbing xterm256_converter-0.2.0
[INFO] frobbed toml for xterm256_converter-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/xterm256_converter/0.2.0/Cargo.toml
[INFO] started frobbing xterm256_converter-0.2.0
[INFO] finished frobbing xterm256_converter-0.2.0
[INFO] frobbed toml for xterm256_converter-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xterm256_converter/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting xterm256_converter-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xterm256_converter/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4fc202d0a70846e705e848b1be2c5b1a23b67925a01f815d152d02770cba497a
[INFO] running `"docker" "start" "-a" "4fc202d0a70846e705e848b1be2c5b1a23b67925a01f815d152d02770cba497a"`
[INFO] [stderr]     Checking png v0.11.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.15
[INFO] [stderr]     Checking image v0.18.0
[INFO] [stderr]     Checking xterm256_converter v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:12:17
[INFO] [stderr]    |
[INFO] [stderr] 12 |         sum += (color_a[i] as i16 - color_b[i] as i16).abs() as u16;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^ help: try: `i16::from(color_a[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:12:37
[INFO] [stderr]    |
[INFO] [stderr] 12 |         sum += (color_a[i] as i16 - color_b[i] as i16).abs() as u16;
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^ help: try: `i16::from(color_b[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:33:37
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn encode(start: &[u8], color_code: &u8) -> Vec<u8> {
[INFO] [stderr]    |                                     ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:12:17
[INFO] [stderr]    |
[INFO] [stderr] 12 |         sum += (color_a[i] as i16 - color_b[i] as i16).abs() as u16;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^ help: try: `i16::from(color_a[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:12:37
[INFO] [stderr]    |
[INFO] [stderr] 12 |         sum += (color_a[i] as i16 - color_b[i] as i16).abs() as u16;
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^ help: try: `i16::from(color_b[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         let mut color_code_fg: Option<u8>;
[INFO] [stderr] 102 | |
[INFO] [stderr] 103 | |         if y == img.dimensions().1 - 1 {
[INFO] [stderr] 104 | |             color_code_bg = None;
[INFO] [stderr] ...   |
[INFO] [stderr] 120 | |             };
[INFO] [stderr] 121 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 101 |         let <mut> color_code_fg = if y == img.dimensions().1 - 1 { ..; if img[(x, y)][3] < 128 {
[INFO] [stderr] 102 |                 None
[INFO] [stderr] 103 |             } else {
[INFO] [stderr] 104 |                 Some(find_color_code(img[(x, y)]))
[INFO] [stderr] 105 |             } } else { ..; if img[(x, y + 1)][3] < 128 {
[INFO] [stderr] 106 |                 None
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping `color_code_bg` and `color_code_fg` manually
[INFO] [stderr]    --> src/lib.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 | /             let mut transition = color_code_bg;
[INFO] [stderr] 131 | |             color_code_bg = color_code_fg;
[INFO] [stderr] 132 | |             color_code_fg = transition;
[INFO] [stderr]     | |______________________________________^ help: try: `std::mem::swap(&mut color_code_bg, &mut color_code_fg)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]     = note: or maybe you should use `std::mem::replace`?
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/lib.rs:149:47
[INFO] [stderr]     |
[INFO] [stderr] 149 |           } else if y == img.dimensions().1 - 1 {
[INFO] [stderr]     |  _______________________________________________^
[INFO] [stderr] 150 | |             result.extend_from_slice(String::from("\u{2580}").as_bytes());
[INFO] [stderr] 151 | |         } else {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/lib.rs:147:36
[INFO] [stderr]     |
[INFO] [stderr] 147 |           } else if upper_block_flag {
[INFO] [stderr]     |  ____________________________________^
[INFO] [stderr] 148 | |             result.extend_from_slice(String::from("\u{2580}").as_bytes());
[INFO] [stderr] 149 | |         } else if y == img.dimensions().1 - 1 {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:33:37
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn encode(start: &[u8], color_code: &u8) -> Vec<u8> {
[INFO] [stderr]    |                                     ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `xterm256_converter`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         let mut color_code_fg: Option<u8>;
[INFO] [stderr] 102 | |
[INFO] [stderr] 103 | |         if y == img.dimensions().1 - 1 {
[INFO] [stderr] 104 | |             color_code_bg = None;
[INFO] [stderr] ...   |
[INFO] [stderr] 120 | |             };
[INFO] [stderr] 121 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 101 |         let <mut> color_code_fg = if y == img.dimensions().1 - 1 { ..; if img[(x, y)][3] < 128 {
[INFO] [stderr] 102 |                 None
[INFO] [stderr] 103 |             } else {
[INFO] [stderr] 104 |                 Some(find_color_code(img[(x, y)]))
[INFO] [stderr] 105 |             } } else { ..; if img[(x, y + 1)][3] < 128 {
[INFO] [stderr] 106 |                 None
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping `color_code_bg` and `color_code_fg` manually
[INFO] [stderr]    --> src/lib.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 | /             let mut transition = color_code_bg;
[INFO] [stderr] 131 | |             color_code_bg = color_code_fg;
[INFO] [stderr] 132 | |             color_code_fg = transition;
[INFO] [stderr]     | |______________________________________^ help: try: `std::mem::swap(&mut color_code_bg, &mut color_code_fg)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]     = note: or maybe you should use `std::mem::replace`?
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/lib.rs:149:47
[INFO] [stderr]     |
[INFO] [stderr] 149 |           } else if y == img.dimensions().1 - 1 {
[INFO] [stderr]     |  _______________________________________________^
[INFO] [stderr] 150 | |             result.extend_from_slice(String::from("\u{2580}").as_bytes());
[INFO] [stderr] 151 | |         } else {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/lib.rs:147:36
[INFO] [stderr]     |
[INFO] [stderr] 147 |           } else if upper_block_flag {
[INFO] [stderr]     |  ____________________________________^
[INFO] [stderr] 148 | |             result.extend_from_slice(String::from("\u{2580}").as_bytes());
[INFO] [stderr] 149 | |         } else if y == img.dimensions().1 - 1 {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `xterm256_converter`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "4fc202d0a70846e705e848b1be2c5b1a23b67925a01f815d152d02770cba497a"`
[INFO] running `"docker" "rm" "-f" "4fc202d0a70846e705e848b1be2c5b1a23b67925a01f815d152d02770cba497a"`
[INFO] [stdout] 4fc202d0a70846e705e848b1be2c5b1a23b67925a01f815d152d02770cba497a