[INFO] crate xsv 0.13.0 is already in cache [INFO] extracting crate xsv 0.13.0 into work/ex/clippy-test-run/sources/stable/reg/xsv/0.13.0 [INFO] extracting crate xsv 0.13.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xsv/0.13.0 [INFO] validating manifest of xsv-0.13.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xsv-0.13.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xsv-0.13.0 [INFO] removed 1 missing tests [INFO] finished frobbing xsv-0.13.0 [INFO] frobbed toml for xsv-0.13.0 written to work/ex/clippy-test-run/sources/stable/reg/xsv/0.13.0/Cargo.toml [INFO] started frobbing xsv-0.13.0 [INFO] removed 1 missing tests [INFO] finished frobbing xsv-0.13.0 [INFO] frobbed toml for xsv-0.13.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xsv/0.13.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xsv-0.13.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xsv/0.13.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eeb8c667ac49a7d1281627d985c562a7371af60d260b60e55be49e9956bc2f0f [INFO] running `"docker" "start" "-a" "eeb8c667ac49a7d1281627d985c562a7371af60d260b60e55be49e9956bc2f0f"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/test_select.rs [INFO] [stderr] * /opt/crater/workdir/tests/tests.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_index.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_fmt.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_count.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_split.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_slice.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_join.rs [INFO] [stderr] * /opt/crater/workdir/tests/workdir.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_fixlengths.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_partition.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_table.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_headers.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_frequency.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_cat.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_sort.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_flatten.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_search.rs [INFO] [stderr] * /opt/crater/workdir/tests/test_stats.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Checking streaming-stats v0.2.2 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking chan v0.1.23 [INFO] [stderr] Checking csv-index v0.1.5 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking xsv v0.13.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/join.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | rdr1: rdr1, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rdr1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/join.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | sel1: sel1, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sel1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/join.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | rdr2: rdr2, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rdr2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/join.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | sel2: sel2, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sel2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/join.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/partition.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | template: template, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `template` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/stats.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | sum: sum, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/stats.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | minmax: minmax, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minmax` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/stats.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | online: online, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `online` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/stats.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/stats.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | median: median, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `median` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd/stats.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | which: which, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `which` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | csv_rdr: csv_rdr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `csv_rdr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/select.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | invert: invert, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `invert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cmd/frequency.rs:178:24 [INFO] [stderr] | [INFO] [stderr] 178 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 179 | | if !self.flag_no_nulls { [INFO] [stderr] 180 | | tabs[i].add(null.clone()); [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | } else if !self.flag_no_nulls { [INFO] [stderr] 179 | tabs[i].add(null.clone()); [INFO] [stderr] 180 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cmd/count.rs:50:8 [INFO] [stderr] | [INFO] [stderr] 50 | Ok(println!("{}", count)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in &record.enumerate()` or similar iterators [INFO] [stderr] --> src/cmd/fixlengths.rs:68:30 [INFO] [stderr] | [INFO] [stderr] 68 | for field in &record { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cmd/frequency.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / let mut header = header.to_vec(); [INFO] [stderr] 90 | | if rconfig.no_headers { [INFO] [stderr] 91 | | header = (i+1).to_string().into_bytes(); [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let header = if rconfig.no_headers { (i+1).to_string().into_bytes() } else { header.to_vec() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cmd/sample.rs:78:8 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(wtr.flush()?) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 78 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cmd/search.rs:79:8 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(wtr.flush()?) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 79 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cmd/slice.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(wtr.flush()?) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 74 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cmd/sort.rs:94:8 [INFO] [stderr] | [INFO] [stderr] 94 | Ok(wtr.flush()?) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 94 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd/stats.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | self.sum.as_mut().map(|v| v.add(t, sample)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = self.sum.as_mut() { v.add(t, sample) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd/stats.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | self.minmax.as_mut().map(|v| v.add(t, sample)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = self.minmax.as_mut() { v.add(t, sample) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd/stats.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | self.mode.as_mut().map(|v| v.add(sample.to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = self.mode.as_mut() { v.add(sample.to_vec()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd/stats.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | self.online.as_mut().map(|v| { v.add_null(); }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = self.online.as_mut() { v.add_null(); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd/stats.rs:297:25 [INFO] [stderr] | [INFO] [stderr] 297 | self.online.as_mut().map(|v| { v.add_null(); }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = self.online.as_mut() { v.add_null(); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd/stats.rs:301:21 [INFO] [stderr] | [INFO] [stderr] 301 | self.median.as_mut().map(|v| { v.add(n); }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = self.median.as_mut() { v.add(n); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd/stats.rs:302:21 [INFO] [stderr] | [INFO] [stderr] 302 | self.online.as_mut().map(|v| { v.add(n); }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = self.online.as_mut() { v.add(n); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/cmd/stats.rs:308:18 [INFO] [stderr] | [INFO] [stderr] 308 | fn to_record(&mut self) -> csv::StringRecord { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/cmd/stats.rs:402:16 [INFO] [stderr] | [INFO] [stderr] 402 | if let Ok(_) = string.parse::() { return TInteger; } [INFO] [stderr] | -------^^^^^--------------------------------------------- help: try this: `if string.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/cmd/stats.rs:403:16 [INFO] [stderr] | [INFO] [stderr] 403 | if let Ok(_) = string.parse::() { return TFloat; } [INFO] [stderr] | -------^^^^^------------------------------------------- help: try this: `if string.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cmd/stats.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | fn is_number(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cmd/stats.rs:411:16 [INFO] [stderr] | [INFO] [stderr] 411 | fn is_null(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:113:43 [INFO] [stderr] | [INFO] [stderr] 113 | if env::var("XSV_TOGGLE_HEADERS").unwrap_or("0".to_owned()) == "1" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "0".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:282:33 [INFO] [stderr] | [INFO] [stderr] 282 | pub fn from_reader(&self, rdr: R) -> csv::Reader { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:300:38 [INFO] [stderr] | [INFO] [stderr] 300 | pub fn from_writer(&self, wtr: W) -> csv::Writer { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/select.rs:255:39 [INFO] [stderr] | [INFO] [stderr] 255 | Ordering::Less => (i1..(i2 + 1)).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(i1..=i2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/select.rs:280:20 [INFO] [stderr] | [INFO] [stderr] 280 | if first_record.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `first_record.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/select.rs:360:62 [INFO] [stderr] | [INFO] [stderr] 360 | fn get_field<'c>(row: &mut &'c csv::ByteRecord, idx: &usize) [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/select.rs:416:5 [INFO] [stderr] | [INFO] [stderr] 416 | / pub fn select<'a, T, I>(&'a self, row: I) -> _NormalFilterMap<'a, T, I> [INFO] [stderr] 417 | | where I: Iterator { [INFO] [stderr] 418 | | fn filmap(v: Option) -> Option { v } [INFO] [stderr] 419 | | fn get_field(set: &mut &[bool], t: (usize, T)) [INFO] [stderr] ... | [INFO] [stderr] 426 | | row.enumerate().scan(&**self, get_field).filter_map(filmap) [INFO] [stderr] 427 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/select.rs:420:27 [INFO] [stderr] | [INFO] [stderr] 420 | -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | .and_then(|d| d.argv(argv.iter().map(|&x| x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `argv.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn condense<'a>(val: Cow<'a, [u8]>, n: Option) -> Cow<'a, [u8]> { [INFO] [stderr] 91 | | match n { [INFO] [stderr] 92 | | None => val, [INFO] [stderr] 93 | | Some(n) => { [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.41s [INFO] running `"docker" "inspect" "eeb8c667ac49a7d1281627d985c562a7371af60d260b60e55be49e9956bc2f0f"` [INFO] running `"docker" "rm" "-f" "eeb8c667ac49a7d1281627d985c562a7371af60d260b60e55be49e9956bc2f0f"` [INFO] [stdout] eeb8c667ac49a7d1281627d985c562a7371af60d260b60e55be49e9956bc2f0f