[INFO] crate xpad 0.1.0 is already in cache [INFO] extracting crate xpad 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/xpad/0.1.0 [INFO] extracting crate xpad 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xpad/0.1.0 [INFO] validating manifest of xpad-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xpad-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xpad-0.1.0 [INFO] finished frobbing xpad-0.1.0 [INFO] frobbed toml for xpad-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/xpad/0.1.0/Cargo.toml [INFO] started frobbing xpad-0.1.0 [INFO] finished frobbing xpad-0.1.0 [INFO] frobbed toml for xpad-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xpad/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xpad-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xpad/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f6443562bf8e7366f309f9dfdc490a516f1422c6e60dbe392734378595fe488 [INFO] running `"docker" "start" "-a" "5f6443562bf8e7366f309f9dfdc490a516f1422c6e60dbe392734378595fe488"` [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking xpad v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/lib.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | writeln!(writer, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/lib.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | writeln!(writer, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn split_row<'input>(input: &'input str, delimiter: char) -> Row<'input> { [INFO] [stderr] 33 | | let mut row = Row::new(); [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | for substr in input.split(delimiter) { [INFO] [stderr] ... | [INFO] [stderr] 40 | | row [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn parse_document<'input>(input: &'input str, delimiter: char) -> Document<'input> { [INFO] [stderr] 51 | | input.lines().map(|line| split_row(line, delimiter)).collect() [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:94:15 [INFO] [stderr] | [INFO] [stderr] 94 | document: &Document, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:131:62 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn write<'input, W: io::Write>(writer: &mut W, document: &Document<'input>, config: &OutputConfig, autoflush: bool) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:154:32 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn print<'input>(document: &Document<'input>, config: &OutputConfig) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn split_row<'input>(input: &'input str, delimiter: char) -> Row<'input> { [INFO] [stderr] 33 | | let mut row = Row::new(); [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | for substr in input.split(delimiter) { [INFO] [stderr] ... | [INFO] [stderr] 40 | | row [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn parse_document<'input>(input: &'input str, delimiter: char) -> Document<'input> { [INFO] [stderr] 51 | | input.lines().map(|line| split_row(line, delimiter)).collect() [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:94:15 [INFO] [stderr] | [INFO] [stderr] 94 | document: &Document, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:131:62 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn write<'input, W: io::Write>(writer: &mut W, document: &Document<'input>, config: &OutputConfig, autoflush: bool) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:154:32 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn print<'input>(document: &Document<'input>, config: &OutputConfig) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bin/pad.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | let aligns = optional!(values_t!(matches, "align", xpad::Alignment)).unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | let aligns = match $val { [INFO] [stderr] 40 | Ok(d) => Some(d), [INFO] [stderr] 41 | Err(clap::Error{kind: clap::ErrorKind::ArgumentNotFound, ..}) => None, [INFO] [stderr] 42 | Err(e) => e.exit(), [INFO] [stderr] 43 | }.unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bin/pad.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | let aligns = optional!(values_t!(matches, "align", xpad::Alignment)).unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | let aligns = match $val { [INFO] [stderr] 40 | Ok(d) => Some(d), [INFO] [stderr] 41 | Err(clap::Error{kind: clap::ErrorKind::ArgumentNotFound, ..}) => None, [INFO] [stderr] 42 | Err(e) => e.exit(), [INFO] [stderr] 43 | }.unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.62s [INFO] running `"docker" "inspect" "5f6443562bf8e7366f309f9dfdc490a516f1422c6e60dbe392734378595fe488"` [INFO] running `"docker" "rm" "-f" "5f6443562bf8e7366f309f9dfdc490a516f1422c6e60dbe392734378595fe488"` [INFO] [stdout] 5f6443562bf8e7366f309f9dfdc490a516f1422c6e60dbe392734378595fe488