[INFO] crate xoroshiro 0.3.0 is already in cache [INFO] extracting crate xoroshiro 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/xoroshiro/0.3.0 [INFO] extracting crate xoroshiro 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xoroshiro/0.3.0 [INFO] validating manifest of xoroshiro-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xoroshiro-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xoroshiro-0.3.0 [INFO] finished frobbing xoroshiro-0.3.0 [INFO] frobbed toml for xoroshiro-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/xoroshiro/0.3.0/Cargo.toml [INFO] started frobbing xoroshiro-0.3.0 [INFO] finished frobbing xoroshiro-0.3.0 [INFO] frobbed toml for xoroshiro-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xoroshiro/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xoroshiro-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xoroshiro/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3bb2f407f414ef427abd6122e21d591de4665e6b47302fc7def36565d963ac7 [INFO] running `"docker" "start" "-a" "f3bb2f407f414ef427abd6122e21d591de4665e6b47302fc7def36565d963ac7"` [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking xoroshiro v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rng/splitmix64.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return z ^ (z >> 31); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `z ^ (z >> 31)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/splitmix64.rs:50:38 [INFO] [stderr] | [INFO] [stderr] 50 | self.x = self.x.wrapping_add(0x9e3779b97f4a7c15); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9e37_79b9_7f4a_7c15` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/splitmix64.rs:52:42 [INFO] [stderr] | [INFO] [stderr] 52 | z = (z ^ (z >> 30)).wrapping_mul(0xbf58476d1ce4e5b9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbf58_476d_1ce4_e5b9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/splitmix64.rs:53:42 [INFO] [stderr] | [INFO] [stderr] 53 | z = (z ^ (z >> 27)).wrapping_mul(0x94d049bb133111eb); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x94d0_49bb_1331_11eb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/rng/splitmix64.rs:67:27 [INFO] [stderr] | [INFO] [stderr] 67 | *v = (r >> 8*i) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `r >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xoroshiro128.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | s0: 0x193a6754a8a7d469, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x193a_6754_a8a7_d469` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xoroshiro128.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | s1: 0x97830e05113ba7bb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9783_0e05_113b_a7bb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xoroshiro128.rs:66:33 [INFO] [stderr] | [INFO] [stderr] 66 | const JUMP: [u64; 2] = [0xbeac0467eba5facb, 0xd86b048b86aa9922]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbeac_0467_eba5_facb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xoroshiro128.rs:66:53 [INFO] [stderr] | [INFO] [stderr] 66 | const JUMP: [u64; 2] = [0xbeac0467eba5facb, 0xd86b048b86aa9922]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd86b_048b_86aa_9922` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/rng/xoroshiro128.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | *v = (r >> 8*i) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `r >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | const JUMP: [u64; 16] = [0x84242f96eca9c41d, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8424_2f96_eca9_c41d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | 0xa3c65b8776f96855, 0x5b34a39f070b5837, 0x4489affce4f31a1e, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa3c6_5b87_76f9_6855` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | 0xa3c65b8776f96855, 0x5b34a39f070b5837, 0x4489affce4f31a1e, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5b34_a39f_070b_5837` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:60:53 [INFO] [stderr] | [INFO] [stderr] 60 | 0xa3c65b8776f96855, 0x5b34a39f070b5837, 0x4489affce4f31a1e, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4489_affc_e4f3_1a1e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | 0x2ffeeb0a48316f40, 0xdc2d9891fe68c022, 0x3659132bb12fea70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2ffe_eb0a_4831_6f40` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:61:33 [INFO] [stderr] | [INFO] [stderr] 61 | 0x2ffeeb0a48316f40, 0xdc2d9891fe68c022, 0x3659132bb12fea70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xdc2d_9891_fe68_c022` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:61:53 [INFO] [stderr] | [INFO] [stderr] 61 | 0x2ffeeb0a48316f40, 0xdc2d9891fe68c022, 0x3659132bb12fea70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3659_132b_b12f_ea70` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | 0xaac17d8efa43cab8, 0xc4cb815590989b13, 0x5ee975283d71c93b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xaac1_7d8e_fa43_cab8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | 0xaac17d8efa43cab8, 0xc4cb815590989b13, 0x5ee975283d71c93b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc4cb_8155_9098_9b13` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:62:53 [INFO] [stderr] | [INFO] [stderr] 62 | 0xaac17d8efa43cab8, 0xc4cb815590989b13, 0x5ee975283d71c93b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5ee9_7528_3d71_c93b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | 0x691548c86c1bd540, 0x7910c41d10a1e6a5, 0x0b5fc64563b3e2a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x6915_48c8_6c1b_d540` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:63:33 [INFO] [stderr] | [INFO] [stderr] 63 | 0x691548c86c1bd540, 0x7910c41d10a1e6a5, 0x0b5fc64563b3e2a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7910_c41d_10a1_e6a5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:63:53 [INFO] [stderr] | [INFO] [stderr] 63 | 0x691548c86c1bd540, 0x7910c41d10a1e6a5, 0x0b5fc64563b3e2a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0b5f_c645_63b3_e2a8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | 0x047f7684e9fc949d, 0xb99181f2d8f685ca, 0x284600e3f30e38c3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x047f_7684_e9fc_949d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | 0x047f7684e9fc949d, 0xb99181f2d8f685ca, 0x284600e3f30e38c3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb991_81f2_d8f6_85ca` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:64:53 [INFO] [stderr] | [INFO] [stderr] 64 | 0x047f7684e9fc949d, 0xb99181f2d8f685ca, 0x284600e3f30e38c3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2846_00e3_f30e_38c3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | self.s[self.p].wrapping_mul(0x9e3779b97f4a7c13) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9e37_79b9_7f4a_7c13` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/rng/xorshift1024.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | *v = (r >> 8*i) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `r >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rng/splitmix64.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return z ^ (z >> 31); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `z ^ (z >> 31)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/splitmix64.rs:50:38 [INFO] [stderr] | [INFO] [stderr] 50 | self.x = self.x.wrapping_add(0x9e3779b97f4a7c15); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9e37_79b9_7f4a_7c15` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/splitmix64.rs:52:42 [INFO] [stderr] | [INFO] [stderr] 52 | z = (z ^ (z >> 30)).wrapping_mul(0xbf58476d1ce4e5b9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbf58_476d_1ce4_e5b9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/splitmix64.rs:53:42 [INFO] [stderr] | [INFO] [stderr] 53 | z = (z ^ (z >> 27)).wrapping_mul(0x94d049bb133111eb); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x94d0_49bb_1331_11eb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/rng/splitmix64.rs:67:27 [INFO] [stderr] | [INFO] [stderr] 67 | *v = (r >> 8*i) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `r >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xoroshiro128.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | s0: 0x193a6754a8a7d469, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x193a_6754_a8a7_d469` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xoroshiro128.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | s1: 0x97830e05113ba7bb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9783_0e05_113b_a7bb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xoroshiro128.rs:66:33 [INFO] [stderr] | [INFO] [stderr] 66 | const JUMP: [u64; 2] = [0xbeac0467eba5facb, 0xd86b048b86aa9922]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbeac_0467_eba5_facb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xoroshiro128.rs:66:53 [INFO] [stderr] | [INFO] [stderr] 66 | const JUMP: [u64; 2] = [0xbeac0467eba5facb, 0xd86b048b86aa9922]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd86b_048b_86aa_9922` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/rng/xoroshiro128.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | *v = (r >> 8*i) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `r >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | const JUMP: [u64; 16] = [0x84242f96eca9c41d, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8424_2f96_eca9_c41d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | 0xa3c65b8776f96855, 0x5b34a39f070b5837, 0x4489affce4f31a1e, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa3c6_5b87_76f9_6855` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | 0xa3c65b8776f96855, 0x5b34a39f070b5837, 0x4489affce4f31a1e, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5b34_a39f_070b_5837` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:60:53 [INFO] [stderr] | [INFO] [stderr] 60 | 0xa3c65b8776f96855, 0x5b34a39f070b5837, 0x4489affce4f31a1e, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4489_affc_e4f3_1a1e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | 0x2ffeeb0a48316f40, 0xdc2d9891fe68c022, 0x3659132bb12fea70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2ffe_eb0a_4831_6f40` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:61:33 [INFO] [stderr] | [INFO] [stderr] 61 | 0x2ffeeb0a48316f40, 0xdc2d9891fe68c022, 0x3659132bb12fea70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xdc2d_9891_fe68_c022` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:61:53 [INFO] [stderr] | [INFO] [stderr] 61 | 0x2ffeeb0a48316f40, 0xdc2d9891fe68c022, 0x3659132bb12fea70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3659_132b_b12f_ea70` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | 0xaac17d8efa43cab8, 0xc4cb815590989b13, 0x5ee975283d71c93b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xaac1_7d8e_fa43_cab8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | 0xaac17d8efa43cab8, 0xc4cb815590989b13, 0x5ee975283d71c93b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc4cb_8155_9098_9b13` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:62:53 [INFO] [stderr] | [INFO] [stderr] 62 | 0xaac17d8efa43cab8, 0xc4cb815590989b13, 0x5ee975283d71c93b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5ee9_7528_3d71_c93b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | 0x691548c86c1bd540, 0x7910c41d10a1e6a5, 0x0b5fc64563b3e2a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x6915_48c8_6c1b_d540` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:63:33 [INFO] [stderr] | [INFO] [stderr] 63 | 0x691548c86c1bd540, 0x7910c41d10a1e6a5, 0x0b5fc64563b3e2a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7910_c41d_10a1_e6a5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:63:53 [INFO] [stderr] | [INFO] [stderr] 63 | 0x691548c86c1bd540, 0x7910c41d10a1e6a5, 0x0b5fc64563b3e2a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0b5f_c645_63b3_e2a8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | 0x047f7684e9fc949d, 0xb99181f2d8f685ca, 0x284600e3f30e38c3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x047f_7684_e9fc_949d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | 0x047f7684e9fc949d, 0xb99181f2d8f685ca, 0x284600e3f30e38c3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb991_81f2_d8f6_85ca` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:64:53 [INFO] [stderr] | [INFO] [stderr] 64 | 0x047f7684e9fc949d, 0xb99181f2d8f685ca, 0x284600e3f30e38c3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2846_00e3_f30e_38c3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng/xorshift1024.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | self.s[self.p].wrapping_mul(0x9e3779b97f4a7c13) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9e37_79b9_7f4a_7c13` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/rng/xorshift1024.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | *v = (r >> 8*i) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `r >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in chunk.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/rng/splitmix64.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | for v in chunk.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in chunk.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/rng/xoroshiro128.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | for v in chunk.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t` [INFO] [stderr] --> src/rng/xorshift1024.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | for i in 0..16usize { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for (i, ) in t.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t` [INFO] [stderr] --> src/rng/xorshift1024.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | for i in 0..16usize { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for (i, ) in t.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in chunk.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/rng/xorshift1024.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | for v in chunk.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in chunk.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/rng/splitmix64.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | for v in chunk.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in chunk.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/rng/xoroshiro128.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | for v in chunk.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t` [INFO] [stderr] --> src/rng/xorshift1024.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | for i in 0..16usize { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for (i, ) in t.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t` [INFO] [stderr] --> src/rng/xorshift1024.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | for i in 0..16usize { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for (i, ) in t.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in chunk.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/rng/xorshift1024.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | for v in chunk.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/rng_seeding.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #![allow(unreadable_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/rng_basic.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #![allow(unreadable_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/rng_seeding.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #![allow(unreadable_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/rng_basic.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #![allow(unreadable_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::Rng::gen_iter': use Rng::sample_iter(&Standard) instead [INFO] [stderr] --> tests/rng_seeding.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | for (i, &j) in rng.gen_iter::().zip(expected.iter()) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::Rng::gen_iter': use Rng::sample_iter(&Standard) instead [INFO] [stderr] --> tests/rng_seeding.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | for (i, &j) in rng.gen_iter::().zip(expected.iter()) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::Rng::gen_iter': use Rng::sample_iter(&Standard) instead [INFO] [stderr] --> tests/rng_seeding.rs:199:24 [INFO] [stderr] | [INFO] [stderr] 199 | for (i, &j) in rng.gen_iter::().zip(expected.iter()) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::Rng::gen_iter': use Rng::sample_iter(&Standard) instead [INFO] [stderr] --> tests/rng_seeding.rs:264:24 [INFO] [stderr] | [INFO] [stderr] 264 | for (i, &j) in rng.gen_iter::().zip(expected.iter()) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/rng_basic.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 224 | let ratio = (trues as f64) / ((trues + falses) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(trues)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/rng_basic.rs:224:34 [INFO] [stderr] | [INFO] [stderr] 224 | let ratio = (trues as f64) / ((trues + falses) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(trues + falses)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.36s [INFO] running `"docker" "inspect" "f3bb2f407f414ef427abd6122e21d591de4665e6b47302fc7def36565d963ac7"` [INFO] running `"docker" "rm" "-f" "f3bb2f407f414ef427abd6122e21d591de4665e6b47302fc7def36565d963ac7"` [INFO] [stdout] f3bb2f407f414ef427abd6122e21d591de4665e6b47302fc7def36565d963ac7