[INFO] crate xmpp-addr 0.13.0 is already in cache [INFO] extracting crate xmpp-addr 0.13.0 into work/ex/clippy-test-run/sources/stable/reg/xmpp-addr/0.13.0 [INFO] extracting crate xmpp-addr 0.13.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmpp-addr/0.13.0 [INFO] validating manifest of xmpp-addr-0.13.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xmpp-addr-0.13.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xmpp-addr-0.13.0 [INFO] finished frobbing xmpp-addr-0.13.0 [INFO] frobbed toml for xmpp-addr-0.13.0 written to work/ex/clippy-test-run/sources/stable/reg/xmpp-addr/0.13.0/Cargo.toml [INFO] started frobbing xmpp-addr-0.13.0 [INFO] finished frobbing xmpp-addr-0.13.0 [INFO] frobbed toml for xmpp-addr-0.13.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmpp-addr/0.13.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xmpp-addr-0.13.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xmpp-addr/0.13.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a02c1b6b251db64104e0bdad162fd1091f347d80274bfdf57519d89b8d62b36a [INFO] running `"docker" "start" "-a" "a02c1b6b251db64104e0bdad162fd1091f347d80274bfdf57519d89b8d62b36a"` [INFO] [stderr] Checking xmpp-addr v0.13.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:970:9 [INFO] [stderr] | [INFO] [stderr] 970 | / return Jid { [INFO] [stderr] 971 | | local: None, [INFO] [stderr] 972 | | domain: format!("{}", addr).into(), [INFO] [stderr] 973 | | resource: None, [INFO] [stderr] 974 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 970 | Jid { [INFO] [stderr] 971 | local: None, [INFO] [stderr] 972 | domain: format!("{}", addr).into(), [INFO] [stderr] 973 | resource: None, [INFO] [stderr] 974 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:981:9 [INFO] [stderr] | [INFO] [stderr] 981 | / return Jid { [INFO] [stderr] 982 | | local: None, [INFO] [stderr] 983 | | domain: format!("[{}]", addr).into(), [INFO] [stderr] 984 | | resource: None, [INFO] [stderr] 985 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 981 | Jid { [INFO] [stderr] 982 | local: None, [INFO] [stderr] 983 | domain: format!("[{}]", addr).into(), [INFO] [stderr] 984 | resource: None, [INFO] [stderr] 985 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lib.rs:1030:38 [INFO] [stderr] | [INFO] [stderr] 1030 | Some(s) => match (&self).local { [INFO] [stderr] | ^^^^^^^ help: try this: `self.local` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lib.rs:1037:38 [INFO] [stderr] | [INFO] [stderr] 1037 | Some(s) => match (&self).resource { [INFO] [stderr] | ^^^^^^^ help: try this: `self.resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/lib.rs:358:41 [INFO] [stderr] | [INFO] [stderr] 358 | let inner = unsafe { domain.slice_unchecked(1, domain.len() - 1) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:970:9 [INFO] [stderr] | [INFO] [stderr] 970 | / return Jid { [INFO] [stderr] 971 | | local: None, [INFO] [stderr] 972 | | domain: format!("{}", addr).into(), [INFO] [stderr] 973 | | resource: None, [INFO] [stderr] 974 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 970 | Jid { [INFO] [stderr] 971 | local: None, [INFO] [stderr] 972 | domain: format!("{}", addr).into(), [INFO] [stderr] 973 | resource: None, [INFO] [stderr] 974 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:981:9 [INFO] [stderr] | [INFO] [stderr] 981 | / return Jid { [INFO] [stderr] 982 | | local: None, [INFO] [stderr] 983 | | domain: format!("[{}]", addr).into(), [INFO] [stderr] 984 | | resource: None, [INFO] [stderr] 985 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 981 | Jid { [INFO] [stderr] 982 | local: None, [INFO] [stderr] 983 | domain: format!("[{}]", addr).into(), [INFO] [stderr] 984 | resource: None, [INFO] [stderr] 985 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lib.rs:1030:38 [INFO] [stderr] | [INFO] [stderr] 1030 | Some(s) => match (&self).local { [INFO] [stderr] | ^^^^^^^ help: try this: `self.local` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lib.rs:1037:38 [INFO] [stderr] | [INFO] [stderr] 1037 | Some(s) => match (&self).resource { [INFO] [stderr] | ^^^^^^^ help: try this: `self.resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:612:5 [INFO] [stderr] | [INFO] [stderr] 612 | / pub fn from_str(s: &'a str) -> Result> { [INFO] [stderr] 613 | | let (lpart, dpart, rpart) = Jid::split(s)?; [INFO] [stderr] 614 | | Jid::new(lpart, dpart, rpart) [INFO] [stderr] 615 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/lib.rs:358:41 [INFO] [stderr] | [INFO] [stderr] 358 | let inner = unsafe { domain.slice_unchecked(1, domain.len() - 1) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:612:5 [INFO] [stderr] | [INFO] [stderr] 612 | / pub fn from_str(s: &'a str) -> Result> { [INFO] [stderr] 613 | | let (lpart, dpart, rpart) = Jid::split(s)?; [INFO] [stderr] 614 | | Jid::new(lpart, dpart, rpart) [INFO] [stderr] 615 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #![feature(try_from)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `xmpp-addr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "a02c1b6b251db64104e0bdad162fd1091f347d80274bfdf57519d89b8d62b36a"` [INFO] running `"docker" "rm" "-f" "a02c1b6b251db64104e0bdad162fd1091f347d80274bfdf57519d89b8d62b36a"` [INFO] [stdout] a02c1b6b251db64104e0bdad162fd1091f347d80274bfdf57519d89b8d62b36a