[INFO] crate xmodem 0.1.3 is already in cache [INFO] extracting crate xmodem 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/xmodem/0.1.3 [INFO] extracting crate xmodem 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmodem/0.1.3 [INFO] validating manifest of xmodem-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xmodem-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xmodem-0.1.3 [INFO] finished frobbing xmodem-0.1.3 [INFO] frobbed toml for xmodem-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/xmodem/0.1.3/Cargo.toml [INFO] started frobbing xmodem-0.1.3 [INFO] finished frobbing xmodem-0.1.3 [INFO] frobbed toml for xmodem-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmodem/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xmodem-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xmodem/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aaa3e9db17a513a44191190250b94482f76652568471edb2cf6d16aad98ed31b [INFO] running `"docker" "start" "-a" "aaa3e9db17a513a44191190250b94482f76652568471edb2cf6d16aad98ed31b"` [INFO] [stderr] Compiling crc16 v0.3.4 [INFO] [stderr] Checking xmodem v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Xmodem` [INFO] [stderr] --> src/lib.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / pub fn new() -> Self { [INFO] [stderr] 74 | | Xmodem { [INFO] [stderr] 75 | | max_errors: 16, [INFO] [stderr] 76 | | pad_byte: 0x1a, [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | impl Default for Xmodem { [INFO] [stderr] 72 | fn default() -> Self { [INFO] [stderr] 73 | Self::new() [INFO] [stderr] 74 | } [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Xmodem` [INFO] [stderr] --> src/lib.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / pub fn new() -> Self { [INFO] [stderr] 74 | | Xmodem { [INFO] [stderr] 75 | | max_errors: 16, [INFO] [stderr] 76 | | pad_byte: 0x1a, [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | impl Default for Xmodem { [INFO] [stderr] 72 | fn default() -> Self { [INFO] [stderr] 73 | Self::new() [INFO] [stderr] 74 | } [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.59s [INFO] running `"docker" "inspect" "aaa3e9db17a513a44191190250b94482f76652568471edb2cf6d16aad98ed31b"` [INFO] running `"docker" "rm" "-f" "aaa3e9db17a513a44191190250b94482f76652568471edb2cf6d16aad98ed31b"` [INFO] [stdout] aaa3e9db17a513a44191190250b94482f76652568471edb2cf6d16aad98ed31b