[INFO] crate xmlrpc 0.13.0 is already in cache [INFO] extracting crate xmlrpc 0.13.0 into work/ex/clippy-test-run/sources/stable/reg/xmlrpc/0.13.0 [INFO] extracting crate xmlrpc 0.13.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmlrpc/0.13.0 [INFO] validating manifest of xmlrpc-0.13.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xmlrpc-0.13.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xmlrpc-0.13.0 [INFO] removed 2 missing examples [INFO] removed 2 missing tests [INFO] finished frobbing xmlrpc-0.13.0 [INFO] frobbed toml for xmlrpc-0.13.0 written to work/ex/clippy-test-run/sources/stable/reg/xmlrpc/0.13.0/Cargo.toml [INFO] started frobbing xmlrpc-0.13.0 [INFO] removed 2 missing examples [INFO] removed 2 missing tests [INFO] finished frobbing xmlrpc-0.13.0 [INFO] frobbed toml for xmlrpc-0.13.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmlrpc/0.13.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xmlrpc-0.13.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xmlrpc/0.13.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11d4e54718cc1b907d381aa471124d1ab80295683c5663741992a2fd52b0a3b2 [INFO] running `"docker" "start" "-a" "11d4e54718cc1b907d381aa471124d1ab80295683c5663741992a2fd52b0a3b2"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/custom-header.rs [INFO] [stderr] * /opt/crater/workdir/examples/client.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/python.rs [INFO] [stderr] * /opt/crater/workdir/tests/version-numbers.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking iso8601 v0.2.0 [INFO] [stderr] Checking version-sync v0.5.0 [INFO] [stderr] Checking xmlrpc v0.13.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/parser.rs:203:36 [INFO] [stderr] | [INFO] [stderr] 203 | if let Ok(_) = self.expect_close("struct") { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 204 | | break; [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________- help: try this: `if self.expect_close("struct").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/parser.rs:235:36 [INFO] [stderr] | [INFO] [stderr] 235 | if let Ok(_) = self.expect_close("data") { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 236 | | break; [INFO] [stderr] 237 | | } [INFO] [stderr] | |_____________________________- help: try this: `if self.expect_close("data").is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/error.rs:260:26 [INFO] [stderr] | [INFO] [stderr] 260 | fault_code: -123456, [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:515:30 [INFO] [stderr] | [INFO] [stderr] 515 | Ok(Value::Int64(-100100100100))); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `100_100_100_100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/parser.rs:203:36 [INFO] [stderr] | [INFO] [stderr] 203 | if let Ok(_) = self.expect_close("struct") { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 204 | | break; [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________- help: try this: `if self.expect_close("struct").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/parser.rs:235:36 [INFO] [stderr] | [INFO] [stderr] 235 | if let Ok(_) = self.expect_close("data") { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 236 | | break; [INFO] [stderr] 237 | | } [INFO] [stderr] | |_____________________________- help: try this: `if self.expect_close("data").is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | / match result { [INFO] [stderr] 374 | | Ok(t) => panic!("assert_err called on Ok value: {:?}", t), [INFO] [stderr] 375 | | Err(_) => {}, [INFO] [stderr] 376 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(t) = result { panic!("assert_err called on Ok value: {:?}", t) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.31s [INFO] running `"docker" "inspect" "11d4e54718cc1b907d381aa471124d1ab80295683c5663741992a2fd52b0a3b2"` [INFO] running `"docker" "rm" "-f" "11d4e54718cc1b907d381aa471124d1ab80295683c5663741992a2fd52b0a3b2"` [INFO] [stdout] 11d4e54718cc1b907d381aa471124d1ab80295683c5663741992a2fd52b0a3b2